summaryrefslogtreecommitdiff
path: root/vcl/source/edit
AgeCommit message (Collapse)Author
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15fdo#75757: remove inheritance to std::vectorMichaël Lefèvre
from TEParaPortions (through ToolsList, close to be deleted ;). Change-Id: Iec92ebb54ebc44d94ccc8cb30230ffb44b937b35 Reviewed-on: https://gerrit.libreoffice.org/11954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I58ec00d6f8a4cc6188877db1330c5e32c9db12e5
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-23fdo#82577, fdo#82579: Handle CursorTor Lillqvist
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor typedef and some ancient Carbon (?) Cursor typedef on OS X. Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-20vcl: use enum for complex text layout constantsNoel Grandin
Since these constants are bitfield flags, we define some methods to make working with them reasonably type safe. Move the definitions to outdevstate.hxx, since we need the values there, and that appears to be the "root most" header file. Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write weird code thinking that it's a real flag. Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343 Reviewed-on: https://gerrit.libreoffice.org/10676 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-12callcatcher: another round of ResId removalsCaolán McNamara
Change-Id: Ia3acdb3501b7735820258cb090e731f5814bc07f
2014-07-27fdo#75757: remove inheritance to std::vectorTakeshi Abe
... by boost::ptr_vector. Originally TextCharAttribList::Clear() was never called with false, so this drops the argument. Change-Id: I0306cd787dd38de0960af38afe9c08a910195b26 Reviewed-on: https://gerrit.libreoffice.org/10549 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-21coverity#706084 Unintended sign extensionCaolán McNamara
and coverity#706085 Unintended sign extension Change-Id: I4bb617cd6927542dfef6dea89c5417ec4f9ed495
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-14fix higher debug level buildCaolán McNamara
Change-Id: I5bfa022c3c9fe8d24726989d9068fce7273e3f2d
2014-06-30Called C++ object pointer is nullCaolán McNamara
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-05-17avoid segfault when nBrekPos is past the endLionel Elie Mamane
Change-Id: Ieedc24c0443ba10d8277cd6327b3b735203e5d45
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-08Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: I382289c7188dfdc9839ff9e6362b6e039ffc5f9e
2014-04-02Kill superfluous vertical whitespaceTor Lillqvist
Change-Id: I81ce8fd7022bf283db668705efdfb0666f87bde9
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-07Avoid possible resource leaks with boost::scoped_ptrTakeshi Abe
Change-Id: I835bec5c43b7b4a8638d5032b720661fc2f1397f
2014-03-05Work around unfortunate libstdc++ interpretation of C++ cmath requirementsStephan Bergmann
...that causes a call to std::abs with a short argument to effectively select the double overload (via a template added with <http://gcc.gnu.org/git/ ?p=gcc.git;a=commit;h=8c0edf5c2aad076cbc805299ed82845ae049f4f6> "include/c_std/cmath (abs(_Tp)): Add"), see <http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-toc.html#2192> "Validity and return type of std::abs(0u) is unclear" for details. The workaround is to use int instead of short arguments (and make sure the integral overloads of std::abs from cstdlib are available). Change-Id: If95363f9a54abb9cb1a57fd4828c4b91c12bc4be
2014-03-05remove unused code TextEngine::GetLeftMargin()Noel Grandin
Change-Id: I1b702a4371154ebc10c0caa7697fdbe763337b6f
2014-03-05remove unused code vcl/VclMultiLineEditNoel Grandin
VclMultiLineEdit::IsRightToLeft() const VclMultiLineEdit::SetTextSelectable(bool) Change-Id: I430ffd0bac59baf49bac05123f22fa004a90ec40
2014-03-04Resolves: fdo#75229 missing object:state-changed:focusedCaolán McNamara
in multiline edits, focus remains stuck on internal TextWindow instead of being placed on container MultiLineEdit regression from b755fb8c0f6b1282f62c12f378c0a5ecac64d490 which removed it with no explanation Change-Id: I9d6bd546e341651442538bf40de6c43c521868d7
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from vclAlexander Wilms
Conflicts: vcl/source/app/settings.cxx vcl/source/window/dockmgr.cxx vcl/source/window/dockwin.cxx vcl/source/window/floatwin.cxx vcl/source/window/toolbox2.cxx Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341 Reviewed-on: https://gerrit.libreoffice.org/8339 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I773524536c0ed7bc34eb08cd35cfc77e83f722ba
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-19Related: fdo#74242 hook up a selection and caret change for multiline editsCaolán McNamara
a) split the textengine selection changed broadcast into a text selection changed and text caret change event b) handle both in existing places that handled the text selection event c) listen for them in VclMultiLineEdit and translate to VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and VCLEVENT_EDIT_CARETCHANGED handling in accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-11more similar handling of InputSequenceChecker as in other placesMatúš Kukan
Change-Id: Ia6efc0eda03dac87c73e720d08f320ce3fc6ce4a
2014-02-03xub_StrLen and tools/string.hxx final strawNorbert Thiebaud
Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-26Edit::IsModified should return boolStephan Bergmann
Change-Id: I0aafdd37c73cd47b9dc68b60a32db35c8c11f455
2014-01-25coverity#440841 : Dereference after NULL checkNorbert Thiebaud
Change-Id: Ifdbd256c3478161c16fff02e79608498175aa024
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-14longparas: none of the callers check for the error caseCaolán McNamara
so we can safely change the return of 0xFFFF to 0 without changing any callers. Which makes this safe seeing as before now every caller would have done something stupid with the results Change-Id: I10d9f12525de10661ed82f3405e6c728d38be106
2014-01-14longparas: bump nLen to 32bitCaolán McNamara
Change-Id: I49621bc3887baf8fcee17559818193325b83f27d
2014-01-13drop unnecessary tools/string.hxx includesCaolán McNamara
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
2014-01-13disentangle CalcSizeCaolán McNamara
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-13longparas: drop STRING_MAXLEN limit in TextEngineCaolán McNamara
Change-Id: Ib0f72e1fc0938ca286d0131b7bb1a00499ada7d4