summaryrefslogtreecommitdiff
path: root/vcl/source/window/brdwin.cxx
AgeCommit message (Collapse)Author
2018-01-27tdf#115057 Never use ImplPopupFloatWin for anything except ToolBoxMaxim Monastirsky
ImplPopupFloatWin draws the window title and frame directly on the client window, which is incompatible with .ui layouts, as they try to occupy the whole available space. Instead just use a plain FloatingWindow whenever possible, and change the border window code to mimic the behavior of ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a title. Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8 Reviewed-on: https://gerrit.libreoffice.org/48094 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 829b0564959411d0cc64169fe69153a714050c0d) Reviewed-on: https://gerrit.libreoffice.org/48202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23vcl: Drop a couple of unused member variablesTakeshi Abe
Its usage was gone at df6ba2adbaeea9c5abe6e3ea0a583ec78ca9e7bd. Change-Id: Ia153cb8fb9247818684be09a81ac5eabdb1120e4 Reviewed-on: https://gerrit.libreoffice.org/42682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-18loplugin:constparams in vclNoel Grandin
Change-Id: I36afe2107e07ffb9b73c0b76be600e3e999a0fd4 Reviewed-on: https://gerrit.libreoffice.org/40116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06loplugin unnecessaryparan improvementsNoel Grandin
Change-Id: I73e945d6ec53537a0da45f6b6291018c7f251a7e Reviewed-on: https://gerrit.libreoffice.org/39587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17loplugin:unusedfields in vcl part3Noel Grandin
Change-Id: I5a6319ba1667af6e9b7b92c22f858188c28c4c61 Reviewed-on: https://gerrit.libreoffice.org/38835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25loplugin:checkunusedparams in vclNoel Grandin
Change-Id: I26661684e634aa15a18f78442de15c9db832f319 Reviewed-on: https://gerrit.libreoffice.org/36886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-14Convert WindowType to scoped enumNoel Grandin
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-03drop else branch of if (true)Caolán McNamara
Change-Id: Id11f005f32a0c66e9584c90aebb6943ed41acaf0
2017-01-03SetPin and IsPinned are in an always-false circular isolated relationshipCaolán McNamara
Change-Id: I4fb3aaa8a5e8c62091fbc542deae6af3a113a608
2017-01-03mnPinState is unusedCaolán McNamara
Change-Id: If8764b5cfda173bedfe2e911e39bf5b5e8a8573a
2017-01-03BorderWindowHitTest::Pin is never setCaolán McNamara
Change-Id: Ic50dd49b1470d4ee233e781e8c951c10c84968fd
2017-01-03so maPinRect is always emptyCaolán McNamara
Change-Id: Ia2ee10ead7068d4809f5a3ba8fbf01fdf6e4a1c9
2017-01-03WB_PINABLE isn't set anywhereCaolán McNamara
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2016-12-20KDE4 fix edit box bordersJan-Marek Glogowski
When recalculating the native window frame borders, calculate using already existing window borders. Otherwise the KDE edit box results in an unlimited recursion for increasing the bounding rects, if the control doesn't fit. Change-Id: I45e51e4796b06097ca537c656f004133dfacd033
2016-11-10Resolves: rhbz#1342828 toolbars jumping around while moved under XCaolán McNamara
because the start move by wm conflicts with the manual efforts to position the toolbar. the move by wm was done to get wayland to move the toolbars, but (gnome#768128) supporting docking toolbars under wayland is futile as far as I can see Change-Id: I502d4617efaf1eb686469e100224e56104ad650d Reviewed-on: https://gerrit.libreoffice.org/30751 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-03loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I572b83949c7e643536b7d62567760546509e4d9f Reviewed-on: https://gerrit.libreoffice.org/30514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26loplugin:expandablemethods in vclNoel Grandin
Change-Id: I1876e203d3a3a5fa36d83a9b282ba49429c1da2a Reviewed-on: https://gerrit.libreoffice.org/30261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-07loplugin:constantparam in vcl..xmlscriptNoel Grandin
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a Reviewed-on: https://gerrit.libreoffice.org/28685 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05changes to floating windows shouldn't trigger re-layout on their parentCaolán McNamara
cause they are not inside them so don't affect the parents layout Change-Id: I3c08b874ac450fb4c824b62a4e882df93c34fa68
2016-06-28notebookbar: added slide transition tabSzymon Kłos
- created VclVBox control which creates SlideTransitionPane - SlideTransitionPane extended with second constructor which loads ui in horizontal mode - introduced CloseMethod for NotebookBar to kill widgets in right order Change-Id: Ic3ba35cb7734aa744a4804c5b670fed7c1bec204 Reviewed-on: https://gerrit.libreoffice.org/25844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-20Convert PART to scoped enumNoel Grandin
Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03accidentially reverted fix for tdf#96745Caolán McNamara
Change-Id: I52380248002f6c41f0c6f154f913b05ef32b93d3
2016-06-02these overrides just call only their parent versionCaolán McNamara
looks like the sort of simplfication that could be automated Change-Id: I29ce13fe1b98e99be096e44239b971f6971c5f98
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17Set different ui file for NotebookBar in each appSzymon Kłos
Changes: + added ui file for start center, calc and impress + NotebookBar not visible in Math, Draw Change-Id: Ie35935e67524ac712930b088591e9e53955de4a1 Reviewed-on: https://gerrit.libreoffice.org/24860 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert BORDERWINDOW_STYLE to scoped enumNoel Grandin
Change-Id: Idbd538c69ebb40a319decc1e3a9cf06c99eb6423
2016-05-11Convert BORDERWINDOW_HITTEST to scoped enumNoel Grandin
Change-Id: I67341099c5465cc77840a8087d186b825d79048d
2016-05-11Convert BORDERWINDOW_DRAW to scoped enumNoel Grandin
Change-Id: I25d8c8921445749be05974af5c00e9fde82382a3 Reviewed-on: https://gerrit.libreoffice.org/24837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert BORDERWINDOW_TITLE to scoped enumNoel Grandin
Change-Id: I9e3088c4ba51010a013f5bbaa2bb545ffa11409b Reviewed-on: https://gerrit.libreoffice.org/24836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30notebookbar: Rename NotebookBarWindow to NotebookBar, and move accordingly.Jan Holesovsky
Change-Id: If04a8f62aba0bcb712ae6405db318a4bd073fc54
2016-03-30notebookbar: Instantiate the notebookbar via sfx2 infrastructure.Szymon Kłos
Change-Id: Iaed4596246245560e646d9086e717d5fb516897e
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Related: tdf#98419 gtk3: reimplement passing window move control to wm...Caolán McNamara
for wayland Dragging toolbars around to move them (starting with an undocked toolbar, not the moving outline fake thing) doesn't work under wayland (as far as I can see) without using gtk_window_begin_move_drag i.e. gtk_window_move doesn't work. But this is supposed to be used from the initial mouse click (while it works under wayland from a move, it doesn't work under X from a move) so rework the last attempt to occur right at the initial click to drag. Change-Id: I612f188b3e8482307bc816f5aa775530e6092eda
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-28tdf#96745: Hold VclPtr on a border window's client windowKatarina Behrens
It was Noel's idea ... makes sense given that following Close() call not only closes, but also deletes the window Change-Id: Icea766d2a7bb7bd834f32080f7c69a9fc67ebf54 Reviewed-on: https://gerrit.libreoffice.org/21878 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-04vcl: split classes out of metric.hxxChris Sherlock
Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9 Reviewed-on: https://gerrit.libreoffice.org/21069 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-17remove newly unused WB_NEEDSFOCUS and fragile FLOAT_FOCUSABLECaolán McNamara
Change-Id: Idce03318fbc01039a6c0638879785607970993c0 Reviewed-on: https://gerrit.libreoffice.org/20746 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-16loplugin:vclwidgetsStephan Bergmann
Change-Id: I9a9748879fcc55b524138d865e71a713efad180d
2015-12-16vcl: Initial NotebookBar implementation.Jan Holesovsky
Re-introduced, this is still useful code to have :-) Change-Id: I91535c13d68261f7195989ec78bd305cf572c87c
2015-12-15gtk3+wayland: enable manual movement of toolbarsCaolán McNamara
via gtk_window_begin_move_drag so add some BYDRAG/ByDrag hints to select mechanism to move window by Change-Id: Icc58653dff752a6d4ee49446647d7ede2af9dd9b
2015-11-20loplugin:defaultparamsNoel Grandin
Change-Id: Ia9dca11a7e38fcf2b7b4b0d2459c85a1348f8c43
2015-11-20Revert "vcl: Initial NotebookBar implementation."Samuel Mehrbrodt
Will use a different approach for NotebookBar. Also this should not be in 5.1. This reverts commit 8c1014021dbe9da2e18233d215b970f5359db67b. Change-Id: Ic699723818a890bf4c3be3a2c045527148bd118b Reviewed-on: https://gerrit.libreoffice.org/20075 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-18com::sun::star->css in vcl/Noel Grandin
Change-Id: Ifad76177673cf93746ba221838be80ff76fed228 Reviewed-on: https://gerrit.libreoffice.org/20032 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
generated by cgit (git 2.34.1) at 2024-07-18 16:18:23 +0000