summaryrefslogtreecommitdiff
path: root/vcl/source/window
AgeCommit message (Collapse)Author
2016-10-03Resolves: tdf#99324 accel underlines don't appear in extension option pagesCaolán McNamara
because they are not widget-layout tab pages, we have to dive down through the WB_DIALOGCONTROL widgets as well Change-Id: I13dbf88878efd89794158ce43137381008e18890
2016-10-03fix indentCaolán McNamara
Change-Id: Ia1bc9fe3c2c3833e36ec6fb9636856049acf03ec
2016-10-03Fix typosAndrea Gelmini
Change-Id: Ie75beb4e282a4d1b784a5847262e39cf9c851527 Reviewed-on: https://gerrit.libreoffice.org/29440 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29loplugin:vclwidgetsStephan Bergmann
"VclReferenceBase subclass dispose() function MUST call dispose() of its superclass as the last thing it does" Change-Id: Iab326014d3de805f68729f6d2912f7e960368f11
2016-09-29send an event when the dialog is actually closedMarkus Mohrhard
The last data structures in vcl are only updated when the dialog is disposed. Especially mpFirstFrame is not updated until the dispose. So we need to wait until that point for the UI tests. Change-Id: I7432600e879c4c7dcffa445ac6b3cd228d0aa856
2016-09-27this should always be empty nowCaolán McNamara
Change-Id: I5849ce78407675150ca1fd96388a4569bcd14f4a
2016-09-27Resolves: tdf#102177 focus not restored from context menusCaolán McNamara
the problem being that the attempt to restore the focus in the document in the floatingwindow tear down is blocked because the menus have set that window as modal so the focus isn't set. The attempt to set the focus in the floatingwindow teardown causes the SavedFocus in the menufloatingwindow to be dropped, so the extra layer of code to restore focus after modality is removed doesn't do anything this is fallout from... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves: tdf#87120 no keyboard navigation inside floating windows which allows the focus to "truly" enter the menus, triggering the floatingwindow attempt, which fails but blocks the menufloatingwindow attempt easiest thing seems to make the restoring modality, and then restore focus, something that MenuFloatingWindow does before it finishes Change-Id: I97a4ac71419dcb04709e4667586d8343e89ddbeb
2016-09-27ImplEndPopupModeHdl takes no argumentCaolán McNamara
Change-Id: I2e4a498bb9c4d5e887f55d38cdae6c6aeef44a4d
2016-09-27detangle code that now looks silly since...Caolán McNamara
commit 9b7dfb10641ba7978ffcbd1db0507163411ae027 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jun 9 16:52:21 2016 +0100 EndSaveFocus does nothing on the !bRestore case removed the code that made it look like it made sense Change-Id: I2e7280fd6643e86d65cba04c8302be099d6f3d0e
2016-09-27the only place the default xFocusId arg isn't used...Caolán McNamara
the argument is (effectively) equal to the default Change-Id: I26fcd43d2bc8e37e6887c244f728e3231328e34e
2016-09-25tdf#96736 Let MenuBarManager handle the save dropdownMaxim Monastirsky
Instead of trying to do everything (icon theme changes, disabling commands etc.) manually. Change-Id: Iffd420bf09ccd566e96f39cb9684ab466a7c6555
2016-09-22VCL add support for rollover menubarsJan-Marek Glogowski
KDE theme engines can explicitly support rollover menubars via styleHint( QStyle::SH_MenuBar_MouseTracking ). So this adds support for this feature to the vcl::Menu. Change-Id: Ica923ff2d06cfd54e548ba858b3d90f70d9c255a
2016-09-22KDE4 no more progress bar flickeringJan-Marek Glogowski
This will always redraw the progress bar over the last one. It stops the flickering at least in KDE4 from re-painting the background, but obvously will break any transparent or alaiasing effect, if it was used. There is actually a mbProgressNeedsErase in the global settings, so actually use it when setting a new progress value. Change-Id: Ic62784da4f6d08bf0e03a9e04848a5cc687ee236
2016-09-22tdf#94172 KDE4 fix gradient toolbarsJan-Marek Glogowski
Bug introduced by commit 4f5fe008a3d5f0b5ddfa656299306cff9d57d802. The code was moved from ImplInitSettings to ApplySettings and somehow a not (!) got lost. Change-Id: Ie3fa4fb99d030d106aab712cd6bdafada8c6d423
2016-09-22Resolves: tdf#102347 configure size/expose might never come...Caolán McNamara
if you request a size you might not get it. This attempt dating through... commit 6dc1d2706f519d91617ac1a12fc2051d97ef98c0 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jun 15 10:56:33 2015 +0100 another stab at tdf#91393 block paints only if the new requested size is larger than the original and unblock on explicit expose events as well as configure ones ... commit 8f324aebfb94c4b2023894121b954ad4f35eb395 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Jun 14 15:49:56 2015 +0100 Resolves: tdf#91393 autotext (etc) not fully drawn ... commit e6a1956034c98204e30b0ca40330249d6f6f8155 Author: Jan Holesovsky <kendy@collabora.com> Date: Fri Jun 12 15:36:03 2015 +0200 tdf#91301: Don't cache incomplete tabs. After introduction of the Idle processing, something has changed so that the underlying GetGdkWindow() does not update its size fast enough; even though the gtk_window_resize() is called before the Window::Erase() (that actually paints the background) etc. is all junk. I don't see the original problem of tdf#91393 or tdf#91301 anymore under gtk2 after reverting this yet anyway to see if they need another fix. Change-Id: Ide071eba279de726a9c6a80884bc9021c8914d9d
2016-09-20Obsolete workaround for SUNPRO 5 compilerStephan Bergmann
Change-Id: Ib51f08e1d0e0dff066b06ecd85976b777d722a33
2016-09-15vcl: consistently use sal_IntPtr to marshal drag source / drop targetMichael Stahl
This may be either an X11 Window or a GtkSalFrame*. Change-Id: Ib963cfb329bb711cfaab47f2748da139117cdbae
2016-09-15Remove OutputDevice::PaintScopeNoel Grandin
PaintScope was introduced in commit bfceb557efcd607ef018ae35fc73f8d61a9b9a4e Author: Michael Meeks <michael.meeks@collabora.com> Date: Wed Sep 16 09:17:37 2015 +0100 GL paint-flushing guard re-work. Unfortunately, since we can have 2x SalGraphics' on a OutputDevice, and one of these can be a printer - things got very confused around which context to glFlush. This de-tangles the various reference- counts. and then mostly removed in commit 33fac4828038bc38ab4a0c4b891d762a5ae73e5e Author: Noel Grandin <noel@peralex.com> Date: Thu Dec 24 09:21:23 2015 +0200 loplugin:unnecessaryvirtual and unwind some apparently now unused VCL OpenGL and GlyphCachePeer stuff. Finish the job, it's not doing anything at all anymore Change-Id: I1365c2d0652ee92630d0649b2df6e5a7b7e37e73
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Resolves: tdf#101879 explicitly put menubars at the start of task listsCaolán McNamara
Change-Id: Ia6a36b08f84960b01472833504cd65bfbad473eb
2016-09-10Typo: (un)kown->(un)knownJulien Nabet
Change-Id: I7455c928293cd8d2d2ff16aa85fe02c9a54959d2 Reviewed-on: https://gerrit.libreoffice.org/28801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-07tdf#101869 Allow toolbox to open from spacebarAkshay Deep
Change-Id: I3a60c8f590f78a9d750a428170d2a0521f267fd8 Reviewed-on: https://gerrit.libreoffice.org/28727 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07BigToolBox painting fixSzymon Kłos
If the button was dropdown only type the arrow was on the same position as a text. Change-Id: I3d9693ef57c5c2d27549987339a1c388bc3ff724 Reviewed-on: https://gerrit.libreoffice.org/28721 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07loplugin:constantparam in vclNoel Grandin
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-07loplugin:constantparam in vcl..xmlscriptNoel Grandin
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a Reviewed-on: https://gerrit.libreoffice.org/28685 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert Orientation to scoped enumNoel Grandin
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert ToolBoxButtonSize to scoped enumNoel Grandin
Change-Id: I365b0e34361eb339b04e5f4792f54eff5bf582a5
2016-09-05convert GradientStyle to scoped enumNoel Grandin
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-09-05convert LineStyle to scoped enumNoel Grandin
Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
2016-09-05convert RasterOp to scoped enumNoel Grandin
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-01Looks like the menu highlight handler is now unusedMaxim Monastirsky
Change-Id: I75ff4bce35e7940e07b760f672e08ffe0dd208f8 Reviewed-on: https://gerrit.libreoffice.org/28580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-31gtk3: Implement menubar hidingMaxim Monastirsky
Change-Id: Ia772f05daa74453fc3dc8fe0c257fdac358cd5c6 Reviewed-on: https://gerrit.libreoffice.org/28490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-30default assignment and ctor are fine hereCaolán McNamara
Change-Id: I50edc71ee8bb4398764f2e15180a0269aac233ce
2016-08-28loplugin:defaultparamsJochen Nitschke
Change-Id: I9e6b81855e421186af92e53c71f5ba9bd8005319 Reviewed-on: https://gerrit.libreoffice.org/28433 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28screenshot: added functionality to dialogArmin Le Grand
Moved code to cui, added abstraction for AbstractDialog, adapted rendering, changed selection, added better selection visualization, added save ressources and dialog, creating pure screenshot with annotation display Change-Id: I533d9f559ee17cd46105b934bcf4beef87b96168
2016-08-28screenshot: develop interactive screenshot dialogArmin Le Grand
Implemented a first version of an interactive screenshot dialog that supports annotations, text excerpts for these and allows to create a screenshot file How to use: * enable experimental features in Tools->Options * open any random dialog * open context menu - there's now a 'Screenshot' entry * click that, screenshot dialog pops open, mouse over the grayed-out screenshot to highlight controls * click once to highlight, click a 2nd time to unselect Change-Id: I3bcd76b96ad023e11421e4fcfac866ebf4f5ff78
2016-08-25GSoC notebookbar: container with context supportSzymon Kłos
+ added sfxlo-ContextVBox + notebookbar's .ui file must contain control implementing NotebookbarContextControl interface with id "ContextContainer" Change-Id: Ice81e23c4ba742564ebceeda95be120ea3f58c99 Reviewed-on: https://gerrit.libreoffice.org/28247 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-08-25BigToolBox: fixed drawing with gtk2Szymon Kłos
Button's width was equal to icon width when gtk2 was used Change-Id: I34e5c5c36653365ac422667a69d89aa6a91340a1 Reviewed-on: https://gerrit.libreoffice.org/28361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-08-18cppcheck: noCopyConstructorCaolán McNamara
Change-Id: Id5323cb6f52666f85965e11b07e4f2bca8af4e78
2016-08-18loplugin:redundantcastStephan Bergmann
Change-Id: I1b1c348311930499e9ee971b87257db40f3873b3
2016-08-18screenshots: fix sc screenshot testfeature/dialog-screenshotsArmin Le Grand
Seems to need a new document Change-Id: I644d2fcb9fe4ec66e964192d3dda61ca331acece
2016-08-18screenshots: clang plugin & tabpage usage fixesArmin Le Grand
Adapted clang compiler results, made TabDialog implementaions of ScreenShot API work with real UXMLDescription names, including a solution for using multiple tabPages with the same *.ui file Change-Id: I56df878b3db3bcc18fa2b4713b7ad72d42e8eb30
2016-08-18screenshots: use new bootstrap fixture in sc and sdKatarina Behrens
Change-Id: Ida0d3179726896b32b0876b1855b1f0be12d3b48
2016-08-18screenshots: added support for minimal Screenshot ifcArmin Le Grand
For simple TabDialogs with minimal interface. That works, but found out that for SD it's using a TabDialog with two TabPages with the same *.ui file. To avoid problems for now, adapted to use PageIDs again, marked in the code as to-be-changed. Change-Id: I30af6367f4d3c1e9097b1fe3d2b230ab4eab5ed7
2016-08-18screenshots: added stuff for Linux buildArmin Le Grand
Change-Id: Icc219fd6d2d8fc555f8e54d1fd0116e5976c5f7b
2016-08-18screenshots: added more virtualization/abstractionArmin Le Grand
TabPabe Identification to UI-File names. Isolated some data initialization constructs. Added more dialogs to dump. Should dump on all systems now Change-Id: I7ee07309e0bf88064f789c13bcbff93c17370f77
2016-08-18screenshots: extend default paths where stuff gets writtenArmin Le Grand
Change-Id: I1886d832bb9474371ea27d4d36f0446b221246d0
2016-08-17GSoC notebookbar: BigToolBoxSzymon Kłos
+ New container: sfxlo-BigToolBox + Writer: Paste button with dropdown menu Change-Id: I8fa9ff2cbf594078cc2347bef790b8647ce4e6ea Reviewed-on: https://gerrit.libreoffice.org/28156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-15mbInitialLayoutDone is unusedCaolán McNamara
Change-Id: Ic660ba53b450071ad222a3c1adb13e908dbf0023
2016-08-15Resolves: tdf#92906 badly rendered elements dock after hide+showCaolán McNamara
The show after hide is seen as "InitShow" which find the optimal size for its contents. That's ok if it was a toplevel dialog, but its not in this circumstance of a docked docking window and has to live with the given size. This seems to have basically come unstuck with commit 05d4077b724f91fca736d3c3fd64f28e304d7172 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Sep 1 07:17:09 2014 +0100 rearrange matters to get FloatingWindows working loaded from .ui Change-Id: If47bb392c8235d946bb2fd07448c6f48479a5163