summaryrefslogtreecommitdiff
path: root/vcl/source/window
AgeCommit message (Collapse)Author
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Be more specific in warningTor Lillqvist
Change-Id: I96d5dc1267af714e78e431581592e75f0bff73f4
2014-11-06rename KEY_MODTYPE to KEY_MODIFIERS_MASKNoel Grandin
Change-Id: I7948988e4fd89bf94a98afee15298cd33e2a4d06
2014-11-05Basic Idle handler implementationTobias Madl
An idle handler will ultimately be a zero time timeout with prioritisation layered on top of that. Change-Id: I3f0802d5001172fc7b8409274bc5a3632e5dad34
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-03fdo#84795 Menu, DropDown-List don't disappear with right mouse clickJuergen Funk
this includes a fix to leave disabled menu entries disabled. This reverts commit 454f5c3018c6d61d5872f7c23c7590c2157444e4. Change-Id: Ifb66b0b241378437f040af19ec163da3cb8d815d Reviewed-on: https://gerrit.libreoffice.org/12061 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01vcl/source: get rid of redundant svsys.h includesDouglas Mencken
+ adapted for WNT (it does really need it for app/settings.cxx) Change-Id: I33a65d24f7c6c46a36718e4421ae88de180a9739 Reviewed-on: https://gerrit.libreoffice.org/11814 Reviewed-by: Douglas Mencken <dougmencken@gmail.com> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-31drop KeyCode::IsDefinedKeyCodeEqualNoel Grandin
because it's implementation is the same as operator== Change-Id: If9b63abcd13f899735d59d85be3da54406a6e324
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-31KEY_ALLMOD is the same as KEY_MODNoel Grandin
so just dump it Change-Id: I006045aea345e84ff1944fc1ed1daa94bd7bca61
2014-10-30vcl button: Avoid a potential crash.Jan Holesovsky
Change-Id: I09d0777ef51045054b8e3bc88aba9fb025e6f9ff
2014-10-29Resolves: rhbz#1146169 a11y frames label dies before frameCaolán McNamara
Change-Id: Ie5650c3a5593dcf68196802169c47270a0c3b0e6
2014-10-29need to initialize mnRefCntCaolán McNamara
all sorts of things crash, e.g. format->properties Change-Id: Ida4fb97dcdddd7adde4b98fa67b107a514eef615
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-22Avoid unnecessary #includeStephan Bergmann
Change-Id: I6ec5de40ce2f4cbcce751dcae16dae60abbc1a37
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20Revert "Fix fdo#84795 Menu, DropDown-List not disappears with right mouse click"Caolán McNamara
This reverts commit 53c836701e22b1babd3702b502facd76236df7ff. because it means that all disabled buttons get their "click" delivered so disabled buttons are only visually disabled. e.g. writer: insert->table->autoformat, click on the disabled "rename" or "add" or "remove" and the sub dialog appears. Or in calc insert->object->chart and click on the disabled "back" -> crash
2014-10-20Work around workaround for old MSVC 2012Stephan Bergmann
...not allowing certain o3tl::is_typed_flags::Wrap conversion operators to be explicit, thus causing ambiguities here. Change-Id: I5108885229eb185ceac57042e67405b393cdcf3b
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Related: fdo#84676 try to give floating windows their original stylebitsCaolán McNamara
as they were before becoming .ui components to see if that makes a difference here Change-Id: I1699e19f14b18579f6b8c973d64f069b206b7cb8
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11coverity#1242425 Dereference after null checkCaolán McNamara
Change-Id: I638d1601ac6cb5e43ee60f60869f6128060e6d05
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10Fix fdo#84795 Menu, DropDown-List not disappears with right mouse clickJuergen Funk
Set for menu and float-list-box the PopupModeFlags to FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK + FLOATWIN_POPUPMODE_ALLMOUSEBUTTONCLOSE Improving the comments Change-Id: I313e4ec38637fa3d46567e08bdb9560ce8475b6a Reviewed-on: https://gerrit.libreoffice.org/11881 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-07Resolves: fdo#44998 crash when opening context menu of a fieldCaolán McNamara
If you right click on a field in an inactive text box, then a mouse down, context command, mouse up sequence is sent. The mouse up is supposed to be captured by the context menu here. But it doesn't because the mouse down in draw sends an artificial mouse down to the editengine which eventually sets up a MouseCapture window so the context menu doesn't get considered (because it occurs before the capture window is released) so the mouse up gets send to sd while the context menu is up and that causes all sorts of havoc. Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-04coverity#1242365: Unchecked return valueNorbert Thiebaud
Change-Id: Iddb8b1bad29bf372f9485514e2cde195237e3cc3
2014-10-04coverity#1242366: Unchecked return valueNorbert Thiebaud
Change-Id: I3f3b5b5a7ce5e387dc2acddc086d9f8a2fa2b12b
2014-10-04fix for invalid dynamic_castNoel Grandin
after my loplugin-cstylecast commits. this is a follow on to the bug reported in fdo#84608 Change-Id: Icc4f4baf3690e939c07a71a949200270bf1f4614
2014-10-03Resolves fdo#84608: Right-click customize crashes LibOJulien Nabet
Regression from 26f2da07b1c6074e519d28557a3d1d5518ff6cb4 Change-Id: I382c4686b5fff0c04bdb36f1859c8ea5b2424772
2014-10-02coverity#1242905 Uninitialized pointer fieldCaolán McNamara
Change-Id: Idbc3c594c5ae6949beaa0b8dcfd8d56f54902f9f
2014-10-02coverity#1242421 Dereference after null checkCaolán McNamara
Change-Id: Iaeac53bd0a9c70cd8445e336400d51bf90b69fed
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29fdo#59299 Personas for bottom toolbarsMichael Jaumann
Change-Id: If823964bf3bb67563504db61b6c5d557cab89243 Reviewed-on: https://gerrit.libreoffice.org/11609 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: I58ec00d6f8a4cc6188877db1330c5e32c9db12e5
2014-09-25coverity#1147661 Uninitialized scalar valueCaolán McNamara
Change-Id: I7a225287c9ca2f14d2e8da15380c541148d1a15f
2014-09-25coverity#1241396 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ib9c38ae857125036252ba27ebd03f428046724e0
2014-09-25nHighlightedItem only ever set, never readCaolán McNamara
Change-Id: Ie4b1517e41e09df3c243b6d4ff124f50777e8bc0
2014-09-24vcl button: Allow automatic handling of UNO commands (like .uno:Something).Jan Holesovsky
Change-Id: I71c00286dde2e5a01a7a592305c1790f1ed63a93
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a