summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2018-06-09hold and return SalPrinter with std::unique_ptrNoel Grandin
and remove DestroyPrinter, doesn't not anything beyond delete'ing the object Change-Id: I25e14b962e65a0e131fae3ff5771c82920a4e375 Reviewed-on: https://gerrit.libreoffice.org/55498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return SalSession with std::unique_ptrNoel Grandin
Change-Id: I85527407c0cd2d3b94565fd7e24b0616948c9b0f Reviewed-on: https://gerrit.libreoffice.org/55497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalI18NImeStatus using std::unique_ptrNoel Grandin
Change-Id: I3657980045290a4d65b2944afac04d610c0a94fd Reviewed-on: https://gerrit.libreoffice.org/55496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08hold LogicalFontInstance with rtl::ReferenceNoel Grandin
instead of manual reference counting. Also the releasing of not-currently-in-use LogicalFontInstance objects from the cache is made less aggressive - we now only flush entries until we have less than CACHE_SIZE instances, instead of flushing the whole cache. Change-Id: Ib235b132776b5f09ae8ae93a933c2eebe5fa9610 Reviewed-on: https://gerrit.libreoffice.org/55384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08support comboboxtext id valuesCaolán McNamara
Change-Id: Ibebdaab5b073a55cb646687890bc16d5f55c0341 Reviewed-on: https://gerrit.libreoffice.org/55460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08sync tristate/inconsistent featureCaolán McNamara
Change-Id: Id1107f4fb1f51f377ad546f9b673f9037fee1538 Reviewed-on: https://gerrit.libreoffice.org/55459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08tdf#117440 Can't move focus to disposed windowMaxim Monastirsky
xSaveFocusId is the already disposed comments floating window, so it can't accept focus anymore. Moreover, if closing the menu by clicking its title, the focus results nowhere, and no keyboard interaction works at all (including e.g. F6 or F10). This patch makes the focus switch back to the document, like it was in earlier LO versions. And does it in a way that doesn't break tdf#115227. Change-Id: I1d473557c10faf65b5b1fa917f5a5d66d0de8656 Reviewed-on: https://gerrit.libreoffice.org/55457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07assert in BitmapInfoAccess if bitmap is empty or we can't read from itNoel Grandin
and fixup the "make unique if two things want to write to bitmap at same time" check, it was using maBitmap before maBitmap has been assigned to. Lets just make it check something more useful, like the share count of the underlying SalBitmap. Change-Id: I97a629457174da2e4df1edc9674290aa9c9a2b52 Reviewed-on: https://gerrit.libreoffice.org/55416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07manage PhysicalFontFace by rtl::ReferenceNoel Grandin
Change-Id: I8f66b5afb066fe83abb83c56ebde6f21197f894b Reviewed-on: https://gerrit.libreoffice.org/55333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07vcl: svx: misc improvements to pdfium importingAshod Nakashian
Change-Id: I58f2fd973a731b148f40b37139cd74bac097a7d2
2018-06-07vcl: fix pdf rendering regressionAshod Nakashian
Change-Id: I6c2c48c033facb317b4ca7ed2af07348d6386b98 Reviewed-on: https://gerrit.libreoffice.org/54921 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07pdf: preserve the original page dimensions on importAshod Nakashian
Also allow for rendering PDFs to images at custom resolution, instead of hard-coded (old hard-coded value of 96 dpi is now default arguments). Change-Id: Ia5b52f72d6ce7130a2debc7c6f86504aa041bdc8 Reviewed-on: https://gerrit.libreoffice.org/54786 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: render the correct PDF page on swapping inAshod Nakashian
Change-Id: I81225e228d9cf2b9849110715dbfdeb59f2805dd Reviewed-on: https://gerrit.libreoffice.org/54746 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: support breaking any PDF pageAshod Nakashian
Change-Id: Ifa5f58163bef209a988fc0f88e2b609b1973e0d4
2018-06-07svx: support importing PDF imagesAshod Nakashian
Change-Id: Id4524a30b8f9fa4228c4acb4bf8714700da3017c
2018-06-07svx: support breaking PDFs imported as imagesAshod Nakashian
Change-Id: I990c2b3c3055fbffddedc407c34beb5824277b38
2018-06-07vcl: svx: preserve the imported PDF page number in GraphicAshod Nakashian
Change-Id: I1bb3fa7d44d5f92df2bb8c4ed4b85ccd984c2617
2018-06-07sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-06-07pdf: share pdf data in GraphicAshod Nakashian
Change-Id: I8146aa4e206788afff71142e1877fd7a885f4652
2018-06-07tdf#116916 - Icon themes missing on LibreOffice Vanilla from macOS appstoreheiko tietze
Update of blacklist for $WITH_THEMES Fallback to Tango for ancient/unknown DE, Colibre only on Windows MPL vs. non-MPL on macOS Change-Id: Ibea9e9429a79911d632b54fa4aa9649003830aa3 Reviewed-on: https://gerrit.libreoffice.org/55295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/54794
2018-06-06tdf#107266 made background continous for menubar and notebookbarKshitij Pathania
Change-Id: Ieed538741f2a252c8acf1e751bb2ddbe6361b2fa Reviewed-on: https://gerrit.libreoffice.org/55118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-06Translate German comments and debug stringsJohnny_M
And correct a few comments (translation and grammar) Change-Id: Ifafa521c683e9ca65aeba8031cd4cbfc1fadc137 Reviewed-on: https://gerrit.libreoffice.org/54888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-06-05tdf#102928 PDF export: do recompress CMYK imagesMiklos Vajna
The export filter writes /DeviceRGB unconditionally, so for now don't optimize CMYK image handling here. Though the added GraphicDescriptor API allows supporting this natively in the export filter in the future. Change-Id: I76b44b910948467aeb1f15e5ae765201d183c99d Reviewed-on: https://gerrit.libreoffice.org/55343 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-05forms - move the Bitmap accessing code inside BitmapExNoel Grandin
Change-Id: I58d5200332c133146adb6bb99b4b88697f03990a Reviewed-on: https://gerrit.libreoffice.org/55313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-05reducing Bitmap copying in BitmapExNoel Grandin
Change-Id: I674230548c6a10cfcc3c4c2542e48fd999b80e57 Reviewed-on: https://gerrit.libreoffice.org/55314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04ofz: fix buildCaolán McNamara
Change-Id: I8b5badc7ad6493b9268d6d141885a6f0bff1baa1
2018-06-03uitest logger: ListboxSelect and ListboxFocus loggingSaurav Chirania
Change-Id: I5a38adaeea3c2e64366563bd449d8bf06d9161a3 Reviewed-on: https://gerrit.libreoffice.org/55112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-03uitest logger: support for buttons, dialog, command and key loggingSaurav Chirania
This patch adds logging faclity for radiobuttons, checkboxes and button clicks. It modifies the logging for UNO commands and dialogs execution for consistency with other log statements. It also makes key logging more informative by printing the details of the object on which the user is typing. Change-Id: I911d0dfb64dacfde64193f0aea21f7d837dbf9da Reviewed-on: https://gerrit.libreoffice.org/54745 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-03Fix tdf#100937: LO Freezed when I insert a very long text in...Matteo Casalin
... the Description box The issue was triggered by ImpVclMEdit::Resize initially calling TextEngine::SetMaxTextWidth() with a negative width (due to an initial empty area, further "reduced" to take into account a vertical scroll bar) and then with positive values in following iterations. I preferred to consider such negative widths a no-op instead of extending them to the "maximum" possible width. Change-Id: I756652a30c23ebe6674e481e7d8d6e0d8ba45e75
2018-06-03Improve 1a2ee0ecd5b0cff52922c1d261f7d03a57a52ca0Matteo Casalin
Change-Id: I50f369f28c3b97ba7fed494cb238b7756920abc6
2018-06-03Fix tdf#117410 - UI: Settings in PDF Options not remembered...Matteo Casalin
for next export Change-Id: I6f066c81d96595a4560f5bb9e148001b004b38f0
2018-06-03avoid a deadlock when the crash handler can't acquire SolarMutexLuboš Luňák
Change-Id: Iea2d9b993dcf08fe022f97a2ac8e15fba9a8568c Reviewed-on: https://gerrit.libreoffice.org/55090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-02fix dubious cache comparison checkCaolán McNamara
in... commit 083b7ca26bbf4b9bad2922520caaf5c0227dac5e Date: Tue Dec 26 15:58:21 2017 +0100 Move PhysicalFontFace member of FontSelectPattern this went from... if ( (rA.mpFontData && rA.mpFontData->IsSymbolFont()) || (rB.mpFontData && rB.mpFontData->IsSymbolFont()) ) to ... if (rA.IsSymbolFont() && rB.IsSymbolFont()) { Change-Id: I1407573dfa73ac843b790ff3bc4ac0d5f66ab42c Reviewed-on: https://gerrit.libreoffice.org/55183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-02valgrind: uninitialized readCaolán McNamara
Change-Id: I29811f652c2368a0fecef66dd02343d12ee67068 Reviewed-on: https://gerrit.libreoffice.org/55178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-01use more BitmapEx in filterNoel Grandin
Change-Id: I68fdad6a69a178df8c59c4272f1d8d0b2f101315 Reviewed-on: https://gerrit.libreoffice.org/55163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01remove old "convert to SVM1" code only active in debug modeNoel Grandin
Change-Id: I1d83e6ea5f8eb998f95e6ec334a695eb1df78df1 Reviewed-on: https://gerrit.libreoffice.org/55173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-31connect up accessibility locationCaolán McNamara
Change-Id: I226e42cf6bd7aa455514439f7303b490aa6d192d Reviewed-on: https://gerrit.libreoffice.org/55137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31focus rect for value setCaolán McNamara
Change-Id: I208cf42db4256bb7286222781cf2bf29f843c673 Reviewed-on: https://gerrit.libreoffice.org/55101 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31drop Graphic::GetBitmapNoel Grandin
so that we flush out various code using Bitmap, in favour of using BitmapEx. This is part of the process of making Bitmap largely an internal detail of vcl Change-Id: Iaf2ead5e3d9960838723fb55b812b97108093d74 Reviewed-on: https://gerrit.libreoffice.org/55062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-31move some CanvasHelper::implDrawBitmap inside vclNoel Grandin
part of making mask and alpha internal details of Bitmap/BitmapEx Change-Id: I87ca24af18a29f5eb8a5761c5d95ae2806d97e77 Reviewed-on: https://gerrit.libreoffice.org/55078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-30tdf#112034 , tdf#107266 label color on basis of persona and personaKshitij Pathania
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-30ImplSplitSet::mpBitmap is unusedNoel Grandin
Change-Id: Iadbeb462a34b9bdabe5bf71249eeef798fe6372a Reviewed-on: https://gerrit.libreoffice.org/55044 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30Remove AddTable unused return typeStephan Bergmann
Change-Id: Ied2dfddab780cac1a5edc21519240537d2054b1c Reviewed-on: https://gerrit.libreoffice.org/55042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-30tdf#116498 Use win metrics for 'DIN Light' fontSamuel Mehrbrodt
This adds a special treatment for fonts which rely on the win metrics for correct line spacing calculation. At the moment, only 'DIN Light' is known to need that treatment. Change-Id: Idd9fd6f63083ab7a706e0cbcd33a947d4949d4e9 Reviewed-on: https://gerrit.libreoffice.org/53962 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-30use BitmapEx in the screenshot stuffNoel Grandin
part of the process of moving Bitmap usage to BitmapEx Change-Id: I4f02f8aa60d19a3639d623a998491447adf79e15 Reviewed-on: https://gerrit.libreoffice.org/55031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30Bitmap->BitmapEx in FixedBitmapNoel Grandin
Change-Id: I0e409beb0d046d927b6a0c1987abec42df76727d Reviewed-on: https://gerrit.libreoffice.org/55032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29Remove unused SFErrCodes::TableFormatStephan Bergmann
...which was apparently unused (under its original name SF_TABLEFORMAT) ever since its introduction in 571f15004533c1e7a5472e033139d5765862fb73 "Unix PS- Print Environment". (Not sure what its appearance in the comment to AddTable, also there since that introductory commit, was ever supposed to mean.) Change-Id: I363e21e2e2d23aaf17c6f10b3936ba700203b9eb Reviewed-on: https://gerrit.libreoffice.org/55020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29Change SFErrCodes to scoped enumStephan Bergmann
Change-Id: Ib2f267397e419e8164bb2d732f7cbcca7acad1a6 Reviewed-on: https://gerrit.libreoffice.org/54996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>