summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2018-07-06uitest logger: log the events calling CallEventListeners()Saurav Chirania
Some events directly call CallEventListeners() instead of calling ImplCallEventListenersAndHandler. This patch thus moves logAction to CallEventListeners() Further, this patch adds logging for EditSelectionChanged which is broadcasted using CallEventListeners(). Change-Id: Ib15367688cdbcdb542f6139d270d8d463f214fde Reviewed-on: https://gerrit.libreoffice.org/56952 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Some cleanup and commentsJan-Marek Glogowski
Change-Id: Ic1dda9b0e5d7896703b65d0d43be340196bcb871
2018-07-04Notebookbar:Context for printpreview is now workingKshitij Pathania
Also the context stuff is now working well even after print preview is set Change-Id: Ia43f512394cf4d162b4019257c039aecb664df22 Reviewed-on: https://gerrit.libreoffice.org/56740 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-04Make ThreadPool::pushTask take param by std::unique_ptrNoel Grandin
And fix leak in XclExpRowBuffer::Finalize, was not freeing the synchronous task it creates Change-Id: Id1e9ddb5d968e6b95d9d2b5ca0c9e50774580182 Reviewed-on: https://gerrit.libreoffice.org/56874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-30cppcheck: variableScopeJochen Nitschke
and use unique_ptr for vector elements Change-Id: I5421a53e96928699fd451d4ff3e2eef0bf847f42 Reviewed-on: https://gerrit.libreoffice.org/56772 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-29Improved loplugin:redundantcast (const-qualified typedefs): vclStephan Bergmann
Change-Id: Iac5978ee41f76a2b34c7dae12509212ba1c9d7e7 Reviewed-on: https://gerrit.libreoffice.org/56706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-27This assert() seems superfluousTor Lillqvist
The assertion fails when one reproduces tdf#69460 but removing the assert() does not cause any problems. Change-Id: Idaa5d41a0cf76073e406d7152fc3b4e9ebd3e876 Reviewed-on: https://gerrit.libreoffice.org/56538 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-27vcl: prefer OpenType font feature description over GraphiteTomaž Vajngerl
If the fon supports Graphite features we can get the feature descriptions from the font, but this descriptions are mostly limited (available in a limited number of languages), so it is better to only use this descriptions only if the feature does not have an OpenType description available. Change-Id: Ic0b81cb8cc22e1e73f30e6a960167cfa982fbfc7 Reviewed-on: https://gerrit.libreoffice.org/56318 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-25weld SwWatermarkDialogCaolán McNamara
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-24uitest logger: some changes in log statementsSaurav Chirania
These changes will allow the interpreter introduced in gerrit change number 56120 to understand these log statements. Change-Id: I68a406cd19bbe1cfe5b6563025348263d564d5af Reviewed-on: https://gerrit.libreoffice.org/56305 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-24uitest logger: print parent when logging keysSaurav Chirania
Change-Id: I130f266016dc51dab5e4d1395fe579ca21a1b835 Reviewed-on: https://gerrit.libreoffice.org/55675 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-24vcl: treat description of cv** & ss** font features speciallyTomaž Vajngerl
To avoid adding descriptions for each of font features cv** and ss**, where ** is a number between 00-99, process them separately and just use one description for each. This simplifies translation as we don't need to add 99 copy-paste translations but add a bit more complexity when looking up the descriptions. Change-Id: Ia6e9554af20355c90c73afeec33fd18c694865b9 Reviewed-on: https://gerrit.libreoffice.org/56317 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-22tdf#116208 vcl opengl: fix lack of updates in status barMiklos Vajna
Commit f0821f9a347c7752a3c741c3451a2f1630173720 (Cache text layout of statusbar items, 2017-06-08) was a performance improvement of not laying out the text of status bar text during each & every paint. One of these places didn't work correctly with Chinese text, so commit a4ed3d9a1ffa1b51ba4352a955c950235f099fdc (tdf#115353 Status bar: no cache in settext, 2018-03-01) attempted to disable the caching at that particular place by removing the update of the cache. This resulted in lack of updates, e.g. during typing into Writer and checking the word count part of the status bar. Fix this (and at the same time keep the original problem fixed) by still not using the layout cache and that problematic place, but instead of just not updating the cache actually invalidate it -- probably that was the intention in the force place already. Change-Id: Ib7b91e5f24bc68d2f8cae2efea64340585ad9bd5 Reviewed-on: https://gerrit.libreoffice.org/56304 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-22Resolves: tdf#115816 simpler fix for masterCaolán McNamara
Change-Id: Ibafd041728624e781b5da44a0b484206f760d4d0 Reviewed-on: https://gerrit.libreoffice.org/56248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21Resolves: tdf#115816 second 'Insert' menu is pasteCaolán McNamara
reuse existing translation to be backportable wrt no new translations Change-Id: I1fb94f66d696f836e8f6a10ba2d6933f69cfac95 Reviewed-on: https://gerrit.libreoffice.org/56225 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20Add UI test for the Customize dialogMuhammet Kara
Change-Id: I00109ef54ec7cfc1f4976794daa92ded3cd6ce4b Reviewed-on: https://gerrit.libreoffice.org/53119 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-19tdf#103913 keep ".emf" file extension and mime typeLászló Németh
in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: https://gerrit.libreoffice.org/56045 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-18weld SfxSecurityPageCaolán McNamara
and drop the sole use of WB_EARLYTOGGLE Change-Id: I01e7d085eb3f9daf5a62a048178ab90defb4c5b1 Reviewed-on: https://gerrit.libreoffice.org/55983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18Skip required features from the features dialogKhaled Hosny
Many OpenType features are required features that are applied to certain context determined by the layout engine, or should always be on. There is no value in presenting these features to the user and they just clutter the dialog for fonts that usually have many of such features (e.g. Arabic or Indic fonts). Change-Id: Idc3d7d3a9eb1c4f693ea6fdf9f26f0264b910f91 Reviewed-on: https://gerrit.libreoffice.org/55951 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-18tdf#108523 Remove @author annotationsAbhyudaya Sharma
Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc Reviewed-on: https://gerrit.libreoffice.org/55263 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18vcl: share GfxLinkAshod Nakashian
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-17gtk3: Correctly mirror popovers in rtl uiMaxim Monastirsky
e.g. formula prompt or fill series in Calc. The reason is that for this particular vcl::Window, HasMirroredGraphics() != IsRTLEnabled(). Change-Id: Icd4bb2d22ba77d64c32b243d9c07745824e5e558 Reviewed-on: https://gerrit.libreoffice.org/55936 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-16vcl: parser of font features included in the font nameTomaž Vajngerl
Change-Id: I7347410b4eb5e940d94c34aac4fdf344869541fa Reviewed-on: https://gerrit.libreoffice.org/55893 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-16fix build because of the change to Reference<LogicalFontInstance>Tomaž Vajngerl
Change-Id: I97c23685d70c751dc6b365db776c4438a5f05db0
2018-06-16tdf#58941 implement retrieving font features and structuresTomaž Vajngerl
This adds the following: - Retrieving of features using HarfBuzz - Retrieving of feature definitions from graphite fonts - Adds description texts of OpenType features - Tests for retrieving features (Linux Libertine G graphite font) and making sure the features and definitions are what we expect. Change-Id: I51573fe086e59c6228cb546bbfac95ac53824c47 Reviewed-on: https://gerrit.libreoffice.org/55892 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-14Remove now unusedsEike Rathke
Which effectively would be going to happen with https://gerrit.libreoffice.org/49033 for 6-0 and https://gerrit.libreoffice.org/55795 for 6-0-5 so have the same on master in case it would have unknown side effects. Change-Id: I312d7c5e723fb9417ac512641acb843ecd7a9867 Reviewed-on: https://gerrit.libreoffice.org/55811 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-14Icons in menubutton are visible nowKshitij Pathania
Change-Id: Icccf8ebfafcb556327def38bc37d1d25a1b6e58d Reviewed-on: https://gerrit.libreoffice.org/55744 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-14do setPreviewsToSamePlace at SfxTabDialogController display timeCaolán McNamara
Change-Id: Ia38c1a577b7d054ab4e7e70a8f2cbce16a3573f5 Reviewed-on: https://gerrit.libreoffice.org/55793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14return SalBitmap using std::shared_ptrNoel Grandin
since we hold it like that in Bitmap anyway Change-Id: I6264dfaaae6210cb008df5db8a421fc80c508f5b Reviewed-on: https://gerrit.libreoffice.org/55458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14wayland: Make popup menus not show off-screenMaxim Monastirsky
Depends on gtk 3.22 for gtk_menu_popup_at_rect. Had to rework the toolbar context menu to not execute async, as otherwise it just closes immediately. (Basically it's same as rhbz#1342823, except that I couldn't find a way to feed gtk_menu_popup_at_rect with the correct timestamp). Change-Id: I779d8803c80314d93a342f1294c7280f1adf4c98 Reviewed-on: https://gerrit.libreoffice.org/55772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-13weld SvxCharTwoLinesPageCaolán McNamara
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13tdf#109353 - Base: Listbox doesn't show a value.Alex McMurchy1917
This is because text in box is same colour as the background. This is only an issue for Linux/KDE. This change fixes this issue. Change-Id: Icb908ace25c69fd2fb51f8f44082ca6b00f55c43 Reviewed-on: https://gerrit.libreoffice.org/55660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-12WIP: uitest: complete combobox, tabcontrol wrapperSaurav Chirania
Change-Id: I3ba1b0d1b5412c30e540cf45fe21ef946839afed Reviewed-on: https://gerrit.libreoffice.org/55372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-12crashtesting: asserts on inability to scale oversize graphicsCaolán McNamara
since... commit d46c32140fdb05758c039dd27552b1788faac104 Date: Thu Jun 7 12:37:33 2018 +0200 assert in BitmapInfoAccess if bitmap is empty or we can't read from it Change-Id: I138a53e9ce0763d4e62cfbba594abb323e807378 Reviewed-on: https://gerrit.libreoffice.org/55704 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12remove incorrect SAL_WARN in BitmapInfoAccess::BitmapInfoAccessNoel Grandin
just because use_count is > 2, doesn't mean we have two simultaneous writes, could be 2 readers and a writer Change-Id: Ife7fc91ff2e597e6bb847460f46bdde954e63e4f Reviewed-on: https://gerrit.libreoffice.org/55695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12crashtesting: asserts on empty gifsCaolán McNamara
since... commit d46c32140fdb05758c039dd27552b1788faac104 Date: Thu Jun 7 12:37:33 2018 +0200 assert in BitmapInfoAccess if bitmap is empty or we can't read from it Change-Id: I0861667227b512634bce7381ef77ab99c7c011cf Reviewed-on: https://gerrit.libreoffice.org/55685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12loplugin:constantparamNoel Grandin
Change-Id: Ia769b3176aea287cd57414d7ce8e88c6da43883e Reviewed-on: https://gerrit.libreoffice.org/55622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#117175 wayland: Make popup windows not show off-screenMaxim Monastirsky
Depends on the gtk-3-24 dev branch, for the public gdk_window_move_to_rect symbol. Change-Id: Ic7a34ceb3d133ecac2addac54cf5f635eea332ed Reviewed-on: https://gerrit.libreoffice.org/55612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-11loplugin:unusedfieldsNoel Grandin
Change-Id: I42a55562747e6097c1193e285da67235f5364bea Reviewed-on: https://gerrit.libreoffice.org/55610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I26a0da1ec9cda9030371977596053a45303756a0 Reviewed-on: https://gerrit.libreoffice.org/55609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11new loplugin:shouldreturnboolNoel Grandin
look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11drop PhysicalFontFace::CloneNoel Grandin
since we are now holding these via reference counting, no need to clone them Change-Id: I7b0bd86f4a5bca428f7dcd989f838a9aa0c7e179 Reviewed-on: https://gerrit.libreoffice.org/55427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09rename SalPrinterQueueInfo::mpSysData to mpPortNameNoel Grandin
and simplify, most places can just leave it alone Change-Id: Id938ec12d21ef244a15b5e5a72626c5ad0d0e124 Reviewed-on: https://gerrit.libreoffice.org/55499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalMenu by std::unique_ptrNoel Grandin
and drop DestroyMenu, all the implementations just delete the object Change-Id: I673997ea1a9c5216b100cafdc70a8f697732769b Reviewed-on: https://gerrit.libreoffice.org/55501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return and hold SalMenuItem by std::unique_ptrNoel Grandin
and drop DestroyMenuItem, all the implementations were just deleting the pointer Change-Id: I058817b963988b1e399279f61f45716a2cdba023 Reviewed-on: https://gerrit.libreoffice.org/55500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-11 22:46:00 +0000