Age | Commit message (Collapse) | Author |
|
Change-Id: I545aa03d46b0673aafe73daa23047d2a4b6936dd
|
|
Change-Id: I5d7127bfc639591862cea91f0597ef050112b43b
|
|
Change-Id: Ibd1d27767b5679a3375d43851363de8c207a43ff
|
|
Change-Id: Ia1352105acef1ededaf876a224ebc277121d6942
|
|
Change-Id: I020ce8efc9d2315a0d6d72914976c2a01b893d12
|
|
Audit for this problem in:
"vclwidget: change all vcl::window fields to be wrapped in VclPtr"
Change-Id: I6e57f078364a7fd3fd4e61c748d7af843458758e
|
|
Change-Id: I7524ca3da7d134d94553be0e7a6db7e879984ae8
|
|
Change-Id: Ifd52953086ea923fa1770892d13f32c2263aec54
|
|
Change-Id: I98fcf119a1a7118b46482a43c5f8acb7f0044900
|
|
Change-Id: I2411ce6d661f5bcbdc5e6d09f195ba6f15da24ba
|
|
Change-Id: I4da1f4daaf94456bc951b1d7a96cb28cb7fba0e9
|
|
Change-Id: I46e1b2fac3e49e1ef1a0aa7de7fc8e8cb90ddcf8
|
|
Change-Id: I2100de7c599c3d2c241e336d369fc5998e23af16
|
|
Change-Id: Iadd2b5214661e00209f789c9ada83d5d9dce12b7
|
|
Change-Id: I79e15b45769ced44b1679943972f7a71c7df8fca
|
|
Change-Id: I578aa360c9923abd3fc516865896a004f377375b
audit: "vclwidget: check for calling delete on subclasses of vcl::Window"
|
|
Another (complete) audit of delete usage in:
"vclwidget: change all vcl::window fields to be wrapped in VclPtr"
Change-Id: I828212ded66ecc5cc30c75a4de626c7b386cb77a
|
|
Change-Id: I2500a2079cd029505f404f34c9b3d9ec1961afbd
|
|
workaround "OutputDevice subclass should have nothing in it's destructor
but a call to disposeOnce()."
Change-Id: Icc7e09ea4dec3292b62d1aba4dc881220c115414
|
|
Change-Id: Ia0c259a4518e91b3dac50927812bef717bce5273
|
|
Change-Id: Ic61f85ef159981721420ebc5157bcf09cf09ec51
|
|
Change-Id: Id12dbb9219a9581dd52d1f820c47f3da47b62187
|
|
Change-Id: I1468fc94aa0c709528a767b96bc26eefdb7ed08f
|
|
Change-Id: Ibc091cefab7fb0b628db0896af077a03fcda4094
|
|
Change-Id: I667852d1c854259ed698541b868a49322c6fbe64
|
|
Change-Id: If1926c8ecc94c3b9786a3f255371b440c482a155
|
|
Change-Id: I9a1d47202e2794461f6ec44f3e72ee1dd2fde09d
|
|
Change-Id: I364c5eb176d5003deb1938810cccf4f2aaedbd59
|
|
Now its ok to reference / un-reference ourself during construction.
Change-Id: Ib3b302719c7d40d7a42272f93db5e4c437859cad
|
|
Document that in README.lifecycle; the problem is that our constructors
currently take and release references left/right on the object being
created, which ... means we need an initial reference.
Change-Id: I5de952b73ac67888c3fbb150d4a7cde2a7bc9abf
|
|
Change-Id: I4a28ba4740e9c84666cd85c046598862f20a7a96
|
|
This pointer is used to pass extra information through dialog
constructors, and (as such) if implemented with a VclPtr it causes
us to take and then release a reference on our in-construction
object, before it can return it's 'this' into the safety of its
calling VclPtr<> constructor; not good. cf.
Dialog::doDeferredInit vs. SystemWindow::loadUI.
Change-Id: Idcab40cedcdebed560077cfaa1a14395e6e01cd6
|
|
Change-Id: I33ec0318a257929583aa4bb0d107f16d1f8edbcd
|
|
Change-Id: Ia7085cf98141fdbd50cf9cc9ed45e2e0c09e448e
|
|
Change-Id: Ie6f135d9e91d0831717c2a0726161825d0a06665
|
|
also audit commit: "start wrapping OutputDevice in VclPtr"
Change-Id: I6e018d7c3e3c8f941c184ad1aaa8593f7750c620
|
|
Change-Id: I0e9460cb33b7cb5da9ddb950ff27bac8cbf7fed8
|
|
No need to pay a per-instance cost for this, also avoid a self
reference for every Window sub-class.
Change-Id: I040a0ede9481229e43a39bc23297969e90b95f5e
|
|
Change-Id: I2b154e0ed9eee0a45900ada7f805a1d444a31bc0
|
|
Change-Id: Ic5bc5c3325b460cba0d95484454c9bb826684890
|
|
Change-Id: I2149511f958ba75e81dc41b10b01eb9d19610037
|
|
Without this, assigning to a ScopedVclPtr instance thus:
pScopedVclPtr = new Foo();
constructed a new intermediate ScopedVCLPtr, used a default assignment
operator, unhelpfully disposing the new Foo before it could make it to
pScopedVclPtr => add operator, and hide problematic constructors.
Change-Id: Icc0da962938bf115eac0c24a6a76cfeb66ddf23a
|
|
Change-Id: Iebdf2af3866d884289f6913646106fe3f2d4dde5
|
|
Change-Id: Ia742c47399231bc5914b6586132ad3daf694fdb0
|
|
They need to be wrapped in ScopedVclPtr in order to be disposed properly.
Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
|
|
Change-Id: Iba04ec828f7ce37fc6ede28a64f1c286d81ff705
|
|
Change-Id: I71c877773cbdabe10f617d1d3d7141ebd6d93923
|
|
Change-Id: I4f05929daa8b78b309d8a0498a2bb3246af9e18a
|
|
Change-Id: Ib593f05447a8a657649ef83febb4ef0e5b6476dd
|
|
Change-Id: If3ecbb0599b50d50ce6b3997ca7892200c332ffe
|