summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20Add UI test for the Customize dialogMuhammet Kara
Change-Id: I00109ef54ec7cfc1f4976794daa92ded3cd6ce4b Reviewed-on: https://gerrit.libreoffice.org/53119 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-19tdf#103913 keep ".emf" file extension and mime typeLászló Németh
in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: https://gerrit.libreoffice.org/56045 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-18weld SfxSecurityPageCaolán McNamara
and drop the sole use of WB_EARLYTOGGLE Change-Id: I01e7d085eb3f9daf5a62a048178ab90defb4c5b1 Reviewed-on: https://gerrit.libreoffice.org/55983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18Skip required features from the features dialogKhaled Hosny
Many OpenType features are required features that are applied to certain context determined by the layout engine, or should always be on. There is no value in presenting these features to the user and they just clutter the dialog for fonts that usually have many of such features (e.g. Arabic or Indic fonts). Change-Id: Idc3d7d3a9eb1c4f693ea6fdf9f26f0264b910f91 Reviewed-on: https://gerrit.libreoffice.org/55951 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-18tdf#108523 Remove @author annotationsAbhyudaya Sharma
Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc Reviewed-on: https://gerrit.libreoffice.org/55263 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-18weld SfxManageStyleSheetPageCaolán McNamara
Change-Id: I3769d294e5a5458d3172c330360f7e6207c3d1b1 Reviewed-on: https://gerrit.libreoffice.org/55961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18vcl: share GfxLinkAshod Nakashian
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-17gtk3: Correctly mirror popovers in rtl uiMaxim Monastirsky
e.g. formula prompt or fill series in Calc. The reason is that for this particular vcl::Window, HasMirroredGraphics() != IsRTLEnabled(). Change-Id: Icd4bb2d22ba77d64c32b243d9c07745824e5e558 Reviewed-on: https://gerrit.libreoffice.org/55936 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-16vcl: parser of font features included in the font nameTomaž Vajngerl
Change-Id: I7347410b4eb5e940d94c34aac4fdf344869541fa Reviewed-on: https://gerrit.libreoffice.org/55893 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-16fix build because of the change to Reference<LogicalFontInstance>Tomaž Vajngerl
Change-Id: I97c23685d70c751dc6b365db776c4438a5f05db0
2018-06-16tdf#58941 implement retrieving font features and structuresTomaž Vajngerl
This adds the following: - Retrieving of features using HarfBuzz - Retrieving of feature definitions from graphite fonts - Adds description texts of OpenType features - Tests for retrieving features (Linux Libertine G graphite font) and making sure the features and definitions are what we expect. Change-Id: I51573fe086e59c6228cb546bbfac95ac53824c47 Reviewed-on: https://gerrit.libreoffice.org/55892 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-14Remove now unusedsEike Rathke
Which effectively would be going to happen with https://gerrit.libreoffice.org/49033 for 6-0 and https://gerrit.libreoffice.org/55795 for 6-0-5 so have the same on master in case it would have unknown side effects. Change-Id: I312d7c5e723fb9417ac512641acb843ecd7a9867 Reviewed-on: https://gerrit.libreoffice.org/55811 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-06-14Icons in menubutton are visible nowKshitij Pathania
Change-Id: Icccf8ebfafcb556327def38bc37d1d25a1b6e58d Reviewed-on: https://gerrit.libreoffice.org/55744 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-14do setPreviewsToSamePlace at SfxTabDialogController display timeCaolán McNamara
Change-Id: Ia38c1a577b7d054ab4e7e70a8f2cbce16a3573f5 Reviewed-on: https://gerrit.libreoffice.org/55793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14return SalBitmap using std::shared_ptrNoel Grandin
since we hold it like that in Bitmap anyway Change-Id: I6264dfaaae6210cb008df5db8a421fc80c508f5b Reviewed-on: https://gerrit.libreoffice.org/55458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14wayland: Make popup menus not show off-screenMaxim Monastirsky
Depends on gtk 3.22 for gtk_menu_popup_at_rect. Had to rework the toolbar context menu to not execute async, as otherwise it just closes immediately. (Basically it's same as rhbz#1342823, except that I couldn't find a way to feed gtk_menu_popup_at_rect with the correct timestamp). Change-Id: I779d8803c80314d93a342f1294c7280f1adf4c98 Reviewed-on: https://gerrit.libreoffice.org/55772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-13weld SvxCharTwoLinesPageCaolán McNamara
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13tdf#109353 - Base: Listbox doesn't show a value.Alex McMurchy1917
This is because text in box is same colour as the background. This is only an issue for Linux/KDE. This change fixes this issue. Change-Id: Icb908ace25c69fd2fb51f8f44082ca6b00f55c43 Reviewed-on: https://gerrit.libreoffice.org/55660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-12WIP: uitest: complete combobox, tabcontrol wrapperSaurav Chirania
Change-Id: I3ba1b0d1b5412c30e540cf45fe21ef946839afed Reviewed-on: https://gerrit.libreoffice.org/55372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-12crashtesting: asserts on inability to scale oversize graphicsCaolán McNamara
since... commit d46c32140fdb05758c039dd27552b1788faac104 Date: Thu Jun 7 12:37:33 2018 +0200 assert in BitmapInfoAccess if bitmap is empty or we can't read from it Change-Id: I138a53e9ce0763d4e62cfbba594abb323e807378 Reviewed-on: https://gerrit.libreoffice.org/55704 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12remove incorrect SAL_WARN in BitmapInfoAccess::BitmapInfoAccessNoel Grandin
just because use_count is > 2, doesn't mean we have two simultaneous writes, could be 2 readers and a writer Change-Id: Ife7fc91ff2e597e6bb847460f46bdde954e63e4f Reviewed-on: https://gerrit.libreoffice.org/55695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12crashtesting: asserts on empty gifsCaolán McNamara
since... commit d46c32140fdb05758c039dd27552b1788faac104 Date: Thu Jun 7 12:37:33 2018 +0200 assert in BitmapInfoAccess if bitmap is empty or we can't read from it Change-Id: I0861667227b512634bce7381ef77ab99c7c011cf Reviewed-on: https://gerrit.libreoffice.org/55685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12loplugin:constantparamNoel Grandin
Change-Id: Ia769b3176aea287cd57414d7ce8e88c6da43883e Reviewed-on: https://gerrit.libreoffice.org/55622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#117175 wayland: Make popup windows not show off-screenMaxim Monastirsky
Depends on the gtk-3-24 dev branch, for the public gdk_window_move_to_rect symbol. Change-Id: Ic7a34ceb3d133ecac2addac54cf5f635eea332ed Reviewed-on: https://gerrit.libreoffice.org/55612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-11loplugin:unusedfieldsNoel Grandin
Change-Id: I42a55562747e6097c1193e285da67235f5364bea Reviewed-on: https://gerrit.libreoffice.org/55610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I26a0da1ec9cda9030371977596053a45303756a0 Reviewed-on: https://gerrit.libreoffice.org/55609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11new loplugin:shouldreturnboolNoel Grandin
look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11drop PhysicalFontFace::CloneNoel Grandin
since we are now holding these via reference counting, no need to clone them Change-Id: I7b0bd86f4a5bca428f7dcd989f838a9aa0c7e179 Reviewed-on: https://gerrit.libreoffice.org/55427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09rename SalPrinterQueueInfo::mpSysData to mpPortNameNoel Grandin
and simplify, most places can just leave it alone Change-Id: Id938ec12d21ef244a15b5e5a72626c5ad0d0e124 Reviewed-on: https://gerrit.libreoffice.org/55499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalMenu by std::unique_ptrNoel Grandin
and drop DestroyMenu, all the implementations just delete the object Change-Id: I673997ea1a9c5216b100cafdc70a8f697732769b Reviewed-on: https://gerrit.libreoffice.org/55501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return and hold SalMenuItem by std::unique_ptrNoel Grandin
and drop DestroyMenuItem, all the implementations were just deleting the pointer Change-Id: I058817b963988b1e399279f61f45716a2cdba023 Reviewed-on: https://gerrit.libreoffice.org/55500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalPrinter with std::unique_ptrNoel Grandin
and remove DestroyPrinter, doesn't not anything beyond delete'ing the object Change-Id: I25e14b962e65a0e131fae3ff5771c82920a4e375 Reviewed-on: https://gerrit.libreoffice.org/55498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return SalSession with std::unique_ptrNoel Grandin
Change-Id: I85527407c0cd2d3b94565fd7e24b0616948c9b0f Reviewed-on: https://gerrit.libreoffice.org/55497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalI18NImeStatus using std::unique_ptrNoel Grandin
Change-Id: I3657980045290a4d65b2944afac04d610c0a94fd Reviewed-on: https://gerrit.libreoffice.org/55496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08hold LogicalFontInstance with rtl::ReferenceNoel Grandin
instead of manual reference counting. Also the releasing of not-currently-in-use LogicalFontInstance objects from the cache is made less aggressive - we now only flush entries until we have less than CACHE_SIZE instances, instead of flushing the whole cache. Change-Id: Ib235b132776b5f09ae8ae93a933c2eebe5fa9610 Reviewed-on: https://gerrit.libreoffice.org/55384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08support comboboxtext id valuesCaolán McNamara
Change-Id: Ibebdaab5b073a55cb646687890bc16d5f55c0341 Reviewed-on: https://gerrit.libreoffice.org/55460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08sync tristate/inconsistent featureCaolán McNamara
Change-Id: Id1107f4fb1f51f377ad546f9b673f9037fee1538 Reviewed-on: https://gerrit.libreoffice.org/55459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-08tdf#117440 Can't move focus to disposed windowMaxim Monastirsky
xSaveFocusId is the already disposed comments floating window, so it can't accept focus anymore. Moreover, if closing the menu by clicking its title, the focus results nowhere, and no keyboard interaction works at all (including e.g. F6 or F10). This patch makes the focus switch back to the document, like it was in earlier LO versions. And does it in a way that doesn't break tdf#115227. Change-Id: I1d473557c10faf65b5b1fa917f5a5d66d0de8656 Reviewed-on: https://gerrit.libreoffice.org/55457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07assert in BitmapInfoAccess if bitmap is empty or we can't read from itNoel Grandin
and fixup the "make unique if two things want to write to bitmap at same time" check, it was using maBitmap before maBitmap has been assigned to. Lets just make it check something more useful, like the share count of the underlying SalBitmap. Change-Id: I97a629457174da2e4df1edc9674290aa9c9a2b52 Reviewed-on: https://gerrit.libreoffice.org/55416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07manage PhysicalFontFace by rtl::ReferenceNoel Grandin
Change-Id: I8f66b5afb066fe83abb83c56ebde6f21197f894b Reviewed-on: https://gerrit.libreoffice.org/55333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07vcl: svx: misc improvements to pdfium importingAshod Nakashian
Change-Id: I58f2fd973a731b148f40b37139cd74bac097a7d2
2018-06-07vcl: fix pdf rendering regressionAshod Nakashian
Change-Id: I6c2c48c033facb317b4ca7ed2af07348d6386b98 Reviewed-on: https://gerrit.libreoffice.org/54921 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07pdf: preserve the original page dimensions on importAshod Nakashian
Also allow for rendering PDFs to images at custom resolution, instead of hard-coded (old hard-coded value of 96 dpi is now default arguments). Change-Id: Ia5b52f72d6ce7130a2debc7c6f86504aa041bdc8 Reviewed-on: https://gerrit.libreoffice.org/54786 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: render the correct PDF page on swapping inAshod Nakashian
Change-Id: I81225e228d9cf2b9849110715dbfdeb59f2805dd Reviewed-on: https://gerrit.libreoffice.org/54746 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-06-07sd: support breaking any PDF pageAshod Nakashian
Change-Id: Ifa5f58163bef209a988fc0f88e2b609b1973e0d4
2018-06-07svx: support importing PDF imagesAshod Nakashian
Change-Id: Id4524a30b8f9fa4228c4acb4bf8714700da3017c
2018-06-07svx: support breaking PDFs imported as imagesAshod Nakashian
Change-Id: I990c2b3c3055fbffddedc407c34beb5824277b38