summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2017-09-25vcl: [loplugin:badstatics] rename xDefaultImplFontCharMapMichael Stahl
It looks harmless. Change-Id: Ibe54b9059f46ced95602914bf852d342aef89905
2017-09-25Disable Scheduler shutdown assertionJan-Marek Glogowski
This currently kills 50% of Windows Jenkins build, which I can't reproduce. So disable the assertion while looking for a real solution. Change-Id: Ic03787893b6a970b608e3e8bdd3247f4664be40e
2017-09-25Translate German comments and debug strings (leftovers)Johnny_M
Additionally: - A few grammatical fixes Change-Id: I15ba3809f6b4746be5a691ec2adc0ea17730fa4a Reviewed-on: https://gerrit.libreoffice.org/42690 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-25Different take on tdf#108406: exclude helpimg from installed themesKatarina Behrens
as it still might get selected as default theme under some circumstances and removing it from list in optgdlg.cxx leads to crash This reverts commit 60adba3fb904ed66251ff39c82fe20bec151ef0b but allegedly still crashes on Debian Change-Id: Ib853cc27058d8635482f19a8db26075d64103e1b Reviewed-on: https://gerrit.libreoffice.org/42545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-24tdf#106762 Avoid warning when opening and closing the color pickerMaxim Monastirsky
... from the Drawing toolbar in Impress. The warning was "DockingWindow has become non-layout because extra children have been added directly to it.", but this DockingWindow is actually a ToolBox which set as the parent of the color picker, although it isn't really a parent in layout terms. Change-Id: Id1384653ceda938ca0cc300c35467e562984bca1
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-09-24Support non-ToolBox popup case in DockingManager, tdf#106762 prepMaxim Monastirsky
Change-Id: I54d4de28336b70dbd07923377e6cceb67079fa80
2017-09-24Adjust DockingWindow layout calculation, tdf#106762 prepMaxim Monastirsky
This is needed for the color widget to have the correct size at initial show, and to keep this size after selecting a different palette. The parent FloatingWindow will assume that the border width stays outside the space that was allocated to the DockingWindow (see VclContainer::setLayoutPosSize), and yet DockingWindow tries to handle the border width as part of its allocated space. One option could be to let FloatingWindow handle this alone, but this won't work for other possible parents. The current solution is to load and store the border width in a way that can be used internally, but not visible to the outside world via get_border_width(). Change-Id: Id51152cf64eef719368e29253eb93e99834489cd
2017-09-23vcl: no need to have dispose() hereTakeshi Abe
Inlining it in dtor is enough. Change-Id: I20769f4b0af51103dd8fb2c5d24ee5e6ef2be1f8 Reviewed-on: https://gerrit.libreoffice.org/42634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-23vcl: Drop a couple of unused member variablesTakeshi Abe
Its usage was gone at df6ba2adbaeea9c5abe6e3ea0a583ec78ca9e7bd. Change-Id: Ia153cb8fb9247818684be09a81ac5eabdb1120e4 Reviewed-on: https://gerrit.libreoffice.org/42682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22vcl: [loplugin:badstatics] aInstanceMichael Stahl
Move this to struct ImplSVWinData, which is deleted on shutdown. Change-Id: Ie604c2105f1176858b4050fb34d37cf376f8f82a Reviewed-on: https://gerrit.libreoffice.org/42631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22vcl: [loplugin:badstatics] xCharClassMichael Stahl
There's even 2 of these; move them to struct ImplSVData which is deleted on shutdown. Change-Id: I8040cd6f9f31c0a1ab48987a490395f316d52220 Reviewed-on: https://gerrit.libreoffice.org/42630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-21Ignore AquaBlinker on Scheduler shutdownJan-Marek Glogowski
Change-Id: If107d2ac01b7be91be34ff753b52f307a6e10f58
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Workaround static Task destruction errorJan-Marek Glogowski
A task has to get the SchedulerLock to remove itself from the Scheduler list. This doesn't work, if the Task is static, as the static Scheduler might be destroyed earlier. In this case we fail with the following backtrace: #0 SchedulerMutex::acquire #1 Task::~Task #2 __run_exit_handlers Thanks to Michael Stahl to catching this backtrace. As a workaround this marks static tasks, so they ignore the SchedulerMutex in the destructor, We also mark all scheduled Tasks as "static" in DeInitScheduler, as their cleanup was already done. In the end all Tasks should be removed from static objects. Change-Id: I38be3206378b9449193efaccbc96896ac8de9478 Reviewed-on: https://gerrit.libreoffice.org/42574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-21ofz#2869 avoid oom with bmp rle imagesCaolán McNamara
and to the sanity checks on remaining data size *after* the seek to the offset, which requires moving the read of the palette to remain before that seek Change-Id: I687a79fb3f109556c1a7aaa9423f77a1eb98a3cf Reviewed-on: https://gerrit.libreoffice.org/42461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20Related: tdf#101881 keys not handled by native menubar sent to vcl oneCaolán McNamara
so 'o' pops up native menu, shift+o is unhandled by native, sent to vcl one which pops up some shoddy emulated version of the o menu Change-Id: Id6b0d27dd81f8a6d141cef79cc4825703c923636 Reviewed-on: https://gerrit.libreoffice.org/42538 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20Ignore DrawWorkStartupTimer on Scheduler shutdownJan-Marek Glogowski
Change-Id: Ia0cf4311b42dfa170ce429a958a26afd9c70ff0c
2017-09-19Assert active Tasks on scheduler de-initJan-Marek Glogowski
This shuts down the VCL scheduler later in the DeInitVCL call and asserts active pending tasks, as these will never be processed after shutdown. There is currently a TODO whitelist, so the unit tests still pass but probably most of these should be fixed. No task in the list looks critical - all seem to do some idle / cleanup work. This also processes all the Idles before shutdown. All seem to be of type sfx::SfxItemDisruptor_Impl. Change-Id: I9cc484a525cc2bacd54c4f271f86997517393e92 Reviewed-on: https://gerrit.libreoffice.org/40533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-19Unify SolarMutex implementationsJan-Marek Glogowski
All backends implement the SolarMutex in mostly the same way. So this consolidates this code into a GenericSolarMutex. We still need the abstract SolarMutex class for the fake AKA fascade implementation in dbaccess. The patch also replaces various places of direct mutex usage with either SolarMutexGuard or SolarMutexReleaser objects. Change-Id: Ia0146dd6c51a3b9a513cc6af34a66def58aad831 Reviewed-on: https://gerrit.libreoffice.org/42325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-18Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAryStephan Bergmann
Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334 Reviewed-on: https://gerrit.libreoffice.org/42406 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-17detect corrupted job setupCaolán McNamara
Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-16tdf#79877 add button text for 'previous' button (gtk-media-previous)Bernhard Widl
Change-Id: I605849cd753ed3f33b8dec5921488730dc9682dd Reviewed-on: https://gerrit.libreoffice.org/42332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-15some defaults for when config is unavailableCaolán McNamara
Change-Id: I0fd7cedbf9957707d56f99b5801dacf3a8868f02 Reviewed-on: https://gerrit.libreoffice.org/42337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-15Fix BASIC storage that stored an HTML <P> elementEike Rathke
&lt;P STYLE=&quot;margin-bottom: 0cm&quot;&gt; ended up in the XML stream, Regression from commit 2e0a25ce2b87d3a4bbf944025fc3720933fb391d Date: Fri Sep 8 08:31:42 2017 +0200 loplugin:constantparam that removed/kept the wrong path of !bHTML/bHTML Change-Id: I29ad9c4e7dff7a2d5537f5e52e7316aff7347c7a
2017-09-14use unique_ptr for mpControlFontNoel Grandin
Change-Id: I71eed3254cf073b754c1a634315e6e739a816606 Reviewed-on: https://gerrit.libreoffice.org/42264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14clang-tidy modernize-use-emplace in vclNoel Grandin
Change-Id: Ie0a6d105b0167431275e628935df4f4c1a36d070 Reviewed-on: https://gerrit.libreoffice.org/42259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13no need to call GetNumerator() / GetDenominator() for FractionNoel Grandin
simplify the calculations - why have a Fraction and then just split it up for the calculation? Change-Id: I81af95e1ee1633f77e088c0990f308b1c169a6a2 Reviewed-on: https://gerrit.libreoffice.org/42242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13drop first/last link callbackCaolán McNamara
of course this stuff is exposed through uno through com::sun::star::awt::XSpinListener so VclEventId::SpinfieldFirst and VclEventId::SpinfieldLast have to be retained Change-Id: Icbf31cc8c62f2bc3bc0ccf966c0fd4f5c43dcf6b Reviewed-on: https://gerrit.libreoffice.org/42231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-12tdf#108963 PDF export of editeng text highlight: handle rotated textMiklos Vajna
The highlight rectangle was not rotated, handle it similar to PDFWriterImpl::drawStrikeoutChar(). Change-Id: I97a5b1fc05706729c58c92b90d6808629af8ca4c Reviewed-on: https://gerrit.libreoffice.org/42180 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-12cppcheck: identicalConditionAfterEarlyExitJochen Nitschke
Change-Id: I59d91390ee303eadc10315405cce44cfd7c37d56 Reviewed-on: https://gerrit.libreoffice.org/42179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11Translate German comments/debug strings (leftovers in dirs vbahelper and vcl)Johnny_M
Translates leftovers found using a custom regex. Additionally: - Translated the "SGV Fonts for StarView" INI file parameter group in vcl/source/filter/sgf.ini and .../sgvtext.cxx Change-Id: I1360aac1a2f3fa825f86d77ac1b05e2de9ffb007 Reviewed-on: https://gerrit.libreoffice.org/42145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-11hidpi+gtk3: move setting the opengl slide viewportCaolán McNamara
to when the window size is set, and adjust to gtk3 hidpi scaling factor Change-Id: Id9bd0defd0b6ae640ac57f88133d954202d4bcc3 Reviewed-on: https://gerrit.libreoffice.org/42143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-10OSL_ASSERT->assert in putG4Bits (vcl)Julien Nabet
Change-Id: Iac93447146ba7d9b3ae7de4eca6fa272b1cc1187 Reviewed-on: https://gerrit.libreoffice.org/42133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-08tdf#108722 vcl: fix bugs in TextEngine with TEXTATTR_PROTECTEDMichael Stahl
1. If the cursor is at the end of the paragraph, attributes ending at that position are skipped in TextEngine::FindCharAttrib(). 2. If a TEXTATTR_PROTECTED is found, TextView::KeyInput() retains the selection that was extended to cover the attribute after deleting the text, because it compares to the initial selection. Why delete/backspace keys only work with the "gtk" vcl-plug but not "gtk3", "gen" or "kde4" is a mystery to me. Change-Id: Id7a6f298332f5a99454c793dd2dd6d424a975ad4
2017-09-08loplugin:constantparamNoel Grandin
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06Rename wrong name of vars in auto loopJulien Nabet
My commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=8c7b42c942d6693915dc825ede80279f720a5775 was wrong for some variable names, var in for loops aren't iterators on objects but objects Change-Id: I13484e5faa50aa8585231661846afa007b7a6eab Reviewed-on: https://gerrit.libreoffice.org/42026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-06Use o3tl::make_unique when var is unique_ptrJulien Nabet
Change-Id: I2d8b20aeb686bd4b59fe8dcaf695a17d94a440c9 Reviewed-on: https://gerrit.libreoffice.org/41967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06loplugin:unnecessaryparen include case statementsNoel Grandin
Change-Id: I79fb3eec0d5d466e33b2e18621a7169695edf82f Reviewed-on: https://gerrit.libreoffice.org/41920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-05Resolves: tdf#107249 round ascent/descent/extleading on conversion to intCaolán McNamara
Change-Id: Ia3ab5960d5288f5831aaa4ade800ca7513dad766 Reviewed-on: https://gerrit.libreoffice.org/41944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-05Drop lazywrite property, which is silently ignored by configmgr anywayStephan Bergmann
...at least ever since the "new" configmgr reimplementation, 6b849a6aeeb9ea8b1e25e28d5a8be390e425f84e "#i101955# initial work in progress of a configmgr reimplementation (for now in an extra module 'configmgr2')" et al Change-Id: I43430d991647fb2e26762463d51175247db0604b
2017-09-05Revert "Resolves: tdf#107249 round ascent/descent/extleading on conversion ↵Stephan Bergmann
to int" This reverts commit e2159061db8e266a3fe9f31773c676887168b254, it broke CppunitTest_vcl_complextext.
2017-09-05rename GetTTFontMterics -> GetTTFontMetricsNoel Grandin
Change-Id: I9952ddf0b1256e768a664f4da70455245cf67f41 Reviewed-on: https://gerrit.libreoffice.org/41934 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-05Resolves: tdf#107249 round ascent/descent/extleading on conversion to intCaolán McNamara
Change-Id: Iaf30b90762818c57fc0277e771b5bf172fb558be Reviewed-on: https://gerrit.libreoffice.org/41933 Reviewed-by: Michael Meeks <michael@gnome.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-04tdf#39468 Translate German comments/termsAndreas Brandner
Change-Id: I528e7e4b4d365ff512cd03ea22f7517319541e05 Reviewed-on: https://gerrit.libreoffice.org/41907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-12 01:56:53 +0000