summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2024-06-21tdf#161648 vcl a11y: Add weld::Toolbar::set_item_accessible_nameMichael Weghorn
Add API to set the accessible name of toolbar items and implement it for the VCL, gtk3 and gtk4 implementations. This will be used in an upcoming commit to set a11y names for the border items in Calc's sidebar. Change-Id: I958390d8736da8f1281f91586cacbefb5975e229 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169320 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-21tdf#161708 sw content controls: handle font color when exporting to PDF formMiklos Vajna
Export the bugdoc to PDF, the orange "date" lost its font color. This went wrong in commit 82d90529dc2b3cb8359dec78852cbd910a66d275 (sw content controls, rich text: add initial PDF export, 2022-09-12), we export the content control as a PDF form widget by default since then. Various properties like checkbox status and dropdown items were handled already, but not text color. Fix the problem by mapping the SwFont color to the widget descriptor color, this fixes the color of the already filled in content of the widget. Note that given this is a property of the form widget, the color is correctly applied also to strings filled in via PDF readers, interacting with the form. Change-Id: Id3e8611e415c0d571afe1cd14561c97b8a910ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169317 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-06-20loplugin:unusedfieldsNoel Grandin
Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-20pdf: remove CHECK_RETURN macro from codeTomaž Vajngerl
Doesn't help with code readability and makes code more complex. Change-Id: I0c1dc421d5fb173e610ab303d7c4f707dc65a093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169203 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-20Resolves tdf#153223 - Suppress variable line height when skia is offHeiko Tietze
Change-Id: I9194c25bf2fc104574bd27e6b8683b63111e6ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169192 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-06-20tdf#159835 vcl: Notify when floating window toggledMichael Weghorn
Notify listeners using an `VclEventId::WindowToggleFloating` event when the floating mode was toggled in `DockingWindow::SetFloatingMode`. This will be used in upcoming commit Change-Id: I9a7e341e88d2de5f34e8f85ebada3ff2ebf6b47d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Jun 18 13:41:03 2024 +0200 tdf#159835 sfx2: Keep sidebar menu up to date to react to that toggling. Change-Id: I5286ab727c30d4dd4bbc3cf5d42f19ff649b39f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169195 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-06-20tdf#159835 Deduplicate a few lines in DockingWindow::SetFloatingModeMichael Weghorn
They're the same for both branches. Change-Id: I73c3433fe3cfbb3eaa1b25cc2a76613d59d894a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169194 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-18loplugin:ostr in variousNoel Grandin
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-17annot: use createBitmapFromBuffer also when rendering the PDFTomaž Vajngerl
This removes the duplicated code. Change-Id: I54ada6875f7897b7eb480f10b8e1c8be887ca5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168978 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: make sure the annotation subtypes in PDFium match with oursTomaž Vajngerl
Change-Id: Ic18f394b532118f39988a650d046880b049c9ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168810 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: read PDF FreeText annotation "DS" and "RC" keysTomaž Vajngerl
DS (DefaultStyle) and RC (RichContent") contain xhtml, css3 rich text content for the text presented by the FreeText annotation in the document. This adds reading of those 2 things to the PDFium library, PDFium based import and the PDFAnnotationFreeTextMarker class. Change-Id: I32f89640611c730c8a1a8d1a2107e2e11669ec18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168787 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2024-06-14annot: add support to import Stamp annotation from PDFTomaž Vajngerl
Stamp annotation shows an arbitrary bitmap in the document, where the most common bitmaps are stamps like "Approved", "Confidential", "Expired", "Sold",... Change-Id: I332e34cbb346a686ee16eac7ca437ec4048e65ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168760 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-14annot: add annotation marker for free text annotationTomaž Vajngerl
Added new class PDFAnnotationMarkerFreeText as we need a marker to know if the annotation is a special one. Change-Id: Ica0e72dd6bf62b322676c8e87659a3850074522a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168759 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-12Resolves: tdf#160635 allow larger tiff imagesCaolán McNamara
Change-Id: I67a21877e7e75c2753218a7e6c978f691d679583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168747 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-10tdf#152024 Diacritics cut off at top and bottom of paragraphJonathan Clark
This change fixes issues causing Writer to clip paragraphs at the ascent of the top line, and descent of the last line, of a paragraph. This issue caused certain diacritics to render incompletely, or not at all. Change-Id: I99a3a25335f8b1d798fc8a55ff42d5c78749fca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168557 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-06-10tdf#99528 Use vertical tabs in para dialogSamuel Mehrbrodt
Change-Id: I7ec61c07f75e9a8aa124ac5b3d67c90077cca033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166625 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-06the remaining Help::GetHelpText calls don't want their parent as fallbackCaolán McNamara
so we can drop the hierarchical search these probably do nothing in the absence of the classic help. fpicker case might benefit from moving some a11y translations out of help into core. Change-Id: I01b8d0c7cc1a1b3697d3332e330c6b4654e76af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06drop searching for widget extended tips in the offline helpCaolán McNamara
by now these extended tips for the widgets of the general ui appear in the .ui file directly instead as accessibility descriptions instead. In any case, the default build configs of distro-configs/LibreOfficeLinux.conf distro-configs/LibreOfficeMacOSX.conf distro-configs/LibreOfficeWin64.conf use --with-help=html where these ahelps are not available. So, existing in the classic help only. Change-Id: Ie27736e9140e445c7f8986a741c2002f2efa9ccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06if we don't have local help then Help::GetHelpText will be emptyCaolán McNamara
anyway, so we can skip that work on Window::GetHelpText. It might even be that by now all the a11y/extended-tips are in the local .ui files and the whole fallback to local help is redundant and should be removed. But that's not done here. Change-Id: I03b759aba6d1619aff37ded6764fbe3b6ded9555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168494 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06Online: send color preview JSON property to onlineDarshan-upadhyay1110
- Autofilter has submenus like `filter by font color` and `filter by bg color` - to display it's color preview in online we some data from core to identify that it's a color base dialog - this patch will help to add color preview of following Change-Id: I71c4e276f8c6dd35d6d318ce67cedf9c15a91d29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165298 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5d7910f21e881998f142aef473b27ebfd29eb020) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-06-06tdf#161397 Fix incorrect glyphs for RTL font fallbackJonathan Clark
This change fixes an issue causing incorrect font fallback for certain RTL grapheme clusters. Change-Id: I6cff7f175b766d40c4faf204d1d65c8c366eb3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168410 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-06-05annot: improve PDF annotation export and clean-up PDFNote classTomaž Vajngerl
Add support for exporting more PDF annotation types and props. Prefix member variables in PDFNote class, extract it out of pdfwriter.hxx file into it's own header file. Change-Id: I99fb4cbb0c68fcec6585c9c21d81daaef26344cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168418 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-03tdf#161030 Improve vertical Tab list displaySamuel Mehrbrodt
* Increase width a bit to allow for longer tab names * Avoid jumping while moving through the list with arrow keys Change-Id: Ie418dd40c5f69dcdea8fa07743ff26e3c9e04ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168251 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-06-02cid#1602442 Uninitialized pointer fieldCaolán McNamara
Change-Id: I3586685ba132fd09b00d778fc3fe8e479d1a8aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-31tdf#99528 Move through tabs with Ctrl-PageUp/Down keysSamuel Mehrbrodt
As required by test_tab_navigation unit test Change-Id: Ia77aa57de420574922b4fd4a0759f18c2dc778f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166856 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-31Resolves tdf#161082 - Set focus on topmost item (Printer)Heiko Tietze
Change-Id: Ib5b8f2587efaa683a28f1d8298eb9bcba2539705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168280 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-05-31loplugin:indentation (macOS)Stephan Bergmann
Change-Id: I989ad1a8d8100a9bbd60d2bbd8aa1c206860d966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168243 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-05-30tdf#161006 tdf#161049 tdf#161020 tdf#161047 fix VertTabCtrl size calculationThorsten Behrens
* don't rely on initial dummy pages * so instead override GetOptimalSize() and do the math again * this assumes that all tab pages have been inserted at the time time GetOptimalSize() gets called for the last time Change-Id: I668347744d8ec9b94824f38cfc4b7ca00771a476 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168081 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-05-30'tagged' pdf export of spreadsheets doesn't perform wellCaolán McNamara
m_aStructure is appended to for every row and cell, so a spreadsheet with 20 cols and 100,000 rows is many seconds slower to export in 24.8 than 24.4 since: commit b3c93b16d62e809500005edc749af4b8ad10162c Date: Wed Jan 3 11:18:19 2024 +0100 tdf#123870 sc: fix tagged content for accessible PDF export Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161581 shave a sliver of work off. Change-Id: Ibeb817083fef3c9499326abe381527a31917303b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-29tdf#81272 Improved CJK fallback rendering performanceJonathan Clark
This change includes the following performance fixes: - Removes an expensive vector sort from fallback run computation. - Reduces unnecessary BreakIterator use while collecting grapheme clusters requiring fallback. Change-Id: I760825596e0609059ef0c5ca97e210ab6647e466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168175 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-05-28ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib5220d2f44344455e6333f24b0dc2a20e5f9b0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168126 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-28tdf#160971 gtk: Don't select combobox text on entry selectionMichael Weghorn
In the same way that Change-Id: I17ce71198ec37cb1735194818bae17d1a5654d89 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon May 27 13:35:52 2024 +0200 tdf#160971 qt a11y: Don't select combobox text on entry selection together with Change-Id: Ia2c77245049d708885cbd374c20ce1892259329b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon May 27 13:29:39 2024 +0200 tdf#160971 vcl a11y: Make combobox text selection mode style-able sets the style option to not select combobox text when switching between entries in an editable combobox for the Qt-based VCL plugins, do the same for the GTK-based VCL plugins, except for putting the text cursor at the beginning of the entry text instead of the end, as happens when using a native GtkComboBox (see tdf#160971 comment 11). Since the GTK-based VCL plugins use native GTK widgets in most places, the behavior for e.g. the "Font Name" combobox in Writer's Formatting toolbar is already like that without this change in place and is unaffected by this change (even though LO's gtk3 VCL plugin is using a custom combobox implementation, see vcl/uiconfig/ui/combobox.ui). However, the new behavior applies for combobox form controls, as can be seen e.g. with the sample doc attachment 194376 from tdf#160971. Change-Id: I5b17efaa167ab49d07f19b3649ff934cf0f34754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168104 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-28tdf#160971 vcl a11y: Make combobox text selection mode style-ableMichael Weghorn
When selecting an entry of an editable combobox, the whole text of the text entry currently gets selected. That matches the behavior observed with a sample Windows Forms application. However, both native GTK and Qt applications behave differently and do not select the combobox entry text (s. tdf#160971 comment 11 and the referenced sample programs and screencasts). The extra text (un)selection makes the Orca screen reader on Linux announce an extra "selection deleted" every time another entry is selected using the up/down keys e.g. in the font selection combobox in Writer's Formatting toolbar when using the qt6 VCL plugin and the combobox popup is not shown. Introduce a new style setting to define the text selection behavior when switching between entries in a ComboBox and take that into account in `ComboBox::ImplSelectHdl`. The default behaviour remains unchanged. Behavior for the Qt and GTK based VCL plugins will be aligned more with the behavior of corresponding native widgets in separate upcoming commits. Change-Id: Ia2c77245049d708885cbd374c20ce1892259329b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168102 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-26ofz#69256 Integer-overflowCaolán McNamara
Change-Id: I564635a52282ee632a0c028199ec86dd4bff99a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168044 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-23tdf#159899 sw: show hyperlink name as tooltipTibor Nagy
Change-Id: I48f841d1c42f9541e03632a88e1a4f65975a5335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167971 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-05-22tdf#124116 Correct Writer text shaping across formatting changesJonathan Clark
Previously, Writer performed shaping for each span of text separately. In certain situations, this caused incorrect glyph use, or incorrect glyph positioning. This change updates Writer so it will also consider neighboring text while performing shaping. This change resolves the outstanding duplicates filed against tdf#61444. As a side effect, this change also fixes tdf#134226. In addition to the shaping fix, this change implements rendering for individually-styled glyphs, which is required to fix tdf#71956. However, this change does not implement diacritic selection, which is also required for that issue. Change-Id: Iab4774ffaab5ad6113778c54d02cb260a70c1010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167699 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-05-19Resolves: tdf#157453 support FM_PROP_LINECOUNT for combobox dropdow rowsCaolán McNamara
Change-Id: I3d18ed505c2eea7305903f9a476c332db0148113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-19tdf#160884: Apply scale to position of embedded images in Type 3 fontsKhaled Hosny
Regression from: commit bc3f6c3a47411a3b5dafadca4e5c55cd24e30662 Author: Khaled Hosny <khaled@libreoffice.org> Date: Tue Aug 22 10:47:33 2023 +0300 tdf#155610: Workaround Acrobat bug with Type 3 fonts and unusual UPEM Change-Id: I5e352292268d19fb8348a038d251f2d395a0be46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167830 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: خالد حسني <khaled@libreoffice.org> Tested-by: Jenkins
2024-05-18lok: dump more SfxViewShell state, and LOK notifier state on Windows.Michael Meeks
This should help to associate the right view-ids, with the right windows, and help to catch any stray / lingering windows from closed sessions - hopefully. Change-Id: I197a3280d5d2aeddd356ee037c51e4887f43278b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167765 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 8d979fae0c435b820302c76fcfdc2642b4820360) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167684 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2024-05-18tdf#161154: pass "scaling is done externally" information down the stackMike Kaganski
VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D does the scaling, taking into account the font scaling. Before commit 8557ea84c9336ba8061246f1f46ddb6e02f413a1, D2DWriteTextOutRenderer was doing own scaling in addition, but it seems that it somehow didn't affect the result much. The said commit removed the scalng from D2DWriteTextOutRenderer. As tdf#160901 demonstrated, the scaling is necessary in different code paths - and it turns out, that we need to know, if the caller does its own scaling or not, to make a decision, if the scaling should be fone in D2DWriteTextOutRenderer. This hack passes this from VclProcessor2D to D2DWriteTextOutRenderer through OutputDevice. Thanks to Miklos for the isea. I still don't understand, why all this seemingly doesn't affect other renderers. Change-Id: I001036f4574898b8e7606652525638df43c35240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167786 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-05-17tdf#61444 Correct Writer text layout across formatting changesJonathan Clark
Previously, Writer performed text layout for each span of text separately. This caused incorrect kerning when the text style changed mid-word, for example by highlighting or changing the color of a single letter. This change updates Writer so it will also consider neighboring text while performing text layout. Change-Id: I511096c009343f39cc1b9ba745909c5b8cbad86f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167016 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-05-16VCL: Windows: more usecases for FlashWindow() API to inform on changesVasily Melenchuk
FlashWindow() can be used to bring user attention to application in background. Right now in LO it has implementation only for Windows. Here some new cases were added when flashing is used: * dialog window did open * document loaded * LO started Some redesign of previous solution is also performed: no manual search for top window, let's reuse existing code. Changed behavior for bringing LO window to foreground: it is made always and not depending on current value of NewDocumentHandling:ForceFocusAndToFront. It has no sense to tweak this behavior: if user clicks on document in file explorer, LO should came to foreground, no exceptions. Change-Id: I22b5b4e2b170cd25632083a55b3e9f0358bcae03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166615 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-05-15tdf#160690 set an opaque alpha mask for non-transparent framesPatrick Luby
Due to the switch from transparency to alpha in commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, an empty alpha mask is treated as a completely transparent bitmap. So revert all of the previous commits for tdf#157576, tdf#157635, and tdf#157793 and create a completely opaque bitmap instead. Note: this fix also fixes tdf#157576, tdf#157635, and tdf#157793. Change-Id: Ic2ccad6ab94e4d43b1b66013f85955d474dc0151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167563 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-05-14tdf#160824 vcl: Require mouse over spinfield to mouse-wheel through valuesMichael Weghorn
In the same way that commit 22250df05830700b2555348b8ac46ee1007d0e5d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Dec 8 11:50:40 2023 +0100 tdf#158548 vcl: Require mouse over listbox to mouse-wheel through entries restricted changing listbox values for the focused listbox on mouse-wheel to the case when the listbox is also hovered over by the mouse, do the same for `SpinField` as well, to avoid accidently changing the value as described e.g. for the tdf#160824 scenario. This is also in line with Qt spin boxes that only change their values on mouse-wheel when the mouse pointer is above them. For the gtk3 VCL plugin that uses native spin boxes, this commit has no effect, and the value doesn't change on mouse-wheel at all. Change-Id: I22277294f76655cd13b1dc57416c82afe44460d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167604 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-13vcl: Merge ComboBox and ComboBox::ImplMichael Weghorn
This removes one level of indirection. `ComboBox::Impl` had originally been introduced in commit ece8699f8f22f6bae137c601bc29b83b75dc3bf3 Author: Michael Stahl <mstahl@redhat.com> Date: Fri Jul 10 12:05:48 2015 +0200 vcl: pImplify ComboBox The boost::signal stuff is quite heavy (33 kloc), so try to hide it from the header. Change-Id: I87826ccfd2a151aff274ffa6b7159a988f751808 , but all of the boost usage in here has been replaced since then. Change-Id: Ia8fb5cb895800edae104857c7713fa65e509a3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167485 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-12replace createFromAscii with OUString literals in FilterConfigCacheNoel Grandin
Change-Id: I31a16e4b709955cb01d6aebaf169d40f71f7ea09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167551 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-11replace createFromAscii with OUString literals in OConfigurationNodeNoel Grandin
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11workaround clang segfault on macos-intelNoel Grandin
Change-Id: Icfced4a990e2d02995bff4078f14b8ee26e9cca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-11lok: Don't dump empty aria properties in every JSON element.Michael Meeks
They simply bloat the json to no benefit if the properties are empty, avoid serializing empty values. Change-Id: I83c780d01820ec39acc85899d45ad9e929ad7e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167496 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 24876e5611abbaec9b2fe5fcbcf4be71a10ee366) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167457 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-10lok: dumpState should truncate very long JSON messages.Michael Meeks
Otherwise we get huge dumps which can overwhelm our logging and hide more useful information, and/or the journal can drop them on the ground. Change-Id: Ie942c70a90a6df60ccd8986444362d622c213e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167456 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-04 22:52:32 +0000