summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2017-11-03loplugin:constparam in vcl,svtoolsNoel Grandin
Change-Id: I7a3eb2bfda869e9e66db919f929ead60cf8890a4 Reviewed-on: https://gerrit.libreoffice.org/44209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03improve debug printing of ErrCodeNoel Grandin
Change-Id: Ia6ebf2c43777774a91e27468272d713f0dadb1c3 Reviewed-on: https://gerrit.libreoffice.org/44204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03Replace some lists by vectors (vcl)Julien Nabet
Change-Id: Ic31f4f5a2f44e39ee965e7c3fc6a2246bbb10076 Reviewed-on: https://gerrit.libreoffice.org/44237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-03vcl: remove sgf/sgv ancient gfx filtersThorsten Behrens
Change-Id: Ib02986e5b3d54d65982836e22ebcb70eb7a0e7b3 Reviewed-on: https://gerrit.libreoffice.org/44216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-02improve constparam lopluginNoel Grandin
lots of little fixes to make the logic less pessimistic Change-Id: If368822984250b11b98c56f5890177a1402e8660 Reviewed-on: https://gerrit.libreoffice.org/44168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31tdf#113519: fix crash by releasing returned unique_ptrJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=19910c461230f70bb9e98ad44db3525f0d755724 tdf#112658: fix leak when calling TextEngine::SetAttrib Change-Id: Iee82196ca10d82e898d8806a11874c3bedc28895 Reviewed-on: https://gerrit.libreoffice.org/44077 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-31ReleaseYieldMutex is always called with trueNoel Grandin
so drop param and rename to ReleaseYieldMutexAll Change-Id: Ic4fcee24d46405659e54363c87f21d88696b0ce1 Reviewed-on: https://gerrit.libreoffice.org/44057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30Constify some VCL interface functionsJan-Marek Glogowski
This drops the bPaintEnd optimization for vertical and horizontal lines on Windows, where Polyline and LineTo exclude painting the last pixel of the line. Instead we just always set the last pixel. It also merges the various "SetPixel" call sites into a common drawPixelImpl function. Change-Id: I01cc3c01c908ba74f7978fa90eaaf8d88f923ae3 Reviewed-on: https://gerrit.libreoffice.org/43939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-30tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removing unnecessary 1L occurrences Change-Id: I85d4949eacde0dfc0ff7a513f4bf42324e6d34c1 Reviewed-on: https://gerrit.libreoffice.org/42840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30loplugin:constmethod in vcl and stocNoel Grandin
Change-Id: I7c02eecc16ca7cf89d9f7021116b0226885dbf06 Reviewed-on: https://gerrit.libreoffice.org/44044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+Furkan Ahmet Kara
Change-Id: If0ed3929f8faab187327b90e63014720e287e501 Reviewed-on: https://gerrit.libreoffice.org/43681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30loplugin:constantparam in vclNoel Grandin
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d Reviewed-on: https://gerrit.libreoffice.org/44043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30Replace list by vector for m_aSubsets (vcl)Julien Nabet
+ use for range loops for those related to m_aSubsets Change-Id: I2fa3e3c46394381f5d0bb042481c1884bfe52da9 Reviewed-on: https://gerrit.libreoffice.org/44033 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-27loplugin:includeform: vcl (Windows)Stephan Bergmann
Change-Id: I4a0fc4b483069141d2b943079adf5aa741df968e
2017-10-27Handle decimalSeparatorAlternative, tdf#81671Eike Rathke
Change-Id: I3a3d3b0683ea46cff5c023e911977ce5b2f5f032
2017-10-27Handle decimalSeparatorAlternative, tdf#81671Eike Rathke
Change-Id: Ica696322bfeea641452e73fd49bf89c33b6d4d96
2017-10-27support stock text in checkboxes and radiobuttonsCaolán McNamara
Change-Id: I03b2e125736b7f8a7127174a7a837760f76f8249 Reviewed-on: https://gerrit.libreoffice.org/43893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26vcl: minor cleanups in pdfdocumentMiklos Vajna
Change-Id: Ib1284b819d4af2e8055698be4160bbb41acba851 Reviewed-on: https://gerrit.libreoffice.org/43866 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-26Refactor font substitute removing (vcl/svtools)Julien Nabet
+ replace list by vector for maFontSubstList Change-Id: I4d5668611212358c759fa5cf26f5341311551298 Reviewed-on: https://gerrit.libreoffice.org/43855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26tdf#113444 removed capping of default font sizeBernhard Widl
Change-Id: Ic2ef7eeea7dd9306b57d55952ab716d6255f9576 Reviewed-on: https://gerrit.libreoffice.org/43605 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-25ofz#3750 Undefined-shiftCaolán McNamara
Change-Id: If227dea7758c22cadfad83192e0ad31a4183b5b5 Reviewed-on: https://gerrit.libreoffice.org/43747 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-25ofz#3753 Integer-overflowCaolán McNamara
Change-Id: Icdcd42cc064e18686e6738b4195b6668c7d5d05e Reviewed-on: https://gerrit.libreoffice.org/43748 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-25tdf#113400: fix crash by destroying returned unique_ptrJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=19910c461230f70bb9e98ad44db3525f0d755724 tdf#112658: fix leak when calling TextEngine::SetAttrib Change-Id: I4f1edf41e11f3cdfda6071b30a84372db68cd59d Reviewed-on: https://gerrit.libreoffice.org/43795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-25Parsing locale decimal separator after OUStringBuffer::append(double) is wrongEike Rathke
OUStringBuffer::append(double) always uses '.' decimal separator. Change-Id: I5c937ef78e918e01cd98a329e22f1be8f524db44 Reviewed-on: https://gerrit.libreoffice.org/43792 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-24ofz#3748 Invalid-bool-valueCaolán McNamara
Change-Id: I5a14ff75c27062e33cbd93efb931c203135648a3
2017-10-24ofz#3747 Invalid-bool-valueCaolán McNamara
Change-Id: I168fc71471dc9aeb4cd5149aaab765e65f7d5a82 Reviewed-on: https://gerrit.libreoffice.org/43756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-23loplugin:includeform: vclStephan Bergmann
Change-Id: Id7dea3917740aaf4db8dada5e2bea6e117d714ea
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22Avoid compiler eliding redundant dynamic_castStephan Bergmann
...from vcl::Window to itself. This relies on vcl::Window deriving solely from OutputDevice. Change-Id: I530108ff41d2c141a88e9ec9d9d6929abc773c0d
2017-10-21check bmp seekCaolán McNamara
Change-Id: Ie5e40d7817c4bac2a645822863e62467739801e8 Reviewed-on: https://gerrit.libreoffice.org/43672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20pdfextoutdevdata: Rearrange code for readability and efficiencyMike Kaganski
Change-Id: I506e77d97940570b076274a35cc92d3ec7278d3c Reviewed-on: https://gerrit.libreoffice.org/43584 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-19tdf#113225 - reset framebuffer count when resetting OpenGLContextMichael Meeks
Otherwise we can fail to allocate a new one when we need it post reset. http://crashreport.libreoffice.org/stats/crash_details/e4f26191-15d5-441a-868f-9ada21ef4424 Change-Id: Icc5ec6c51338e18a0a1bc890f56670e8fe9c73ea Reviewed-on: https://gerrit.libreoffice.org/43508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-10-19tdf#112830 measure test with ApplySettings appliedCaolán McNamara
and don't invalidate on first view Change-Id: I1156c83c0365ef27946cc414cad8dfa07206e5af Reviewed-on: https://gerrit.libreoffice.org/43498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19Avoid throwing C++ exception across libjpeg C framesStephan Bergmann
It causes trouble at least for (non-debug) 32-bit ARM Flatpak builds, where CppunitTest_vcl_filters_test aborts with an uncaught css::uno::RuntimeException. This is a partial revert of 6889fa826eef6bd1074d77507818e71dfe8ba152 "rework jpeg error handling to throw rather than setjmp to avoid leaks", switching back to setjmp/longjmp but trying to keep the leaks fixed by introducing any relevant local variables before the setjmps. Change-Id: Ia5984528ea98be1c89a21aee800b247120f88a89 Reviewed-on: https://gerrit.libreoffice.org/43494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-18tdf#107224 use correct bg for notebookbarSzymon Kłos
Change-Id: I26093cb9cf0170aa9ba4ccfc8c8556c2e78086b3 Reviewed-on: https://gerrit.libreoffice.org/43515 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-18presumably we don't need to recalculate on subsequenct 'show' nowCaolán McNamara
Change-Id: I7e5fdd2b328a7d88e11cc15ba9e1027ef55c5e17 Reviewed-on: https://gerrit.libreoffice.org/43461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17tdf#112845 get optimal size before showing popupsCaolán McNamara
because in rtl mode we need to know the final size in order to position it correctly according to the right edge Change-Id: Ia701626968f828fd23ab1637ed6171d0e3367c16 Reviewed-on: https://gerrit.libreoffice.org/43460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17use std::unique_ptr in vcl::Animation and vcl::MenuItemListNoel Grandin
Change-Id: I0d682bcf3bd9d5f4852675fd0d6b61f10ea4f7de Reviewed-on: https://gerrit.libreoffice.org/43455 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-16ofz: optimize 1bit mask to avoid timeoutCaolán McNamara
Change-Id: Ieaf3eb0800d2e80f16cfa29718d752e43ad534d0 Reviewed-on: https://gerrit.libreoffice.org/43418 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-15cid#1419773: Uninitialized scalar fieldJulien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=2dd1645d7cd12e8f5d8e950af3d156f8df2fa417 Change-Id: I2077bcf1ca53d5378f2690267f307d3350dd037e Reviewed-on: https://gerrit.libreoffice.org/43401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-13tdf#107605: Fix reading version 0 OS/2 font tableKhaled Hosny
The version 0 table os exactly 78 bytes since it does not have any of the extra fields from the later versions. Change-Id: Ie2e478bdefb201b988dc0844240d4ff193d66583 Reviewed-on: https://gerrit.libreoffice.org/43374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-13Fix typoAndrea Gelmini
Change-Id: Icb23e192961aadcd23d17546aa397df18dd32979 Reviewed-on: https://gerrit.libreoffice.org/43366 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-13tdf#110742 add support for icon themes via extension managerCaolán McNamara
Change-Id: Ic33c086ef67cdcb634d9f03f84799c234fe3beec Reviewed-on: https://gerrit.libreoffice.org/43341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-12Notebookbar: allow only one tab lineSzymon Kłos
Change-Id: I5f671bdc34e5852af06c99db93e859e8cf837c0d Reviewed-on: https://gerrit.libreoffice.org/43009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-12prevent crash while disposing ListControl when children are disposedMarkus Mohrhard
Change-Id: I9e69d0b29ab41428d87bf37edeebe652f7e9c297 Reviewed-on: https://gerrit.libreoffice.org/43251 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-12allow adding a menu to a modal dialogMarkus Mohrhard
Change-Id: I3da2ec747f73c44bf7bcb8a7ec3d116272dc806f Reviewed-on: https://gerrit.libreoffice.org/43252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-10add a method to get all entries from ListControlMarkus Mohrhard
Change-Id: I9ff73dab53f5769270e8eb32889314e9c61a1828 Reviewed-on: https://gerrit.libreoffice.org/43254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>