summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11loplugin:indentation in vclNoel Grandin
Change-Id: Idd7166833764fdf1d9c42a050490572a8b330199 Reviewed-on: https://gerrit.libreoffice.org/67610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09Use PngImageReader for loading the icons from the icon-themesTomaž Vajngerl
Change-Id: Id48c7707fd6c0ef72a41b102048be5749d5c4858 Reviewed-on: https://gerrit.libreoffice.org/67578 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09add PngImageFilter that uses libpng for PNG loadingTomaž Vajngerl
This adds loading of PNG images that uses libpng instead of our own solution. It always loaded the image as either RGB or RGBA image and if the source PNG is using something else, libpng converts to either RGB or RGBA. In addition this adds tests for loading of various PNG files to make sure the resulting bitmaps are using pixel data as expected. (especially needed to check the RGBA bitmaps) Change-Id: I194321caf76c2ec2365bb6075c79c5e84983658a Reviewed-on: https://gerrit.libreoffice.org/67571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-08getToken+comparison+copy ==> startsWithMatteo Casalin
Change-Id: I3d243cecc21b0364b2ceac1f64cbfa1764c3ddf1 Reviewed-on: https://gerrit.libreoffice.org/66938 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08o3tl::make_unique -> std::make_unique in tools..xmloffGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib3201f865d43f372007cdf381c7e244e9cbeae26 Reviewed-on: https://gerrit.libreoffice.org/67474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-08weld AddConditionDialogCaolán McNamara
Change-Id: Ib685ea89b31c1f000bc2276e3362ba059f997422 Reviewed-on: https://gerrit.libreoffice.org/67521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-07tdf#123165 cache recently scaled bitmaps for reuseCaolán McNamara
dropping the cached scaled bitmap when the bitmap is accesed via BitmapAccessMode::Write for writing Change-Id: Ib6539522944838238bd699ec3531039d21dc0f8b Reviewed-on: https://gerrit.libreoffice.org/67459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-06Harmonize SalPrinterQueueInfo::mnJobs and QueueInfo::mnJobsStephan Bergmann
The former was of type sal_uLong while the latter has been of (potentially smaller) type sal_uInt32 ever since at least a02e8af56ba44e9bb3ba2c6e995a23745ee629a0 "INTEGRATION: CWS hedaburemove01", and Printer::GetQueueInfo (vcl/source/gdi/print.cxx) assigns from the former to the latter (so potentially truncates). But it appears the only non-zero values ever stored in the former are QUEUE_JOBS_DONTKNOW (defined as 0xFFFFFFFF in include/vcl/prntypes.hxx, fitting into sal_uInt32) and Windows-specific PRINTER_INFO_2W::cJobs (in WinSalInstance::GetPrinterQueueState, vcl/win/gdi/salprn.cxx), which is of Windows type DWORD, i.e., unsigned 32-bit, compatible with sal_uInt32. So change the former (and QUEUE_JOBS_DONTKNOW) to sal_uInt32, too. Change-Id: I0cc993d26831313b362cc31ee06fd879c854d146 Reviewed-on: https://gerrit.libreoffice.org/67468 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-06Extend MetafileXmlDump with MetaActionType::TransparentMuhammet Kara
Change-Id: Ia74c43372b12eb71a8cc443de15458b374ee6b85 Reviewed-on: https://gerrit.libreoffice.org/67446 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-06no need to use OUStringHash here anymoreNoel Grandin
Change-Id: I2faa8c971dc7f4642353dceafa25b9022a0dfd2a Reviewed-on: https://gerrit.libreoffice.org/67436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-05weld WebConnectionInfoDialogCaolán McNamara
Change-Id: Idff8a0589075c8b7c774f187f5082fd954251d77 Reviewed-on: https://gerrit.libreoffice.org/67420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-02ofz#11203 fuzzing timeoutCaolán McNamara
Change-Id: I0feb8aa17f71a6efddc1b8b95008116b36f0a1f0 Reviewed-on: https://gerrit.libreoffice.org/67239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-02ofz#12828 svm TimeoutCaolán McNamara
Change-Id: I12f493a90177838ea4f29c2b4411846df19241a4 Reviewed-on: https://gerrit.libreoffice.org/67260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31misleading and unnecessary fall through commentsCaolán McNamara
Change-Id: I6309a484c3411bc1151ff2ccd276d70600854021 Reviewed-on: https://gerrit.libreoffice.org/67191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31Related: tdf#122780 skip GetTextWidth() when we don't need the resultCaolán McNamara
Change-Id: I1919d3da162e05ea6fec6269a53344b0625338e9 Reviewed-on: https://gerrit.libreoffice.org/67174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-30Resolves: tdf#122958 bmps with weird compression values that work in msoCaolán McNamara
Change-Id: Ie1887288cba7c1d56b807dbc9ddb886b9d20ff33 Reviewed-on: https://gerrit.libreoffice.org/67143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-30loplugin:external (clang-cl, HasAtHook)Stephan Bergmann
Change-Id: I5d644f338dca5b329bc6d27c82ffa77593059220 Reviewed-on: https://gerrit.libreoffice.org/67157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-30ofz#11545 can treat BITFIELDS like COMPRESS_NONE for size sanity checkCaolán McNamara
Change-Id: Ic8b0cbe0c7821d287b2233bc015cb888e0e18d88 Reviewed-on: https://gerrit.libreoffice.org/67110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29tdf#122079 - Document orientation is no longer changed in print dialogDaniel
Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954 Reviewed-on: https://gerrit.libreoffice.org/66483 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29Drop kde4 desktop detectionMichael Weghorn
KDE 4 has been unmaintained upstream for various year now and the kde4 VCL Plugin was removed with 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e in favor of the kde5 one. Drop desktop detection for this obsolete KDE 4 version as well. Should new LO versions be run on old systems still running KDE 4, it's very unlikely that they have the kf5 libraries that are required to use the kde5 or gtk3_kde5 SAL plugins anyway, so the default fallback for an unknown desktop environment is quite as good. Change-Id: If8de489fbca836a80451435edfb00d2a8d501031 Reviewed-on: https://gerrit.libreoffice.org/67053 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29ofz#11104 for timeouts, limit decompression ratios when fuzzingCaolán McNamara
Change-Id: If9efe56a40a866269a06ce944885a324495af48a Reviewed-on: https://gerrit.libreoffice.org/67036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-29Remove some kde4 leftoversMichael Weghorn
The kde4 VCL Plugin was removed with 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e, so drop some now superfluous leftovers. Change-Id: I92887b679462a6ac22c3668a24ec6a9fdee8fac1 Reviewed-on: https://gerrit.libreoffice.org/67047 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-27Get data from full string, without tokenizationMatteo Casalin
Change-Id: I8cdaef18329543cbbe316b9499d6707d645a789d Reviewed-on: https://gerrit.libreoffice.org/66644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Optimize: getToken()+comparison+copy() ==> startsWith()Matteo Casalin
Change-Id: Ic0e343f80ef91aad9baef8cc48648207b0365c68 Reviewed-on: https://gerrit.libreoffice.org/66642 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27getToken: reuse known index informationMatteo Casalin
Change-Id: I87f274addcba0776016e9996a0b568f503e2081a Reviewed-on: https://gerrit.libreoffice.org/66939 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-26add a Dialog::runAsync for the non-controller caseNoel Grandin
.. and use it to make the solver warning dialogs async Change-Id: I3589a1d3ae58190bf545bac1e2a95f81a114d44f Reviewed-on: https://gerrit.libreoffice.org/66896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-26vcl: test gradient draw into a metafile, extend the dumperTomaž Vajngerl
Change-Id: I87600c8cb648686b80092a9526a07ed71b324907 Reviewed-on: https://gerrit.libreoffice.org/66918 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-25Assert missing SalGraphics font on GetTextLayoutJan-Marek Glogowski
Trying to layout text without a font can't work. Without a font, currently the text is simply not painted, but this is still a programming error, so warn the developer. And we can get rid of all the intermediate OutputDevice font and gpahics checks, as everything now uses Harfbuzz and there won't be any layout which can't use the cached runs, so just generate them directly. Change-Id: Iae1fab0afeefec1cb1ca82c4e5d8dcbe9919859d Reviewed-on: https://gerrit.libreoffice.org/66818 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-25tdf#122259 resolve image link as both - png and svgTomaž Vajngerl
This is needed to prevent mismatches when we have a image defined as png and we have a svg available. As we currently support both png and svg icon themes we need to try both or some resolvable icons just won't be resolved. Once svg support is in a good shape that we can get rid of png, we can also possibly get rid of this. Change-Id: I34e9c24ac1016ef3af46be06330b60aaab730da0 Reviewed-on: https://gerrit.libreoffice.org/66826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-25Change SalGraphics::GetTextLayout definitionJan-Marek Glogowski
* drop the unused ImplLayoutArgs argument * return a std::unique_ptr<GenericSalLayout> Change-Id: I150a2a46f67f1ffbbd3ba0ffa68f5bffb30206c8 Reviewed-on: https://gerrit.libreoffice.org/66884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-24ImplImageTree.cxx - hide local functions in anonymous namespaceTomaž Vajngerl
Change-Id: I8f031e276955dad714b47c35527d3536d699590b Reviewed-on: https://gerrit.libreoffice.org/66825 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-24Cleanup and simplify Image.{cxx,hxx}Tomaž Vajngerl
no functional change Change-Id: I8d7171913d14ccb81b88c82362cfa997f9b9964a Reviewed-on: https://gerrit.libreoffice.org/66823 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-24Revert "lok: custom widgets: render editbox borders"Ashod Nakashian
Looks like this is no longer needed to correctly render editbox borders. Not clear what fixed the issue. This reverts commit 7484f1691cbe9513dabf084effe8a0366b737a80. Change-Id: Ieb3b8d6f60ab762d0baccb341ed6a39ae2771e79 Reviewed-on: https://gerrit.libreoffice.org/66774 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-24cleanup ImplImageTree.cxx - whitespace, remove unneeded css::Tomaž Vajngerl
Change-Id: Ic0c4d10d60bddc461fc20e98b8424c4e8480ee6e Reviewed-on: https://gerrit.libreoffice.org/66822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-23loplugin:constparams in vclNoel Grandin
Change-Id: Icf1a952fbe190fd6c4efd89364136aa2b48050e3 Reviewed-on: https://gerrit.libreoffice.org/66767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-22Resolves: tdf#122241 support persona header in native gtk3 menubarCaolán McNamara
Change-Id: Ia4485ec4c342c86f40e8e0bb7e5e1af1a47bb9b9 Reviewed-on: https://gerrit.libreoffice.org/66725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-22Resolves: tdf#122874 select row when user clicks toggle in rowCaolán McNamara
Change-Id: I761d0566eef07eadf9e583566b8707b18563ee33 Reviewed-on: https://gerrit.libreoffice.org/66742 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21Simplify nXWidth initializationStephan Bergmann
...which happens to avoid an unhelpful -Werror=strict-overflow with GCC 7 and --enable-optimized: > vcl/source/edit/texteng.cxx: In member function ‘bool TextEngine::CreateLines(sal_uInt32)’: > vcl/source/edit/texteng.cxx:2197:9: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow] > if ( nTmpWidth > nXWidth ) > ^~ Change-Id: Ia87933da6e38b8b462d2ea34c3db6a84c5840f92 Reviewed-on: https://gerrit.libreoffice.org/66690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselectCaolán McNamara
Change-Id: I941e32a973cdd1bc79e3739b24fdf834aa52cb11 Reviewed-on: https://gerrit.libreoffice.org/66628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21Fix -Werror=maybe-uninitializedStephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized: > In file included from vcl/source/gdi/pngread.cxx:27: > include/vcl/pngread.hxx: In member function ‘bool vcl::PNGReaderImpl::ReadNextChunk()’: > include/vcl/pngread.hxx:49:12: error: ‘aDummyChunk.vcl::PNGReader::ChunkData::nType’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > struct ChunkData > ^~~~~~~~~ The immediately relevant part is initializing sal_uInt32 nType = 0; in the ChunkData ctor, but while at it, also make the Read*Int32 calls in PNGReaderImpl::ReadNextChunk more robust. Change-Id: Id6ad10a4382a8d063fd70c7bac595c3693475ca3 Reviewed-on: https://gerrit.libreoffice.org/66619 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-19Index is not needed for single getToken callMatteo Casalin
Change-Id: I503e6e96a6a61b45e741f2131107ecaef8566b83 Reviewed-on: https://gerrit.libreoffice.org/66640 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-18Resolves tdf#122118 - Toolbar dropdown button triangles are too largeheiko tietze
Toolbar expander triangles are now scaled depending on the parent size Change-Id: I4974c0976c1591fc09594bf4aeca020a72ebf11a Reviewed-on: https://gerrit.libreoffice.org/66565 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-18vcl: LOK: notify of dialog creation before size changeAshod Nakashian
Notifying the size change of a non-existing dialog is worse than useless. This also fixes the issue with positioning dialogs in the center of the client window. Change-Id: I2e8163f4c5a0a09f79ea11c704c250b17a158948 Reviewed-on: https://gerrit.libreoffice.org/66511 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-01-18tdf#42949 Fix remaining IWYU warnings in include/vcl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some new headers were added since I begun the cleanup here Also blacklist the header from commit 403e3c04420c4d20c77427c43df52d554d7329ff Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5 Reviewed-on: https://gerrit.libreoffice.org/66255 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-17tdf#122761: Revert "Resolves tdf#122118 - Toolbar dropdown button triangles ↵Xisco Faulí
are too large" This reverts commit b56ad2a1292b01647c4ee1f4364f7c4aa20fc449. Change-Id: I0fa94c4a027a85a14e85c53a18443d97fa862a59 Reviewed-on: https://gerrit.libreoffice.org/66507 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-15vcl: protect more outdev functions for disposed stateMiklos Vajna
This is similar to commit c612c3b0aed9ad7f7f42b4313f821b71995ead15 (protect more printer code-paths., 2015-03-20), but handles more OutputDevice member functions. The user-level problem was that in case a macro creates a dialog with an embedded Chart document and the user clicks on e.g. the chart title (so an sdr::overlay::OverlayManager is created), then it can happen during closing the dialog that the overlay manager calls these functions after the output device is disposed. Change-Id: I8021fb795704f19e52d70505804d68725c636ce0 Reviewed-on: https://gerrit.libreoffice.org/66403 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-15Related: tdf#122627 auto detect of toggle column doesn't workCaolán McNamara
so remove it and explicitly state what column contains the toggle Change-Id: I58fb12a4b8fa9eeb9c038f796e48b0aeaa0b2404 Reviewed-on: https://gerrit.libreoffice.org/66379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-15Resolves tdf#122118 - Toolbar dropdown button triangles are too largeheiko tietze
Fix values for toolbar expander triangles with 7px resp. 4px depend now on the actual toolbar height. Change-Id: I0241e3cfa9472bfbd2533afa84bcbfd9ef92c920 Reviewed-on: https://gerrit.libreoffice.org/66166 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-01-15Resolves: tdf#122633 - Print dialog Preview is Offheiko tietze
By default on now Change-Id: I7619d290e3dd9032b765057b8878d5dad035eafc Reviewed-on: https://gerrit.libreoffice.org/66351 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-28 14:49:34 +0000