summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)Author
2023-06-01WaE: WhitespaceToSpace() spurious -Werror=maybe-uninitializedCaolán McNamara
vcl/source/helper/strhelper.cxx:366:9: error: ‘pBuffer[-1]’ may be used uninitialized [-Werror=maybe-uninitialized] I see this with gcc 13 too Change-Id: I3ddc5fadb9177827e6cd49f5b6366a79204e95c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-31vcl: one more nullptr check in Window::GetOutDev()Miklos Vajna
As it was pointed out at <https://gerrit.libreoffice.org/c/core/+/151857/2#message-ced4ba9ebaf5725ec06853682c146211824af158>, it makes little sense to have the nullptr check in the non-const version of Window::GetOutDev() but not have it in the const version, fix this. Change-Id: I2f97938a4015d3ce27e35b9971b65090f7289c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152429 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-30Related: tdf#155542 drop workaround for "XB Roya" issueCaolán McNamara
Change-Id: I8323ae631c13da80cc3f4b8b8826cb9b23e788f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-30tdf#155542: Fix crashtesting assertKhaled Hosny
When cloning an RTL glyph range, we might end up cutting in the middle of a cluster e.g. between a base character and a combining mark since both with have the same charPos() after: commit 09c076c3f29c28497f162d3a5b7baab040725d56 Author: Khaled Hosny <khaled@aliftype.com> Date: Wed Oct 5 21:00:46 2022 +0200 tdf#151350: Fix extraneous gaps before marks (which changed how HarfBuzz sets up clusters back to the default where marks form clusters with their bases, before that a mark formed its own cluster). This leads to the cloned glyph range to include the glyph for the combining marks, while it is not included in the text string. Change-Id: I83031e0e0ffc7c5932101649a9cc2bf953a6347d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152380 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-28Use getXWeak in vclMike Kaganski
Change-Id: I665c9dc8c4f9cc4a996d9bf990cbfa33822bd07f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150885 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-26vcl: PDF export: stop adding pointless circular RoleMap entriesMichael Stahl
... for standard roles; no idea what these are supposed to be good for. Change-Id: Ie2ccf394631a2bccb496b2f93e26a571ba84d58d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152334 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-26replace find_if by none_ofDr. David Alan Gilbert
A set of cases where find_if is used just to test if there are no matches; use none_of as per tdf#153109 Change-Id: I6c705ab7a8289914743199722a444ee40d11d746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25tdf#152048: Fix underline width for Kashida-justified textKhaled Hosny
Fix GenericSalLayout::GetTextWidth() again, this time doing away with using linearPos as it is wrong, the glyph’s position is not directly related to how much it contributes to the text width (for example, combining marks have zero advance width yet their position is different from the base glyph they apply too). This is a followup to: commit ce7c1c608fa99c86c8f2380cd8b82d02123f514e Author: Khaled Hosny <khaled@aliftype.com> Date: Wed Aug 31 07:07:54 2022 +0200 vcl: Fix GenericSalLayout::GetTextWidth() Additionally, inserted Kashida should have its origWidth and newWidth both set to zero, since it does not add to the text width, all additional width is already added to the glyph the Kashida is applied to. With both fixes, the text width of Kashida-justified lines is correctly calculated and the underline no longer extends beyond the text line. Fix test expectation now we are reporting the real text width. Change-Id: I0de93f955929cf3030cf420cb4f4e94df974fb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152267 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-24tdf#141684 tdf#147740 notebookbar: fix disappearing icons in groupbar #2Justin Luth
AFAICS, the code was non-sensical before. Hopefully now it is logical. Apparently returning the correct width doesn't mean much, but that is the only thing that should be changing in this patch. I would assume that returning an accurate width is the proper thing to do for this function... Change-Id: Iab26ac7fd8cd00127d2646f792fa552ec148dc74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152126 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-05-23perf: surprising to see getenv on a profile.Michael Meeks
Change-Id: Id97c77d4c836e4f3c5a9eff6da07eb52d29248c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152105 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-05-23tdf#140557 notebookbar: be smarter about hidden window sizeJustin Luth
This fixes a 7.1 regression from 53d73d532281b6734a7d4614bb74fc6cc15510f0 where notebookbar controls were being hidden (and then shown after a refresh of the toolbar), leaving big empty gaps. I don't know anything about vcl or window layout idiosyncracies, so I just read through this code looking for some way to fix the problem of the notebookbar not using all of its available space. The problem was that GetOutputSizePixel was returning zero. Why that would be I don't know. Perhaps because it had never actually been displayed on screen yet? (This was occurring on simply loading Calc.) Substituting a small DUMMY_WIDTH didn't give a very accurate reduction, so there was no space to add back in any items later on. When adding it back, it adds using a legitimate-seeming width, with an (unused this time) fallback to DUMMY_WIDTH. So, unless getLayoutRequisition cannot be depended upon for returning an accurate size, this should be a nice fix. It will no longer hide too many controls from the notebookbar. Change-Id: I1c39fe3532dad501c16f53612f8e26835b72638a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152125 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-05-23tdf#155235 workaround gtk3 accessiblibility crashes on closeNoel Grandin
we are still working around the problem here, which is that various bit are not firing accessibility events when their children change. So clear the static map in comphelper on shutdown, to prevent crashes resulting from objects being kept alive after vcl has shutdown Change-Id: I3ae216b345a1bb4cb4e3fde3527e4d4aa5968f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23Resolves tdf#145080 - Use accent color for focused cellHeiko Tietze
Accent color added but effectively working only on macOS See inline comments for gtk, qt, and win Change-Id: I1e4a729331735683921f94b27bb2bb02555c0165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-21Revert "tdf#63130 when getting the size, do not do a full paint"Caolán McNamara
because it is triggering many CppunitTest_toolkit_a11y failures This reverts commit 67c3b3becab2aa2b9522e3a092d46bfe507c3101. ImplCallResize is not called on the same Window after that commit than it was originally called on. Change-Id: I0c3721d2674067ac7f0bf765e0fe1097b1d67dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ief95f111350808f010539bb733a553007d30a9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-20loplugin:unusedfieldsNoel Grandin
Change-Id: I5036b484055e516fd808428238a044e12d34e089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-18tdf#63130 reduce large memory copies when reading from BinaryDataContainerNoel Grandin
rather than writing a bunch more code, extract the common part from comphelper::SequenceInputStream into a new base class Change-Id: I0d3561e3ca2e748b904128e3b5955e27196d7170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17vcl: fix crash in Window::GetOutDev()Miklos Vajna
Crashreport signature: program/libmergedlo.so rtl::Reference<vcl::WindowOutputDevice>::get() const include/rtl/ref.hxx:208 program/libmergedlo.so vcl::Window::GetOutDev() vcl/source/window/window.cxx:574 program/libswlo.so SwViewShell::ImplEndAction(bool) sw/source/core/view/viewsh.cxx:294 program/libswlo.so SwViewShell::EndAction(bool) sw/inc/viewsh.hxx:611 i.e. GetOutDev() is called on a disposed vcl::Window. Change-Id: I5b17225fced85c6804fc93fd12021c92966d3aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151857 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-17tdf#63130 when getting the size, do not do a full paintNoel Grandin
otherwise we end up doing double work when called from ImplWindowFrameProc, which is the main driver of painting on the screen This reduces the load time by 10% Change-Id: I9eb82a180344875f707fbf3d8128351a35def6a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-16Resolves tdf#155278 - Adjust minimum statusbar height according iconsHeiko Tietze
Change-Id: I7dbcf35f338bfe87702afb45651cd99630efe875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151768 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-12ofz#58883 Out-of-memoryCaolán McNamara
Change-Id: I91de8f537ae237de814ed7e933fb6d0a3cc98466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-12tdf#155228 vcl: PDF export: /Tabs needs PDF name, not stringMichael Stahl
(regression from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9) Change-Id: I5ccc37cd538448b2cb9db594287b49869589b2db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151700 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-11tdf#155241 keep current MetricSpinButton value if unparseable junk inputCaolán McNamara
Change-Id: I0f13c9ae25c1788924fd81ed77307e96400f6220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11cid#1529966 silence bogus Resource leakCaolán McNamara
Bitmap::ReleaseAccess(foo) is just delete foo, so null is fine there anyway Change-Id: I18143c9cf0c63e985866276273b099f5d3b8d5a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11tdf#97228 Move MenubarValue class to separate include fileanfanite396
Change-Id: I5da4bb1765f91d1f9d78e27221d243d5c2ef92e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149076 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-10ImplPrintTransparent is always called with an empty maskNoel Grandin
which we can use to simplify it Change-Id: I8fa38a9f414d8d720e31bd1f71fd722f6a95fdbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151635 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10AlphaMask::BlendWith wants an AlphaMask parameterNoel Grandin
so make it so Change-Id: Ia5a91c78d2fd10f22eb19e4ebbd753151149190f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09drop unused ImplPrepareExitMsgCaolán McNamara
Change-Id: I9254328829ac051524fbfdf6a3b5b2f72b12c427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09ofz#58756 Integer-overflowCaolán McNamara
Change-Id: Ie2782c1d68f73e5e88cf868eb1ce106ec0c181b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151558 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-08tdf#155161: Always embed fonts with CFF2 table as PDF Type 3 fontsKhaled Hosny
PDF doesn’t support CFF2 table and we currently don’t convert them to Type 1 (like we do with CFF table), so treat it like fonts with variations and embed as Type 3 fonts. Change-Id: I963b55d5d0ed1470eda157c7e10cae63195a0c91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151532 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-05-08unique_ptr->optional for BitmapNoel Grandin
since Bitmap is really just a tiny wrapper around SalBmp Change-Id: Ie2c9be40f6abba72c600c6778ec42d0689c66558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07use AlphaMask for variables when calling GetAlphaMaskNoel Grandin
Right now this doesn't make any difference, since Bitmap is the superclass of AlphaMask. But when I switch to using alpha instead of transparency, passing AlphaMask around is going to mean something different to passing plain Bitmap around. Change-Id: Ic1541e5f0a3b97331793cd23e23115faa7f382b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07simplify codeNoel Grandin
The BitmapEx constructor already does this check, no need to do it here Change-Id: Iacd0e1b1d4aa3dfae120e0d4a60a6924ecd9f778 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07ofz#57493 Timeout negative width/height is negated and mirrored by vclCaolán McNamara
Change-Id: I70c0a72d6bbbec7e809edc856976633fce3efa9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-07improve some usage of OInterfaceIteratorHelper4Noel Grandin
we can drop the lock immediately after construction (since the iterator holds a thread-safe COW link to the underlying listener container) Change-Id: I08f8fa9ed7393747938572097f3c25f5f3f847fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07tdf#154211 SwNavigator: select range of content by shift + double-Jim Raykowski
click or shift + enter key Enhancement to make a selection from the current cursor position in the document to the position in the document that is navigated to when a content entry in the Navigator tree is double clicked or the enter key is pressed. No selection is made when the current cursor position is in a table, header, footer, footnote, or frame. To make shift + double-click behavior for x11 and qt5 the same as gtk3, FunctionSet::SetCursorAtPoint is added to the Shift case for SelectionMode::Single in SelectionEngine::SelMouseButtonDown. Change-Id: Id845dad8011ff7777a24f9b2730f10c62271c368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151157 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-05-06cid#1529287 Explicit null dereferencedCaolán McNamara
after commit c55d5586304f23f9d8acbaffefba68a3a11c6175 Date: Sat Apr 1 16:10:33 2023 +0100 BinaryDataContainer: hand out shared_ptr's to SvStreams. and commit 0f2581204a70038ed7ca78089a9bd96d158e02c0 Date: Mon Apr 3 09:34:54 2023 +0100 BinaryDataContainer swap out implementation. it is possible that a eLinkType of GfxLinkType::NativeGif and a nStreamLength of 0 could lead to BinaryDataContainer::getAsStream being called on a default ctored BinaryDataContainer which would mean an mpImpl of null and a null dereference here Change-Id: Id964e3ce97e5527c5357576131fe03440f1ea00c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-06update loplugin:stringview* for o3tl::iterateCodePointsNoel Grandin
And change o3tl::iterateCodePoints to use sal_Int32 for its second param, to integrate better with places where the parameter comes from an UNO API, which cannot use std::size_t Change-Id: I7b9dd2c9bc7f48e6c4a912f039f1b5dae7beae69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-05BinaryDataContainer swap out implementation.Michael Meeks
We can easily accumulate a large number of in-memory graphic objects, and swapping these as well as the un-compressed images can become important. For now we swap out the container when the image is swapped out, however it seems unlikely it will ever need to be swapped in again. Despite the shared pImpl, we retained the reference counting on the underling vector to keep this immutable while we hand out a MemoryStream reference to it. Change-Id: Ib7ca45afb8499460b1852461f7c11afca3f3cdfa Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151359 Tested-by: Jenkins
2023-05-04remove some dead code in ImplWriteDIBNoel Grandin
which has been dead since commit 1ecdddcc32ce2b003fca43ac2c5ef0668afef8dd Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Oct 27 17:13:16 2017 +0200 loplugin:constantparam in vcl Change-Id: I39c689b75231a6de1eb993c13e416df63f9a16db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-03pass the std::vector instead of its data()Caolán McNamara
Change-Id: I9319896eb4d0e7728a9ded77fa1bfd05e63fbbe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-02ofz#57493 TimeoutCaolán McNamara
Change-Id: I2a61016c771012f23415e753ca91bf254584131a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-02ofz#58551 Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: Iee5d82fff5edf14dd4f8adeabc305e96dd0ddd8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-28survive exporting to pdf without config for fuzzingCaolán McNamara
Change-Id: I229f25a8a15b21257756ecfa008b9e99681003c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-27ofz#58380 Integer-overflowCaolán McNamara
Change-Id: I88155f7f2abf42a11376d6f54aab28c233cf7e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-26tdf#108757 speed up PDF generationNoel Grandin
std::list->std::vector reduces output time by 10% because we search the m_aChildren often and vector is better at that Change-Id: I4d0d5f6248a9c36aa0085cb22315ad6e2f53738e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-25tdf#38194 tdf#106556 Enhancement to highlight direct formatting,Jim Raykowski
paragraph style, and character style use in Writer documents Initial commit to realize direct formatting, paragraph style, and character style highlighting enhancement requests. Highlighting of character direct formatting is turned on/off using .uno:HighlightCharDF. Highlighting of paragraph styles and character styles is turned on/off using a check box in the Sidebar Styles panel. Closing the Sidebar also turns paragraph and character style highlighting off. Paragraph direct formatting is indicated by a hatch pattern over the paragraph style highlight bar and also by "+ Paragraph Direct Formatting" appended to the tooltip that appears showing the name of the paragraph style when the mouse pointer is over the style highlight bar. Colors used for styles highlighting are determined by a hash of the style name. Lightgray is used for character direct formatting. Known issue: Tooltip doesn't show for paragraph style highlighting in tables and in frames where the highlighting bar is drawn outside of the frame. Change-Id: I6e00ee38c1c169bc7c6542a1782c03b2593e1891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150451 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25ofz#57493 avoid TimeoutCaolán McNamara
Change-Id: I9fee1ad3467c18d2714ef211f2c95c6b4211415b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150946 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24ofz#58241 Integer-overflowCaolán McNamara
Change-Id: Ie5b82df4642c786e309022e3b5a436aef66d1137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24loplugin:unnecessarygetstr extend to more std::string checkingNoel Grandin
suggested by mike kaganski Change-Id: I5f5f254142767aca45a6101abdd84a0163ca6a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-06-22 09:57:06 +0000