Age | Commit message (Collapse) | Author |
|
The test creates two MetaCommentActions from the GDIMetafile and
checks their attributes and contents.
Change-Id: I748a6fa5dcf0dc09359fb48ea0bf3d7ceef3dbcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117245
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ia90e8ad537fccdf38ed0bf0e9f963033c69ec202
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117612
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1bc2a7555f6d129526cabbebb8b88190e3ec3a4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iec41990bbf076c0f8aaeda36ac56d3ac7ebc81d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117544
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Fallback layout beyond level1 isn't generated because pre-caculated
glyph items does not contain glyph items that needs to fallback, i.e.
when calling ImplLayoutArgs::PrepareFallback. Hence it produce no
maFallbackRuns and maRuns. The patch changes
ImplLayoutArgs::PrepareFallback so that it use pre-caculated glyph
items in the next level to create maRuns to ensure the same fallback
layouts are genrated as layouts generated without pre-caculated glyph
items.
Change-Id: I672f3be6c4915892792b3cb968ad4a325465ccc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117105
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
which has the potential to be more efficient than STREAM_SEEK_TO_END
Change-Id: I64d84632bc4751e07309332c9dff7a02bcd507fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117496
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
improve the plugin to detect more cases.
I only apply the new final changes to classes in /include here.
Which reveals that
RoadmapWizard::getPageController( TabPage* _pCurrentPage )
will always return nullptr
Also needed to sprinkle some
SAL_DLLPUBLIC_TEMPLATE
around to workaround Visual Studio linking problems.
Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...and combine three calls to SvStream::WriteOString into one.
Despite its name, SvStream::WriteOString takes a std::string_view, but which
cannot be constructed from a u8"..." char8_t string literal. Besides the
OStringLiteral detour, other fixes could have been a
reinterpret_cast<char const *> (but which would have defeated constexpr'ness of
the std::string_view construction) or a plain "..." char string literal with
the UTF-8 encoding of \uFEFF spelled out as \0xEF\xBB\xBF.
Change-Id: I029f061134381a67516cbc4b0479942684c80c20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117461
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I492c7d5c1846df7507b1f043b80de4e61ff8ca86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117282
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
The test creates two MoveClipRegions and checks their attributes.
mtfxmldump.cxx was modified to support MoveClipRegion case.
Change-Id: Ibfabf9d4048cf94e43c259e411a6c59b73baff34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117153
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
the frame/window can become disposed during the early stages of this
method
Change-Id: I974cbeefa75a3b5274e397a6da70db8b7cf73528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The test creates multiple ClipRegions with
different shapes and tests their attributes.
Makefile was edited to support basegfx::B2DPolyPolygon
Change-Id: Iabdf744e1749627b2bc4cbc0c8e933b38552e785
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116959
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ibd4f8ac232eddad2b8a6c970999f0adf61a07acf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117077
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
|
|
Actually, if we have the graphics data, just copy the graphics data,
that'll keep both the EMF+ and non-EMF+ content.
Change-Id: Ia14df0ba2a94d4310ee745b49de1d2190e425f05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117063
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
A WMF may have EMF with EMF+ actions embedded. When we read that,
we drop drawing non-EMF+ actions if we use EMF+. But EMF+ actions
are stored as MetaCommentAction in the metafile, and WMF writer
(unlike EMF) writer simply ignores comments. So when writing WMF,
make sure to read non-EMF actions so that something is written.
This is an extension of 295626a0bd39540544b774094a63df23e5376839.
Change-Id: I37355f694fe656b661abe54274ea203934e68151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117062
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
This extends the solution from
commit fa8db25af6218262b3dab2e93b76464975889ceb
Date: Thu Jun 3 20:47:10 2021 +0100
gtk4 crash on exit
to cover the qt5/kf5 cases as well, after seeing
equivalent crashes with kf5 VCL plugin
(e.g. when starting Writer and no profile exists) after
commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
Date: Wed Jun 2 13:06:54 2021 +0200
fix shutdown leak in CppunitTest_sw_filters_test
Change-Id: I4ef25bac0891c059588dbc8e6abe50db14230dea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117042
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Id93bde17dbc4c71ad93bc094b94408fc9e39ec98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117055
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I269fd92a6076fe9ebe18646e537e7031aec47fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116976
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
26ee34d1332e164cf938fcf78902df7d0cc3fe8f "uitest: add logging for UI actions"
had added the original
> return "Action on element: " + mxWindow->get_id() + " with action : " + aActionName;
That commit had stated
> The long term goal for this logging is that it generates content in a
> DSL for the UI testing. The generated file can then be interpreted by
> the UI testing and replay the interaction with the UI.
>
> For now the plan is to have a readable output of what happens in the UI
> layer that allows to quickly transform it to a UI test.
Later, 5578bc99542953b6318a117a4e4b99f12964d9d2 "uitest: Some new features in
ui_logger project", apparently as part of working on such a Python-from-DSL code
generator, commented out the original return statement. The comment at
<https://gerrit.libreoffice.org/c/core/+/116811/
1#message-867650d186ade924cd38240ebbf8603222adac6d> "Lets assume this was
commented out in error" has instructions how to test that (the generated
test.log is in the UserInstallation rather than in instdir, though), and the
comment at <https://gerrit.libreoffice.org/c/core/+/116811/
1#message-36bf2eab1110bf51ccaaa1014188b841beb32041> suggests returning just
aActionName instead of the dressed-up, human-readable "Action on element ..."
However, when I tried out those instructions, the dsl_core.py generation failed
(with an arpeggio.NoMatch exception) both when just returning aActionName and
when returning the full dressed-up, human-readable "Action on element ..." But
it also generally failed if WindowUIObject::get_action returns an empty string
(i.e., the status quo), with e.g.
> AttributeError: 'CloseDialog' object has no attribute 'uno_command_name'
apparently due to some
> Close Dialog
lines in my generated test.log.
So it appears that dsl_core.py is unfinished work in progress, which does not
work properly regardless of what WindowUIObject::get_action returns. Coming
back to the original commit that produced "readable output of what happens in
the UI layer", it is thus probably best to leave it at that output for now, and
reinstate the original full dressed-up, human-readable "Action on element ..."
That addresses the -Werror,-Wunused-but-set-variable. If anybody wants to fix
that dsl_core.py generation, that can happen in later commits.
Change-Id: Ie1123df53d9505fc5f039405f666977550f967d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116811
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
If a document is opened in several Online views, each of them using
a different zoom, then the scale cache is used for the scaling,
and each view is sent updated tiles, so if there are too many
views, the cache is not large enough.
(Collabora T28503)
Change-Id: I3fa719b0515064773fe4584fedbc8aff98e6e213
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116928
Tested-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
With previous implementation, only BitBlt record with 1 bit color depth
was supported and StretchBlt was not implemented at all.
With this commit the support for 1 bit, 24 bit and 32 bit,
for both BitBlt and StretchBlt were added.
Change-Id: I061b2beae8c2f143ddff9c8c8bb64bf52f4cf502
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116873
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
regression from
commit 2168d709805a847ac012ff87b06e081ca139d064
Date: Mon Feb 12 15:29:10 2018 +0200
use RawBitmap in PSDReader
Change-Id: I8d547d3cca7fb8fc90a8d9382e054b4d4b2f3519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116916
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The test creates two GradientEx and checks
their attributes. In mtfxmldump.cxx the
case regarding GradientEx was completed
Change-Id: I52f2303fa3123b97fb8a4b0783610c0bae300fc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116819
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Most of DIB records (DIBCREATEPATTERNBRUSH, STRETCHDIB)
are implemented partially. If the unimplemted feature are inside
WMF, then the whole reading steam is interrupted and nothing
is displayed.
With this commit if DIB record used missing feature,
then the warning is displayed, and the displaying continue.
The fix allows for displaying WMF image from tdf#55058
Change-Id: I6cc88d41486c52a2b1a6ec0b89166460a78ce7d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116763
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
for gen map to existing sc/res/date.png
Change-Id: Id85f5df27fd93deb7d1e653ae6cac1fb471d3470
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116761
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons
Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The test had previously raced between the effect of
vnd.sun.star.findbar:FocusToFindbar, typing, and pressing
the "Find All" button. If typing happened before focusing,
then focusing selected the already typed text. If button
was clicked before focusing, it found the edit unfocused,
and grabbed the focus, selecting its content.
This adds "HasFocus" property to WindowUIObject::get_state.
Change-Id: Ib277bd70508a3c1e86e1668afb7592d7a1523947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116697
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
But leave the CSS pixel size of them unchanged in the HTML markup.
Also add some documentation on the various options, so one doesn't have
to dig them out from testcases.
Change-Id: I6c6ee4e9c98d674f44e7c5835f2e6a6737e13f34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116722
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
It needs to wait until vnd.sun.star.findbar:FocusToFindbar does its
magic, which was racing with Python executing its typing.
This adds "SelectedText" property to ComboBoxUIObject::get_state.
Change-Id: I30faab2cc36a3cde59cf72ae5a383738a3ad4738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116694
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
- the twips logic size was set, but it was consumed as mm100 logic size,
so the pixel size was about half of the correct one
- the HTML export didn't write a logic size ("CSS pixels size") for
shapes
Change-Id: I37f6b4acde9d1298fae81f9975e9db95485631ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116691
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
since...
commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
Date: Wed Jun 2 13:06:54 2021 +0200
fix shutdown leak in CppunitTest_sw_filters_test
the vclplug .so is dlclosed and the GtkSalData dtor
subsequently crashes. gtk3 doesn't crash because its not
dlclosed.
for a simple life add gtk4 to the list here, probably
moving delete pSVData->mpSalData before the DestroySalInstance
or making it part of that is the right way to go
Change-Id: I683fdc217cb3486e3e9029817c8d6207f27bcd6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116680
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I434eadb8f7a10406dc8d9fc4d880fd5b2f2f179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116669
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia722297051eb3413b9db17024173c9eb596d8e7a
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115235
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115276
Tested-by: Jenkins
|
|
Change-Id: I8da4c929ebe7b93fe9211ba432ce321e31482a8f
Signed-off-by: merttumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114636
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116292
Tested-by: Jenkins
|
|
Fixed some cases generating crashes because mpWindowImpl was not checked for nullptr.
Change-Id: I5540f9f21a870b02655b5bf2afdbf3a8153c1519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116330
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
of GenericUnixSalData
Change-Id: I4201d617fa4618fc0be58dcf4d1279e0b60e2dcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116582
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8024410b1d259cc12e0fa25a009a51589640835e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116583
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie7eb634ce75b8156fae02f48429deca6d63c0251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The main idea was to move complexity from source (and Makefiles)
into configure.ac, because otherwise these must replicate the
"same" branching, often resulting in diversions. Better to keep
the logic in one place (configure.ac) and set additional variables
to be used directly by source code and Makefiles.
Notably this introduce the "using_*" platform flags, which should
be considered constants. There is USING_X11, which actually tells,
if the build uses the platform's X11 (and I opted for the removal
of HAVE_FEATURE_X11). I also consider variables constant, after
they have been exported by AC_SUBST, which should never be
conditional, or some AC_DEFINE set them for a config header.
A large block of defaults depends on $using_x11, so we set them to
the same value, but just if the platform doesn't set it.
The other important flag is $using_freetype_fontconfig, if the
platform uses freetype and fontconfig. The headless plugin uses
cairo for its drawing operations and freetype+fontconfig for text,
so $test_cairo = $using_freetype_fontconfig. This is independent
from a the cairo canvas!
The OpenGL X11 code now depends on USING_X11, but it doesn't yet
reflect the filter in Library_vcl.mk protecting glx. I don't know
how correct this glx filter is, seeing that the source code just
checked for "UNX - some non-X11 targets".
Change-Id: Id1ba1a967a5d8d10ee217458be879ed00459f7e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116440
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I63e69ca9daa8a452eee28333d8639d1db093e826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116518
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
in favour of the isDisposed in the VclReferenceBase base class,
so we have one flag for this instead of two.
Change-Id: Ib3d6ba750f95f21996bab2838af4c56295a13f4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113249
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since...
commit d90aa314961ea4a6893144cd6be66dd71cc2cca1
Date: Fri May 28 20:39:00 2021 +0200
IsDisposed->isDisposed in vcl/../app
revert the offending hunk for now.
maybe final fix is to special case VclEventId::ObjectDying or convert to
!xWin->mpWindowImpl or something.
Change-Id: I6987aeb753181fa2eb705fa0535c092e51587a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116396
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie3e0eb7cb7ca25536e825e30c53e112bf537b325
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116379
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
.. and convert Android to it. Will also be used by WASM.
It's also kind of a followup on commit
f5af2104fc490b90510e36bbf1d2adec8017c594.
Change-Id: I3a1b5bc2eae2692e706da10c6352534433c61e57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116385
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Ic1c8bb6bb9a45d4e91c997b752e23aed35767f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116364
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icd5fb88f3827eddb307f5fe6b46667a72062e408
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116358
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|