summaryrefslogtreecommitdiff
path: root/vcl/uiconfig
AgeCommit message (Collapse)Author
2024-10-30tdf#163684 gtk3 a11y: Don't use combobox role twice for non-editable oneMichael Weghorn
Since commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue May 7 10:04:16 2024 +0200 tdf#160971 gtk3 a11y: Set role for custom editable combobox Set the combobox a11y role for the box in the .ui file used for the custom gtk3 combobox implementation. With this in place, moving focus to the "Font Name" or another editable combobox in the Writer toolbar now makes Orca announce that one as "editable combobox" rather than just "text". , the combobox a11y role is set for the GtkBox of the custom combobox implementation used for gtk3. That box contains the edit (for editable comboboxes) and the button. While this is needed for editable comboboxes for AT to identify this as a combobox when the edit receives focus (by the fact that the edit's parent has a combobox role), this resulted in Orca no longer announcing the combobox role when the button receives focus for non-editable comboboxes. While the button also has the combobox role, Orca has logic to not announce the role of combobox children. (`SpeechGenerator._should_speak_role` returns `false` for that case [1].) To avoid this problem and make announcement for both, editable and non-editable comboboxes work as expected, no longer set a combobox role for the box in the .ui file, but set it only for the editable combobox in the C++ code. [1] https://gitlab.gnome.org/GNOME/orca/-/blob/78e44c625ef5fb082907ca484230458624d24ee8/src/orca/speech_generator.py#L365-366 Change-Id: Ia3ff00688f47e61d5a98c79f1a256061b2fb18a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175823 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-04Fix regression Gtk-CRITICAL+Gtk-WARNING on vcl/wizard.uiJulien Nabet
(soffice:40467): Gtk-CRITICAL **: 11:08:58.517: gtk_assistant_set_page_has_padding: assertion 'child != NULL' failed (soffice:40467): Gtk-WARNING **: 11:59:34.471: ../../../gtk/gtkcontainer.c:1348: container class 'GtkHeaderBar' has no child property named 'expand' Regression from 2f3f1170a7ae8bb06c6cd66a8ba3eb85cc63c2ac Resave with newer Glade version Change-Id: I9fd86af43149f2ea6bd25e63c1c04360fdae0bcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169987 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-06-30Resave with newer Glade versionBogdan Buzea
Change-Id: I9e8672e92648359ff8ec7e3f7b667e785b51f0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169602 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-06-26Resave with newer Glade versionBogdan Buzea
Change-Id: I8acca3d2c035fea8caf41b5d5072f5b27604568a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169417 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins
2024-05-07tdf#160971 gtk3 a11y: Set role for custom editable comboboxMichael Weghorn
Set the combobox a11y role for the box in the .ui file used for the custom gtk3 combobox implementation. With this in place, moving focus to the "Font Name" or another editable combobox in the Writer toolbar now makes Orca announce that one as "editable combobox" rather than just "text". See also commit 1e851093f0148d2c55fc3fd377d274f6703c71c9 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Apr 18 14:02:25 2024 +0200 tdf#159910 gtk3 a11y: Keep a11y props for combobox for a very similar change that caused the proper role to be announced for non-editable comboboxes. Change-Id: I3062e5c062911040ef0ec5721d15fee78d85d0dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167262 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-20tdf#159910 gtk3 a11y: Keep a11y props for comboboxMichael Weghorn
Due to various issues with GtkComboBox, the gtk3 VCL plugin does not use the original GtkComboBox, but a custom implementation, originally introduced in commit bc0e0f633b05c4f91b6695488fc9e5c127507ba5 Date: Thu Apr 9 11:41:00 2020 +0100 tdf#131120 use a replacement for GtkComboBox (See full commit message for more details and reasons.) This means that the accessible role, name and description from the .ui file are not set automatically for the GtkToggleButton widget that acts as the combobox instead and receives keyboard focus. In order to make these available for AT, explicitly take these over from the original GtkComboBox. With this in place, the Orca screen reader now e.g. properly announces the comboboxes in Writer's Navigator as "Navigate By, combobox" and "Active window, combobox" (similar to how it already does for the qt6 VCL plugin), rather than just saying "toggle button, not pressed", which didn't give any hint to the user what the currently focused UI element is about and how to interact with it. Also set a default a11y role of combo-box in the replacement's .ui file. (The role from the GtkComboBox's AtkObject should always override that in practice, though.) Change-Id: If5faf77c5f82836c376c04bb6e4e42ce5a3023a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166248 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-20tdf#159910 gtk3: Resave vcl/uiconfig/ui/combobox.ui with glade 3.40Michael Weghorn
... before doing more changes to the file in an upcoming commit, to keep the diff clearer. Change-Id: I3da5d9d708681888418251139e1d5aad4c152ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166247 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-14tdf#155138 Change context stringsTaichi Haradaguchi
"stock" -> "openlockedquerybox|[id]" Change-Id: I2325bf9257ba168d52dc37579f10a9b7685b0751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159343 Tested-by: Jenkins Reviewed-by: sabri unal <libreajans@gmail.com> Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-08-16Resolves: tdf#156751 add "Special Character..." to GtkEntry context menusCaolán McNamara
translation exists so doesn't require additional translation Change-Id: Ibc5df15b9b8442307195d79c862c69e0506c4057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-01Remove option to set printer language typeKhaled Hosny
Drop support for changing printer language type from printer properties dialog, in preparation for dropping support for PostScript printing. This is a follow up to: commit 2a40505d00fcd79bfa433c301ddc05a35287bfb1 Date: Thu Jan 26 11:49:43 2023 +0000 remove option to toggle IsPDFAsStandardPrintJobFormat from UI Change-Id: I970d627588396d6ff648d6e6304e449da7ec1425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-01Resave with gladeKhaled Hosny
Change-Id: I9ef19ef10be497842be25e03fb72d97d1465bedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-25Resolves tdf#147514 - Number of copies on top of the print dialogHeiko Tietze
Swapped with Odd/Even pages option to keep the dialog small Number of copies is assume to be the more relevant function Simple "More" renamed to give some clue of the options Change-Id: I8d1bd3455d5b8d57f47ac97c1a310fd47a4a5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153495 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-02-15move image into the .ui fileCaolán McNamara
Change-Id: I5dad1bd0bcdbedf20d27109ca08109a1a2a6234b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147085 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-15resave with latest gladeCaolán McNamara
Change-Id: Ib1cbf1869fd7b1633178e56a47977050457640f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-07we don't use urgency-hint or want any gravity hintsCaolán McNamara
Change-Id: I86255f9ba018aab7db654d91bf49043fcd4cb057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-20tdf#141026 Put user and computer name into collapsed sectionSiddhant Chaudhary
This patch hides away the file name and the name of the user when the user tries to open a locked file. This improves privacy, as discussed in the bug report. The .ui file for the new dialog box is `vcl/uiconfig/ui/openlockedquerybox.ui`. The source files `openlocked.hxx` and `openlocked.cxx` have been changed to implement the new dialog. The old string template `STR_OPENLOCKED_MSG` has been deleted to hide away the private data, and a new string template `STR_OPENLOCKED_HIDDEN_DATA` has been added; the latter will be hidden inside the expander dialog. Finally, corresponding changes in the makefiles have been made to let the makefiles know about the UI file. Change-Id: I3cc9d2f6e2d9bc43857c80662e2a405aacd7fc70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132342 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-07tdf#140222 make InterimTearableParent docking windows not dockableJim Raykowski
and only allow dockable type docking windows to be undocked/docked Change-Id: Ia1b0ccbdd911c24f83baf1c0514954e354c9070b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129650 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-02-06Resolves: tdf#147218 label doesn't have use-underline setCaolán McNamara
so the _ is shown to the user, not used to add an underline Change-Id: I2de707a2d1da8d842ef03497f9b8f69d37368f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-20add suggested-action to some buttonsCaolán McNamara
Change-Id: Iacb477c17f1c8ac68b331705796e56b4c92292cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11gtk4: add a separator between toggle and menu buttonsCaolán McNamara
Change-Id: I00e9245801529ce817781e65fb75fa59cd3d7f79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11gtk4: get startcenter MenuToggleButton workingCaolán McNamara
the button parts, not the menu part yet Change-Id: I016d2c2160a4e8c0c4d1e096f49d0e518b89a55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-06drop stray skip-pager-hint propertiesCaolán McNamara
Change-Id: I54f4bba95773797f19290fb357225f9726b2ce72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02gtk4: get fancy blue "suggested-action" button for Print in print dialogCaolán McNamara
Change-Id: I60edccc6bb1a5cbbb615ad7be221158ee243f37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02gtk4: adjust print dialog to position page navigation buttons as wantedCaolán McNamara
Change-Id: Ifbd69faa0e69831ad93a2393234e2d97bdd6f4e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116620 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02add explicit expandsCaolán McNamara
Change-Id: Ic62c05487bd77831b1a15e8601c6ba5bb1c7e001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-14Add extended tips to print dialogOlivier Hallot
The extended tips were not imported for the print dialog in the firts round. Change-Id: Ie4e5282720d927fec51a823bb43c1617349105bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115576 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-16Print Dialog move Selection radio button next to All Pagesandreas kainz
Change-Id: I2d87d5ccdaf533e6d93b5d07cbe19d5e454591bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114169 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-02-22factor out as a ResizableDockingWindowCaolán McNamara
Change-Id: I557ccf866cc879b3cc22fcdbca882f4413cb57d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22move dockingwindow.ui to vclCaolán McNamara
Change-Id: I90f18ba755da8ade247330ed102ffcc95740ebab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-20move docking adapters to vclCaolán McNamara
Change-Id: I9be6f65734c24196758dea6853219a168c53a7fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-15tdf#119931 Fix accessibility warningshomeboy445
Change-Id: I897cc51f6c338e82896591d79b6e167f27189122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16tdf#137695 shrink widget height below natural min within data browserCaolán McNamara
Change-Id: Iba3c12376200b7ce800b48155a4b84ca2e47d63f Change-Id: Iba3c12376200b7ce800b48155a4b84ca2e47d63f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16Cancel action here vcl/screenshotparentJulien Nabet
Change-Id: I136fa04e873932621b92004e8eafd7b3a32ef945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109423 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button imagesCaolán McNamara
Change-Id: I9be83856c0dd15552a042f009464c279bf239848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15replace stock button labelsCaolán McNamara
Change-Id: I726ba7846322863d9f38314b6c6ccc7f71124a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-15tdf#138848 add truncate-multiline to all GtkEntries and GtkSpinButtonsCaolán McNamara
except for extensions/uiconfig/spropctrlr/ui/multiline.ui Change-Id: Ia2eca14332ffd4ac6e277c7529f17eca3ba29c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for vcl Change-Id: I8ed97064bb65b00fac3b024a88677b5abe71d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-15add <!-- n-columns=1 n-rows=1 --> before every GtkGridCaolán McNamara
for a in `git ls-files '*.ui'`; do sed -i 's/^\( *\)\(<object class="GtkGrid".*\)/\1<!-- n-columns=1 n-rows=1 -->\n\1\2/' $a; done so we get the same behavior in glade as before 3.38 in that the grid preview don't show any unoccupied grid squares replace all existing n-columns=X n-rows=Y lines because they are all wrong, except for cui/uiconfig/ui/additionsfragment.ui sw/uiconfig/swriter/ui/pageheaderpanel.ui sw/uiconfig/swriter/ui/pagefooterpanel.ui which are correct. Change-Id: I401bbe8e098c26e7f57d6a872d3b70fc1ce85a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105846 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10lock print dialog height so expanders don't expand the dialogCaolán McNamara
but instead can make use of the scrolledwindow Change-Id: I9a820e077dce8090e6c5d876874dc1babbbd6808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105565 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-10set resize-toplevel true for GtkExpandersCaolán McNamara
because that's what we currently do in practice Change-Id: Ib1154a4a7597dbabb20b1cb7b051995a72256e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-02Print dialog alignment fixesandreas kainz
Change-Id: Ife471e062745ce8aa7dd9b806612c00794e4d878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105159 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-10-29tdf#137556 max-content-height needs gtk >= 3.22Caolán McNamara
where the 7.0 baseline is 3.18 and 7.1 is 3.20 Change-Id: I73adb9bc3cf25112925e663f8fc0c3e5191bbf6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104971 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-10-29tdf#137506: Move single control in 'More Options' to print dialogAyhan Yalçınsoy
Change-Id: Iacefe276bf174b96118015b48e746d1591b93c1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104805 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-28print dialog has one expander "more" and one "More"Caolán McNamara
since... commit 8eff280bc08ec3d7b2312ae4ee48df4d7328b7de Date: Fri Oct 2 12:35:26 2020 +0200 ui files: fix some capitalisation issues so make the other one capitalized to match Change-Id: I7eeac239ea99b85b310354e3a0c6dddf15ceff04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20add MenuToggleButton for split toggle/menu buttonCaolán McNamara
which is uniquely used in the start center Change-Id: I098e79ce34a9d99f8fb2eccb3dd04fa27e38427b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-24tdf#118148 Extended tips from HC2/shared/Olivier Hallot
These extended tips are extracted from <ahelp> in Help files Only for ui files, where dialogs/widget pair could be determined. Other forms of <ahelp hid=".."> such as .uno:.. and *HID* ... will be addressed elswhere. Change#1 Removed extended tips from GtkMenu of svx/.../acceptrejectchangesdialog.ui Change#2 Some empty ET's slipped in cui/macroselectdialog.ui Change-Id: Ic8dc62734143f621fcd3c4156fc004f585630277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-14 17:57:13 +0000