summaryrefslogtreecommitdiff
path: root/vcl/unx/generic
AgeCommit message (Collapse)Author
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22Prevent gnome-shell f/ showing 'unresponsive app' during debugAndreas Brandner
LibreOffice advertises NET_WM_PING atom, so mutter rightfully warns of an unresponsive application during debugging. Hack that out unconditionally for dbg_util builds, as per https://bugzilla.redhat.com/show_bug.cgi?id=981149 upstream refuses to make this configurable in any way. Change-Id: I12edbb49a067ad20903ca9b62557ee02c90c8a6e Reviewed-on: https://gerrit.libreoffice.org/43618 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-22Fix 3bf3cae9b7b4d38e0427d71a2b34629fd5988af7Julien Nabet
wrong use of emplace_back, it should be push_back here Change-Id: I729820336f4aedbebb94ce8311c8fb62aba74e92 Reviewed-on: https://gerrit.libreoffice.org/43688 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-22Replace some lists by vectors (vcl)Julien Nabet
Change-Id: Id6f61cbbcd91e1a81e5ac23cdf19a6cda07f8659 Reviewed-on: https://gerrit.libreoffice.org/43675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22Fix wrong use of emplace/emplace_backJulien Nabet
after these patches: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ea6858c1e388c2d17a0825f3d21353ded67083eb https://cgit.freedesktop.org/libreoffice/core/commit/?id=118a0a3734a3f794c67a9d7d4376d8ed78a96fee https://cgit.freedesktop.org/libreoffice/core/commit/?id=c16804de78b1cf1ad906eaacbcc7c51d35218d8a Change-Id: I287d64d3aef6cf18fbf20602680ae9ead0ab26e5 Reviewed-on: https://gerrit.libreoffice.org/43687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21Replace lists by vectors in printerjob (vcl)Julien Nabet
Change-Id: I6eb9b94839307e6297b5c3e3308d95d3645a215f Reviewed-on: https://gerrit.libreoffice.org/43665 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-21Replace lists by vectors in ppdparser (vcl)Julien Nabet
+ simplify some parts Change-Id: I78c611f234e06e542be56016231f6c16d44e4385 Reviewed-on: https://gerrit.libreoffice.org/43640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21Replace list by vector for maPS3Font (vcl)Julien Nabet
Change-Id: Ida0d1a87e32024430fd314c601b9acb9358a9dd2 Reviewed-on: https://gerrit.libreoffice.org/43641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-20Resolves: tdf#113252 missing tabs in basic library organizerCaolán McNamara
Like SfxTabDialog, as in interim measure throw away the TabPage if its not suitable for reuse Change-Id: If8247ea37dfca42e690716a8b687677e0f73c9a8
2017-10-20ofz+ubsan: left shift of negative valueCaolán McNamara
Change-Id: I304532162fc75b69807d5e45227368ab25736b93 Reviewed-on: https://gerrit.libreoffice.org/43586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20Replace list by unordered_set for m_aAlternateFiles (vcl)Julien Nabet
Change-Id: I66ea61972fed87245b33dfe355eff58d23041120 Reviewed-on: https://gerrit.libreoffice.org/43520 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-18use std::unique_ptr in PPDCacheNoel Grandin
Change-Id: Ib47ffaa0fe754d8aafdf338d8ec8c2109beb21a5 Reviewed-on: https://gerrit.libreoffice.org/43484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-11Replace list by vector fontconfig/manager (vcl)Julien Nabet
+ refactor a bit "analyzeFontFile" to return a vector of std::unique_ptr<PrintFont> instead of just a bool Change-Id: I9c8c307c5c323e40667359f5094672c1cde589fd Reviewed-on: https://gerrit.libreoffice.org/43317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-06KDE update system loop integrationJan-Marek Glogowski
This updates the system loop integration to be on par with the other backends. This includes: 1. Process LO user events before other LO events 2. Correctly handle elapsed QTimer events 3. Don't wait-yield in the main thread from a non-main thread Change-Id: Ia17be032ae39dc4c7bfa44cadd22d85a1b9c4fbd Reviewed-on: https://gerrit.libreoffice.org/43198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-05loplugin:finalclasses in vclNoel Grandin
Change-Id: I7de9cd6c5569217aa8d379c6d112cd1874bca8e2 Reviewed-on: https://gerrit.libreoffice.org/43151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-28Unify SalUserEvent handlingJan-Marek Glogowski
Merges the various SalUserEvent structs and their handling into a single class. This includes a common SalFrame* hash map, as all backends use such a map to verify alive SalFrames. It also reverts the "FIXME: lousy workaround" for i#90083, which was part of commit d6f7c94e5c27ba02ff5c3229760c9808cc9b5bea. At least on my current OSX box application based window switching "just works" "out of the box", even without the code. Change-Id: I188b567e44fd79c162b2d9cabbd771d1f66c7dc4 Reviewed-on: https://gerrit.libreoffice.org/42845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26WIN run main thread redirects ignoring SolarMutexJan-Marek Glogowski
This way we can drop all the special nReleased handling. Instead we use the same mechanism as on Mac, where we keep the lock, but disable it for the main thread. As a security measure we assert on duplicate redirects, which should not happen. As a result we can't use SendMessage on the main thread itself, which would normally just call the WinProc directly. This could be accomplished by converting the redirect bool into a counter, which should be safe, as no other thread could acquire the SolarMutex, as we don't release it. Change-Id: Icd87b3da37a2489f3cad2bc80215bf93fc41d388 Reviewed-on: https://gerrit.libreoffice.org/42583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Install fc_local.conf only where usedStephan Bergmann
...and at least issue a SAL_INFO when it's missing (there may theoretically be multiple directories, and it need not be present in every one, so nothing stronger than SAL_INFO can be used) Change-Id: I9b7257a551626e5ad081cfb75422a8bd71b86aa4 Reviewed-on: https://gerrit.libreoffice.org/42714 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24fix some newer leaksCaolán McNamara
Change-Id: I3a13406db4e441c3a29056f80cb728da2ecc3c25 Reviewed-on: https://gerrit.libreoffice.org/42720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23normalize -> styleCaolán McNamara
Change-Id: I10895e686c7f583dd3d4a002b878f4499d15efa3 Reviewed-on: https://gerrit.libreoffice.org/42697 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23cid#1418339: resource leakJulien Nabet
Change-Id: I87374e32e787f58aa5e4d1b6a78fcd1dddcccdf6 Reviewed-on: https://gerrit.libreoffice.org/42680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-22vcl: [loplugin:badstatics] pManagerMichael Stahl
Move this to class GenericUnixSalData, which is deleted on shutdown. Change-Id: I6366c12f255bfeca737b22259c3f58ffa2c6222c Reviewed-on: https://gerrit.libreoffice.org/42632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22vcl: [loplugin:badstatics] PPDParserMichael Stahl
class PPDContext actually looks harmless but it has an out-of-line destructor so the plugin can't see that it's harmless, so use default destructor instead. Change-Id: I921a4cdaeb5c8fe286615162b9e9c2a8db47b300 Reviewed-on: https://gerrit.libreoffice.org/42633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-19rename GetGenericData to GetGenericUnixSalDataNoel Grandin
Change-Id: Id95334da347c8341d9d190307603218eedb9c1e6 Reviewed-on: https://gerrit.libreoffice.org/42457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19rename SalGenericData to GenericUnixSalDataNoel Grandin
since it's generic over the various unixen, not anything else Change-Id: I994d5c9be99134b804e96bc045bf054fd9b434ef Reviewed-on: https://gerrit.libreoffice.org/42455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19Unify SolarMutex implementationsJan-Marek Glogowski
All backends implement the SolarMutex in mostly the same way. So this consolidates this code into a GenericSolarMutex. We still need the abstract SolarMutex class for the fake AKA fascade implementation in dbaccess. The patch also replaces various places of direct mutex usage with either SolarMutexGuard or SolarMutexReleaser objects. Change-Id: Ia0146dd6c51a3b9a513cc6af34a66def58aad831 Reviewed-on: https://gerrit.libreoffice.org/42325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-18ofz#3419 Null-dereference READCaolán McNamara
Change-Id: I32c5d5039034ac76262223e42a1f27d6f1b84cb5
2017-09-18Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAryStephan Bergmann
Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334 Reviewed-on: https://gerrit.libreoffice.org/42406 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-14clang-tidy modernize-use-emplace in vclNoel Grandin
Change-Id: Ie0a6d105b0167431275e628935df4f4c1a36d070 Reviewed-on: https://gerrit.libreoffice.org/42259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12no CPDParser under AndroidCaolán McNamara
Change-Id: I3cf6df721f89493a527a0b65b24354d3e6135c68
2017-09-12loplugin:unnecessaryparenStephan Bergmann
Change-Id: I6fe1690b6f66e31753da993a256b7586478ef4f1
2017-09-12CUPS_VERSION_MAJOR is not definedCaolán McNamara
on arm Change-Id: Ibeca07800d02f5f69046c7bdee57143c78c03aad
2017-09-12stub things to build without dbus or gioCaolán McNamara
Change-Id: Ibdcf33a6f0a688b322aedd531e8dfbf107e9e755
2017-09-12unnecessary thisCaolán McNamara
Change-Id: Ic5e325e12fb7270e448dd0d32e046b766e029d8e
2017-09-12Add Common Printing Dialog FunctionalityYash Srivastav
Summary: These set of commits add support for the Common Printing Dialog Backends being developed as part of GSoC'17. All backends exist as dbus-services which can be queried for printers, their options, etc. Test Plan: Firstly, without adding any CPD backend, LO printing should work as it works now with graceful fallback to CUPS. Next, we need to install a backend. The backend providing CUPS interface is at git@github.com:NilanjanaLodh/PrintDialog_Backend.git See README.md for installation instructions. After this, run LO and existing CUPS Printers should show up. Also printing does send a job to cups which can be seen at: http://localhost:631/jobs?which_jobs=completed Due to LO shutdown not being handled properly currently, the backend might need to be killed via `pkill print_backend_cups` Future Plans: * Fix shutdown actions. Change-Id: I3bdea5d3272ec4c9c0dfe510f5848fcb398b4b14 Reviewed-on: https://gerrit.libreoffice.org/40565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-12WIP: Implement Basic Common Printing BackendYash Srivastav
Can list printers and basic printing set up. Change-Id: I2be3ac448cec8f40f632dbfa22657088e9cf7ee9 Reviewed-on: https://gerrit.libreoffice.org/38987 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-11Translate German comments/debug strings (leftovers in dirs vbahelper and vcl)Johnny_M
Translates leftovers found using a custom regex. Additionally: - Translated the "SGV Fonts for StarView" INI file parameter group in vcl/source/filter/sgf.ini and .../sgvtext.cxx Change-Id: I1360aac1a2f3fa825f86d77ac1b05e2de9ffb007 Reviewed-on: https://gerrit.libreoffice.org/42145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-02Replace lists by vectors printer part (vcl)Julien Nabet
Change-Id: I0e4685b78f114296b115b4fef5eed4140755e1a1 Reviewed-on: https://gerrit.libreoffice.org/41804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18Fix typosAndrea Gelmini
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16SalFrame Handle* methods can return boolNoel Grandin
Change-Id: Ia28463e1c83aa496e8c389d1614f9b8a78100994 Reviewed-on: https://gerrit.libreoffice.org/41209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-01loplugin:constparams in variousNoel Grandin
Change-Id: Id15f3562f42afa6c679cea3c839172557ead0395 Reviewed-on: https://gerrit.libreoffice.org/40624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28GEN fix timeout result handlingJan-Marek Glogowski
The GEN VCL backend simply ignored the result of the timeout. Change-Id: I0c1b34927ba97886cf11b2c2a203c3e82d851dc9