summaryrefslogtreecommitdiff
path: root/vcl/unx/gtk3
AgeCommit message (Collapse)Author
2016-06-29Resolves: rhbz#1350478 identify that we own the selection with a unique targetCaolán McNamara
so we can tell that we own the selection in the absence of reliable selection ownership notifications under wayland Note that gnome#768177 means that requests for CLIPBOARD targets after requests for PRIMARY targets can time out, which is why my attempts at doing this before giving up with commit 88cd9dd591d7921e5bce33c170b457ae5aa871bb Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 24 15:06:36 2016 +0100 Resolves: rhbz#1326304 cannot detect loss of wayland clipboard ownership didn't work. Change-Id: I1154899e478b6e0cc6f70aa0c90c26663299072c
2016-06-27Resolves: rhbz#1342823 toolbar menus popdown immediatelyCaolán McNamara
Change-Id: I9cecf50fb85d84e108ccc23d22bf97d2ac510a9b
2016-06-27loplugin:singlevalfields in vcl(part2)Noel Grandin
Change-Id: I4782c6f6d3d090ba0f9e29af8afdd7d88aa2d382 Reviewed-on: https://gerrit.libreoffice.org/26598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...Caolán McNamara
better fix, if we listen to the eventbox we get either SMOOTH scrolling or not smooth events, not both. We get SMOOTH when supported, and not if not supported so no need to reintroduce the miserable hack, which doesn't work under wayland anyway Change-Id: I993e71d3553322425a506cd93d812efe081bf3c9
2016-06-24loplugin:redundantcastStephan Bergmann
Change-Id: I1ca323870cfbfae05768489ebd8d0fc59191de06
2016-06-24Resolves: rhbz#1326304 cannot detect loss of wayland clipboard ownershipCaolán McNamara
gtk_clipboard_get_owner always returns what you set with gtk_clipboard_set_with_owner and that doesn't change if some other application takes over the clipboard The "owner-change" signal doesn't contain any useful data under wayland, and doesn't fire when you'd expect either, just when the app becomes active or gets focus or something like that. So you get it when you do have the clipboard and when you don't, so that's no use either to detect loss of clipboard ownership So, forget about clipboard ownership, and always take the data to be pasted from the system clipboard, so when we are pasting from ourselves its "paste"->m_aSystemContents->gtk->"copy"->m_aOurContents Undoubtedly something else will break now Change-Id: I32f2e1a2cc3310687f61a094fdfa940fa0cfcc39
2016-06-23Resolves: rhbz#1349501 gtk3: smooth scrolling events can be disabled...Caolán McNamara
by the user with GDK_CORE_DEVICE_EVENTS=1, and so manage to disable their wheel scrolling Change-Id: I7df63f738983c90dea75b9f43a36133910446aba
2016-06-20Convert PART to scoped enumNoel Grandin
Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17convert DBG_ASSERT in vclNoel Grandin
Change-Id: I732fb1a789f90ca7a7f393cc41a6afe84fecf3d3 Reviewed-on: https://gerrit.libreoffice.org/26200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13Related: tdf#100337 revert x-crossplatform ToTop...Caolán McNamara
which was added in... commit 82abd23f3ee1900b7579e5a0afa23581d5836f01 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Nov 12 16:05:44 2015 +0000 Resolves: tdf#93317 Modified Document Dialog misses focus on Gtk3 because it reportedly causes a windows-only regression and instead fix tdf#93317 by presenting windows and taking focus using the last received user input time to ensure that the ToTop on the main window doesn't take precedence over the following gtk_widget_show of the quit dialog Change-Id: I08d1889232af75ca214ccafe9e4e9364df74fbe2
2016-06-13gtk3: m_bSetFocusOnMap is only used on gtk3Caolán McNamara
Change-Id: I3cf9e13dafb59031ab8dc4e678de9d502a376d52
2016-06-10gtk3: use gtk_window_group_get_current_grab instead of gtk_grab_get_currentCaolán McNamara
now that we are using window groups, otherwise the problem of tdf#99604 comes back Change-Id: I7a940ea72bfd7fd4a7f68f1e60395d5014ce155c
2016-06-10Convert RenderType to scoped enumNoel Grandin
Change-Id: I2f4bb201babc9050b19de2dacc0dea462255dfa2
2016-06-09wrong hunk includedCaolán McNamara
Change-Id: I5fbeea83393e811cdf333f3cf456cbd6cc2f9d6c
2016-06-09EndSaveFocus return value is unusedCaolán McNamara
Change-Id: I746e47b118a8b8c687c435371e2bdf2dc22cbf88
2016-06-09reported abs narrowing complaintCaolán McNamara
Change-Id: Icd27fea97e720607263e5f8a2d233c462f979e1b
2016-06-09Resolves: rhbz#1344042 deb#826654 scale gtk3 smooth scaling events...Caolán McNamara
to give traditional amounts of scroll on a single mouse wheel event ditch non smooth scroll events now seeing as apparently they are always available so the other types are irrelevent now if we get x and y scroll, then like macosx just dispatch x and y scroll events. Note: there seems to be a bug in the stack below us where the first scroll event after getting focus is one of a 0 x and y delta. Because we now check x and y against 0, we don't launch a scroll event in the case of a 0x0 scroll which stops us occasionally appearing to go backwards on the first scroll after getting focus. Which is the same thing I see on e.g. gedit, the first mouse wheel scroll after getting focus doesn't actually do anything. Change-Id: Iec8f2e4627cd84e3896270a0847a5c4907fa083f
2016-06-08gtk3: use window groups so modal dialog are modal to their toplevel frame onlyCaolán McNamara
so e.g. launching help from a modal dialog gives a new toplevel window which is not blocked by the modal dialog on the other window. likesize can go from one blocked e.g. writer window to calc and type away in there happily Change-Id: Id9376b393514e91dfd667dfce132f1f37367084e
2016-06-08Convert ButtonValue to scoped enumNoel Grandin
Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Resolves: tdf#100097 dbaccess self-dnd depends on getting its own transferableCaolán McNamara
on drop that it set on drag. It does some uno tunnel foo to drag the data it needs back out of it in some grotesque fashion. So we have to follow the same style of hackery as under MacOSX to detect on drop that there is an active drag started by ourself and so use that active drag's transferable as the source transferable for the drop, rather that use the intermediate universal GtkDnDTransferable. Change-Id: I3c3a94416db908603bde8f15dc5b1c9d726b8dbd
2016-05-30this signalIMPreeditChanged is a cnp from gtk2 implCaolán McNamara
Change-Id: Ib2e624af2e07b28a2e2ca0e3a0a16f3fe453aeaa
2016-05-24support old gtk3sCaolán McNamara
Change-Id: I20429aa8c06a319f9eb11079b320211f38e16827
2016-05-23Resolves: tdf#99874 gtk3: all-black xbm cursorsCaolán McNamara
Change-Id: I1feca80dd75f7a09e05ac43293e8645da391a775
2016-05-22Convert SetType to scoped enumNoel Grandin
Change-Id: I1f724340a990ce8a811fa84e1f5fc54fad54ae81 Reviewed-on: https://gerrit.libreoffice.org/25198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19loplugin:staticcallTor Lillqvist
Change-Id: I6702cd329aa5931f3edbf67257f4b7db79000f32
2016-05-19gtk3: for x11 case set Display and Visual so opengl slide effects can workCaolán McNamara
Change-Id: Ib354a3bc0e2069117717068d7cfc02623765a6fa
2016-05-16gtk3: min slider size too small since 3.20.0Caolán McNamara
"GtkScrollbar:min-slider-length has been deprecated since version 3.20 and should not be used in newly-written code. Use min-height/min-width CSS properties on the slider element instead. The value of this style property is ignored." sigh.... Change-Id: I0fe44b0a3dd31bd60c07f58ae5245496a7463fe2
2016-05-11gtk[3]: the frame argument is now unusedCaolán McNamara
Change-Id: Ib9989545495a8682d7cac97c02ab73d7c622aecf
2016-05-11convert SAL_FRAME_TOTOP to scoped enumNoel Grandin
Change-Id: Id996e1e6fc29f6323bd4e82785386de26d075cae Reviewed-on: https://gerrit.libreoffice.org/24834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11convert EXTTEXTINPUT_ATTR to scoped enumNoel Grandin
Change-Id: I94706bdea91d367fc8c2bbd482f6b4d8f55449d7 Reviewed-on: https://gerrit.libreoffice.org/24821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Convert SALOBJ_EVENT to scoped enumNoel Grandin
Change-Id: I41fcdbb2381008b99f6cb7cafb085d35f8db9374 Reviewed-on: https://gerrit.libreoffice.org/24828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Convert SAL_EVENT to scoped enumNoel Grandin
Change-Id: I4e605e7acfe9d4fe409d32f20880b4c0e85a0ea7
2016-05-10EXTTEXTINPUT_CURSOR_INVISIBLE is set on the wrong fieldCaolán McNamara
Change-Id: I6d92c86035dd321eb6df46bcd01aed7a0113b0a4
2016-05-10convert WINDOWSTATE_STATE to scoped enumNoel Grandin
Change-Id: I5448c7e46042850f18970c7613ec5a37df57bce7
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-08Resolves: tdf#96604 remove and restore full stack of grabsCaolán McNamara
Change-Id: I51b5943f52ccdce6b4b50131f5f2b7d2c1ff7368
2016-05-06reroute UpdateFull through ActivateAllSubmenusCaolán McNamara
Change-Id: I8689abacbfc970a9124bb97a3962bcfb0df9c67d
2016-05-06gtk3: separate the two different usages of ActivateCaolán McNamara
Change-Id: Ic7442209efac40bd0cd034ff006e87128b0bea35
2016-05-05gtk3: New Folder dialog from Templates dialog doesn't get keyboard focusCaolán McNamara
ctrl+shift+N, and click new folder, no keyboard input is accepted. The dialogs don't get keyboard events, because the keyboard events go to the top level window because of... commit 011ce226e89ecabaf621603d692547c88061eaba Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 19 13:22:10 2016 +0000 Resolves: tdf#99604 ungrab modal dialogs (should be tdf#96604) which stripped away the grab from the sub dialog but I did that because menu dropdowns from comboboxes inside modal dialogs didn't receive mouse focus otherwise. I had set our "modal" dialogs to be truly modal and triggering that problem with commit 8d5822983e9b6a1e04874ce4d2c807fd0cf1ee04 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Dec 14 11:36:50 2015 +0000 Related: rhbz#1290014 gtk3: use gtk_window_set_modal on modal dialogs which makes modal dialogs (which are most of them) place correctly under wayland. Modeless ones are still uselessly shoved far to the left, but this makes things near usable and gives the same "graying into the bg" effect for the main window as other gtk apps which I still contend is "a good thing" if we stop removing the grab from the modal dialog, then we still have the problem that the menu dropdowns from comboboxes inside modal dialogs don't receive mouse focus otherwise. After trying to add/remove grabs around showing/hiding menus we run into another pit of trouble (commit 72e6a1365cb08986b542a5beb797634bca62d85b Author: Caolán McNamara <caolanm@redhat.com> Date: Wed May 4 16:29:35 2016 +0100) so, lets save the widget that has the grab before showing our first menu, clear the grab, and restore it on hiding the first menu again. and still ditch that metacity hack around thing at this point too I truly hate this crap Change-Id: If10e758585f156b33680b8d40355302cc1ae72f3
2016-05-05Revert "gtk3: New Folder dialog from Templates dialog doesn't get keyboard ↵Caolán McNamara
focus" cause testing in libreoffice 5-1 shows that it breaks the menus there, we need that more complicated grab after all, we just don't see that on master because of the native menus in use there. This reverts commit 72e6a1365cb08986b542a5beb797634bca62d85b.
2016-05-05gtk3: New Folder dialog from Templates dialog doesn't get keyboard focusCaolán McNamara
ctrl+shift+N, and click new folder, no keyboard input is accepted. The dialogs don't get keyboard events, because the keyboard events go to the top level window because of... commit 011ce226e89ecabaf621603d692547c88061eaba Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 19 13:22:10 2016 +0000 Resolves: tdf#99604 ungrab modal dialogs (should be tdf#96604) which stripped away the grab from the sub dialog but I did that because menu dropdowns from comboboxes inside modal dialogs didn't receive mouse focus otherwise. I had set our "modal" dialogs to be truly modal and triggering that problem with commit 8d5822983e9b6a1e04874ce4d2c807fd0cf1ee04 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Dec 14 11:36:50 2015 +0000 Related: rhbz#1290014 gtk3: use gtk_window_set_modal on modal dialogs which makes modal dialogs (which are most of them) place correctly under wayland. Modeless ones are still uselessly shoved far to the left, but this makes things near usable and gives the same "graying into the bg" effect for the main window as other gtk apps which I still contend is "a good thing" if we stop removing the grab from the modal dialog, then we need to grab the keyboard and mouse on to the menu on showing those. This then runs into the problem that sometimes we want the keyboard to go to one window and the mouse to go to another, i.e. mouse to the floating menu and the keypresses to its parent combobox. Which was the joy of... commit 27e0fee7da99f3df722668d132bc034bef421514 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Mar 27 15:28:28 2015 +0000 gnome#745909 grab/ungrab keyboard for menus and subsequent fix of commit 57ec66e294b1405a85029aa1f1c0e9485ad4e5b4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 23 09:55:01 2015 +0100 Resolves: tdf#92689 grab keyboard focus to parent, not to earlier generations so... lets drop the ungrab on modal dialog attempt and leave that alone. That means that the keyboard focus travels around the modal dialogs stack correctly. For the mouse and keyboard events in menu problems, instead gtk_grab_add on the menu itself, and convert the separate grab of keyboard and mouse to different places with a single grab of everything to the menu, and in the keyInput of such menus where the keyInput would have gone to their parent in the past, forward it on ourselves directly. Using the gtk_grab_add makes the bOwnerEvents mode of mouse grabbing not work correctly anymore. So throw my hat at it, and instead use the simpler mouse grabbing where all events go to the menu, and doesn't send the events outside of it to the parent, the side effect is that now clicking outside the menu doesn't make it go away automatically because its the parent window which used to do that. So instead of dismissing the menu within the gtk plugin when the button click is outside the application, take it onto ourselves to dismiss the menu when the button click is outside the menu. and ditch some metacity hack around thing at this point too I hate this crap Change-Id: If10e758585f156b33680b8d40355302cc1ae72f3
2016-05-05drop commented out codeCaolán McNamara
Change-Id: Ifb4a19bf9c86cf6294859da73ac380e93b2deb45
2016-04-28vcl: fix loplugin:stylepoliceMiklos Vajna
Change-Id: I40455e04a5f69dc0956ccb01c48d8a40245a4506
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I544ccc79ac0ddc2e5800bc4bd863ff86b4ec8f6a
2016-04-13Fix showing tooltips in RTL UI with GTK 3Khaled Hosny
Change-Id: I29c2c7988fb97e2472188a600a483e5f6ed12d80
2016-04-07gtk3: the list/combo box hack to get internal buttons no longer worksCaolán McNamara
with gtk3-3.20.2 Change-Id: I608f3476a82233cb49e0b43c95f5a984d7c89c92
2016-04-07don't need gComboBoxEntryWidget anymoreCaolán McNamara
Change-Id: Ia48817eb1476ef6479c3b8e53666e63198cc9310
2016-03-17Resolves: tdf#98726 sneaky transparent clearlooks-phenix scrollbarsCaolán McNamara
Change-Id: Idc05d7b6c2b42086eafa9ad8ab8e63116d6f676c
generated by cgit (git 2.34.1) at 2025-01-18 07:45:32 +0000