summaryrefslogtreecommitdiff
path: root/vcl/unx/kde4
AgeCommit message (Collapse)Author
2018-01-24Fix --enable-kde4 codeStephan Bergmann
...after de8f6b25de6fbe813fe172542e7eff1596b37335 "loplugin:unused-returns in vcl" Change-Id: I82414b20b7dbb9e7ba361c0f4d9451c74ea4d4f2
2018-01-17Fix --enable-kde4Stephan Bergmann
...after 2ea733e525773e5631210e9503fd8415a72c2ea9 "loplugin:useuniqueptr in SalXLib" Change-Id: I430458b7e95b4814775f80b688259bc960268f9d
2017-12-11loplugin:salcallStephan Bergmann
Change-Id: I7521b2adb9572efbb1d28f9f44f9d29c62d6e1e9
2017-12-07gpg4libre: add KDE4 fpicker gpg crypt chechboxThorsten Behrens
Change-Id: Iba8fb0e0ac732f36cd1d880884bde1121e6b1eab
2017-12-06loplugin:salcallStephan Bergmann
Change-Id: I5c21f95f763f1491cc68087ecec0909493fd7f63
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-16vcl: StyleSettings - start to unwind code duplication.Michael Meeks
This should be a pure re-factor, plus: switch from Serif -> Sans font default for the UI (wow). enable larger font size for LOK only that avoids a hard to debug svx junit test failure. Change-Id: Id438026064983ea4907819bab55c4be740954605 Reviewed-on: https://gerrit.libreoffice.org/44625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-11vcl: StyleSettings - start to unwind code duplication.Michael Meeks
This should be a pure re-factor, plus headless tweak. Change-Id: Iad7f524ea76625601b3f85cc13a50311ed1de171 Reviewed-on: https://gerrit.libreoffice.org/44624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-10-23loplugin:includeform: vclStephan Bergmann
Change-Id: Id7dea3917740aaf4db8dada5e2bea6e117d714ea
2017-10-06KDE update system loop integrationJan-Marek Glogowski
This updates the system loop integration to be on par with the other backends. This includes: 1. Process LO user events before other LO events 2. Correctly handle elapsed QTimer events 3. Don't wait-yield in the main thread from a non-main thread Change-Id: Ia17be032ae39dc4c7bfa44cadd22d85a1b9c4fbd Reviewed-on: https://gerrit.libreoffice.org/43198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-28Unify SalUserEvent handlingJan-Marek Glogowski
Merges the various SalUserEvent structs and their handling into a single class. This includes a common SalFrame* hash map, as all backends use such a map to verify alive SalFrames. It also reverts the "FIXME: lousy workaround" for i#90083, which was part of commit d6f7c94e5c27ba02ff5c3229760c9808cc9b5bea. At least on my current OSX box application based window switching "just works" "out of the box", even without the code. Change-Id: I188b567e44fd79c162b2d9cabbd771d1f66c7dc4 Reviewed-on: https://gerrit.libreoffice.org/42845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-19Unify SolarMutex implementationsJan-Marek Glogowski
All backends implement the SolarMutex in mostly the same way. So this consolidates this code into a GenericSolarMutex. We still need the abstract SolarMutex class for the fake AKA fascade implementation in dbaccess. The patch also replaces various places of direct mutex usage with either SolarMutexGuard or SolarMutexReleaser objects. Change-Id: Ia0146dd6c51a3b9a513cc6af34a66def58aad831 Reviewed-on: https://gerrit.libreoffice.org/42325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-08-30vcl: [loplugin:constparams]Michael Stahl
Change-Id: Ic390dbb5a83a049635a868a14d09eaf1cfc2080f
2017-07-21de-hrc various thingsCaolán McNamara
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-14loplugin:useuniqueptrStephan Bergmann
Change-Id: Idcfec3e33031eea311377a51f51c65dd3c4d25dc
2017-07-13KDE4 handle timers via queued custom eventsJan-Marek Glogowski
Post the system timer as a custom event to the event queue and also changes the PostUserEvent froom a timer to a posted custom event. Change-Id: I0b77e0c64fce04b20e82ba8bbf72b7a99b1339af
2017-07-13KDE4 change system timer to be single-shotJan-Marek Glogowski
Change-Id: I21a0a62bd0cd122e0da676579d2b2a93264acdd8
2017-07-13Drop special idle handlingJan-Marek Glogowski
Idles are just instant timers, which should most time have a low priority, By dropping most special idle handling we'll just schedule by priority. This also reverts SalYieldResult back to a bool, which just indicates if any event was processed. Change-Id: Ia0b91b06dffb77af066f01838d8f9483523bf67d
2017-07-13Add some Scheduler unit tests and loggingJan-Marek Glogowski
1. calling Start() for invoked tasks 2. correctly schedule by priority 3. self-stopping AutoTimer This also adds SAL_INFO output to Scheduler and Task to log the scheduling processing tasks. Change-Id: I3c8a708d1fd51c550320f8af3f9486c43c32e358
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-31vcl kde4: adapt to tools::RectangleMiklos Vajna
Change-Id: I047a69bd084f44c7bc7a132eddf2ee09e811d783
2017-03-25Fix typosAndrea Gelmini
Change-Id: I623135cd4c76dd6569f4ee521f97dee41de4cb1e Reviewed-on: https://gerrit.libreoffice.org/35660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-16KDE fix various clang plugin complainsJan-Marek Glogowski
Fixes clang plugin reported problems in the KDE and KDE4 backend. Change-Id: I0280beae9dd6f33ee59bdbe89cd38222f33fdc68
2017-03-11Fix typosAndrea Gelmini
Change-Id: I2be7113bfe86476acfd6550f1eed53eed83c9747 Reviewed-on: https://gerrit.libreoffice.org/35063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-08loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ie173849c0956edf9fd111120fa4bdfb2930ab69f
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: Id0823ce54c7adb03c824e4095c835356846c69ca
2017-02-21loplugin:subtlezeroinit: vclStephan Bergmann
Change-Id: I041390c7cea1e246f07e799ee2430c16e86723d8
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-03TyposJulien Nabet
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-28loplugin:stringconstantJochen Nitschke
Change-Id: I4e2e0aba2930d7c4ee60567d1d65e0e773a470bf Reviewed-on: https://gerrit.libreoffice.org/33650 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, vclStephan Bergmann
Change-Id: Icc398ec6cbb9152ee86b4ac0003619ae04206cd6
2017-01-17KDE4 Qt always processes all pending eventsJan-Marek Glogowski
Change-Id: I6a6e37c36a64640b641b116867da5c63c9d36bca
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann
Change-Id: Ic25a50fd25820dabe411f1a726580d3e137b028d
2016-12-20KDE4 fix wrong fallthroughJan-Marek Glogowski
Was found and marked in 03f440c379a03500a40cc34097c68a150d7a226d, but is definitly wrong. Change-Id: I6d04814fb8f25a92dfaf96d8face855315cc0208
2016-12-20KDE4 use correct ComboBox frame pixel metricJan-Marek Glogowski
Change-Id: I03fa5489ffc5cd5bb386bb321519c61058db4fda
2016-12-20KDE4 rely on style()->pixelMetric for frame widthJan-Marek Glogowski
Change-Id: I7a1e89c0c058bab0b6665e2b96b22251dcb51f4f
2016-12-20Update duplicated / outdated NWS documentationJan-Marek Glogowski
Removes the old, copied NWS documentation blocks from all native implementations and update the parent SalGraphics documentation. Change-Id: I0eff8ea0987c5c841e1b023340b1c3787c09e2ca
2016-12-20tdf#78924 KDE4 drop special Combobox codeJan-Marek Glogowski
At least not needed with breeze KDE4 theme. Change-Id: I71a05c395d04a6f19c3bcd681450318831b0c29f
2016-12-20KDE4 add frame to Spinbox and enable buttons...Jan-Marek Glogowski
... and don't claim to support all parts per default. Change-Id: I7a8e0774b4573bf755737bc1adebe19a774736c9
2016-12-20KDE4 fix edit box bordersJan-Marek Glogowski
When recalculating the native window frame borders, calculate using already existing window borders. Otherwise the KDE edit box results in an unlimited recursion for increasing the bounding rects, if the control doesn't fit. Change-Id: I45e51e4796b06097ca537c656f004133dfacd033
2016-12-20KDE4 set shadow colorsJan-Marek Glogowski
These are used to paint Writers ruler text and marks. Makes both readable with disabled and inactive text colors. Change-Id: I39766d623164230a7379623c16e0463cbaaf0af8
2016-12-20KDE4 implement native drag handlersJan-Marek Glogowski
Change-Id: I3d6a1696b8278066b005c1983d226cc67381ba95
2016-12-06OSL_TRACE -> SAL_ in vclNoel Grandin
Change-Id: Icd317671a6b1b5356f0ccc7c59d50952fe20269b Reviewed-on: https://gerrit.libreoffice.org/31667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21loplugin:datamembershadow: KDEXLib::blockIdleTimeout shadows SalXLib memberStephan Bergmann
This smells like there's some sort of needless duplicationg among KDEXLib and its base calss SalXLib, but this duplication of blockIdleTimeout members had been like that ever since those members' introduction in 06d731428ef6cf93c7333e8228bfb6088853b52f "make idle timers actually activate only when idle". Change-Id: Ic3eec821b2433745e83fc23d65d3c5f8e1fcf663