summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2016-09-15loplugin:countusersofdefaultparams in vclNoel Grandin
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979 Reviewed-on: https://gerrit.libreoffice.org/28891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13tdf#74377 Keyboard shortcuts for context menusMaxim Monastirsky
Configurable through the options dialog. The default behavior depends on the current vclplug (hide for gtk2/3 and OS X, show otherwise). Menus currently affected by this change: - SfxDispatcher based context menus - chart2 context menus - vcl's Edit control context menu - Several MenuBarManager based toolbar dropdowns. Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d Reviewed-on: https://gerrit.libreoffice.org/28849 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-08Resolves: tdf#101881 gtk3 3.18 menubar doesn't grab keyboard...Caolán McNamara
the same way gtk3 3.20 does with gtk_grab_add, so on gtk_menu_shell_deselect the keyboard focus doesn't remain in the menubar. bisecting gtk itself I find... commit 5cbbb90e311d95192d1b68ba89c3190cdb652868 Author: Carlos Garnacho <carlosg@gnome.org> Date: Thu Nov 26 19:54:31 2015 +0100 GtkCellRendererAccel: Use gdk_seat_grab() https://bugzilla.gnome.org/show_bug.cgi?id=759309 is the commit that makes it do what I want, so add an extra gtk_grab_add/gtk_grab_remove around our entry and exit of the menubar Change-Id: I5bf09834b4e1a14d30403208d03b3abd28a382a8
2016-09-07Resolves: tdf#100443 handle sun keyboard copy/cut/paste keysCaolán McNamara
Thanks to Charles Lindsey for these suggested changes Change-Id: I22d14f16ee560f189c40ba0b143718278e0a8b7d
2016-09-07Related: tdf#100443 don't use deprecated gtk keysym definesCaolán McNamara
Change-Id: I7c018a304844b06e66b7f344a4deeabb43ae4026
2016-09-07less dlopen, call gtk2 things direct, baseline is newer nowCaolán McNamara
Change-Id: Iff385fe836f8e959fb8b16aa76603b490bc44d9f Reviewed-on: https://gerrit.libreoffice.org/28719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-07Fix not-so-newly introduced perf regression in vclKhaled Hosny
Reverts f688acfdae00ebdd891737e533d54368810185e1 and the cluster boundaries part of 1da9b4c24e806ad2447b4a656e2a7192755bb6a8, checking the user of the GlyphItem::IS_IN_CLUSTER flag again, I think the old code provides what they expect. Change-Id: I47d279837af963a6db74ebd0019dcef83d98ae7a
2016-09-07gtk: drop unneeded X11 includesCaolán McNamara
Change-Id: Iea6f90e40401bd3f0e4c54de598df2262f14b686
2016-09-07loplugin:constantparam in vcl..xmlscriptNoel Grandin
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a Reviewed-on: https://gerrit.libreoffice.org/28685 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-06Work around loplugin:unnecessaryoverrideStephan Bergmann
("public virtual function just calls public parent", in the gtk3 case) Change-Id: I0d5653f835fe0e62a905943fda7d79538dabfee3
2016-09-06use same GtkInstance::AnyInput impl for gtk2 and gtk3Caolán McNamara
Change-Id: Ib69884e0d02b0b245459eb05d5dfb54797d566ce Reviewed-on: https://gerrit.libreoffice.org/28680 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-06GtkInstance should use default no-op I18NImeStatusCaolán McNamara
gtk3 already did, gtk2 claimed to support it, but will use the built-in gtk support for this. So this leaves this as gen/kde4 only now. Change-Id: I640ffafc93bf45a4729ecd33f0f85f23fa67b4bf
2016-09-06move all X11SalData stuff togetherCaolán McNamara
Change-Id: I2dc27e8aa0231ad66955721029f61720d757967f
2016-09-06don't need to include all these headers, reduce to required minCaolán McNamara
Change-Id: I1f05ed32cabc059309f46ec0a195705f0e774bd6
2016-09-05Convert PPDKey::SetupType to scoped enumNoel Grandin
Change-Id: I7c39c9bd4bc3b8fe82840665906f8d520e2e2d2a
2016-09-05convert PrinterInfoManager::Type to scoped enumNoel Grandin
Change-Id: I3ae15e3ef9505b9857ab1dfa0ecdbf57e3a08150
2016-09-05convert DuplexMode to scoped enumNoel Grandin
Change-Id: Ic6f6e11437e75d17630683196c1b94dc25dd888f
2016-09-05convert Orientation to scoped enumNoel Grandin
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05fix usage of std::uniqueNoel Grandin
in commit 26c149617c54e29902a "std::list<sal_Int32> to deque" Change-Id: Ifd6ad15d8f95512e31bac4c39d2092a53a7c0ee1
2016-09-05convert FontAutoHint to scoped enumNoel Grandin
Change-Id: Ie60f2e94e178ab7ed292b20da88fb5958662a041
2016-09-05convert FontHinting to scoped enumNoel Grandin
Change-Id: I13ce9e6d50e8d4e087c936bd86e8e96997f020cd
2016-09-05convert OutDevSupportType to scoped enumNoel Grandin
Change-Id: I7a1e4448dfff0ea6909149533d228829d980796c
2016-09-03coverity#1371244 Missing move assignment operatorCaolán McNamara
Change-Id: I172f8397a96e5b7d0d4639e35c591caea2a0eef4
2016-09-03Resolves: tdf#101795 restore hiding on end of Gtk fpicker executeCaolán McNamara
but don't hide it at the end of every RunDialog::run so that the dialog still exists and is visible if the "sure you want to overwrite" dialog needs to be displayed and restore the cui options stuff to its original state as well, undoing the earlier efforts of... commit c1bd3156cf66318023f36d81ce809a38072588e4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 21 21:44:06 2016 +0100 Resolves: tdf#101054 crash on options->path with non-native file picker and commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker Change-Id: I5d6bcee9fb0a73a95cc29e8f3f2ee2aea91a135a
2016-09-02boost::intrusive_ptr->tools::SvRefCaolán McNamara
Change-Id: I4c913dc62efe3f3747e78670f4efb0216d95c4ad Reviewed-on: https://gerrit.libreoffice.org/28585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-01std::list<sal_Int32> to dequeNoel Grandin
Change-Id: I28942e35cf240b83ad49def6252f2709baf525a9
2016-09-01std::list<sal_Unicode> to vectorNoel Grandin
Change-Id: If437d2588c75c76fdf03413c074f4f49f93a12f4
2016-09-01std::list<sal_Int32> to vectorNoel Grandin
Change-Id: I991fba4593665035df26a0e13f0219029f2eb917
2016-09-01std::list<int> to vectorNoel Grandin
Change-Id: I05d4531ac6d3daa8c996db374bc2a2425215dde8
2016-08-31gtk3: Implement menubar hidingMaxim Monastirsky
Change-Id: Ia772f05daa74453fc3dc8fe0c257fdac358cd5c6 Reviewed-on: https://gerrit.libreoffice.org/28490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-30silence coverity#1371204 Missing move assignment operatorCaolán McNamara
and silence coverity#1371210 Missing move assignment operator Change-Id: I6d7a59fd789c16ee11a27d50ba8fd14f17ae77e0
2016-08-29CairoFontsCache is only used in cairotextrender.cxxStephan Bergmann
...so move it there and remove the VCL_DLLPUBLIC Change-Id: I1fc75984f8a9935e34cd9ac36d878809b538bd1e
2016-08-29Toolbar popups need explicit deactivationMaxim Monastirsky
... if based on MenuBarManager, because unlike context menus, we reuse the same menu instead of creating from scratch each time, so that it suffers from the same "double activation" problem as in tdf#97665. Note that for GtkSalMenu the problem is only for the top level popup menu, as the Deactivate callback is properly called when sub menus are closed. The non-native case also had this problem, but only when closing the menu by selecting one of its items, and was fixed already in b41deb2ef057c3bd43fa61448bb4d7299138c8d4. Change-Id: Iee037f7baba0f80c32fb3a45f16511f8585c203e
2016-08-28coverity#1371444 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3a6c7c4aa688722a318271d5416313baf65db78e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-18coverity#1371444 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3e4294f3459ab069f4bd5a8233cbd8a4c1dd2beb
2016-08-18cppcheck: noCopyConstructorCaolán McNamara
Change-Id: Id5323cb6f52666f85965e11b07e4f2bca8af4e78
2016-08-12loplugin:countusersofdefaultparams in vcl..xmlsecurityNoel Grandin
Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd Reviewed-on: https://gerrit.libreoffice.org/28018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11Resolves: tdf#100250 scrollbar has no bgCaolán McNamara
Change-Id: I48e26b775337809759f8a76be7a9c457c94cd5c9
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-08gtk: a11y: quieten warningsCaolán McNamara
Change-Id: I4b4c7c22482ca0ee45a114798fcab65a9dc69789
2016-08-04Related: tdf#101213 speculative drop of CAIRO_OPERATOR_DIFFERENCE useCaolán McNamara
for tdf#99446 and rhbz#1283420 there is a hackaround which ended up in 5.1.5, which is not in 5.1.4, for corrupt glyphs under X. I can still reproduce the problem if I drop the CAIRO_OPERATOR_DIFFERENCE usage here with master and gtk2. This alternative hackaround to force a read of the underlying surface works just as well (help->license information is the reproducer). Change-Id: Ie3c5b07409537a1734226b4ce034620351297e25
2016-07-29only map GDK_SUPER_MASK to KEY_MOD3 and not GDK_META_MASKCaolán McNamara
on wayland I'm getting a GDK_MOD1_MASK and a GDK_META_MASK on pressing the left alt. The check for KEY_MOD2 in Window::KeyInput trips up with the extra KEY_MOD3 bit set so the auto mnemonic underlines don't appear on pressing left alt under wayland Lets map only GDK_SUPER_MASK to KEY_MOD3 Change-Id: I1e9cc9fc095f5edfa7ad7c71440232c6de1ecf04
2016-07-28tdf#101026 Create more correct replacement control vectorArmin Le Grand
Change-Id: I909adaab3dca3c1bac4331b164343cdbc1205df2 Reviewed-on: https://gerrit.libreoffice.org/27365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-07-28Resolves: tdf#101132 a11y crash in hyperlinkCaolán McNamara
regression from... commit aa6c54f337a616c9ca6a39cfc8708657018d8613 Date: Mon Jan 18 09:01:15 2016 +0200 loplugin:unusedfields Change-Id: Ic2b7fe5f2d49a447a9936c4fb04bafcc7349ecf9
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27loplugin:countusersofdefaultparams in tools..xmlsecurityNoel Grandin
find methods with default params with only zero or one call site Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0 Reviewed-on: https://gerrit.libreoffice.org/27512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26loplugin:overrideparamCaolán McNamara
Change-Id: I5d6c249875e4dcebc63e8d0fcdddfcb48e8df18a