summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2019-04-12rhbz#1691287 tdf#53029 ui prompt for printer authenticationCaolán McNamara
refactor and reuse existing dialog to add potential domain entry Change-Id: Ib884931f8ccc62aad9b3e92ecf93d1da7ffe607b Reviewed-on: https://gerrit.libreoffice.org/69765 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-11tdf#124652 Guard Gtk3KDE5FolderPicker::execute with SolarMutexGuardMichael Weghorn
S.a. commit 8dbe0af729c9e054135a0f41706165033441f867 which already did the same for Gtk3KDE5FilePicker. Change-Id: I35f837b7b8fdaebc5625ff8ea5e20b3f48a3b4ec Reviewed-on: https://gerrit.libreoffice.org/70519 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 728ee3839ea94e3391c36a847bf6b28c12ad7647) Reviewed-on: https://gerrit.libreoffice.org/70529 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-04Resolves: tdf#124219 check at runtime for availability of cairo functionsCaolán McNamara
Change-Id: I0ab3055760d8be690bdfff560212db368a0fa261 Reviewed-on: https://gerrit.libreoffice.org/70246 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-04Resolves: tdf#124411 default dnd to MOVE for internal and COPY for externalCaolán McNamara
which what the macosx version appears to also do Change-Id: Icff9cada2c821544d0130e28cc3e3862154a57dc Reviewed-on: https://gerrit.libreoffice.org/70064 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-30tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scalingJan-Marek Glogowski
LO does its own layouting and also all the scaling, so disable the automatic HiDPI scaling explicitly. Otherwise fonts will be rendered in LoDPI and just scaled as an image, if UI scaling is enabled in KDE, resulting in really blocky / ugly fonts. Change-Id: I38503ce27c1671e80d0749d21c6c6dcff1a808a6 Reviewed-on: https://gerrit.libreoffice.org/69941 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b4698a2241ec26d796c66da3a814f7cc693785b6) Reviewed-on: https://gerrit.libreoffice.org/69984 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-28Resolves: tdf#124234 page leave signal missing on move to overflow deckCaolán McNamara
we were emitting page-entered but not emitting the page-leave signal Change-Id: I64131631016331cf102d08244982148ac8c3c69c Reviewed-on: https://gerrit.libreoffice.org/69686 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-21Resolves: tdf#123650 explicitly grab focus after modificationCaolán McNamara
of the widget after gaining focus, otherwise gtk loses track of where the focus should be and tdf#124226 do fill-on-demand hack only on first visit disconnect focus handler after the fill Change-Id: I90d9f36acf807aec8687c7f563449ef16d5eb574 Reviewed-on: https://gerrit.libreoffice.org/69356 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-19rhbz#1687589: KDE4 gpoll_wrapper can be called with SolarMutex unlockedStephan Bergmann
...when called from MountOperation::Mount (ucb/source/ucp/gio/gio_content.cxx), which itself contains a SolarMutexReleaser since 2eb36dc4b846ab5886ae71fd2978b56b2a2d1d08 "Hack to not leave SolarMutex released after g_main_loop_run call". So calling SolarMutexReleaser ctor in gpoll_wrapper will then cause comphelper::GenericSolarMutex::doRelease (comphelper/source/misc/solarmutex.cxx) to call std::abort() because the SolarMutex is not locked. Change-Id: If893b427e404cf3d9e48430f84cff7d32b61bf87 Reviewed-on: https://gerrit.libreoffice.org/69436 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-03-18Fix build with older versions of BoostTomáš Chvátal
Change-Id: Ic5fa7c703821c23e704d2c58f9a04d0ac8ce8ef2 Reviewed-on: https://gerrit.libreoffice.org/69309 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-07wrong "to-page" reported in split notebooksCaolán McNamara
and when switching decks we need that notification to occur too Change-Id: Ica3c83ad34e072faf044c6d4667f34756688de09 Reviewed-on: https://gerrit.libreoffice.org/68172 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-07menu of currency combobox in format-cells is too narrowCaolán McNamara
we want the combobox to be narrower than it wants to be. To make that happen we have only the option of shrinking the cell renderer of the combobox area. And that is also used by the menu. Setting a small value of e.g. 1 works to let the combobox not request more width than that, and the combobox will correctly render within the wider size it actually gets. But then the menu is a min width menu, which is undesirable, we want the menu to be as wide as it can be. So calculate what part of the combobox belongs to the cell area and set the widest cell area we can within the overall combobox width, resulting in the widest menu we can get. Change-Id: Ie3e9960a320a70471ac21d2a88f32632cafa951f Reviewed-on: https://gerrit.libreoffice.org/68168 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-19Resolves: tdf#122355 search help for active notebook pageCaolán McNamara
before checking for the dialog, to get more specific help results. Change-Id: I2d6128fa39d3f7ebf15e194354307dd924590009 Reviewed-on: https://gerrit.libreoffice.org/67981 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-19KDE5FilePicker: Fix build on 32 bit archsMichael Weghorn
This fixes the following build error on 32 bit archs as reported by ricotz for LibreOffice 6.2.1.1 on #libreoffice-dev: [build CXX] vcl/unx/kde5/KDE5SalGraphics.cxx In file included from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:29, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:6, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hdl:6, from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hpp:6, from /<<PKGBUILDDIR>>/include/cppuhelper/compbase.hxx:25, from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker.hxx:22, from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:20: /<<PKGBUILDDIR>>/include/cppu/unotype.hxx: In instantiation of ‘static const com::sun::star::uno::Type& cppu::UnoType< <template-parameter-1-1> >::get() [with T = int]’: /<<PKGBUILDDIR>>/include/cppu/unotype.hxx:321:37: required from ‘const com::sun::star::uno::Type& cppu::getTypeFavourUnsigned(const T*) [with T = int]’ /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:268:55: required from ‘void com::sun::star::uno::operator<<=(com::sun::star::uno::Any&, const C&) [with C = int]’ /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:664:22: required from here /<<PKGBUILDDIR>>/include/cppu/unotype.hxx:296:38: error: no matching function for call to ‘cppu_detail_getUnoType(T1*)’ return cppu_detail_getUnoType(static_cast< T1 * >(0)); ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I5b734160c4ce218a9a982ba4a595add13affa365 Reviewed-on: https://gerrit.libreoffice.org/67983 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 993b8a6667fb0ca58ec1145cc1f9529c34f3266c) Reviewed-on: https://gerrit.libreoffice.org/68002 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-12Resolves: tdf#123080 don't require wayland at runtimeCaolán McNamara
if it existed at buildtime Change-Id: I8a3285b7ee3b0556605b0c3d4b1fef222eb62d1a Reviewed-on: https://gerrit.libreoffice.org/67692 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-06Qt5/KDE5 use logicalDotsPerInch to report DPIJan-Marek Glogowski
It looks like all other backend don't use the physical, but the logical DPI to report the resolution. So use the QScreens logical resolution when reporting the DPI values. Also use QScreen for KDE5, as the Svp defaults to 96. This might fix tdf#122131, but since I can't reproduce... Change-Id: Iefc75acf26f8664f2a9ad995edbdc749be2228cf Reviewed-on: https://gerrit.libreoffice.org/66525 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b0b089e8f7a6df793761bdec6ee9d98b1bf12a5a) Reviewed-on: https://gerrit.libreoffice.org/67410 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-05tdf#118038: use the ListboxButtonStyle padding for listboxesCaolán McNamara
Change-Id: I916dfe036e1e4fbdc67b0c34dc0d3a428ae50d3a Reviewed-on: https://gerrit.libreoffice.org/67124 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-05tdf#117713 set a tiny default size-request for the fixed containerCaolán McNamara
otherwise we get a default one if SetMinClientSize is never called, which is the case for these spawned-from-basic dialogs Change-Id: I4f0389de6abcb1e99b32798969dca49bf8f0f760 Reviewed-on: https://gerrit.libreoffice.org/67073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-04Resolves: tdf#122930 paper tray is to update on focus-inCaolán McNamara
which adds the problem that GtkComboBox doesn't send a focus-in, but its toggle does, to find and use that instead Change-Id: I18d46511bf2e6997539a8413f574a94b24b4583f Reviewed-on: https://gerrit.libreoffice.org/67016 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-31tdf#123077 gtk3_kde5: Set KFileWidget's custom widget only onceMichael Weghorn
Since the event filter is only used to set the custom widget in the KFileWidget, it can and needs to be removed again once this has been done; which also avoids crashes. (s. https://gerrit.libreoffice.org/#/c/67185/ for more infos, where the same thing is done for kde5) Change-Id: I5c719fb17510916b4730ed5c00bb638df2f183e3 Reviewed-on: https://gerrit.libreoffice.org/67184 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 30cc54a4532a732a0cf6dfe9943521978ff7292f) Reviewed-on: https://gerrit.libreoffice.org/67203 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-31tdf#123077 kde5: Set KFileWidget's custom widget only onceMichael Weghorn
Since the event filter is only used to set the custom widget in the KFileWidget, it can be removed again once this has been done. Previously, events could cause 'fileWidget->setCustomWidget()' to be called multiple times, which resulted in a crash. (The fact that calling 'KfileWidget::setCustomWidget()' multiple times causes a crash could also be easily be reproduced by just duplicating the call.) Basically the same will be done for the gtk3_kde5 case, but in a separate commit to simplify backporting. Change-Id: Ic463c44d8a95f44ce09924893d682f402ad7ed3d Reviewed-on: https://gerrit.libreoffice.org/67185 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 68b15aee96abf5cd2179009424ab6a0229b67756) Reviewed-on: https://gerrit.libreoffice.org/67205
2019-01-30tdf#122752 gtk3_kde5: Use non-native fpicker for non-Plasma desktopsMichael Weghorn
Adding the custom widgets to the native dialog currently depends on the native dialog using a KFileWidget, which is just the case for the native QFileDialog implementation on Plasma/KDE5. In order not to lose custom controls for non-Plasma desktops, fall back to using the non-native QFileDialog there and adding the custom controls to its layout. This was mostly taken over from Qt5FileDialog. (This is a similar approach as that taken for the kde5 VCL plugin in https://gerrit.libreoffice.org/#/c/67106/ ). Adding the controls to the layout returned by 'QFileDialog::layout()' cannot be used for the native dialog as well, since a nullptr is returned in this case. From QFileDialog doc: > By default, a platform-native file dialog will be used if the platform > has one. In that case, the widgets which would otherwise be used to > construct the dialog will not be instantiated, so related accessors such > as layout() and itemDelegate() will return null. You can set the > DontUseNativeDialog option to ensure that the widget-based > implementation will be used instead of the native dialog. Change-Id: I75fbe7731da28d0dc7df878f4c57e141d4d89902 Reviewed-on: https://gerrit.libreoffice.org/67111 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit bf93bae6990b01ee726b59b0969b93585719671a) Reviewed-on: https://gerrit.libreoffice.org/67132 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-30tdf#122752 kde5: Use plain qt5 fpicker for non-Plasma desktopsMichael Weghorn
Since KDE5FilePicker relies on the Plasma-specific KFileWidget to be present for inserting custom controls, this doesn't work on non-Plasma desktops, resulting in missing controls. Therefore, use a plain (non-native) Qt5FilePicker for the non-Plasma case. Change-Id: I163af89ecd7eab800d55baa2ce057802caed262c Reviewed-on: https://gerrit.libreoffice.org/67106 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit c902b3a96dcfbc52e53164f108e605547e598bc7) Reviewed-on: https://gerrit.libreoffice.org/67131 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-30vcl: fix deadlock in VclGtkClipboard::setContents()Michael Stahl
Must not call getTransferDataFlavors with m_Mutex held; 6 TransferableHelper::getTransferDataFlavors() (this=0x567b980) at svtools/source/misc/transfer.cxx:392 7 VclGtkClipboard::setContents(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardOwner> const&) (this=0x3199550, xTrans=uno::Reference to (SwTransferable *) 0x567b9a8, xClipboardOwner=uno::Reference to (SwTransferable *) 0x567b9b0) at vcl/unx/gtk3_kde5/../gtk3/gtk3gtkinst.cxx:618 8 TransferableHelper::CopyToSelection(vcl::Window*) const (this=0x567b980, pWindow=0x301b0c0) at svtools/source/misc/transfer.cxx:960 CopyToSelection() uses SolarMutexReleaser, then getTransferDataFlavors() has a SolarMutexGuard; this will deadlock against the main thread that holds SolarMutex and calls VclGtkClipboard::setContents() itself, from VclGtkClipboard::OwnerPossiblyChanged(). Change-Id: Ibda0b6bce6f3388c45cee8077dd977abb3dda366 Reviewed-on: https://gerrit.libreoffice.org/67121 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 9286cebdff378a19ec146183676c6da96aac77db) Reviewed-on: https://gerrit.libreoffice.org/67152 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-30tdf#123031 allow natural cell width if the combobox contents are >= requestCaolán McNamara
which matters in at least gtk 3.19 Change-Id: I760e46d02f2678842a685aa077bd0129520a3263 Reviewed-on: https://gerrit.libreoffice.org/67074 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-29KDE5 map QFont::stretch() == 0 to WIDTH_DONTKNOWJan-Marek Glogowski
From the Qt5 documentation: "QFont::AnyStretch / 0: Accept any stretch matched using the other QFont properties (added in Qt 5.8)". So this maps 0 to LO's WIDTH_DONTKNOW, which fixes the too narrow font selection in the KDE5 backend, when applying the KDE5 font setting to LO. Change-Id: I5f1a62d6c314c0766b540869c49c72bc3f6821c3 Reviewed-on: https://gerrit.libreoffice.org/67059 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 7cafc7962f371d8f9bcc4d1a26c507a2536df383) Reviewed-on: https://gerrit.libreoffice.org/67067 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-29tdf#123011 Detect kde5 desktop in Plasma Wayland sessionMichael Weghorn
Both env variables 'KDE_FULL_SESSION' and 'KDE_SESSION_VERSION' are set in both X11 and Wayland sessions for Plasma 5 (kde5), s.a. https://userbase.kde.org/KDE_System_Administration/Environment_Variables, so drop the alternative X-specific check. Move the check for a kde5 upward, so that kde5 is actually detected in a Plasma 5 Wayland session, rather than falling back to assuming GNOME. Change-Id: Ieb5b47272f375ceed4d44a2ccc5b517222ae86b9 Reviewed-on: https://gerrit.libreoffice.org/67044 Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 7eccf0b3fe771a519dbdaaf536d64b5b193a723f) Reviewed-on: https://gerrit.libreoffice.org/67051 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-01-29Resolves: tdf#122949 gtk_style_context_save doesn't work the way I wantCaolán McNamara
so write something that does Change-Id: I294b9288af0ddf49cbb5a8a69b4509e1ae03d9b8 Reviewed-on: https://gerrit.libreoffice.org/67019 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28tdf#121129: more custom listboxes in kde5 fpickerKatarina Behrens
the following additional fpicker templates are now fully supported: FILEOPEN_LINK_PREVIEW_IMAGE_TEMPLATE FILESAVE_AUTOEXTENSION_TEMPLATE FILEOPEN_LINK_PREVIEW_IMAGE_ANCHOR FILEOPEN_READONLY_VERSION Listboxes now also have valid mnemonic labels Change-Id: Ib7f9dd234bf2cbd0eadc1a7675ef51abcea3c532 Reviewed-on: https://gerrit.libreoffice.org/66736 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/66759 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-01-28tdf#121129: custom listboxes in kde5 fpicker, first stabKatarina Behrens
for FILESAVE_AUTOEXTENSION_TEMPLATE only so far (e.g. menu Insert > Image) Change-Id: I5674025788ce9bab4094f717e2b940e7cd6891e3 Reviewed-on: https://gerrit.libreoffice.org/66705 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 2d33c7cb4b4835de77194650124a1cf046920f66) Reviewed-on: https://gerrit.libreoffice.org/66758 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-01-28tdf#122990: return if no mpMenuBarContainerWidget in ApplyPersonaJulien Nabet
Related to patches for tdf#122241 Change-Id: I0ce46a3a362855aaa6c11f375d20c2212f1cb20b Reviewed-on: https://gerrit.libreoffice.org/66976 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-26vcl: unx: apply configuration to "Generic Printer" so it's PDF ...Michael Stahl
... by default, instead of leaving it with m_nPSLevel == 0 && m_nPDFDevice == 0. Change-Id: I44059ac39791442602cbc48582670d98edc578ee Reviewed-on: https://gerrit.libreoffice.org/66802 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c8dd1c22d7512d4922461350c6cb804cd0864e0b) Reviewed-on: https://gerrit.libreoffice.org/66850 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-25Resolves: tdf#122931 crash on closing b&n dialog after gallery menu activatedCaolán McNamara
Change-Id: I3284edc2ed64895642bd12ea479a1aba8023b2ba Reviewed-on: https://gerrit.libreoffice.org/66883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Resolves: tdf#122662 restore context after changing stateCaolán McNamara
otherwise we may change a context which get reused by gtk for rendering something we don't ourselves draw directly Change-Id: I814140cd63489f7e4fac47a7486a006a4aa1fac5 Reviewed-on: https://gerrit.libreoffice.org/66848 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Resolves: tdf#122353 silence useless selection-changed event attemptsCaolán McNamara
Change-Id: Ie84fb12e6561d93832159779d233102a34b1c78c Reviewed-on: https://gerrit.libreoffice.org/66044 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Resolves: tdf#122241 support persona header in native gtk3 menubarCaolán McNamara
Change-Id: Ia4485ec4c342c86f40e8e0bb7e5e1af1a47bb9b9 Reviewed-on: https://gerrit.libreoffice.org/66735 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Related: tdf#122786 update value when spinbutton text explicitly setCaolán McNamara
Change-Id: Idb6fefe08dc7cbf4d0b73485e0b1471fe0494364 Reviewed-on: https://gerrit.libreoffice.org/66604 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25tdf#122393 move to overflow row on using left/right at end of other rowCaolán McNamara
and on ctrl+page_up/ctrl+page_down Change-Id: I3320abfb91655b7b4278886cc6fc4dceb637e4b1 Reviewed-on: https://gerrit.libreoffice.org/66527 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25SolarMutexGuard needed hereCaolán McNamara
assert seen in dbgutil Change-Id: I09cab9e4fa4ce81d71518d87c4a571a467ead52d Reviewed-on: https://gerrit.libreoffice.org/66327 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-22Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselectCaolán McNamara
Change-Id: I941e32a973cdd1bc79e3739b24fdf834aa52cb11 Reviewed-on: https://gerrit.libreoffice.org/66688 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17Resolves: tdf#122623 theme unwanted tab into invisibilityCaolán McNamara
its nigh impossible to have a GtkNotebook without an active tab, so try and theme it into invisibility with no width Change-Id: I312b81ae51abe9fdd222fb5d5c45cb41603b80cb Reviewed-on: https://gerrit.libreoffice.org/66471 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-16Related: tdf#122627 auto detect of toggle column doesn't workCaolán McNamara
so remove it and explicitly state what column contains the toggle Change-Id: I58fb12a4b8fa9eeb9c038f796e48b0aeaa0b2404 Reviewed-on: https://gerrit.libreoffice.org/66380 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Resolves: tdf#122467 drop down field name is too narrowCaolán McNamara
ellipise only when we have to Change-Id: I79820dc84fc9ac0a755700c70bca9edbb14cf371 Reviewed-on: https://gerrit.libreoffice.org/66001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-10Resolves: crash in double-split when first timeout hadn't expired yetCaolán McNamara
Change-Id: Ieba97589a3794cf5ed95839e20cc4028cfedae3a Reviewed-on: https://gerrit.libreoffice.org/66019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-10Related: tdf#122527 gtk < 3.20 and gtk_image_new_from_surfaceCaolán McNamara
seems to be a problem Change-Id: I2aac780a44ce392372af9f688cde594d67fea3df Reviewed-on: https://gerrit.libreoffice.org/66052 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-09tdf#122527 dot symbols in chart menubutton not workingCaolán McNamara
a few problems here *) each symbol was drawn on top of the previous one instead of clearing it *) some spurious placeholder text in the menu entry *) m_nSymbolType not set correctly on activation of a submenu entry *) under gtk3 adding entries to the submenus didn't inform the menubutton of their addition *) we can drop m_xMenu because set_item_sensitive can be used instead, which didn't exist at the initial time of writing Change-Id: Id339992c4192f3782fddfd56cb3e9b67cfcbe2a2 Reviewed-on: https://gerrit.libreoffice.org/65978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-04Qt5+kde4 don't override generic VCL style settingsJan-Marek Glogowski
In commit 3911bf8364da ("tdf#98253 Qt5 rely on VCL for SetDeactiveColor") the named was dropped from the Qt5 styling. This results in SetDeactiveColor now being controlled by LO, but SetActiveColor by the Qt theming. But IMHO both need to be managed together in some way, as the deactive color is normally some variant of active with a lower opacity. Also no other backends except Windows and headless even overide the four general colors Set(De|A)ctive(Text)?Color and Windows is setting them from the window decorations (CAPTION)?! So let's get rid of all these settings for Qt5 and kde4. Change-Id: Id9497dc067e4718d25d24c5795589b6c028a8817 Reviewed-on: https://gerrit.libreoffice.org/65028 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 89c888b48eca24e25ffe8895542cf7ac9b731187) Reviewed-on: https://gerrit.libreoffice.org/65857 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-27tdf#122116 Only create CPDManager if D-Bus descriptions presentMichael Weghorn
Since the XML files are required in the 'onNameAcquired()' method, check for their existence before returning a CPDManager pointer in 'tryLoadCPD()', to avoid returning a CPDManager that is unusable (and will even lead to a crash). Change-Id: I83c493ba8bd775ea398111971cbecb9352050194 Reviewed-on: https://gerrit.libreoffice.org/65576 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 87d90b6e60659e9c976daa9692ae99ec87a6978c) Reviewed-on: https://gerrit.libreoffice.org/65634
2018-12-20Resolves: tdf#121555 sometime crash on menu hierarchy changeCaolán McNamara
seems menubar gets set to dirty due to some menu activity that needs a refresh, but then the hierarchy changes and as its already dirty the maUpdateMenuBarIdle doesn't get launched the placement of the mbMenuBar test inside the loop through parents shows some confusion as to what which mbMenuBar might be met, the one belonging to this, or that of the parent being traversed, but it does seem to be the one belonging to this. Change-Id: I0b9dceadf64f7adf18eb1aa2dbda9bbfbcb66e0a Reviewed-on: https://gerrit.libreoffice.org/65462 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-12-17drop scroll-wheel moves notebook page workaroundCaolán McNamara
now that the double-decker monstrosity is in place Change-Id: I8bc8f98d0cfd2bf4506bbc61632c1e7b0f9cd3f1 Reviewed-on: https://gerrit.libreoffice.org/65230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-15Resolves: tdf#121050 draw fixedlines like toolbar separatorsCaolán McNamara
Change-Id: Ib91b3f204d847cbe96750b4c080e958597bb3b9b Reviewed-on: https://gerrit.libreoffice.org/65110 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit baa3c7389ec3f570be0486b3647ab424c7835ee1) Reviewed-on: https://gerrit.libreoffice.org/65196
generated by cgit (git 2.34.1) at 2024-07-18 11:46:01 +0000