Age | Commit message (Collapse) | Author |
|
Change-Id: Ie93a2e47bbe92c8268ea2b463c6134685445fc2b
|
|
Change-Id: Ie9f5fbd21a6223520cbea3af6436beb407d7a88c
Reviewed-on: https://gerrit.libreoffice.org/21477
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I935f69d275d2073d8f0924392a5aa1fb2567cedf
|
|
Change-Id: I06f3e941bfb1af861298d4fbf666d270c5bac051
|
|
Change-Id: I5b27a21ff49ca84400c635b6e8539c7041b117d4
|
|
Change-Id: I623da89ea390a07bd6a3236b5c099be094a7acde
|
|
The change I made in commit 7b974e056df3 ("vcl: merge
ImplFontMetricData with ImplFontAttributes") was... ill-advised. For
starters, there really needs to be this split as FontSelectPattern
needs it, and PhysicalFontFace only requires the font attributes, not
the metric data.
So the merge was unfortunately, in my mind, a failure and I'm manually
backing it out now.
Change-Id: Iac38f0815f984541e2f55099c965376dd88eeb43
Reviewed-on: https://gerrit.libreoffice.org/21380
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I7b326d8fc8d2b6ecd9642ba958015285d0929a44
Reviewed-on: https://gerrit.libreoffice.org/21341
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I6173cd191cd771b1f030fa737617b1067278ee10
Reviewed-on: https://gerrit.libreoffice.org/21338
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
...assuming they were implicitly made private by accident rather than by design.
(And private derivation can cause unexpected failure of dynamic_cast, cf.
63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove
then-unnecessary downcasts.")
Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
|
|
These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).
Change-Id: Idba1e9bbe14d8a4bb8e5dd2c2ad1dc75458da53c
Reviewed-on: https://gerrit.libreoffice.org/21335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).
Change-Id: I6008a272c4b961a12702e2ef8727c56df9e80164
Reviewed-on: https://gerrit.libreoffice.org/21334
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
These source files as all specific to Unix environments (not, however,
OS X) and are not "generic" (i.e. used across all platforms).
Change-Id: I23650c86a7b74c2ac150b981e4be88eaea07e936
Reviewed-on: https://gerrit.libreoffice.org/21314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
All the files in glyph are only used by Unix based systems, with the
exception of OS X. Therefore, it's not really "generic" as in "used
across all platforms" but is generic as in "used in all Unix-based
systems".
Change-Id: Id89c09df74f0ddafee5c88c55bac4c35f9b23ef8
Reviewed-on: https://gerrit.libreoffice.org/21312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: If17c0c36108c2437accba105e11a93a009d2c91f
Reviewed-on: https://gerrit.libreoffice.org/21311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Id12edc0660a2c22c6d04b820ad052bde4fa75143
Reviewed-on: https://gerrit.libreoffice.org/21310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1
Reviewed-on: https://gerrit.libreoffice.org/21306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
ImplFontAttributes is no longer merely a pImpl (or "compilation
firewall", take your pick) but is a fully fledged class in its
own right that is used by a number of classes, including
FontSelectPattern, LogicalFontInstance and PhysicalFontFace. Thus
I'm "promoting" the use of this class in the codebase.
Change-Id: I26866080a64796978d1c25efbcd16e3e6f94aaa5
Reviewed-on: https://gerrit.libreoffice.org/21305
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Freetype is definitely not "generic" code. It is only used for Unix
platforms, but is not used for OS X which has it's own font/glyph/text
system called CoreText and that is implemented elsewhere in our
codebase.
Change-Id: I30b2756d2cd9a81b6f746988685295d25ba1de44
Reviewed-on: https://gerrit.libreoffice.org/21286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
I want to keep this class in line with the naming of the base class.
ImplServerFontEntry derives from LogicalFontInstance, so the name
ServerFontInstance is a better fit.
Change-Id: I2d2e3919634c2aaa8e5d6d63b0bf718dec18c336
Reviewed-on: https://gerrit.libreoffice.org/21284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
There is a TODO in the code that suggests to do this, when I looked at the
collaboration diagram on Doxygen things made a LOT more sense.
Change-Id: If335498bb70872ffa5738cc5c17660faec84c35e
Reviewed-on: https://gerrit.libreoffice.org/21257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I3355d25f04a3c57063fd3d03e72a75da32e16efc
Reviewed-on: https://gerrit.libreoffice.org/21109
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
This leak is produced when copy and paste of text/numbers
is done in Calc/Writer.
Following is the trace produced by valgrind (trimmed)
malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
g_malloc (in /usr/lib64/libglib-2.0.so.0.4600.2)
g_strdup (in /usr/lib64/libglib-2.0.so.0.4600.2)
VclGtkClipboard::makeGtkTargetEntry(...) (gtk3gtkinst.cxx:467)
VclGtkClipboard::setContents(...) (gtk3gtkinst.cxx:557)
TransferableHelper::CopyToSelection(vcl::Window*) const (transfer.cxx:1019)
ScTabView::CheckSelectionTransfer() (tabview3.cxx:319)
ScTabView::UpdateAutoFillMark() (tabview3.cxx:144)
ScTabView::SelectionChanged() (tabview3.cxx:365)
ScViewFunc::PostPasteFromClip(ScRangeList const&, ScMarkData const&) (viewfun3.cxx:1753)
ScViewFunc::PasteFromClip(...) (viewfun3.cxx:1415)
ScClipUtil::PasteFromClipboard(ScViewData*, ScTabViewShell*, bool) (cliputil.cxx:69)
ScCellShell::ExecuteEdit(SfxRequest&) (cellsh1.cxx:1285)
SfxStubScCellShellExecuteEdit(SfxShell*, SfxRequest&) (scslots.hxx:7135)
SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (shell.hxx:206)
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (dispatch.cxx:258)...
...
Change-Id: I12468e746f33a64e2b5f05e9ac1c6814c702ffd7
Reviewed-on: https://gerrit.libreoffice.org/20646
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: Ibc51fb4cc72163fb643a85ad3f0b6061b7d77ccc
|
|
Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9
Reviewed-on: https://gerrit.libreoffice.org/21069
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Ib0a3d82af858304bf63a20bcb30b8de741491935
Reviewed-on: https://gerrit.libreoffice.org/21054
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Ia2fe20559745e705667f23cdd73cbe50c6371aaa
Reviewed-on: https://gerrit.libreoffice.org/21053
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Changed private variables to use accessor functions in ImplFontMetric.
It turns out there are some variables that are redundant as they are
already in ImplFontAttributes. These are:
- meFamilyType
- mbDevice
I also needed to change ImplFontMetric::GetSlant() to GetSlantType()
as the names conflicted.
Change-Id: Ic06a374fb929e3b2ffb18a6c66577c526c3b31a7
Reviewed-on: https://gerrit.libreoffice.org/21050
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Ib2520679c3d62991f4ae6c5a325a44ab3cce1d89
|
|
Use Qt submodule notation for Qt includes and also "correct"
some KDE headers AKA use <> notation for external headers.
Change-Id: I9457f75baae56514989800b016a11348a72a242b
|
|
ImplFontAttributes handles device independent data, whilst
ImplDevFontAttributes handles device dependent data. However, there
is no real reason for the divide in classes, and in fact I'm not at
all a fan of using a pImpl directly - sort of defeats the purpose of
having one!
Change-Id: I2db22727e3479b14e3bc37dfad9136703bbdeb13
Reviewed-on: https://gerrit.libreoffice.org/21018
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I0494a1db1a1e5c164bd5da2d0a221a8db6c494d6
Reviewed-on: https://gerrit.libreoffice.org/21016
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I9ccd506b20dcfb492767bf4d0c42dff8c1c0b815
|
|
Change-Id: I97374357f27dc26fc67412f5cec7b96ad9bce9c2
|
|
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
|
|
As part of tdf#39944, the mappings of UNO and ATK roles have been
reviewed and right now there is a match in ATK for every UNO role.
Still, some protection must be done in case of running LO with an
old ATK version that does not contain all the roles we need. The
function registerRole serves this purpose now, and it has been
renamed consequently.
Finally, removed a redundant mapping of the HEADING role.
Change-Id: I7a19c3f3efa5d6ff2697c19e3ae7856d4702a253
|
|
Fix more roles according to information found in https://bugzilla.gnome.org/show_bug.cgi?id=732702
Change-Id: Ibe260784f12b1cf1f6baff490f400526d1c796d2
Reviewed-on: https://gerrit.libreoffice.org/20369
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
|
|
Change-Id: Ib86d6b63d16f24f3c5e17981562d100e247dc267
|
|
This reverts commit 4d6742f644970e24dfda7dded9cf63ebeb6c9644.
|
|
Change-Id: Ib62fd2a6f4c27c6e891f3bb74d120f415d6b54f5
|
|
and unwind some apparently now unused VCL OpenGL and GlyphCachePeer
stuff.
Change-Id: Ic85302d4e1ad4056dabc49c97a608891052e3167
Reviewed-on: https://gerrit.libreoffice.org/20920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6ff580f6ff190d8e48f107cb28bfe8f39985d709
Signed-off-by: burcinakalin <brcnakalin@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/20840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I6cc9694b14366f022f1cef440d03ac4a1be94c4a
|
|
Change-Id: Idce03318fbc01039a6c0638879785607970993c0
Reviewed-on: https://gerrit.libreoffice.org/20746
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
for getting and setting the window state, work on the toplevel m_pWindow. Leave
the "geometry" alone as its for the purpose of the current known size of the
toplevel window contents
Change-Id: Idf701aacf4aed4eefbca1bc1ebebaf38d1c82e27
Reviewed-on: https://gerrit.libreoffice.org/20397
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
because we're setting DISPLAY always, and under wayland that resolves to
"wayland", not the original ":0" so the gtk2 gvfs-open eventually called open
xdg-open cannot open the correct display
Change-Id: I246120f2430b92cd2d3e5003445aa4c9da4f6a68
|
|
We already used it without the :: prefix, in many cases in the same
files even. It is nice to have some consistency.
I was not bored enough to do it everywhere.
Change-Id: Ic8ac5bd9b4b2c02c41e5ea937a3d9477824f21cf
|
|
via gtk_window_begin_move_drag so add some BYDRAG/ByDrag hints
to select mechanism to move window by
Change-Id: Icc58653dff752a6d4ee49446647d7ede2af9dd9b
|
|
Change-Id: Ibbf45b44eba9f5f65db0e7ae26cf6946b32f879d
|