summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-23m_nExtStyle isn't used in gtk[2|3]Caolán McNamara
Change-Id: Id03d0ee0d4aa29df85c7fcbcb59e1f769b63862f
2017-02-21GtkSalPrinter_Impl must be complete for the definition of ~GtkSalPrinterStephan Bergmann
Change-Id: Ieafd639e6665025e17f6a2eb3bd5a05167de07ea
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:subtlezeroinit: vclStephan Bergmann
Change-Id: I041390c7cea1e246f07e799ee2430c16e86723d8
2017-02-20tdf#105256 gtk findfocus return only if focusedJustin Luth
A patch related to tdf#96685 (commit 598e6a024163f1510d076000788b7745625f5ed5) caused the initial regression that Japanese-mozc would freeze(tdf#100903). That patch only modified what happened when the text was marked as focused. However, the regression fix for Japanese bug 100903 (commit 1c81af2c1814e8bd12701f85e09cebf5fe206647) was not placed inside of the "if focused" code, and so it applies to more situations than were broken by the first regression, thus causing new bug 105256. So, applying fix 100903 ONLY when focused solves both problems. Change-Id: I1d8381f2d8cf793d481287ae975ce8a485b6c573 Reviewed-on: https://gerrit.libreoffice.org/34453 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-20remove unused enumerators from PrinterCapTypeNoel Grandin
Change-Id: Id4f788dfae64e7a9bcde16af2db2ddeafaf6900e Reviewed-on: https://gerrit.libreoffice.org/34468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20remove unused ModalDialogue from WMWindowType enumNoel Grandin
Change-Id: I22269d6d1868b744f48274ff53ca46fa93ce9fc1 Reviewed-on: https://gerrit.libreoffice.org/34455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14Convert WindowType to scoped enumNoel Grandin
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12Get rid of "unicodes" in lower-case, tooTor Lillqvist
Instead, use "code points" (if you mean full 21-bit Unicode code points), or "code units" (if you mean the 16-bit units that make up UTF-16). Hopefully I got it right which one was meant in each case here. Change-Id: I8ee7a98996f1cebcfb95cd7d18a56570e48fa390
2017-02-10convert Orientation to scoped enumNoel Grandin
and drop unused enumerators Change-Id: I2f42f0f441cf9ce96338d40382acb6d75ea1e1a0 Reviewed-on: https://gerrit.libreoffice.org/34061 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09convert PDFVersion to scoped enumNoel Grandin
Change-Id: I9920f4c9783eb23a41d135e5eacd12805c1b9c2b Reviewed-on: https://gerrit.libreoffice.org/34060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09remove ConnectionIdentifierType enumNoel Grandin
since we only use the AsciiCString enumerator. Consequently simplify the GetConnectionIdentifier method Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1 Reviewed-on: https://gerrit.libreoffice.org/34026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09convert BmpConversion to scoped enumNoel Grandin
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators Also fix a bug in x11::convertBitmapDepth where we were incorrectly passing BmpConversion enumeratirs to ReduceColors Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242 Reviewed-on: https://gerrit.libreoffice.org/34062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09convert FontType to scoped enumNoel Grandin
Change-Id: Ieb8f90be8effde5f25bc872784c3ea2177b14bf9 Reviewed-on: https://gerrit.libreoffice.org/34056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08This is only used within vclKhaled Hosny
Change-Id: I64d7e39506495e9fcc78bb670b897338a01a9ae1
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08convert WMWindowType to scoped enumNoel Grandin
and drop read-only ModalDialog enumerator Change-Id: Ie295e4863381401c73bd2a4151b94ad529c261fd Reviewed-on: https://gerrit.libreoffice.org/34023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08drop unused enum TTCreationFlagsNoel Grandin
there is only one method using it, and all of the call sites pass 0 Change-Id: I5d71b36cf890fbcf0be9d795756da0cfd61ae309 Reviewed-on: https://gerrit.libreoffice.org/34024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08Missing includeStephan Bergmann
Change-Id: I312677b88982ef1ff430d8cd440f3bd7c52d51fb
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I0c2cc9df85932e25dbfed88727d3b83d299671c7
2017-02-07revert unready stuffCaolán McNamara
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I5f11f9b3196c3d42c82ac03bc332ef84189f3737
2017-02-07tdf#104101 Improve the session management handlingJuergen Funk
- Set the current time to the SessionID - Split the SetProperties-Data, and send DeleteProperties for DiscardCommand (above both topic is the same as kate and plasma-desktop to do) - in statusChange the saveDone was not called, and call only once the saveDone - in shutdownCanceled must be send the saveDone too Change-Id: I42855c75b88b5d651ef8091947e359dc2c3f9209 Reviewed-on: https://gerrit.libreoffice.org/33215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06tdf#43157 Clean up OSL_ASSERT, DBG_ASSERT, etc.dilekuzulmez
Change-Id: I37b62b7cc4b26789e961148c0411615ef1c2ffa1 Reviewed-on: https://gerrit.libreoffice.org/33884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-05sal_uIntPtr to sal_uInt16Matteo Casalin
Change-Id: If463ae457f53a0a8b12cc0748afbc654f54ae3c3
2017-02-03TyposJulien Nabet
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01fix crash with gtk3, opengl and presentation consoleCaolán McNamara
PresenterSlideShowView::PaintInnerWindow has a mbIsForcedPaintPending flag which is used to throw away the console canvas, but for other backends the paint occurs at a much different time after a clear has a chance to get triggered, while for gtk3 it happens as its being setup. hack around this presenter console weirdness by skipping the initial paint for this salsysobj case Change-Id: If1b23600ef07241e52d92bd5eb38b9e90d9ed192
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30Resolves: rhbz#1417480 stray bare XWarpPointer call in gtk3 codeCaolán McNamara
which blows up under wayland naturally can get here from tools->options->mouse positioning->"dialog center" table->insert table Change-Id: Id81b06a63cc3a2a1073d236e2f36dc65e533e598
2017-01-28loplugin:stringconstantJochen Nitschke
Change-Id: I4e2e0aba2930d7c4ee60567d1d65e0e773a470bf Reviewed-on: https://gerrit.libreoffice.org/33650 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27-Werror=int-in-bool-context (GCC 7)Stephan Bergmann
Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647
2017-01-27Remove dynamic exception specifications from some TDE-only codeStephan Bergmann
Change-Id: I55cfacfd66ed31c8ec209d8deed7746ce917f8ba
2017-01-27loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e
2017-01-27loplugin: unnecessary destructor vbahelper..vclNoel Grandin
Change-Id: I6b7800d4a456391251168f7923a1ec7a5ca9efc9 Reviewed-on: https://gerrit.libreoffice.org/33577 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Resolves: tdf#104598 make bright theme shadow the same as it always wasCaolán McNamara
The shadow color was originally set via StyleSettings::Set3DColors taking the background color as the input, and doing DecreaseLuminance(64) on it to make the shadow color So, continue to follow that mode if the "dark shadow" is darker than the foreground, and IncreaseLuminance the equal amount the other direction for dark themes. This way under a dark theme the problem of impossible to see rulers of tdf#90214 is still fixed, while the bright theme colors are the same as they always were, which avoid the wearing-on-the-nerves "regression" problem. Change-Id: I33133ff180ecadce3a14ee45bd33db73c56c0225
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-19New loplugin:dynexcspec: Add @throws documentation, vclStephan Bergmann
Change-Id: Icc398ec6cbb9152ee86b4ac0003619ae04206cd6
2017-01-19silence warning spew, these aren't seriousCaolán McNamara
Change-Id: I8c027a5ec0ed61722eb299d247d79032fd1dcd84
2017-01-19Expand and improve the output log in Session-ManagementJuergen Funk
in dependency of tdf#104101 Change-Id: I799f81adf4e4751fb505c84aa075363acf70f5a7 Reviewed-on: https://gerrit.libreoffice.org/33034 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-17GTK3 getTransferDataFlavorsAsVector: Filter out non-MIME-typesStephan Bergmann
...that would cause needless (though caught, so not causing real harm) exceptions downstream, as in > #0 0x00007ffff6a2d4dd in __cxxabiv1::__cxa_throw(void*, std::type_info*, void (*)(void*)) (obj=0x7c60480, tinfo=0x7ffff7b0c940 <typeinfo for com::sun::star::lang::IllegalArgumentException>, dest=0x7fff81733b80 <com::sun::star::lang::IllegalArgumentException::~IllegalArgumentException()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63 > #1 0x00007fff817318c5 in CMimeContentType::acceptSym(rtl::OUString const&) (this=0x7fff4617b608, pSymTlb="/") at dtrans/source/cnttype/mcnttype.cxx:113 > #2 0x00007fff817317de in CMimeContentType::type() (this=0x7fff4617b608) at dtrans/source/cnttype/mcnttype.cxx:148 > #3 0x00007fff81730bf6 in CMimeContentType::init(rtl::OUString const&) (this=0x7fff4617b608, aCntType="INTEGER") at dtrans/source/cnttype/mcnttype.cxx:95 > #4 0x00007fff81730a5d in CMimeContentType::CMimeContentType(rtl::OUString const&) (this=0x7fff4617b608, aCntType="INTEGER") at dtrans/source/cnttype/mcnttype.cxx:35 > #5 0x00007fff8172daee in CMimeContentTypeFactory::createMimeContentType(rtl::OUString const&) (this=0x7fff46165e48, aContentType="INTEGER") at dtrans/source/cnttype/mcnttfactory.cxx:50 > #6 0x00007fff8172dbe3 in non-virtual thunk to CMimeContentTypeFactory::createMimeContentType(rtl::OUString const&) () at instdir/program/../program/libmcnttype.so > #7 0x00007fffeecc97e1 in TransferableDataHelper::FillDataFlavorExVector(com::sun::star::uno::Sequence<com::sun::star::datatransfer::DataFlavor> const&, std::__debug::vector<DataFlavorEx, std::allocator<DataFlavorEx> >&) (rDataFlavorSeq=uno::Sequence of length 23 = {...}, rDataFlavorExVector=std::__debug::vector of length 1, capacity 1 = {...}) at svtools/source/misc/transfer.cxx:1221 > #8 0x00007fffeecc894e in TransferableDataHelper::InitFormats() (this=0x7fffffffa698) at svtools/source/misc/transfer.cxx:1308 > #9 0x00007fffeecc8722 in TransferableDataHelper::TransferableDataHelper(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&) (this=0x7fffffffa698, rxTransferable=uno::Reference to (GtkClipboardTransferable *) 0x7fff46181718) at svtools/source/misc/transfer.cxx:1128 > #10 0x00007fffeecd00bd in TransferableDataHelper::CreateFromSystemClipboard(vcl::Window*) (pWindow=0x1675000) at svtools/source/misc/transfer.cxx:2118 > #11 0x00007fff9f267777 in SwBaseShell::StateClpbrd(SfxItemSet&) (this=0x37df2d0, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at sw/source/uibase/shells/basesh.cxx:462 > #12 0x00007fff9f2673c8 in SfxStubSwBaseShellStateClpbrd(SfxShell*, SfxItemSet&) (pShell=0x37df2d0, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at workdir/SdiTarget/sw/sdi/swslots.hxx:2104 > #13 0x00007ffff1b9c632 in SfxShell::CallState(void (*)(SfxShell*, SfxItemSet&), SfxItemSet&) (this=0x37df2d0, pFunc=0x7fff9f2673a0 <SfxStubSwBaseShellStateClpbrd(SfxShell*, SfxItemSet&)>, rSet=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}) at include/sfx2/shell.hxx:216 > #14 0x00007ffff1bb41c8 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*) (this=0x257eea0, rSvr=..., rState=SfxItemSet of pool 0x23bed90 with parent 0x0 and Which ranges: [(5311, 5312), (5712, 5712)] = {...}, pRealSlot=0x7fff9ffad240 <aSwBaseShellSlots_Impl>) at sfx2/source/control/dispatch.cxx:1894 > #15 0x00007ffff1b91d58 in SfxBindings::Update_Impl(SfxStateCache*) (this=0x257ee30, pCache=0x37e0570) at sfx2/source/control/bindings.cxx:327 > #16 0x00007ffff1b9421c in SfxBindings::NextJob_Impl(Timer*) (this=0x257ee30, pTimer=0x1a1e398) at sfx2/source/control/bindings.cxx:1498 > #17 0x00007ffff1b983ed in SfxBindings::NextJob(Timer*) (this=0x257ee30, pTimer=0x1a1e398) at sfx2/source/control/bindings.cxx:1441 > #18 0x00007ffff1b90478 in SfxBindings::LinkStubNextJob(void*, Timer*) (instance=0x257ee30, data=0x1a1e398) at sfx2/source/control/bindings.cxx:1439 > #19 0x00007fffec93f228 in Link<Timer*, void>::Call(Timer*) const (this=0x1a1e3b8, data=0x1a1e398) at include/tools/link.hxx:84 > #20 0x00007fffec93f007 in Timer::Invoke() (this=0x1a1e398) at vcl/source/app/timer.cxx:88 ... Change-Id: I5bac21f400cea04957554483aab2d44cca5b4bfc
2017-01-17I very much doubt we need this single special LinuxPPC ifdefCaolán McNamara
Change-Id: I1661981fabcefde9ef7819fa554a31c68972e619
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17KDE4 Qt always processes all pending eventsJan-Marek Glogowski
Change-Id: I6a6e37c36a64640b641b116867da5c63c9d36bca
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c