Age | Commit message (Collapse) | Author |
|
This addresses some cppcheck warnings.
Change-Id: Ia3910e7f1b33d16866b7e606fd648f152f9fe67a
Reviewed-on: https://gerrit.libreoffice.org/13971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
glibc declares write() with the warn_unused_result attribute, so we need
to check the return value to avoid a compiler warning.
(This warning only seems to occur when gcc optimizations are enabled)
Change-Id: I31962aae63d0a12eecfe44bb7920a68b29c05d8a
Reviewed-on: https://gerrit.libreoffice.org/13927
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia53dc393e4284989f6e967c4fa42e7ba6fc58183
|
|
$(call gb_Library__get_name,foo) returns "libmerged" if library foo is merged.
This reverts commit ee567a63fad9e755b11ca28696da35f00ed3b0fc.
Change-Id: I6ab9b7f0b01262a6f9d5a6834a6cffdd6ffc6f8a
|
|
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
Change-Id: I60c989a86ad94d35c7bfa650a0bd993a23b26c0d
|
|
and a handful of other currently uncompiled spots,
after my commit 7f8f277b94704a289fbbd1b836e4e5d66311580d
"fdo#84938: convert STREAM_ #defines to 'enum class'"
Change-Id: I550f6fb850e1d71a6f08767eeb222a18071b89d5
|
|
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
|
|
Change-Id: I155e45f58974a2b946c4a7703b350bcbfbad342e
|
|
and replace SalIndicatorState, it serves the same purpose
Change-Id: I618b8946b8e2527883eecb13060b2256abc505b6
|
|
Change-Id: I6ace72606ba666322c045d28bea713443c0fc45f
|
|
Change-Id: Iaed915b3765a3d23aea7f771a7c912956d864c5b
|
|
Change-Id: If6ab3a27a958e83419f576f720ab891a9c36c684
|
|
Change-Id: I0d21d9685cdc801f7d6975a752999788c1f132e4
|
|
Change-Id: I1451180d258315a310a048b27510b4b58fa9145c
|
|
A few states have been added in the IA2 integration. These need to be
handled somehow on linux as well. At the moment they all get the state
INVALID. Let's add the state DEFAULT that already have a equivalent.
The state MOVEABLE is causing the issues in paragraphs of LibreOffice
Writer. The state is not invalid so let's avoid reporting it at all.
There must be a cleaner way of doing this however.
Change-Id: I859439f92fe19f5050195383f43fa4af787b249e
Reviewed-on: https://gerrit.libreoffice.org/13727
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
|
|
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
|
|
Change-Id: I169624820cd7d25eab18a6b90482e075ebfebcc6
|
|
Conflicts:
vcl/source/opengl/OpenGLContext.cxx
Change-Id: Ie2b93de8efe5ea56b0420adf23639c0153103385
|
|
Conflicts:
vcl/unx/generic/gdi/openglx11cairotextrender.cxx
Change-Id: I469b34c9f1047a274550229391d3dfb578291df6
|
|
Change-Id: Id446d20599f072f657c6106d6c6457fce08830e6
|
|
Change-Id: Iec9f8c7d8f7cded0aef9e017373e44387dc0b05c
|
|
Change-Id: I30bf474fc44b122c8b7218e187c822a8784783fd
|
|
Change-Id: I3ae51b8c57e70593153805e5c7c139573c543b5a
|
|
It is already checked on all call chains:
* CreateSalInstance (vcl/unx/generic/plugadapt/salplug.cxx) checks
IsHeadlessModeRequested before calling autodetect_plugin ->
get_desktop_environment -> get_desktop_environment
* Application::GetDesktopEnvironment (vcl/source/app/svapp.cxx) checks
IsHeadlessModeEnabled before potentially calling SalGetDesktopEnvironment
(vcl/unx/generic/plugadapt/salplug.cxx) -> get_desktop_environment
-> get_desktop_environment
* The two calls to SalGetDesktopEnvironment in vcl/unx/gtk/ are clearly only done
for GTK plugins, not headless
Change-Id: I44b43cecd63effc5b2e3ad2a449943fee183462a
|
|
That is the version available in RHEL 5. The configure change for
telepathy has been changed for consistency only.
Change-Id: I664901dd2bbcc75f6f6fb84940f3fa85d69f57dd
Reviewed-on: https://gerrit.libreoffice.org/13369
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I81a2af7aa5a52a0b19d05a64eacf89ed957a9ce8
|
|
Change-Id: Ic0884c2e6a051a7767ac965a7daadfe64537b13d
|
|
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
|
|
Change-Id: I533f1177ff7de2409cdca90f35788d057a5fc3e5
|
|
Change-Id: If2758fa42b484a5afbe0d358a3d4533c68189697
|
|
Change-Id: I8cf382e7f5f5ed9c797be9ec2b42f0d7f9f0b0ce
|
|
...as it needs SalDisplay to be a complete type, but unx/saldisp.hxx depends on
X11 headers and can thus e.g. not be included in generic/gendata.hxx on Android.
Change-Id: Iec5f51408eef0d6eb7e2d04105a7408372b06079
|
|
Change-Id: Ia25b857738bb7b6c3baf18c68ef0d1bc0b3e142e
|
|
Change-Id: I7ad80af29d094348f07c9a6b69e160ae5b0b8916
|
|
Change-Id: I2f8b11a3f7cb8872a1d8f6eeeae8ce3f30223496
|
|
Change-Id: I5790deb9ab5af6f8678c964af5321264d3bce733
|
|
Conflicts:
vcl/inc/openglgdiimpl.hxx
Change-Id: I1d764a8dba1850d2475f08e1014a085846f336c3
|
|
Implemented by both SalFrame and SalVirtualDevice, to help us to
un-tangle code that needs to operate on resources associated with
both of these without special cases.
Change-Id: If681a002647e20c57186577fe039d4ac85bba872
|
|
It is presumed that #i59315# is fixed already, and that this is no
longer necessary.
Change-Id: Ifb2f6550fac2481c4fec269b38d6e806753cb53e
|
|
Conflicts:
include/vcl/opengl/OpenGLContext.hxx
vcl/inc/openglgdiimpl.hxx
vcl/opengl/gdiimpl.cxx
vcl/opengl/x11/gdiimpl.cxx
vcl/source/opengl/OpenGLContext.cxx
Change-Id: I17f6ce66fb8b5bc027d35b4016ae56c24ee0a738
|
|
Change-Id: I162199233c9d3feb03e7ab33b777174b2a03035a
Reviewed-on: https://gerrit.libreoffice.org/13104
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...via SelectionManager::run's aKeep acquring and releasing getReference()
Change-Id: I18696d30c41ca9ae101261668cbf54cb0a6c45fc
|
|
Change-Id: Id0a8bac3c14e668f066ddcafc84d3397c0d9b74f
|
|
Change-Id: I936d31300126e2ce000ea3a7cd70c8a2dec19502
Reviewed-on: https://gerrit.libreoffice.org/13043
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Ief0e947149c133aaa8e81973e088c4df6432bfdc
|
|
Change-Id: Ie6078308f7a7f70683a7f963b15857b5dac753b0
|
|
Change-Id: Ic4c073360070a559855732d2de41ae9085d7d51b
|
|
Change-Id: Iba64eb42965c86ca5655b9a105ef3f397e033ecf
|