summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2018-10-12tdf#120420 fix for overwide Ubuntu 16.04 GtkSpinButtonsCaolán McNamara
Change-Id: I581a7f4e8e10b8002fee5ddf9b24fdb867b2235e Reviewed-on: https://gerrit.libreoffice.org/61694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12XInitThreads only when running under XCaolán McNamara
Change-Id: I5068b5229e88da3b1f00b03a2f1c1aea67526de9 Reviewed-on: https://gerrit.libreoffice.org/61703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12set m_nSizeAllocateSignalId to 0 when not installedCaolán McNamara
Change-Id: I1023f5b51fefd86d7faa749c9488a7fcaeeaf3ff Reviewed-on: https://gerrit.libreoffice.org/61695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11don't show_all null popoverCaolán McNamara
Change-Id: Id918a413febc39a8f147bd1b65b7204433d91ae1 Reviewed-on: https://gerrit.libreoffice.org/61663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Related: tdf#120371 relax tabs on leftCaolán McNamara
Allow on-top if tabs would fit, even when > 6. Some themes have much smaller tabs where more can fit comfortably. Change-Id: Ia9de9059bd5af4de0e6d6a8b8817f87226e2066a Reviewed-on: https://gerrit.libreoffice.org/61661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Add support for LXQt as a Linux desktop environment.Simon Quigley
This change makes LXQt use the Breeze icon theme, and adds it as a desktop environment along the other supported DEs. Change-Id: I482d85620986c8fc4e33b4722b887b81c77c23bf Reviewed-on: https://gerrit.libreoffice.org/61641 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-10Resolves: tdf#120407 support popover getting replacedCaolán McNamara
Change-Id: I56f51a5effccd8854361790c68fa11a2cc067aa9 Reviewed-on: https://gerrit.libreoffice.org/61623 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10optimize adding a block of entries at one timeCaolán McNamara
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530 Reviewed-on: https://gerrit.libreoffice.org/61618 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10tdf#120420 only show as much column widgets as don't distort the page widthCaolán McNamara
Change-Id: Ibde6f2bcb4fed1261ebd7efa45904600855a20ef Reviewed-on: https://gerrit.libreoffice.org/61596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09bruteforce typeahead into combobox menusCaolán McNamara
Change-Id: I2cf75773f380c3a53d3e091e7e72beb62a4ff119 Reviewed-on: https://gerrit.libreoffice.org/61593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120371 follow GNOME HIG on tab placement on mega tab notebooksCaolán McNamara
tradionally we do double/triple decker tab dialogs when there are a lot of tabs, that option isn't available with native gtk3 notebooks. Instead follow https://developer.gnome.org/hig-book/unstable/controls-notebooks.html.en#controls-too-many-tabs and when there are > 6 tabs position them at-left Change-Id: I8e6ca78abeec3c1fa9f616c21f21fd7367be2ec9 Reviewed-on: https://gerrit.libreoffice.org/61487 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09support typeahead for entryless unpopped up comboboxCaolán McNamara
Change-Id: I14ecd4d4a967a7c49aef77a423ea17b3fc46fe76 Reviewed-on: https://gerrit.libreoffice.org/61583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09bodge not needed when it has an entryCaolán McNamara
Change-Id: I790703790e49bd9e5b4ad0d5f357681f56db5121 Reviewed-on: https://gerrit.libreoffice.org/61582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120377 weld cluster of animation pages and dialogCaolán McNamara
Change-Id: Ia5a9880c1e6d88141bd654a9cc761b289f27c249 Reviewed-on: https://gerrit.libreoffice.org/61542 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-08Run GarbageCollect() for freetype fontsJan-Marek Glogowski
Restores wrong hunk removed in commit dd36db168c65 ("UNX use font cache based glyph rect cache"), so we actually run the font based garbage collect. Just the glyph based one is gone. Change-Id: I30b4f9987d21764398ac00cf24968aa65aff8fc0 Reviewed-on: https://gerrit.libreoffice.org/61536 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-08loplugin:external (--enable-gtk3-kde5)Stephan Bergmann
Change-Id: Id096bd25cd6df5941eaec45f7573f5887ae51d79
2018-10-08tdf#120261 gtk3_kde5: Leave event handling on gtk3 side to gtkMichael Weghorn
This introduces a new thread that takes care of handling the IPC command and result for executing the file picker ('Commands::Execute'), which is the only command in the file picker that may block for a longer time until it receives its result from the kde5 side (namely, when the dialog has been closed). While the file dialog is being executed, activate a dummy GTK dialog that also takes care of handling events in its main loop as long as the file dialog is shown. The dummy dialog is closed together with the KDE file dialog. (Since the actual KDE file dialog is run as a separate process, this one is mostly "transparent" to the soffice process from the point of view of a dialog.) This allows dropping the custom event processing previously done in 'Gtk3KDE5FilePickerIpc::readResponse()' that had the potential to cause all kinds of problems, e.g. when another event related to the file picker was triggered from a Java process via UNO. Change-Id: I3d663253f09320f7a8e0d9ec32a8fd6ec191c189 Reviewed-on: https://gerrit.libreoffice.org/61253 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-10-08tdf#120261 gtk3_kde5: Read IPC cmds in own thread on kde5 sideMichael Weghorn
Move reading IPC commands and arguments to those commands to a separate thread and use the signal/slot mechanism to notify 'FilePickerIpc' whenever a new command and its arguments have been read. This allows to handle the events of other commands that have been received while the dialog is being executed. This will be needed by a subsequent change that will modify how IPC is handled on the gtk3 side. Change-Id: Ia77b21045b0196710cbe164fb640b36a128d5081 Reviewed-on: https://gerrit.libreoffice.org/61252 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-10-06Support estimateUsageInBytes for SystemDependentDataArmin Le Grand
Change-Id: I6074035ed8f90e452915e9ecffdbe9363375e126 Reviewed-on: https://gerrit.libreoffice.org/61306 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-06UNX use font cache based glyph rect cacheJan-Marek Glogowski
Drop the special / duplicate glyph rect bound cache implementation for Freetype fonts. The GlyphCache class now looks a lot like the ImplFontCache class. The lru handling for Freetype fonts is based on the byte / memory size, including the glyth bound-rect caching. Using the new common cache is effectivly removing the bound-rects from this accounting, so the garbage collection won't free them anymore. Change-Id: Ie53226596ee2287e1059a74885f52c3d64bbccaa Reviewed-on: https://gerrit.libreoffice.org/61377 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06Add GlyphCache instance to GenericUnixSalDataJan-Marek Glogowski
This gets rid of some statics and drops some duplicate code: - the X11 based GlyphCache => gone - the svp version of the GlyphCache => gone - the "normal" GlyphCache - the PrintFontManager And while at it move the implementation into its own file gendata.cxx. Change-Id: I9063139c9482f5f37285505f389cf5f32c02426b Reviewed-on: https://gerrit.libreoffice.org/61454 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06UNX merge FreetypeManager into GlyphCacheJan-Marek Glogowski
Change-Id: I736cc60af6d0c91623a25843bd9ff8fcdd9e8e90 Reviewed-on: https://gerrit.libreoffice.org/61453 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-05weld ExportDialogCaolán McNamara
Change-Id: I9d0f21a10708edcc7f5da14f83944da58c33b1d9 Reviewed-on: https://gerrit.libreoffice.org/61408 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05bodge up a workaround for GtkComboBox menus not appearing under waylandCaolán McNamara
when the menu is too tall to fit and the active entry is sufficiently far down the menu that the problem gets triggered. i.e. https://gitlab.gnome.org/GNOME/gtk/issues/94 as a workaround set wrap to 1, which is good enough to make GtkComboBox take an alternative path to the one which sets the problematic rect-anchor-dy value and the menu will at least appear Change-Id: Ia05887e0db727b7e1045179e36d348d22228a0ce Reviewed-on: https://gerrit.libreoffice.org/61416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05Alpha channel in BitmapColor - change bIndex to alphaTomaž Vajngerl
We want to store the alpha channel in BitmapColor. To achieve this we can repurpose bIndex attribute for alpha. Generally we don't need bIndex at all as we can infer if we use index colors or not from the context (using palette or not) Change-Id: I18fe748beeca59e2869368a1c3c2ee9d2062b41e Reviewed-on: https://gerrit.libreoffice.org/61057 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-04weld SwFindEntryDialogCaolán McNamara
Change-Id: Ia45e4ce13b92fd73fcc8ad52233aa5eccc3cfb6d Reviewed-on: https://gerrit.libreoffice.org/61365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04color moved to slot 4Caolán McNamara
Change-Id: I965d4b042cf1510d5286c85043792a140116497f Reviewed-on: https://gerrit.libreoffice.org/61331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#120277 special character dialog not appearing in OnlineCaolán McNamara
the magic smoke connecting the dialog to the viewshell was in SfxModalDialog, so not inheriting from that drops the connection add a SfxDialogController to enable setting up the connection Change-Id: I29c45cd43e05295309fc647b039db0c6565ca0d1 Reviewed-on: https://gerrit.libreoffice.org/61304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03when gtk3 >= 3.22.0 set natural size propagateCaolán McNamara
so 1-10 in format numbering etc isn't slightly clipped with a scrollbar on top of it Change-Id: I55909993d4b4c846ca0aeff2f2cd458dfa59d860 Reviewed-on: https://gerrit.libreoffice.org/61262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld SwSvxNumBulletTabDialogCaolán McNamara
Change-Id: I8ea74dc15bba04c0615e61c069407160a7b95c4c Reviewed-on: https://gerrit.libreoffice.org/61242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02filename may be nullCaolán McNamara
Change-Id: I373886d3613607b8ee8e96d8c0314865f3991a92 Reviewed-on: https://gerrit.libreoffice.org/61241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Unify sal plugin loadersJan-Marek Glogowski
Change-Id: Ic099761eaff80349e985ccf62e3f4aa6b2e98022 Reviewed-on: https://gerrit.libreoffice.org/61103 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01weld SvxLineTabPageCaolán McNamara
Change-Id: I91d7ec8a51ce935db40c57feeeed7b160cf4dad8 Reviewed-on: https://gerrit.libreoffice.org/61172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30add GetFileImageId and check if there is no parentCaolán McNamara
Change-Id: I80fdcb800642dbb850072a259d0f742e8c6cbb20 Reviewed-on: https://gerrit.libreoffice.org/61071 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29band-aid: deprecated-declarations related to gtkJulien Nabet
Don't hesitate to revert this one but only if there's a patch to fix it. Change-Id: Ib15352e1a94d0542120f6710acfe19887494ed51 Reviewed-on: https://gerrit.libreoffice.org/61142 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-28listen to [leave|enter]-notify-event at event widget levelCaolán McNamara
rather than toplevel. This avoid the problem under wayland where with an initially maximized calc clicking in it will select all cells from 0,0 to the clicked cell until the mouse is released Change-Id: I138fe587c9cb7cfff0293847c00730593e3244e1 Reviewed-on: https://gerrit.libreoffice.org/61087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28loplugin:unusedfieldsNoel Grandin
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27dispose custom widget a11y on teardownCaolán McNamara
Change-Id: Iea80ffff0b36e093e4b8e513e924a21da67cb2ce Reviewed-on: https://gerrit.libreoffice.org/61009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21Support buffering SystemDependent GraphicDataArmin Le Grand
Started to make the buffering more flexible by adding virtual methods virtual sal_uInt32 getHoldCyclesInSeconds() const; virtual sal_Int64 estimateUsageInBytes() const; to class SystemDependentData. This will allow to add more sensitive buffering/caching. Also fine-tuned Linux-derived classes actively used for buffering to be more sensitive when and where to reuse the buffered data Change-Id: Ifc69c318ade0209aff071d76001869d9f4eeb10d Reviewed-on: https://gerrit.libreoffice.org/60881 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-20Support buffering SystemDependent GraphicData (III)Armin Le Grand
This change is for speedup of fat line drawing when using X11. This is a long-term problem which never really progressed, but is avoided using Cairo in the future. Still - if used, speedup using current state and buffering possibilities. Two speedup steps will be used: (1) The tesselation is no longer done using trapezoids. That works (but was done wrong leaving artifacts) but is not fast and done every time. It is even not done with FatLines and more than 1000 points. New version will use triangulation. Dspite using the existing triangulator (that works but is slow) extend the FatLine geometry creator to directly create triangles. This is also necessary since for buffering that data a transformation-invariant version is needed (in device coordinates the data changes all the time when scrolling). Trapezoids are by definition *not* transformation-invariant (e.g. rotation) (2) Buffer that triangulation - with the needed care and watch. It is e.g. necessary to react on 'hairlines' since these change their logical LineWidth view-dependent (zoom). In those cases, the buffered data *has* to be removed due to the base for buffering is the created FatLine geometry based on one stable logical LineWidth Also took the time to adapt B2DPolygonTriangulator to use an own data type (B2DTriangle) and a vector of these for better understandability and security. Adapted all usages as needed. Change-Id: Iedb2932b094a8786fd9c32d0d0ab1ca603a1a7b2 Reviewed-on: https://gerrit.libreoffice.org/60818 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-20weld SwWrapTabPageCaolán McNamara
Change-Id: I76e4a8e557ae6c92ad16dc9b6cf88a6c6ca59e4e Reviewed-on: https://gerrit.libreoffice.org/60812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld SvxHyphenWordDialogCaolán McNamara
Change-Id: If92d57c5c807a7fc04fe66a748aa385c558be664 Reviewed-on: https://gerrit.libreoffice.org/60774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20weld BreakPointDialogCaolán McNamara
Change-Id: Icecef8b0b939c5d87bdf1bb781731df8fc4419b5 Reviewed-on: https://gerrit.libreoffice.org/60756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19weld TPGalleryThemeGeneralCaolán McNamara
Change-Id: Id5ec1b1282c039f30c40fc781be0f6d72a8bfb47 Reviewed-on: https://gerrit.libreoffice.org/60718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-19loplugin:useuniqueptr in GetTTSimpleGlyphMetricsNoel Grandin
and only return the advance, we don't use the other field Change-Id: I956033dac97763caea2b27404fe9f099da809899 Reviewed-on: https://gerrit.libreoffice.org/60703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>