summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2018-03-02weld split cells dialogCaolán McNamara
Change-Id: I726c6d84807ab3efba509058eed554fe4c0ffced Reviewed-on: https://gerrit.libreoffice.org/50636 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02drop old tools/gen methods in vclNoel Grandin
Change-Id: I863ce5ae46ae90f06780261fa17b087a7153c807 Reviewed-on: https://gerrit.libreoffice.org/50445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01hook up extended tips to find them in our helpCaolán McNamara
Change-Id: I1360403b3b21eec3fd37bb5ba74e0fab1945af94 Reviewed-on: https://gerrit.libreoffice.org/50590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01debuging versions crash a lotCaolán McNamara
regression from... commit c3074cb5784329eaf558c2f58d96a64085b42d48 Date: Sun Jan 7 00:39:33 2018 +1100 vcl: remove dead code Change-Id: I1a81ae3fe8063377deaf41a9159d763ca9b4f9c4
2018-03-01weld ScStringInputDlg to native dialogCaolán McNamara
ScStringInputDlg and SwStringInputDlg do the same thing, but one uses the old name as the label and leaves the new name blank in the entry. The other puts the old name into the entry and autoselects it and uses a normal label. Both are used from the rename button of the shared autoformat dialog. Change-Id: I2ebf09a79f92c3f9020304e23e8907b67c06cd35 Reviewed-on: https://gerrit.libreoffice.org/50525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01vcl: remove dead codeChris Sherlock
I have converted the debug code that causes a force redraw/widget_queue_draw/dumpframes to be activated when using the environment variable VCL_GTK3_PAINTDEBUG=1 Change-Id: Ia2d41dbd42b5b45f97b195efa15c91674f5956bf Reviewed-on: https://gerrit.libreoffice.org/47493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-28use ok, cancel under kde vs cancel, ok under gnomeCaolán McNamara
for the native welded dialogs Change-Id: I34663616826c1eb084262ea1c830f8580785d50c Reviewed-on: https://gerrit.libreoffice.org/50458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26vcl: fix hangs in SvpSalInstanceMichael Stahl
Since commit cb8bfa9a32799bcde4e960fa56e388d5f7b2a928 the main thread will read from the timer pipe until it is empty. But evidently this introduces the problem that the poll() in another thread will not return, as the file descriptor will no longer be readable; see https://paste.debian.net/1011306/ for a reproducer of that rather under-documented poll behaviour. So other threads can get stuck forever in poll, and then the main thread can block in poll too with no other thread to wake it up. This is the problem that plagues UITest_writerperfect_epubexport. The timer pipe is difficult to fix, since the main thread can block on either the poll or the subsequent AcquireYieldMutex(). So replace the timer pipe with a condition etc. that is mostly copied from the OSX AquaSalInstance/SalYieldMutex implementation. The main thread now does something different than the other threads, and blocks on a condition_variable with a timeout, while other threads still block on acquiring the mutex. Non-main threads can poke the main thread to do a DoYield() on their behalf, and then get the result back with a blocking read from a pipe, all while holding the YieldMutex. This requires some fudging of the YieldMutex so that the main thread can borrow the ownership temporarily. Unfortunately SvpSalInstance, in addition to being directly instantiable for --headless, has a whole bunch of subclasses: * HeadlessSalInstance * AndroidSalInstance * IosSalInstance * GtkInstance (in the gtk3 case) * KDE5SalInstance Of these GtkInstance overrides everything related to the DoYield/SalYieldMutex implementation, but the others will be affected by the change. This commit will probably break IOS due to me not understanding the point of the undocumented random #ifdef IOS in svpinst.cxx. Change-Id: I1bbb143952dda89579e97ac32cd147e5b987573c Reviewed-on: https://gerrit.libreoffice.org/50237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26vcl: consolidate ColorOf() and GrayOf() functionsChris Sherlock
Change-Id: Ic80dda409ceaff89be5f249cf906abbb40679f3c Reviewed-on: https://gerrit.libreoffice.org/50272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22weld native message dialogsCaolán McNamara
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22loplugin:changetoolsgen in vclNoel Grandin
Change-Id: I0fc68cf51fb23ed9bb86a5087e8247c81b024494 Reviewed-on: https://gerrit.libreoffice.org/50107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19weld: hook up help responseCaolán McNamara
and keep the current legacy ownership behaviour when welding the legacy backend Change-Id: I7e1f90f2d235abf0e10062b4be11ba5150bbdbfb Reviewed-on: https://gerrit.libreoffice.org/49918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16gtk3_kde5: Checkboxes on the left, texts on the rightKatarina Behrens
QFormLayout does it the other way round (text left, checkbox right) and it looks odd, so use QGridLayout Change-Id: Iff4255f695ce17561bac44e496a3567e1b438581 Reviewed-on: https://gerrit.libreoffice.org/49815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-16native dialog initial basisCaolán McNamara
Change-Id: I392be563e38257390f748c70bb71c67a66778ddd Reviewed-on: https://gerrit.libreoffice.org/49677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15gtk3_kde5: advertise vcl plugin correctly in about dialogThorsten Behrens
Change-Id: Icfe977f7f9750003d992d795cad8cd86d7055e59 Reviewed-on: https://gerrit.libreoffice.org/49813 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-12Fix typosAndrea Gelmini
Change-Id: Ia01f85e87706b02ffb816b3385765e2729dafa02 Reviewed-on: https://gerrit.libreoffice.org/49585 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-09Fix conditionSamuel Mehrbrodt
OSL_DEBUG_LEVEL is always set as it seems Change-Id: Ie555f705fd13de778463c8073e86d30b3ce09073 Reviewed-on: https://gerrit.libreoffice.org/49476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-09Sync the fix with Muffin upstream changesMaxim Monastirsky
See: https://github.com/linuxmint/muffin/commit/f3fce7898ba8aa82c4c82a50af2bb44c0ff79ddf Change-Id: Ic569bb7139fcb12e9549fa136c269f1a7ed10cb3 Reviewed-on: https://gerrit.libreoffice.org/49453 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-02-08Disable NET_WM_PING for all debug buildsSamuel Mehrbrodt
To allow debugging under Gnome 3 Change-Id: I75e3a3fe797c4973072b46f9ee58270fd0e366c5 Reviewed-on: https://gerrit.libreoffice.org/49417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-08tdf#86739 Option to set image anchor type in image insert dialogSamuel Mehrbrodt
This adds the selectbox to (hopefully) all filepickers: - LO native - GTK/GTK3 - KDE4 - KDE5 - Windows - macOS Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce Reviewed-on: https://gerrit.libreoffice.org/49311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-05vcl: remove BitmapColor Color() operatorChris Sherlock
BitmapColor has a Color() operator. However, this is confusing and tends to hide that the two classes aren't the same. I have converted this to GetColor(). Change-Id: I0be2dcb3fc420e7be9c8d04330e7a3fe69a5412a Reviewed-on: https://gerrit.libreoffice.org/48245 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-02loplugin:useuniqueptr in X11SalFrameNoel Grandin
Change-Id: If8693b106f8755e506375f1a65754c972971700f Reviewed-on: https://gerrit.libreoffice.org/49129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02Replace some front/pop_front by for-range loops+clearJulien Nabet
Change-Id: I8a9239667b0d80ee2fa6ebbc8a19ba4c0076c2fb Reviewed-on: https://gerrit.libreoffice.org/49107 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-02loplugin:useuniqueptr in GtkSalFrameNoel Grandin
Change-Id: Ia98080d5c214824624ca4cbe875038374919f662 Reviewed-on: https://gerrit.libreoffice.org/49132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02loplugin:useuniqueptr in SalGtkFilePickerNoel Grandin
Change-Id: I3cbe4121c1cb323ad00e110bcdb1f61334e656bc Reviewed-on: https://gerrit.libreoffice.org/49131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02loplugin:useuniqueptr in NWPixmapCacheNoel Grandin
Change-Id: Ibf9f5c3ec3ea502bb93942516936ff844235b4d3 Reviewed-on: https://gerrit.libreoffice.org/49130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Convert 2 lists in vectors in X11_selection (vcl)Julien Nabet
by replacing front/pop_front calls with use for-range loops with a call clear() afterwards Change-Id: I5eadebadca688dc2bb9818b67ca8b5f4ddb06acc Reviewed-on: https://gerrit.libreoffice.org/49089 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-31Modernize a bit vcl (part5)Julien Nabet
by using for range loops Change-Id: I52d6e6c9e1c2c321dc81d8258943a1a9a611441c Reviewed-on: https://gerrit.libreoffice.org/48987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30Fix compilation with GCC 4.8Milian Wolff
Workaround a bug in variadic template parameter pack expansion in lambdas that affects GCC 4.8. The workaround expands the pack outside the lambda into a custom functor that then calls readIpcArgs. Change-Id: I7a2d8572a6f2b330bb22a4f18f5cc13fd7ef9b45 Reviewed-on: https://gerrit.libreoffice.org/48895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-27Fix typosAndrea Gelmini
Change-Id: I914ac70f39028caebafb874e871f11017fda7795 Reviewed-on: https://gerrit.libreoffice.org/48682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-26Remove redundant(?) initialization of frame geometryStephan Bergmann
The memset of maGeometry was added with 79e2c2577527578629d7bb719a88396645a4cc49 "INTEGRATION: CWS vclplug" in 2003, before f7be39169fef0823e04f556cc9c9fdcda34d8685 "INTEGRATION: CWS presenterview" in 2008 introduced a user-provided _SalFrameGeometry default ctor, which sets all members except nWidth and nHeight to 0, and sets nWidth and nHeight to 1. So the memset effectively set nWidth and nHeight to back 0 (whether or not that was by design or by accident after the latter commit), but that seems to be unnecessary after all, seeing that a SAL_USE_VCLPLUGIN=gen soffice appears to stll work well after removing the memset. Change-Id: Ic6d1c6476a1234e84dca1e560149cd1e9af37b73 Reviewed-on: https://gerrit.libreoffice.org/48696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-26Fix typosAndrea Gelmini
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad Reviewed-on: https://gerrit.libreoffice.org/48546 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25lo_kde5filepicker: cleanup main and add version and help optionsMilian Wolff
This way users can figure out what this tool is about. Most notably, you can run it now with `-h, --help` as one would expect. Change-Id: If8dd3142bdcc96d2962a2647b2187d75666b9394 Reviewed-on: https://gerrit.libreoffice.org/48592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Properly restore size of KDE5 file picker dialogMilian Wolff
The event filter we installed prevented the show event from reaching the KDEPlatformFileDialogHelper::show method. This prevented the dialog from being restored to the size chosen by the user previously. Change-Id: I7af457f19f59d27bd104f8f70d9f4767da6641ee Reviewed-on: https://gerrit.libreoffice.org/48591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Properly quit the lo_kde5filepicker on Quit commandMilian Wolff
Quitting the event loop is not enough, we also have to get out of the readCommands loop. Return false for this scenario. Also exit the command when an unhandled command comes in, we cannot really recover the stream from this anyways. Change-Id: I7d58724ea0364565e476516d5645cb436ce1d461 Reviewed-on: https://gerrit.libreoffice.org/48590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25gtk3_kde5: port away from boost::processMilian Wolff
While this uglifies the code, it removes a dependency on newer boost 1.64+ which ships boost::process. This helps on systems where LO is linked against system boost and an older version of boost is used. Additionally, and this is the main motivation, this makes it easier to backport these changes to 5.2, where the bundled boost is also only at 1.60. To keep the required changes at a minimum, the osl_* API for reading from/writing to the stdout/stdin of the helper process, we buffer the responses on a line-by-line basis. Note that one cannot simply reuse osl_readLine on the non-seekable oslFileHandle. Instead, we have to roll our own simplistic readLine implementation... Change-Id: I1197e38cb2416e926d8ba985accd6c10d78bcc52 Reviewed-on: https://gerrit.libreoffice.org/48490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Fix typosAndrea Gelmini
Change-Id: If75cf86a65c6f03c6c467efb677e2f7e3e5da576 Reviewed-on: https://gerrit.libreoffice.org/48547 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-24Use a more conventional way of zero-initializing class membersStephan Bergmann
...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non- trivial type ‘class SalVisual’") Change-Id: Id9c5a6fa7e084b5abd549c99d07f05f183d56a52 Reviewed-on: https://gerrit.libreoffice.org/48402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24fix kde4 vclplug buildNoel Grandin
by reverting parts of commit de8f6b25de6fbe813fe172542e7eff1596b37335 loplugin:unused-returns in vcl and reverting commit 78bb1a2a51a991f605ae5c51d813697673bbc67 Fix --enable-kde4 codeHEAD <noelgrandin> sberg, is that safe ^^ ? I was just about to push a partial revert of the commit that caused the breakage <sberg> noelgrandin, oops, I'd naively assumed that all impls of Dispatch had just always returned true Change-Id: Icbca450a76de30a04bc90a2887066840191c9d5f
2018-01-24Fix --enable-kde4 codeStephan Bergmann
...after de8f6b25de6fbe813fe172542e7eff1596b37335 "loplugin:unused-returns in vcl" Change-Id: I82414b20b7dbb9e7ba361c0f4d9451c74ea4d4f2
2018-01-24loplugin:unused-returns in vclNoel Grandin
Change-Id: I507320900a47f604d17ed7d402d531a7cbdf744e Reviewed-on: https://gerrit.libreoffice.org/48331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23Fix typosAndrea Gelmini
Change-Id: I05a1234d7bcbae6f4851abd34ff7acec5853f5f5 Reviewed-on: https://gerrit.libreoffice.org/48329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-23Removed duplicated includeAndrea Gelmini
Change-Id: I20d4304013e12035e522fd1b1e0c201d49961114 Reviewed-on: https://gerrit.libreoffice.org/48434 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-03-06 23:11:24 +0000