summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2014-02-21Adapt vcl to various loplugin warnings on Mac OS XStephan Bergmann
Change-Id: I4553ce218fbcf2ac681b284c71e7d558a451511c
2014-02-21other vclplugs need adaptingCaolán McNamara
Change-Id: I83c54b27dc58dfeac72462d8c5eb92a08b5e8e2e
2014-02-21Bug #63962 Dynamically scan the config directory for icon themesTobias Lippert
The hard-coded icon themes have been replaced by a dynamic list which is filled by scanning the config directory Conflicts: include/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/window/window.cxx Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed Reviewed-on: https://gerrit.libreoffice.org/7935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-18fdo#41524: CUPS printing: use "collate" option when PDF is availableMichael Stahl
Assume that the CUPS printer is able to handle collating by itself, don't send multiple print jobs (except if user clicks on "Create single print jobs for collated output" of course...). To enable collating with PDF based printers, add the "collate" option; legacy PS based printers still get the weird stuff read from the PPD (not sure what the risks of changing that are). Change-Id: Ia12dc69f9083bba94f2ed633ecbd153aac7e40ab
2014-02-18vcl: convert some printfs to SAL_INFOMichael Stahl
Change-Id: I0c0ec5242160333a47a4a459c7be5c0a25079f44
2014-02-18coverity#738944 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic4cc2e8e8b1ff21bc4e1d74cf2fddc0c0d85eafd
2014-02-14fdo#74931 Prevent UpdateSettings from dereferencing null pointerChris Sherlock
When calling on GtkSalFrame::GetGraphics(), if all graphics are in use then it will return NULL. We don't currently check for this, but we still try to use the graphics object even if none are available. I have added a warning when this occurs and just return immediately, as there's nothing more we can do. Change-Id: I24dfbb6f37f41527078a60a7577cb3b20de3fcca Reviewed-on: https://gerrit.libreoffice.org/8031 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-12callcatcher: update unused codeCaolán McNamara
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-10coverity#1027661 Explicit null dereferencedCaolán McNamara
Change-Id: I196bc592e3803a49096a640f2b8da2e1077dcc28
2014-02-07coverity#705773 Resource leakCaolán McNamara
Change-Id: I630fc03502b7bc510313656ae11ae1159f2319ae
2014-02-07Related: fdo#35105 initially map HEADING to ATK_ROLE_HEADINGRadu Ioan
gets overwritten anyway, but its less confusing this way Change-Id: Ib7da2b7787afa7804496337358f0ef6fc7d42b3e Reviewed-on: https://gerrit.libreoffice.org/7834 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-06fdo#72187 Implement KDE4 picker notificationsJan-Marek Glogowski
This notifies the XFilePickerListener of filter changes and file selection changes. Change-Id: I749c5f7420f020a3a2fbb764acb5c45d40972cf1
2014-02-06Simplify control item switch statementsJan-Marek Glogowski
Just check the dynamic_cast result to verify check boxes. Change-Id: I5f370e337e12719eb7ef0dd3512a0f46c76a981e
2014-02-06Related: rhbz#1061864 filtername is somehow NULLCaolán McNamara
Change-Id: I11930d8401ada43c7fce570131baf2e8a7067ecb
2014-02-06coverity#736301 the 2nd arg is a gpointerCaolán McNamara
Change-Id: I66e57d570c5ae70e69eea2d44812a72a3b67509e
2014-02-06fdo#39944: improve mapping between ATK and UNO rolesJacobo Aragunde Pérez
* UNO role GROUP_BOX was not mapped to any ATK role, now it's mapped to ATK_ROLE_GROUPING. * UNO role COMMENT was mapped to ATK_ROLE_SCROLL_PANE, we replaced it with ATK_ROLE_COMMENT. We use registerRole method to map these instead of doing a direct association to prevent a failure in case the installed version of ATK doesn't contain these roles. Change-Id: I7e266a7e92d59b282c51934df05b53414588cc7e
2014-02-05fdo#35105: notify role change through a new UNO a11y eventJacobo Aragunde Pérez
A new UNO accessibility event called ROLE_CHANGED has been created. It should be triggered when an accessible object changes its role and every accessibility toolkit should use its own methods to make that change effective. Code to support the event in ATK has been added. Change-Id: I132e303bdb148967231334458c3cfa369c36ec8f Reviewed-on: https://gerrit.libreoffice.org/7853 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-05fdo#39944: fallback for DOCUMENT_* roles in ATK < 2.1.0Jacobo Aragunde Pérez
Set fallback to DOCUMENT_FRAME role. Change-Id: Ib83cd2f9881bcdec7b69a7660cf4166a612aaf60
2014-02-04have a stab at fixing RHEL-5 build that hasn't got new atk rolesCaolán McNamara
Change-Id: Idbfc9bae9593416564783974ef7237e20e6400b0
2014-02-04fdo#39944: Add DOCUMENT_* accessibility UNO rolesJacobo Aragunde Pérez
Added a set of UNO accessibility roles for specific kinds of documents: * DOCUMENT_PRESENTATION for Impress * DOCUMENT_SPREADSHEET for Calc * DOCUMENT_TEXT for Writer The other applications still use the existing DOCUMENT role. These roles translates directly to ATK but in the other toolkits we keep using the same association that DOCUMENT role had. Change-Id: Ibac47527e5effdecb28d2314cde8558cf4fb010a Reviewed-on: https://gerrit.libreoffice.org/7847 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-02-04fdo#44270: vcl: GTK+ file picker: fix non-grouped filter patternsMichael Stahl
lcl_CreateAutoMarkFileDlg calls appendFilter() with "... (*.sdi)" and the GTK+ file picker then strips off the (*.sdi) in the string given to GTK+ and then doesn't compare result properly with its stored filters; only filters added with appendFilterGroup() work but not appendFilter() ones. Change-Id: I0ac9272b5606ff8b81f0c14160fc6972789bb1ea
2014-02-03bool improvementsStephan Bergmann
Change-Id: I2f81497a830c8e1802ffbeeb362cea16e8b731d7
2014-01-30Assert in X11SalSystem::GetDisplayScreenPosSizePixelChris Sherlock
If we detect that the display is using Xinerama, then we shouldn't be able to pick a screen more than the number of screens available! Therefore, assert if we meet this condition. Also remove a comment decoration. Change-Id: Ic8d2e0acf3e65825b76472adbd4a355e5435b6df Reviewed-on: https://gerrit.libreoffice.org/7694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-28coverity#440974 Dereference before null checkCaolán McNamara
Change-Id: I680a2f9f53aaf9e45a0059173744afa9b6ef1d5a
2014-01-25coverity#440824 : Dereference after NULL checkNorbert Thiebaud
Change-Id: Ie5c5c687c4a6dbe07abdf2f8ad0dfedb39c7abf0
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21bool improvementsStephan Bergmann
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-17bool improvementsStephan Bergmann
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
2014-01-13Work around G_DEFINE_TYPE -Werror,-Wunused-functionStephan Bergmann
At least G_DEFINE_TYPE from glib2-devel-2.38.2-2.fc20.x86_64 /usr/include/glib-2.0/gobject/gtype.h defines unsed *_get_instance_private functions. Change-Id: I47211b6451d9699c7b8741555f3ad11a09e411bf
2014-01-13-Wunused-variableStephan Bergmann
Change-Id: I1913eaf265a4cbe8a8658c9b465a6f0e6b53f7e5
2014-01-13SalDisplay::Dispatch shall apparently return boolStephan Bergmann
Change-Id: I46ab0ef04b598a4154659f9a1e1cbb2164023b63
2014-01-12mnDeltaStart is unusedCaolán McNamara
Change-Id: I4f970a150b8ecf6e5631c89ae78ae97134c78d7c
2014-01-10endSpool return value is effectively success flag, not job IDStephan Bergmann
Change-Id: I5b96eeff80ca29f0f8f24ee6da7a2ca76cbb05ce
2014-01-08Resolves: rhbz#1050162 don't draw to NULL windowCaolán McNamara
Change-Id: Ia84e3ae05f2d3eacfb48136ce920173b46783bc7
2014-01-07fdo#72521 fdo#73103 Fix editable combo-boxes behavior under KDE4Maxim Monastirsky
Change-Id: I92a781a1e0f0adcb779155f8c477595e0dd762b1 Reviewed-on: https://gerrit.libreoffice.org/7287 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2014-01-06Resolves: #i123840# add and use the sal_GlyphId typeHerbert Dürr
Using the central definition adds consistency and cleans up many ad hoc declarations. The type sal_GlyphId will become a class in the future so that its bitfield operations etc. can then be isolated into nice methods. (cherry picked from commit c0a84ad10964fb7a65b6239cbe1cef8698b5d17b) Conflicts: vcl/aqua/source/gdi/salatslayout.cxx vcl/aqua/source/gdi/salgdi.cxx vcl/generic/glyphs/gcach_ftyp.cxx vcl/generic/print/genpspgraphics.cxx vcl/generic/print/glyphset.cxx vcl/generic/print/glyphset.hxx vcl/headless/svptext.cxx vcl/inc/generic/genpspgraphics.h vcl/inc/generic/glyphcache.hxx vcl/inc/os2/salgdi.h vcl/inc/quartz/salgdi.h vcl/inc/salgdi.hxx vcl/inc/sallayout.hxx vcl/inc/unx/salgdi.h vcl/inc/vcl/fontmanager.hxx vcl/inc/win/salgdi.h vcl/os2/source/gdi/os2layout.cxx vcl/os2/source/gdi/salgdi3.cxx vcl/source/gdi/pdfwriter_impl.cxx vcl/source/gdi/sallayout.cxx vcl/source/glyphs/gcach_ftyp.hxx vcl/source/glyphs/gcach_layout.cxx vcl/source/glyphs/glyphcache.cxx vcl/source/glyphs/graphite_layout.cxx vcl/unx/generic/fontmanager/fontmanager.cxx vcl/unx/generic/gdi/gcach_xpeer.cxx vcl/unx/generic/gdi/gcach_xpeer.hxx vcl/unx/generic/gdi/salgdi3.cxx vcl/unx/generic/gdi/xrender_peer.hxx vcl/unx/headless/svpgdi.hxx vcl/unx/headless/svppspgraphics.cxx vcl/unx/headless/svppspgraphics.hxx vcl/win/source/gdi/salgdi3.cxx vcl/win/source/gdi/winlayout.cxx Change-Id: Ic629131950360e2df4c15db30d6a5362193c6330
2013-12-31Resolves: #i123840# normalize SalGraphics point count argument types...Herbert Dürr
to sal_uInt32 The old mixture of sal_uInt32, ULONG, sal_uLong, sal_uIntPtr gets consolidated. 4e9 points are more than enough for a SalGraphics. (cherry picked from commit 03f5dce97331acc1a5e832f956d711a5dc0aac0e) Conflicts: vcl/aqua/source/gdi/salgdi.cxx vcl/generic/print/genpspgraphics.cxx vcl/inc/os2/salgdi.h vcl/inc/quartz/salgdi.h vcl/inc/salgdi.hxx vcl/os2/source/gdi/salgdi.cxx vcl/os2/source/gdi/salgdi2.cxx vcl/source/gdi/salgdilayout.cxx vcl/unx/generic/gdi/salgdi.cxx vcl/unx/headless/svpgdi.hxx vcl/unx/headless/svppspgraphics.cxx vcl/unx/headless/svppspgraphics.hxx Change-Id: Iddf806256c7e5403158635e3f5f0049e9382500f
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-13Targetted text updates, with seasonable changes before l10n freeze.Michael Meeks
Change-Id: If37ef9f68711da3a0aa9a3ba59b111a8a23421df
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-11fontmanager.hxx is private to vclTor Lillqvist
Change-Id: Iec1d1539db0b44d2ddc420cf500585098d4793fc
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-06fdo#60705 Don't discard valid printing options.Andrzej Hunt
PPDValue::m_aValue is simply an optional parameter description, whereas m_aOption is the actual option being passed to cups. For example, for the key "PageSize" (which was previously passed without problem), a typical PPDValue could be: m_aOption = "A4" m_aValue = "<</PageSize[595.3 841.9]/ImagingBBox null>>setpagedevice" However for the key "InputSlot" (which was previously not passed to the printer), a typical PPDValue could be: m_aOption = "RearPaperFeedSlot" m_aValue = "" Change-Id: I7959317c9f9d67bfafd911e710927a70edfa8792
2013-12-04fdo#67011: Run Display::Yield through KDEXLib::Yield.Jan-Marek Glogowski
Drag'n'Drop is handled in a second thread, which tries to "yield the display" while the main Qt thread probably is already yielding. Both need the YieldMutex, which freezes the application until the D'n'D thread times out. Trying to yield the display throught the application yield results in a recursive loop. So this catches and breaks the recursion, but just inside the Qt thread, so other processes can "yield on the display", instead of simply disabling the Display::Yield. Change-Id: Ifba91aa89fe5b0a89cc94820935dc996a065112f Reviewed-on: https://gerrit.libreoffice.org/6750 Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2013-12-04No more uses of printer built in fontsKhaled Hosny
Less parsing of AFM files at startup. Change-Id: I62d4c81d6e892f2356df22b53bb35c0f9f7bc344 Reviewed-on: https://gerrit.libreoffice.org/6860 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>