summaryrefslogtreecommitdiff
path: root/vcl/unx
AgeCommit message (Collapse)Author
2017-10-22tdf#113353 gtk2: No decoration for floating toolbarsMaxim Monastirsky
Some window managers need this explicit setting. Change-Id: I007f066e29002d8988132f72ef55fbe3b679fa8c Reviewed-on: https://gerrit.libreoffice.org/43697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-22Prevent gnome-shell f/ showing 'unresponsive app' during debugAndreas Brandner
LibreOffice advertises NET_WM_PING atom, so mutter rightfully warns of an unresponsive application during debugging. Hack that out unconditionally for dbg_util builds, as per https://bugzilla.redhat.com/show_bug.cgi?id=981149 upstream refuses to make this configurable in any way. Change-Id: I12edbb49a067ad20903ca9b62557ee02c90c8a6e Reviewed-on: https://gerrit.libreoffice.org/43618 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-22Fix 3bf3cae9b7b4d38e0427d71a2b34629fd5988af7Julien Nabet
wrong use of emplace_back, it should be push_back here Change-Id: I729820336f4aedbebb94ce8311c8fb62aba74e92 Reviewed-on: https://gerrit.libreoffice.org/43688 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-22Replace some lists by vectors (vcl)Julien Nabet
Change-Id: Id6f61cbbcd91e1a81e5ac23cdf19a6cda07f8659 Reviewed-on: https://gerrit.libreoffice.org/43675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22Fix wrong use of emplace/emplace_backJulien Nabet
after these patches: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ea6858c1e388c2d17a0825f3d21353ded67083eb https://cgit.freedesktop.org/libreoffice/core/commit/?id=118a0a3734a3f794c67a9d7d4376d8ed78a96fee https://cgit.freedesktop.org/libreoffice/core/commit/?id=c16804de78b1cf1ad906eaacbcc7c51d35218d8a Change-Id: I287d64d3aef6cf18fbf20602680ae9ead0ab26e5 Reviewed-on: https://gerrit.libreoffice.org/43687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21Replace lists by vectors in printerjob (vcl)Julien Nabet
Change-Id: I6eb9b94839307e6297b5c3e3308d95d3645a215f Reviewed-on: https://gerrit.libreoffice.org/43665 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-21Replace lists by vectors in ppdparser (vcl)Julien Nabet
+ simplify some parts Change-Id: I78c611f234e06e542be56016231f6c16d44e4385 Reviewed-on: https://gerrit.libreoffice.org/43640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21Replace list by vector for maPS3Font (vcl)Julien Nabet
Change-Id: Ida0d1a87e32024430fd314c601b9acb9358a9dd2 Reviewed-on: https://gerrit.libreoffice.org/43641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-21Replace lists by vectors in gtkgdi (vcl)Julien Nabet
Change-Id: I328fd67c24607173ead855179c44f7f08baf9e0b Reviewed-on: https://gerrit.libreoffice.org/43620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-20Resolves: tdf#113252 missing tabs in basic library organizerCaolán McNamara
Like SfxTabDialog, as in interim measure throw away the TabPage if its not suitable for reuse Change-Id: If8247ea37dfca42e690716a8b687677e0f73c9a8
2017-10-20ofz+ubsan: left shift of negative valueCaolán McNamara
Change-Id: I304532162fc75b69807d5e45227368ab25736b93 Reviewed-on: https://gerrit.libreoffice.org/43586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20Replace list by unordered_set for m_aAlternateFiles (vcl)Julien Nabet
Change-Id: I66ea61972fed87245b33dfe355eff58d23041120 Reviewed-on: https://gerrit.libreoffice.org/43520 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-19tdf#106163 tdf#112830 Mirror mouse enter/leave for gtk2Maxim Monastirsky
Change-Id: I02bc5be82bc2bf51ff3e93939273d2c60c1c4d46 Reviewed-on: https://gerrit.libreoffice.org/43570 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18use std::unique_ptr in PPDCacheNoel Grandin
Change-Id: Ib47ffaa0fe754d8aafdf338d8ec8c2109beb21a5 Reviewed-on: https://gerrit.libreoffice.org/43484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17tdf#112845 rtl dropdowns in wrong positionCaolán McNamara
for rtl we mirror the position of popdowns, so we need to know their initial desired position before they have actually appeared yet and have a valid maGeometry.nX, so fill in the hoped-for position as the current position Change-Id: Ic22dc3e5d9922f5d48bbbdaad53caabff57188d8 Reviewed-on: https://gerrit.libreoffice.org/43459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17gtk3: drop faking initial nTopDecoration size from parentCaolán McNamara
in rtl we change the x pos. To change the x pos we need a y pos to go with it, and taking the y pos before we get the true (0) top decoration size of menu and menu-like widgets means rtl popdowns like the color and highlight popdowns are vertically misplaced there's no reason that a window would share the same decoration value as its parent Change-Id: I8cd1e96bb8ef7b0b728ff1baac5ee069325f9753 Reviewed-on: https://gerrit.libreoffice.org/43458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-11Replace list by vector fontconfig/manager (vcl)Julien Nabet
+ refactor a bit "analyzeFontFile" to return a vector of std::unique_ptr<PrintFont> instead of just a bool Change-Id: I9c8c307c5c323e40667359f5094672c1cde589fd Reviewed-on: https://gerrit.libreoffice.org/43317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-06KDE update system loop integrationJan-Marek Glogowski
This updates the system loop integration to be on par with the other backends. This includes: 1. Process LO user events before other LO events 2. Correctly handle elapsed QTimer events 3. Don't wait-yield in the main thread from a non-main thread Change-Id: Ia17be032ae39dc4c7bfa44cadd22d85a1b9c4fbd Reviewed-on: https://gerrit.libreoffice.org/43198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06gtk3+hidpi: ScreenSize is in real pixels, scale it downCaolán McNamara
Change-Id: I867425bfd20ec67f76e570a6e71e11c437af427c Reviewed-on: https://gerrit.libreoffice.org/43174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05tdf#112890 some dialog don't appear under gtk2Caolán McNamara
Change-Id: I90a59bfdaec0e78d93888e5cc30d1c7fa147a7e7 Reviewed-on: https://gerrit.libreoffice.org/43162 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05Minimize GtkSalData scope in timeout callbackJan-Marek Glogowski
After commit 2e8a95d1f87a3dbdcc8846fa44d1899abc8edd9c this doesn't anymore generate false positives in the constparams clang plugin: vcl/unx/gtk/gtkdata.cxx:817:39: error: ... ... this parameter can be const [loplugin:constparams] static gboolean call_userEventFn( void *data ) ^~~~~~~~~~ 1 error generated. /vcl/unx/gtk3/gtk3gtkdata.cxx:782:39: error: ... ... this parameter can be const [loplugin:constparams] static gboolean call_userEventFn( void *data ) ^~~~~~~~~~ 1 error generated. Change-Id: Id8d42a0c14bfcc887ec1ecbf70f4c41c26e26efb Reviewed-on: https://gerrit.libreoffice.org/42912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-05loplugin:finalclasses in vclNoel Grandin
Change-Id: I7de9cd6c5569217aa8d379c6d112cd1874bca8e2 Reviewed-on: https://gerrit.libreoffice.org/43151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-28Unify SalUserEvent handlingJan-Marek Glogowski
Merges the various SalUserEvent structs and their handling into a single class. This includes a common SalFrame* hash map, as all backends use such a map to verify alive SalFrames. It also reverts the "FIXME: lousy workaround" for i#90083, which was part of commit d6f7c94e5c27ba02ff5c3229760c9808cc9b5bea. At least on my current OSX box application based window switching "just works" "out of the box", even without the code. Change-Id: I188b567e44fd79c162b2d9cabbd771d1f66c7dc4 Reviewed-on: https://gerrit.libreoffice.org/42845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26WIN run main thread redirects ignoring SolarMutexJan-Marek Glogowski
This way we can drop all the special nReleased handling. Instead we use the same mechanism as on Mac, where we keep the lock, but disable it for the main thread. As a security measure we assert on duplicate redirects, which should not happen. As a result we can't use SendMessage on the main thread itself, which would normally just call the WinProc directly. This could be accomplished by converting the redirect bool into a counter, which should be safe, as no other thread could acquire the SolarMutex, as we don't release it. Change-Id: Icd87b3da37a2489f3cad2bc80215bf93fc41d388 Reviewed-on: https://gerrit.libreoffice.org/42583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-25vcl: [loplugin:badstatics] aDocumentFocusListenerMichael Stahl
Move it into class GtkSalData; have to use 2 variables because the class is only defined in atkutil.cxx but the ~GtkSalData is in gtkdata.cxx. Change-Id: I3b12f02a1a5454f39206cbd0fe224d3f08a44c73 Reviewed-on: https://gerrit.libreoffice.org/42673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-25Fix typosAndrea Gelmini
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Install fc_local.conf only where usedStephan Bergmann
...and at least issue a SAL_INFO when it's missing (there may theoretically be multiple directories, and it need not be present in every one, so nothing stronger than SAL_INFO can be used) Change-Id: I9b7257a551626e5ad081cfb75422a8bd71b86aa4 Reviewed-on: https://gerrit.libreoffice.org/42714 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24fix some newer leaksCaolán McNamara
Change-Id: I3a13406db4e441c3a29056f80cb728da2ecc3c25 Reviewed-on: https://gerrit.libreoffice.org/42720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-24fix some leaksCaolán McNamara
Change-Id: I06a3971d1d269b49b2a7954f977469fbc3d16f35 Reviewed-on: https://gerrit.libreoffice.org/42719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23normalize -> styleCaolán McNamara
Change-Id: I10895e686c7f583dd3d4a002b878f4499d15efa3 Reviewed-on: https://gerrit.libreoffice.org/42697 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-23cid#1418339: resource leakJulien Nabet
Change-Id: I87374e32e787f58aa5e4d1b6a78fcd1dddcccdf6 Reviewed-on: https://gerrit.libreoffice.org/42680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-22vcl: [loplugin:badstatics] pManagerMichael Stahl
Move this to class GenericUnixSalData, which is deleted on shutdown. Change-Id: I6366c12f255bfeca737b22259c3f58ffa2c6222c Reviewed-on: https://gerrit.libreoffice.org/42632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22vcl: [loplugin:badstatics] PPDParserMichael Stahl
class PPDContext actually looks harmless but it has an out-of-line destructor so the plugin can't see that it's harmless, so use default destructor instead. Change-Id: I921a4cdaeb5c8fe286615162b9e9c2a8db47b300 Reviewed-on: https://gerrit.libreoffice.org/42633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-19rename GetGenericData to GetGenericUnixSalDataNoel Grandin
Change-Id: Id95334da347c8341d9d190307603218eedb9c1e6 Reviewed-on: https://gerrit.libreoffice.org/42457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19rename SalGenericData to GenericUnixSalDataNoel Grandin
since it's generic over the various unixen, not anything else Change-Id: I994d5c9be99134b804e96bc045bf054fd9b434ef Reviewed-on: https://gerrit.libreoffice.org/42455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19rename GtkData to GtkSalDataNoel Grandin
to match all of the other SalData derivates Change-Id: I1d40ea5934edbeab747c10570657ac7d23230840 Reviewed-on: https://gerrit.libreoffice.org/42454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-19Unify SolarMutex implementationsJan-Marek Glogowski
All backends implement the SolarMutex in mostly the same way. So this consolidates this code into a GenericSolarMutex. We still need the abstract SolarMutex class for the fake AKA fascade implementation in dbaccess. The patch also replaces various places of direct mutex usage with either SolarMutexGuard or SolarMutexReleaser objects. Change-Id: Ia0146dd6c51a3b9a513cc6af34a66def58aad831 Reviewed-on: https://gerrit.libreoffice.org/42325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-18ofz#3419 Null-dereference READCaolán McNamara
Change-Id: I32c5d5039034ac76262223e42a1f27d6f1b84cb5
2017-09-18Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAryStephan Bergmann
Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334 Reviewed-on: https://gerrit.libreoffice.org/42406 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-14clang-tidy modernize-use-emplace in vclNoel Grandin
Change-Id: Ie0a6d105b0167431275e628935df4f4c1a36d070 Reviewed-on: https://gerrit.libreoffice.org/42259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Enable -Wunreachable-codeStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-12no CPDParser under AndroidCaolán McNamara
Change-Id: I3cf6df721f89493a527a0b65b24354d3e6135c68
2017-09-12loplugin:unnecessaryparenStephan Bergmann
Change-Id: I6fe1690b6f66e31753da993a256b7586478ef4f1
2017-09-12CUPS_VERSION_MAJOR is not definedCaolán McNamara
on arm Change-Id: Ibeca07800d02f5f69046c7bdee57143c78c03aad
2017-09-12Resolves: tdf#106163 MouseMove/MouseLeave from crossing not mirrored in rtlCaolán McNamara
but we do mirror the event for normal mousemove, this looks like the real bug here Change-Id: I178d53f5f40dbd075984019e25e6d7665b6cdf87
generated by cgit (git 2.34.1) at 2025-02-01 17:13:20 +0000