summaryrefslogtreecommitdiff
path: root/vcl/win
AgeCommit message (Collapse)Author
2023-03-02no need to allocate mpPortName separatelyNoel Grandin
it is only one pointer big Change-Id: I7c8c99c4dad4289e2f073d73e8b3703ee5c8e64e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-12Resolves: tdf#153566 set darkmode menubar background colorCaolán McNamara
because we use it for custom menu titles backgrounds Change-Id: I1ae679bc032d29c4901befc2f1b0cbb53d0a5d1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-10loplugin:staticaccessStephan Bergmann
Change-Id: If0a2032bede27af3176951dabaab4a165efb144d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146738 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-10loplugin:externalStephan Bergmann
Change-Id: Idde40e44254a6c545185470a1db36ab684504bec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146737 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-08tdf#153229 add a switch to override honoring system dark modeCaolán McNamara
Change-Id: Iafb6182e05dc65d20d0809476ee58908f7426d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-03Avoid clang-cl -Werror,-WparenthesesStephan Bergmann
(assuming 9274d41bd72c5310491d81c6d8d938e44ed9d223 "tdf#148085 get a more readable hyperlink color under windows dark mode" didn't introduce a = vs. == typo) Change-Id: Ifd72029836726a804bcb0e3b5441aa7943705a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-01tdf#148085 get a more readable hyperlink color under windows dark modeCaolán McNamara
Change-Id: I392206eb9fcff7fca39c6efee747486f4dfa925e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31tdf#153273 bodge dark scrollbar into drop downsCaolán McNamara
Change-Id: I9c53b931feb7f720f86edfbb6ae88ff5ee436cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146386 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-31tdf#153287 rollover in dark mode with "Explorer" is incongruousCaolán McNamara
Using "CFD" gives a brighter border with rollover, but no notable focus state when focused. Try a combination here to get something decent. Change-Id: If7844cb0f1e88410959aa622b0271c3f3954230e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24tdf#152404 crash with ibus-mozc with ctrl+alt+c during ExtTextInputCaolán McNamara
Change-Id: I86e19387d93a57c3ad263f0c2dc9222a5f3480be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24tdf#152404 crash in Windows with ctrl+alt+c during ExtTextInputCaolán McNamara
Change-Id: I73ed19eeae49ef737aae372b8f4c053f67a169c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-13tdf#152994 actually return in this caseCaolán McNamara
Change-Id: I40cb4dc4ce1fd3caa2464f92803124c3d2107afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12tdf#152994 only query dark mode in Windows >= 10.0.18362Caolán McNamara
Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-21No need for bool return value hereNoel Grandin
all of the implementations of this method return true. Change-Id: I6dc02499af1809110edd482a48d9f6d5d42ead19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-16BP_CHECKBOX should be teamed with some CBS_* partCaolán McNamara
noticed by Julien at https://gerrit.libreoffice.org/c/core/+/143999 Change-Id: Ic17834d503f174f91200614cd48e6771835cc08d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-13Related: tdf#152454 don't use Button to render dark mode TabsCaolán McNamara
on Windows. I can't find anything obviously suitable, so fall back to drawing simple rectangles with ActiveTabColor/InactiveTabColor Change-Id: Ic9e67baeb9e86c80787aa935d8f266e4a7db4489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-13Related: tdf#152454 pick something suitable for dark mode Inactive tab colorCaolán McNamara
on Windows Change-Id: I400ca7d8c0c541977b574ae08f08aa5f28a2e3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-13MBI_NORMAL should be PBS_NORMALCaolán McNamara
Change-Id: I263d96e50699fe878ce153dc88ebfd00cd92415b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-02Resolves: tdf#152284 pull Shadow and DarkShadow from themeCaolán McNamara
Change-Id: Idd5031aa2744d5b04f9f656fcab9fe6f21e2ddcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143594 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-01Avoid dynamic cross casts to WinSalGraphicsImplBaseStephan Bergmann
Change-Id: I1102c5525f47d3e07cadc602dd55f7b78118a709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143535 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-23Avoid memory leak on PostMessageW failureMike Kaganski
In addition to leaking memory, the struct holds a couple of VclPtr, so would prevent destroying referenced windows. Change-Id: I258b5f32aca033a602d7b2805b33bd08ba637309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143154 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-11-21remove FontAttributes::meCharSetCaolán McNamara
its baked in that Symbol means RTL_TEXTENCODING_SYMBOL, so accept that status quo and make it explicit Change-Id: I78d90965e3d6b4543cd74a7847e13246485380d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-20vcl: fix artificial bold and italic on WindowsKhaled Hosny
Move creating DWFontFace to WinFontInstance so that it get proper font synthesis settings. Regression from: commit a80239ede3236c84d7a05d0fbc0f299811fee6c0 Author: Khaled Hosny <khaled@aliftype.com> Date: Sat Nov 19 03:03:15 2022 +0200 vcl: move creating DWFontFace to WinFontFace Change-Id: Ifba947d8908a37972d723028258500b10ec24cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142982 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-19vcl: use std::optional in PhysicalFontFaceKhaled Hosny
Otherwise when a font does not, say, support variations or color palettes, we keep querying the font each time they are requested. Change-Id: I3a41bc73dd814b25af3a8b5b009632ecf7ef27ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142963 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-19vcl: add WinFontFace::GetVariations()Khaled Hosny
This makes font variation settings to be applied to glyph advances and text layout, not only glyph shapes. The sw-extra.h file is needed because we target Windows 7 and the interfaces we want to use are only exposed for Windows 10. File copied from: https://hg.mozilla.org/mozilla-central/file/704f09a557a4dfc9057f1672b711789f64f74a82/gfx/2d/dw-extra.h Change-Id: I7bbb4c3f2b70274754f844fedb0c4329c8f649a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142347 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-19vcl: move creating DWFontFace to WinFontFaceKhaled Hosny
Change-Id: Ie0e94787d962eaec7753ae50d548ad8655dbc209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142957 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-19vcl: move creating DWriteFactory to a centeral placeKhaled Hosny
We already have code in two places to create it, and I will need it in yet another place. Change-Id: I12dee85347a3894045c345b0ec9d5e02c493c218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142956 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-19vcl: remove unused D2DWriteTextOutRenderer codeKhaled Hosny
Change-Id: I873d13e3a230c2679daea2080a102d89003c90c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142955 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-18rename IsStarSymbol to IsOpenSymbolCaolán McNamara
Change-Id: If525ba9826f5bc2d860233cbabf58d1d290be054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-12vcl: remove unused WinFontFace() private membersKhaled Hosny
Change-Id: I0f7f9f03064a63f7c27346fd679e4cb436633cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142638 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-11-09give main thread on Windows a nameNoel Grandin
to make it easier to find in profilers and debuggers Change-Id: I8ce3ee0b89ca8498683367c2b39176edc571137b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-01-Werror,-Wunused-macros (clang-cl)Stephan Bergmann
...which started to hit me now either due to building against a recent Visual Studio 2022 Preview 17.4 (which would presumably no longer define those macros in some system headers, so that the #ifndef's started to kick in now), or due to building against a more recent Windows SDK (see below), no idea which. But just dropping the seemingly unused macro definitions from the various .cxx caused builds against old Windows SDK versions like Jenkins <https://ci.libreoffice.org/job/gerrit_windows/139228/> to fail like > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(479): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(480): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(481): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(482): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(503): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(504): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(505): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(506): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(667): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(668): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(669): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(670): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(691): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(692): error C3861: 'max': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(693): error C3861: 'min': identifier not found > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(694): error C3861: 'min': identifier not found [...] > make[1]: *** [C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:334: C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/vcl/win/app/salinst.o] Error 2 so move those macro definitions to prewin.h (where they don't trigger clang-cl's -Werror,-Wunused-macros from within an include file, even if they happen to be unused in a translation unit). (For simplicity, see whether it works in practice to drop those #ifndef wrappers. If they turn out to be relevant for some build scenarios after all, they can be added back.) Change-Id: I76d8794ae2de310bdca420e5488db2bc19de23ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-24for windows HighContrast use COLOR_HOTLIGHT for hyperlink colorCaolán McNamara
use the same thing for both unvisited and visited Change-Id: Icce13ccb88c7ca35e655f01e8ebb8ac92869753c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-24Related: tdf#151641 set windows WorkspaceColor similiar to other platformsCaolán McNamara
from the same bg as the dialog/face, so we get a good "application background" color in dark mode Change-Id: Ieeb29ed1df177a91691b7b83d056af4068d0e170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-18Move access to SystemDependentDataHolder to Bitmap (2)Armin Le Grand (allotropia)
I was too positive thinking that SalBitmap would be fine, but it's locked to vcl. To be able to add system-dependent BitmapBuffering I move the access to Bitmap now. This is no functional change, but offers the same access as e.g. B2DPolygon/B2DPolyPolygon offer already. Also cleaned up usage/access to SystemDependentDataManager which removes quite some code in constructors and makes things easier in general. Change-Id: I2baa40a12479fab0fe66063a018f058c6b8f5597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141507 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-17Move access to SystemDependentDataHolder to SalBitmapArmin Le Grand (allotropia)
To be able to buffer BitmapData which is created based on Bitmap class data, move the access to basegfx::SystemDependentDataHolder from classes where it was used until now (WinSalBitmap and SvpSalBitmap) up to SalBitmap which is accessible outside vcl. This is a reorder plus a virtual access method to detect/access that helper layer, no functional change. It will be needed for system-dependent renderers when they want to use that standard buffering e.g. already used in the headless & windows backends. Change-Id: Ib30e7b98e722b977bb0c87ad253e3ffc1841e87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141456 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-15tdf#151522 drop Accessibility::AutoDetectSystemHCCaolán McNamara
which doesn't preclude having a different option to force it on/off against the system HighContrast mode setting. Change-Id: Iab9f7f501ac5fd7bb865d07b30b6fad9f1f6809c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-13tdf#120326: properly prevent Windows from entering power savingMike Kaganski
The previous call to SystemParametersInfoW with SPI_SETSCREENSAVEACTIVE only prevented screen saver from running (which is not often used these days), but screen was still turned off (and power saving was started). Despite SetThreadExecutionState documentation [1] claims that it does not stop the screen saver from executing, my experiments show that it does (on my Windows 10). So just use it, because it is designed exactly for this task (documentation discusses the presentation applications). [1] https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-setthreadexecutionstate Change-Id: I6eced8f0a7c17211a0b68851a40227eed9a22b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141289 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-11loplugin:unreffunStephan Bergmann
...after the last use of that RawFontData got removed in 112d07027c4484dd571519911596d11eae897524 "vcl: Use PhysicalFontFace::GetRawFontData() for font embedding" Change-Id: Id85eb39b6fd946da132d53ba937032f3c58b061d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-07Related: tdf#98067 get high contrast hover/default button text color rightCaolán McNamara
Normal and high contrast themes seem to behave differently (in Windows 10) to play more directly with themes than the usual ui try: Press Windows Key + R and paste: shell:::{ED834ED6-4B5A-4bfe-8F11-A626DCB6A921} -Microsoft.Personalization\pageColorization High Contrast themes seem different to the others, with a high contrast theme set then its possible to customize the colors, otherwise not. Playing with 'Selected Text' it seems that this is the color used for the active/hover button text color with a high contrast theme. Change-Id: I561616fce6a6f6d781e4881bfdf8ba0abedcd75c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-07Related: tdf#98067 use EP_EDITBORDER_NOSCROLL for EditsCaolán McNamara
which gives a border which indicates if the Edit has focus or not. In High Contrast Black this is a bright yellow and I see it in notepad and visual studio, so lets do that too. MultilineEdit left alone for now Change-Id: I6785e3cdef7d563509a3a6ea8617ab5f89602a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-07tdf#98067 get menu readable in windows high contrast modeCaolán McNamara
possibly a problem since: commit 9c5a22d19708eae17ad9880422bd03e81ea48c5d Date: Thu Jun 21 17:55:53 2012 +0200 aero toolbar: Extend the drawing of the toolbar to the menubar area. Change-Id: If76be9bf09a19992dafedf16d7e577acf1bc500d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141034 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-01vcl: Use PhysicalFontFace::GetRawFontData() for font embeddingKhaled Hosny
Change-Id: I6f7c4508f7cef022eaf65a998cb242078d3771c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140826 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-27Fix some headless window sizes on Windows, to make `make check` more reliableStephan Bergmann
...by making it more resilient against varying screen sizes. On my 2560x1600 Windows laptop, three `make check` tests systematically failed, and apparently all of them were caused by that larger-than-average screen (similar to what has been detailed in the commit message of 3db6a93c558c55eed085b4386228f9951bb08936 "Compute a better GetDefaultCenterPos"): * CppunitTest_sw_layoutwriter > test/source/xmltesttools.cxx:191:testTdf134298::TestBody > equality assertion failed > - Expected: 2 > - Actual : 3 > - In <>, XPath '/root/page' number of nodes is incorrect * CppunitTest_sw_ooxmlexport12 > sw/qa/extras/ooxmlexport/ooxmlexport12.cxx:526:testObjectCrossReference::TestBody > equality assertion failed > - Expected: Text 2 > - Actual : 2 * CppunitTest_sw_uiwriter2 > sw/qa/extras/uiwriter/uiwriter2.cxx:2702:testTdf122942::TestBody > equality assertion failed > - Expected: 2 > - Actual : 1 Those tests are all run with both SAL_USE_VCLPLUGIN=svp and --headless. But svp is only present on Linux and is thus ignored on Windows. And --headless, while preventing any windows from actually being shown, nevertheless uses the GUI code to set up window sizes. So the idea here is to hack the Windows backend in strategic places so that it uses "appropriate" window sizes in --headless mode to make `make check` succeed. The Linux svp backend has a single place in vcl/headless/svpframe.cxx where it hardcodes the number of monitors to 1 and the screen size to 1024x768. However, for the Windows backend, code determining and using those values is somewhat spread, but it turned out that there is one strategic place in ImplSalGetWorkArea that does what we want (without touching the reported number of monitors at all), without (it appears) negatively affecting other scenarios. (It appears that macOS, also not supporting an svp backend, is similarly affected. But it looks harder there to come up with such a strategic place to hardcode --headless window sizes, and at least my own macOS build's `make check` is unaffected as I use a default scaled 1829x1080 screen resolution there instead of the "raw" 3840x2160.) Change-Id: I822241f81497b9f6bed8e9688eddbe7d798c6b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140588 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-19loplugin:unreffun (clang-cl)Stephan Bergmann
...and with ScopedFontHDC::fsp gone, there appears to be no reason to keep ScopedFontHDC::m_aFSP alive for the whole lifetime of the ScopedFontHDC instance Change-Id: I1028bc24f49f3bbaf6e23c09aef4459418267154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-19tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor"Caolán McNamara
they are the same in light mode, so do the same in darkmode Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19vcl: Add PhysicalFontFace::UnitsPerEm()Khaled Hosny
Change-Id: I9239085aabe450499193e74ac91d6a16437545c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140124 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-19Rename MouseNotifyEvent to NotifyEventTypeSamuel Mehrbrodt
Also contains keyboard and focus events, not only mouse events Change-Id: Iec1d6c341b01a489ba80fe9634ea3579afb02ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-17loplugin:staticmethods (clang-cl)Stephan Bergmann
Change-Id: I875b60fba5267e158ac85d1442133f1bd4bfe560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140099 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-17-Werror,-Wshadow (clang-cl)Stephan Bergmann
Change-Id: I58d99d17baf8dc13e4dc951bf281d7c7c358d259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140101 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-11 19:51:42 +0000