Age | Commit message (Collapse) | Author |
|
Change-Id: Ia1f1abfece4667baad4036d9bedb36d07e8212ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174565
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ifae0795de882d833865ba973cf8098c8b59b8eb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174541
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ib805b2e8245903f63096cc21f511ba7ae0a4f488
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173466
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I4be65927215dbf9c10ecd51baca42b59b569d75b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173677
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I8c2071cf8fef16201365ba8e4cb356f5605383c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172704
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I8d98054b4e1fe5ea2d2f04f38ccb3ccfea11e9c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172703
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Replace the classic For loop with vector initializers.
Change-Id: I60ee577ef395127e99148a32e02009e0cc1c1d51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171568
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
|
|
so reenable this and bump up min fuzz length
Change-Id: Iaafe917d75c0e9c6482957b368e39196b5c0ead8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171748
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
so reenable this and bump up min fuzz length
Change-Id: Ia5a8c725aa827c18f68c46077fae020831608395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
so reenable this and bump up min fuzz length
Change-Id: Ic493e1a55899761f6bc88dc7f4b598a82dd00411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
oss-fuzz has got into that annoying state where the original bugs are
not reproducible, and probably fixed, but some follow up issues trigger
the same problem so the original won't close and its not easy to see the
new cases.
Change-Id: I8e515c0c5b8eafe40bfda695774ef56ec24948c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I5b6ee5bda0c5ff69d297f7f8e87d4c3f3d21791c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167470
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
I had done these a while ago, when I looked into extending loplugin:ostr to do
more automatic rewriting, and these were places where I needed to do something
manually, for one reason or another, because the automatic rewriting would not
pick it up correctly.
However, I got distracted, and a wholesale automatic rewrite would still run
into cases where an _ostr/_ustr instance from a library's .rodata would still be
referenced after the library has already been dlcose'd. So I never came around
to finishing all that.
But there appears to be renewed interest in (automatic) rewritings here now, so
it probably makes sense if I share this part of my work anyway.
Change-Id: I3da9d38398e4bca373cb0000a9d34b49a36ad58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166792
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
Change-Id: I602b24eb624420549b0fde23e662db7700e23da0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166372
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
... instead of tools::Rectangle.
Several problems were there:
1. First, a horizontal bounding rectangle was calculated, with due
rounding; and then the result was rotated, and after that, rounded
again. That made the resulting rotated rectangle coordinates very
imprecise.
2. Also, ceil/floor was applied without normalization; and in case
of rotated font, that meant, that sometimes the range could be not
expanded to cover partially covered pixels, but instead collapsed.
3. The rotation to angles other than 90 degree multiples was done
incorrectly, resulting in cut off parts of characters.
4. For 90 degrees, the imprecise result of sin/cos converted 0.0
into values like 3e-16, which then could be ceil'ed up to 1.
Using B2DRectangle and its transform allows to simplify and fix
the calculations easily, and avoids premature rounding. Render of
rotated text of small size is more stable with this change.
Change-Id: Idffd74b9937feb2418ab76a8d325fdaf4ff841b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165553
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I0d74859e276bfa98d8abf7b2e66600f849971468
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164956
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I095178b1b3c61829abf5c08b8b81cd7415e3e795
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162747
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I124f97e1f3c024d05f29079bc699cf0ea12d06d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164955
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
which means I can remove one usage of gb_Library_set_plugin_for, which
is blocking linking the sw module into --enable-mergelibs=more
Change-Id: I8c199421c66de2dcf339ccc2d5cb9340d3bea914
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164429
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which means I can remove one usage of gb_Library_set_plugin_for, which
is blocking linking the cui module into --enable-mergelibs=more
Change-Id: Ic6cd48377627f94747037c7247a1cd398738b390
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163820
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3d8778d23a21bdd4a6babf495552112c67938111
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163413
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Try the workaround of https://github.com/google/oss-fuzz/issues/4605
Change-Id: If02072f244b05e005c0c180ce689f7a919105ec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162353
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and try something a bit more generic
Change-Id: I1d8256576cd02f0a589df350ba7b53059dd586a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161250
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and
cid#1545999 COPY_INSTEAD_OF_MOVE
cid#1545995 COPY_INSTEAD_OF_MOVE
cid#1545994 COPY_INSTEAD_OF_MOVE
cid#1545989 COPY_INSTEAD_OF_MOVE
cid#1545982 COPY_INSTEAD_OF_MOVE
cid#1545977 COPY_INSTEAD_OF_MOVE
cid#1545970 COPY_INSTEAD_OF_MOVE
cid#1545856 COPY_INSTEAD_OF_MOVE
cid#1545845 COPY_INSTEAD_OF_MOVE
cid#1545838 COPY_INSTEAD_OF_MOVE
cid#1545776 COPY_INSTEAD_OF_MOVE
cid#1545774 COPY_INSTEAD_OF_MOVE
cid#1545744 COPY_INSTEAD_OF_MOVE
cid#1545719 COPY_INSTEAD_OF_MOVE
cid#1545716 COPY_INSTEAD_OF_MOVE
cid#1545687 COPY_INSTEAD_OF_MOVE
cid#1545648 COPY_INSTEAD_OF_MOVE
cid#1545643 COPY_INSTEAD_OF_MOVE
cid#1545641 COPY_INSTEAD_OF_MOVE
cid#1545604 COPY_INSTEAD_OF_MOVE
cid#1545531 COPY_INSTEAD_OF_MOVE
cid#1545530 COPY_INSTEAD_OF_MOVE
cid#1545524 COPY_INSTEAD_OF_MOVE
cid#1545516 COPY_INSTEAD_OF_MOVE
cid#1545501 COPY_INSTEAD_OF_MOVE
cid#1545486 COPY_INSTEAD_OF_MOVE
Change-Id: Idcf3e27bb9e81b6a77d5ef75c9376eb1d6aff8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161245
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
(*) Make all of it use a "Scoped" paradigm
(*) pass by value, no need to allocate on heap
(*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods.
(*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places.
Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Having it subclass Bitmap encourages confusion in passing it around, and
I need the extra type-safety for my work on merged-alpha
Change-Id: I35819f9b8ee609cbdaf865563c78531e397b529b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160235
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
using the color bitmap __and__ the alpha from another BitmapEx
is equivalent to just doing a straight copy/assign
Change-Id: I134ab8a1197ed538823afc4a8cd28b3d5986c6b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160019
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2a9d5383d1831d8bf61e5280d66556d71fccae52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159666
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I2fcd448d4efef924d088bfc9470ae800dbd78504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157737
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I133dbe40d57eda77b64f3e38631da30f296489f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157517
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Done during the conference hackfest
Change-Id: I765e6dc839a98038c4071c8444ce3db9293c8a6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157173
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I517fe5c9a3168cbaea670e0ead6d1f9588f588a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156664
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
it's all gone very quiet since ofz#61511 Direct-leak
Change-Id: Ia78de8b10e89905a29c0150f9582ad769e6984a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156311
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
very little output from this fuzzer to date
Change-Id: I1bd0eaf983c3c88f620803bbd85f464923d6484d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155374
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I30ee4e76e1ffb8cdec989f81d5bb43ed7bf7529e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154204
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and add xmlInitParser there
Change-Id: Ifde0f8d9e8be413fd3dcf216ad33effa731fa549
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151684
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6a422be17569340865d8799a74dbc5a9867b7562
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151683
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib8c3c0e35c6a7cc8b3b40fce4f89c038e819f088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151587
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idf893faafac27d8a395bd39ca8297121e8ceffa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151435
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3294c4e6cc5671927824cffaf03fd536a0a7dba6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151403
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib6dabc636cd171151ce77e48a0e774e955ab7ce3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151434
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5b238bfad2495b3354140a39366001186b3eb91a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151426
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9b980f3c81d468da4bcc33b6d27df9233f78c365
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151219
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie8596618f62d245f35cb56e128c529464bc7cc25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Initially give it a fairly tiny input size limit.
Change-Id: Iabc2611174e88f1f6050edb21da4f28694bac4a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151151
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia2dd8a4d5c6e558ebea6c170a0b01b5f361e1d39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151135
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
that look a good fit for the formats we're already fuzzing
Change-Id: Ie635d17d829858c0cb10f71ea936f8dc131db811
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151052
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9662d91d2761b4f160858897f19f31f474dccbed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151051
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4d59aa9a684bd3e05fca473d6c7567cd8258b242
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|