summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04Convert tick-based timer events to versioned onesJan-Marek Glogowski
Instead of storing the system ticks in the timer event message simply store a version. Moves the version handling code into a VersionedEvent class, inherited by WinSalTimer and AquaSalTimer. Change-Id: I5add85031d36b3424a26a9ef798294cbfb00b2e4 Reviewed-on: https://gerrit.libreoffice.org/42959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-04don't add WB_CLIPCHILDREN to toplevel dialog builder creationCaolán McNamara
Change-Id: I402ebea3acf6ca7f4d61785944c933663b35e1f3 Reviewed-on: https://gerrit.libreoffice.org/43125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-04loplugin:redundantcastStephan Bergmann
Change-Id: Ia00af1b79ac30ca00345f52a1981d3bfc1620f76
2017-10-04tdf#95656 fix orientation for Bopomofo tonal marksMark Hung
A few Spacing Modifier Letters ( 0x2ca, 0x2c7, 0x2cb, 0x2d9 ) are used as Bopomofo tonal marks. This patch force their vertical orientation property to be transformed upright. This patch also set the script type of them to WEAK to keep them with nearby Bopomofo symbols in the same portion. Change-Id: Ib226ebbcaf140124dee806dd6b2859150eb53f67 Reviewed-on: https://gerrit.libreoffice.org/43001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-04tdf#112486 Do not force GDI in no OpenGLXisco Fauli
See: http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html Change-Id: I19bb4b58d2260fd23c32a687a9f504540c229985 Reviewed-on: https://gerrit.libreoffice.org/42897 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-03tdf#107605: Fix line height cslculation for broken fontsKhaled Hosny
Change-Id: I06368dd15d7898dda61bc07b0f96bf82b00733b9 Reviewed-on: https://gerrit.libreoffice.org/43095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-03convert WB_FORCECTRLBACKGROUND to bool field on EditNoel Grandin
Change-Id: I7a8731635bd22926df98cd70c8bb850408c1854c Reviewed-on: https://gerrit.libreoffice.org/43076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03WB_DOCKBORDER is deadNoel Grandin
the only place that passes it to a window class, does so to a window class that does not implement that style. Change-Id: I74d705ed928b797c3456cf23a8074c62d0c12247 Reviewed-on: https://gerrit.libreoffice.org/43072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03Resolves: tdf#112827 gtk3 menubar not RTL under RTL localesCaolán McNamara
Change-Id: Icb2fa621e1f7da1e2d4bd221c8e1d8677cc956a2 Reviewed-on: https://gerrit.libreoffice.org/43057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02tdf#112769 Don't multi-trigger AllEventsProcessedJan-Marek Glogowski
User events processing - as all event processing - can be nested, which can cause TriggerAllUserEventsProcessed to be called multiple times, when a nested event loops ends. So track TriggerAllUserEventsProcessed calls and just reset, if a new event was inserted. Change-Id: I4a1b1b08901c99a7ece08f8baf008c8bb73506bf Reviewed-on: https://gerrit.libreoffice.org/43043 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-02Removed duplicated includesAndrea Gelmini
Change-Id: I2f2c31e3605c1bff353b5749c593305c3fc7028f Reviewed-on: https://gerrit.libreoffice.org/43044 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-02WIN handle timer Impl* access via friend functionJan-Marek Glogowski
Not sure if this is the better approach, but this gives the application window dispatch function access to the now private timer implementation, so nobody else can call them. Change-Id: Ic361d2c93116fbd6c85b20f7da3cffbd538b3558 Reviewed-on: https://gerrit.libreoffice.org/43041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-02lokdialog: Emit dialog close callback upon dialog closePranav Kant
Change-Id: I4ccef76cc3b2926dd8916f825671bb732e101027
2017-10-02Change CB_DIALOG_INVALIDATE to CB_DIALOGPranav Kant
We can specify whether it is an invalidation or something else in the payload. Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
2017-10-02lokdialog: Mouse events for dialog floating child windowsPranav Kant
Change-Id: I06a081835d246f752e57f8cc289162ed31fc91d4
2017-10-02lokdialog: Support for rendering floating window dialog widgetsPranav Kant
Now gtktiledviewer can show floating window dialog widgets when user clicks any of such widget in the dialog. Change-Id: I13d756f236379bc8b2041ed41cb7b502f7fd9b24
2017-10-02lokdialog: Register IDIalogRenderable with vcl::DialogPranav Kant
Change-Id: I344f5a9c7167abfde15dcd21c747819cc79b12b1
2017-10-02lokdialog: Handle key events in corePranav Kant
Change-Id: If84aaac87beebf69d92db5446fc713d8cc20421e
2017-10-02lokdialog: Forward mouse events to vcl; enable mouse movePranav Kant
The current implementation works well - the mouse events are properly handled by the opened dialog changing the dialog states. However, since the uno commands (dialog IDs) are different from what is returned by LOK_CALLBACK_DIALOG_INVALIDATE, the invalidation doesn't instantaneously, so one have to make the dialog window out-of-focus and then again back to focus to trigger the paint and see the updated dialog state. The mouse coordinates are forwarded in pixels as of now. Enable mouse GDK Motion mask too for mouse move operation. Change-Id: Ia915f734e8cbf4586da2b70da5840fe1568b39bd
2017-10-02lokdialog: Set up intial posting mouse events to dialogsPranav Kant
Events from the dialog in GTV are forwarded correctly, but the events are still not processed by the dialog in core. Change-Id: Ib95ac0a3cd23f6cc2763c21425a67402b15f2de2
2017-10-02lokdialog: Dialog invalidation supportPranav Kant
For now, just invalidate the whole dialog whenever any of the controls in the dialog get invalidated. Since during dialog painting, many such invalidations are triggered, don't listen to them when we are painting. Change-Id: Ia8fc12cf9469691d60e91ef770d687e5ff01a7ef
2017-10-02lokdialog: Better dialog rendering APIPranav Kant
After painting the dialog, also write width and height of the rendered dialog. The dialog is rendered always on the top left of the given canvas, so client can crop the canvas accordingly. Change-Id: If052058a6db8a85d4e28ec88cffcca05564b17f0
2017-10-02Add IDialogRenderable interface for rendering of dialogsTomaž Vajngerl
Change-Id: I1d85729a1ac1a99d33ea2bde1b50ccf4c05ca9a9
2017-10-02move ITileRenderable implementation to own fileTomaž Vajngerl
Change-Id: Ib05ecf5f92e0ae4adf99c4dd10d60e730a95cf45
2017-10-02Give name to debug event injectorPranav Kant
Change-Id: I3468776797426b04c1cb3206dbb194837a652e16
2017-10-01tdf#39468 Translate German comments (leftovers)Johnny_M
Change-Id: I9952c560547b0668d8216edba1486638fa41e553 Reviewed-on: https://gerrit.libreoffice.org/42990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01loplugin:nullptr,redundantcast (clang-cl)Stephan Bergmann
Change-Id: Ic173e38828b04fd177d62551e3323b816c73d556 Reviewed-on: https://gerrit.libreoffice.org/42980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-30Translate German comments and debug strings (leftovers)Johnny_M
Change-Id: I4ab8fbae47037f6e21c51713d1c51aaa5dc61f40 Reviewed-on: https://gerrit.libreoffice.org/42967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30Access to ProcessEventsToSignal's bSignal is racyStephan Bergmann
...so spell out its single use, locking the appropriate mutex around the access Change-Id: I8e8f47de1979f5a80cf1ad65e5ec24d25145c463 Reviewed-on: https://gerrit.libreoffice.org/42908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-29ofz+ubsan: signed integer overflowCaolán McNamara
Change-Id: Ia8d0bb650d222ccda4c323eabebc4b1162fcf42f Reviewed-on: https://gerrit.libreoffice.org/42933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-29OSX rename mpFirstInstance to mpInstanceJan-Marek Glogowski
In the same spirit as the Windows commit 7c52d86f7b05fe7e0178f6d98a12a531b88a32ff. Change-Id: Ic45803c0715723b6f57c9f6a0c731edd559aa92c Reviewed-on: https://gerrit.libreoffice.org/42932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-29tdf#112605 OSX refactor SalAquaTimerJan-Marek Glogowski
Drops all the static calls and variables from SalAquaTimer and moves all timer handling logic inside the class. This also fixes the leak in timerElapsed. Change-Id: Ie7a1a8fffb70b8579ec6876eed10a275d2f06d27 Reviewed-on: https://gerrit.libreoffice.org/42913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-29Drop check for Windows versions we don't supportMike Kaganski
Since we dropped support of Vista and below in master toward 6.0, those checks are needless. Removing the code that only worked in older versions, and streamlining the resulting code. Also, use kernel32.dll version for Windows version, instead of deprecated GetVersionEx, and inconvenient VersionHelpers. Since both GetVersion(Ex) and VersionHelpers (based on VerifyVersionInfo) are subject to manifest-based behavior since Windows 8.1, this move will hopefully result in more reliable OS version detection. Change-Id: I3edd8fc1843e64b6a65bd3a126be6a085511f13c Reviewed-on: https://gerrit.libreoffice.org/42905 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-29Improve the commentMaxim Monastirsky
Change-Id: I131c3e584f4c30b075431a400f9ba6fd6dfa2f9a
2017-09-29Make sure GetText() is called at the right stageMaxim Monastirsky
And document why (similar to DockingWindow::SetFloatingMode). Change-Id: Iefd7d756dfcdfc385344161862d7cc1e492e3711
2017-09-29fix oss-fuzz buildCaolán McNamara
Change-Id: I68f85c652d70eb57227137b03356975556af8e24
2017-09-29check for unnecessary DLLPUBLIC annotationsNoel Grandin
on classes which are fully defined in a header file Rename the dllprivate plugin to dllmacro and add the functionality there. Change-Id: I4581d551c46a8f61213d95973f323359d08278d8
2017-09-29convert GfxLink::IsEqual to operator==Noel Grandin
exactly one use site Change-Id: Id0a75d46c459be213e81b47aa6c1194c87aec848 Reviewed-on: https://gerrit.libreoffice.org/42891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-28Remove dead code behind Calc "Live Data Streams" dialog's "scriptdata" buttonStephan Bergmann
...that has been disabled and hidden ever since 4c90ed782a09e2e4b8738b82028032c42d1a203d "Actually hide these two radio buttons (since there is no choice now)." This removes the sole user of SvScriptStream. (Unfortunately, removing the no longer needed #include <osl/process.h> from include/tools/stream.hxx triggered an avalanche of missing includes elsewhere.) Change-Id: I7b0e683b14c0eaf7f4737f62adc9d691826380c0 Reviewed-on: https://gerrit.libreoffice.org/42916 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-28Fix SalUserEventList usage on AndroidJan-Marek Glogowski
Change-Id: I598446c6f14e9df798bf37cb64c8b7bcbb04dd91
2017-09-28loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: I230c37482cfce85534f860ecf3426254be8981ab
2017-09-28Missing includes (--disable-pch)Stephan Bergmann
Change-Id: Iaa87663255f815e4f837df25d5338439d79c70dd
2017-09-28Unify SalUserEvent handlingJan-Marek Glogowski
Merges the various SalUserEvent structs and their handling into a single class. This includes a common SalFrame* hash map, as all backends use such a map to verify alive SalFrames. It also reverts the "FIXME: lousy workaround" for i#90083, which was part of commit d6f7c94e5c27ba02ff5c3229760c9808cc9b5bea. At least on my current OSX box application based window switching "just works" "out of the box", even without the code. Change-Id: I188b567e44fd79c162b2d9cabbd771d1f66c7dc4 Reviewed-on: https://gerrit.libreoffice.org/42845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-28tdf#112288 set timestamp for otherEventWithTypeJan-Marek Glogowski
In otherEventWithType we have to set the timestamp manually to the current uptime, and can't default to 0. Change-Id: I3e96dff38ea81b0e6744fa175fc3a169e160b982
2017-09-28RTF export: various minor cleanupsMiklos Vajna
Change-Id: I6bdbe246bf65dcfa193289210f7c464769d5e2ad Reviewed-on: https://gerrit.libreoffice.org/42887 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-28tdf#112658: fix leak when calling TextEngine::SetAttribJulien Nabet
TextCharAttribList::RemoveAttrib lets a dangling pointer when release unique_ptr obj maAttribs[n] So retrieve a unique_ptr from the different layers until SentenceEditWindow_Impl::ChangeMarkedWord (SpellDialog.cxx). Change-Id: I734909dce86ec28d69c09b2a8c0fc4a6941f422a Reviewed-on: https://gerrit.libreoffice.org/42881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-04 11:36:18 +0000