summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-07-08Related: fdo#80633 dialog size cache has to be invalidated tooCaolán McNamara
otherwise the VclExpander will have no effect Change-Id: I039fa361d7088dfe4a6ff849623e34b27e2be26b
2014-07-08Fix some OUString construction error with VS2013Tor Lillqvist
A bit unclear to me whether the code really did what was intended with earlier VS versions either. VS2013 said: error C2664: 'rtl::OUString::OUString(const sal_uInt32 *,sal_Int32)' : cannot convert argument 1 from 'const char *' to 'const rtl::OUString &' Reason: cannot convert from 'const char *' to 'const rtl::OUString' No constructor could take the source type, or constructor overload resolution was ambiguous Change-Id: Ie23d8382515064062a3ed46418d9d4a977b35d28
2014-07-08Fix some round() confusionTor Lillqvist
Why insist on using the same name as a standard function? Causes confusion with VS2013 at least, "ambiguous call to overloaded function." Sure, this might be caused by a bug in the compiler (or its headers). Or maybe vagueness in the language definition? Who cares, I still claim that intentionally writing an own function called round() is asking for problems. So rename it to round_to_long(). (And then the return value of calls to this function, which is of type 'long', is assigned in a couple of places to variables of type 'int', fun... Intentional, knowing there will be no overflow, or a bug waiting to happen?) Change-Id: If15d44f10f9f05de1c7c79492baf158eee770b8b
2014-07-07Add a few more SAL_INFOsTor Lillqvist
Change-Id: Id379c88c8a8c16f5276568e2bdb5f3730855255f
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07svp clipping: Rectangle dimensions don't map directly to B2IBox.Andrzej Hunt
Previously the clip region would end up being 1 pixel smaller in both directions than the requested area -- B2IBox considers the bottom-right point to NOT be included in its area, whereas Rectangle considers the bottom-right point to be the last point WITHIN its area. (This is equivalent to the Rectangle's getWidth/GetWidth differentiation.) This is noticeable e.g. with tiled rendering, where images spanning a tile boundary are clipped to paint only the region within a given tile -- however previously they would be clipped by an additional pixel in each direciton, resulting in an empty border along the bottom-right edge. Change-Id: I0ef3098959defc5c82719155c130aa904c04b6b1
2014-07-04fix typo in coverity#704538-9Norbert Thiebaud
Change-Id: If4868ad8190fcb1a64ae6fc18791d7a266d1b1e9
2014-07-04coverity#735340 Unchecked return valueNorbert Thiebaud
Change-Id: I13df98f64ce505a08ba3e8b2582a17f5d202c4d1
2014-07-04coverity#704538-9 Division by zeroNorbert Thiebaud
Change-Id: Ia77648c3e0442bb5e0a08d01bbd495c9d7c8bbf5
2014-07-04vcl: printf -> SAL_INFO in Font::SetFillColorMiklos Vajna
Change-Id: Icbe3d7f2dc8e25bfde6efc92435f1cef50a3b419
2014-07-04Resolves: fdo#80911 toggle original page orientation on paper fallbackCaolán McNamara
User defined page sizes which match rotated paper sizes available to the printer don't work correctly when they are already in landscape mode. i.e. the orientation should be toggled, not overwritten. Change-Id: I30dca5f988ad72319410a03f47eccff277be8640
2014-07-04coverity#736163 Dereference Null returnNorbert Thiebaud
Change-Id: I62046a619315d53dbeefbe0ebd26d24917adca14
2014-07-04coverity#736159 Dereference Null returnNorbert Thiebaud
Change-Id: I6581efb320a9e43cb242dabecfd500d4e04b058b
2014-07-03fix libmerged: vclplug_svp is inMatúš Kukan
Change-Id: I6ab00275b36725fbb0a446c7e5eb888e034a8989
2014-07-03fdo#39944: Fix mapping for some a11y roles to ATKJacobo Aragunde Pérez
In particular, EDIT_BAR, EMBEDDED_OBJECT and HYPER_LINK were being mapped to custom roles when specific roles exist; fixed passing the proper name to registerRole. Besides, moved two roles that were in the section 'don't exist in ATK yet' because that's not the case now. Change-Id: I6818a0ac623f45053812b5c6dd5fc25c9abf4f65
2014-07-03coverity#706115 Unintended sign extensionCaolán McNamara
and coverity#706114 Unintended sign extension coverity#706113 Unintended sign extension Change-Id: Ib9ab82082fb353ecfc98a4130fdf2bb136ac1350
2014-07-03clang scan-build: Assigned value is garbage or undefinedCaolán McNamara
Change-Id: I461bb3d513fdbfffb3b79b549beded82c8d2a3d9
2014-07-03Shorten Spanish key translations in LinuxAdolfo Jayme Barrientos
Change-Id: I3405e0fb4d9d7992d9da15a162311b7a0e75db76 Reviewed-on: https://gerrit.libreoffice.org/10030 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-02fix 'NSCursor' may not respond to operationNotAllowedCursor,dragCopyCursorDouglas Mencken
related commit: e4653eee7680831e6d0995d51d80fb63309c03ab Change-Id: Iba30c90336bf08d15d5990d6e1380867eee3564e Reviewed-on: https://gerrit.libreoffice.org/10013 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-02fix 'NSImage' may not respond to '-lockFocusFlipped:'Douglas Mencken
related commit: b3818f53812053e94196a58bbe474e2c3b72ac69 Change-Id: Ica27b3c2e474ebb85a69149e35021835f8183b69 Reviewed-on: https://gerrit.libreoffice.org/10011 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-02expose a way to drop ownership of a window from builder treeCaolán McNamara
Change-Id: I6f6bff32271ed1d6c328ba211a6b1249fda039dd
2014-07-02callcatcher: rsc loaded fixedbitmap is no moreCaolán McNamara
Change-Id: Ie111d9ed3534eb8892400d638eac4b38b3904646
2014-07-01loplugin:stringconcatStephan Bergmann
Change-Id: Ibf410eb1b8be81505b8e778aadf916a26ba39468
2014-07-01fdo#80014: vcl: fix drawing of linear gradientsMichael Stahl
There is an off-by-one error in OutputDevice::ImplDrawLinearGradient() that causes the bottom line to remain black. (regression from 04d937c1ec36c2d9fa8c90604c81a37d30e97da6) Change-Id: I33948ec8065e446a9ec7efeab5e506c93fa2e9e8
2014-07-01Related: fdo#80633 cache optimal sizeCaolán McNamara
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01Related: #i124638# Second step of DrawingLayer FillAttributes...Armin Le Grand
for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes (cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b) Conflicts: cui/source/factory/dlgfact.cxx cui/source/factory/dlgfact.hxx cui/source/inc/bbdlg.hxx cui/source/inc/cuires.hrc cui/source/tabpages/bbdlg.cxx cui/source/tabpages/bbdlg.src cui/source/tabpages/page.cxx cui/source/tabpages/tparea.cxx include/svx/pagectrl.hxx include/svx/svxdlg.hxx include/svx/svxids.hrc include/xmloff/PageMasterStyleMap.hxx include/xmloff/prstylei.hxx include/xmloff/txtprmap.hxx svx/Package_inc.mk svx/inc/svx/hdft.hxx svx/source/dialog/hdft.cxx svx/source/dialog/pagectrl.cxx svx/source/tbxctrls/tbxcolorupdate.cxx svx/source/unodraw/unobrushitemhelper.cxx sw/Library_sw.mk sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/frmfmt.hxx sw/inc/hintids.hxx sw/inc/hints.hxx sw/inc/ndtxt.hxx sw/inc/node.hxx sw/inc/swunohelper.hxx sw/inc/unobrushitemhelper.hxx sw/inc/unoprnms.hxx sw/source/core/attr/format.cxx sw/source/core/attr/hints.cxx sw/source/core/doc/docdesc.cxx sw/source/core/doc/docdraw.cxx sw/source/core/doc/docfmt.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/docredln.cxx sw/source/core/doc/poolfmt.cxx sw/source/core/doc/visiturl.cxx sw/source/core/docnode/node.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/inc/rolbck.hxx sw/source/core/layout/atrfrm.cxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/findfrm.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/ndtxt.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtedt.cxx sw/source/core/undo/rolbck.cxx sw/source/core/unocore/swunohelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unomap.cxx sw/source/core/unocore/unoparagraph.cxx sw/source/core/unocore/unoprnms.cxx sw/source/core/unocore/unostyle.cxx sw/source/ui/chrdlg/paradlg.src sw/source/ui/chrdlg/pardlg.cxx sw/source/ui/fmtui/tmpdlg.cxx sw/source/ui/fmtui/tmpdlg.src sw/source/uibase/app/docst.cxx sw/source/uibase/app/docstyle.cxx sw/source/uibase/frmdlg/colex.cxx sw/source/uibase/shells/basesh.cxx sw/source/uibase/shells/textsh1.cxx sw/source/uibase/uiview/viewstat.cxx sw/source/uibase/utlui/uitool.cxx xmloff/inc/PageMasterImportContext.hxx xmloff/inc/xmloff/XMLShapeStyleContext.hxx xmloff/source/draw/XMLShapeStyleContext.cxx xmloff/source/draw/sdpropls.hxx xmloff/source/style/PageMasterExportPropMapper.cxx xmloff/source/style/PageMasterImportContext.cxx xmloff/source/style/PageMasterPropHdlFactory.cxx xmloff/source/style/PageMasterStyleMap.cxx xmloff/source/style/prstylei.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx xmloff/source/text/txtprmap.cxx xmloff/source/text/txtstyli.cxx Conflicts: svx/source/dialog/hdft.cxx sw/source/core/doc/visiturl.cxx sw/source/core/txtnode/thints.cxx sw/source/core/txtnode/txtatr2.cxx sw/source/core/unocore/unostyle.cxx Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01clang scan-build: various warningsCaolán McNamara
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-30Cleanup: removed comments and debugging outputmatteocam
Change-Id: I41f13d33da641153784725344f5bd526ca69542b
2014-06-30More debugging; fixed Font::IsTransparentmatteocam
Change-Id: Idcb54408dd3cf6561b78eb28fdb409d2e31df541 (cherry picked from commit d84dba8b01c1f240f22b774c951ebf206d5a3ac9)
2014-06-30Minor changes.matteocam
Change-Id: I3b8c51690eb14601435653e9a2255a5c6ed4fd7e (cherry picked from commit 0b8fe9834b398db7550f30718b3cb63860c6165d)
2014-06-30Debugging output in OutputDevice::SetTextFillColormatteocam
Change-Id: I78a75a94e4012eded1a4a5b4c36d8b399a4dda6c (cherry picked from commit 1441ae75b005b4ff1ae2683755a12c5813a3a6b3)
2014-06-30Debugging outputmatteocam
Change-Id: I4e9418746ad50e1bdb1336459c00a4cf614e2350 (cherry picked from commit 4b2d62f02a386013d0004058a02fed80eb8df675)
2014-06-30Setting SetTextFillColor from Attrs. Experiment with line colormatteocam
Change-Id: If34f000d6c5ef6ec38f7f735ada194b8fff4f56d (cherry picked from commit 7fb0e8c9a659417607c85f9b0e8245e4af4552dc)
2014-06-30Cleaned up code from tranparency in vcl. Trying setfillcolor from edit attrsmatteocam
Change-Id: I263012332e43573f260ac8c54612576eb21a11a1 (cherry picked from commit 02385eb4d8de3c5a57511d8bae3c42a523470838)
2014-06-30Cleaned up code from operations in vclmatteocam
Change-Id: Ica5194f0cf6e30ec099974ae8b794fb2bc5e654a (cherry picked from commit 4445f361aa2730b61fdd339dcdd7014b266e5c42)
2014-06-30 SetTextFillColor immediately before DrawTransparent. DrawTextRect commentedmatteocam
Change-Id: Id283624484dfcda91546fd4965bc0b6b92614f55 (cherry picked from commit ebc7be61df384120f1d0420d3e4dc5e3ac5599f4)
2014-06-30Transparency with DrawTransparent in addition to DrawRectmatteocam
Change-Id: I9e8221652b74a3004857ef4b12c6b45563a373b5 (cherry picked from commit 2f8660008ddd32c8f24825d5ba3e751bc65d6d3e)
2014-06-30Transparency by replacing DrawRectmatteocam
Change-Id: I5ba220df841cbe650c910c1c7bc1815900f13c53 (cherry picked from commit 6ec2a1a6922d22fa5efb25982b0b51cef7a97499)
2014-06-30Changed SetFillColor to SetTextFillColormatteocam
Change-Id: I3c19ac80318733ccae1e8829e3269ec8c716869e (cherry picked from commit 33384f3d23958b62e1ec9f72f2a0e6424313a177)
2014-06-30Fixed color problemmatteocam
Change-Id: I7e9340ebab26d3c979571155a3e9d051c41c58f4 (cherry picked from commit aa7d40399758c7f2270dfb0b71f4bcc39d0e24ea)
2014-06-30Moved Text Filling Color in OutDev. Text Filling occurs in ImplDrawTextmatteocam
Change-Id: I9c75066a8dea32721757d0511a2af58c68408438 (cherry picked from commit b09cf493611f2521e66159287b88acc3c05d6d33)
2014-06-30Put text filling in SvxFontmatteocam
Change-Id: I290fff0cb66fc07122b976d977dff24ac491e108 (cherry picked from commit ea56441757a34082b9ffc5f28936413fcb55e31a)
2014-06-30HasBkg method to Font.HasBkg iff HasSingleUnderline.SetBkgColor in OutputDevmatteocam
Change-Id: I10e6e1b916df0c78d26596a37944e8b57b2897e7 (cherry picked from commit 181266201b5e6aaad1dcd9cbc2dd4db44ecf3dc5)
2014-06-30rework resize into a custom widgetCaolán McNamara
so that the order of resizing will happen in the right sequence to work correctly every time Change-Id: I1adffe276db3fb80eb34ca74c2ceb51a6ee28526
2014-06-30...and ~SystemWindow can recursively destroy its child windowsStephan Bergmann
...so when the pMyParent vs. pMySysWin typos in the asserts (thanks Matteo and Micheal for spotting) were fixed, they would fire in such scenarios. So just hope that it is fine to effectively skip those safety checks in these cases, too. Change-Id: Ib925e57b68643c75a5d4db67fd64692015482179
2014-06-30Once ~SystemWindow calls ~Window, this is no longer a SystemWindowStephan Bergmann
...and hopefully it is just as fine to start this safety check at the paren, anyway. Change-Id: Ie3d7a1e233b9e3076a6603f2c6312d57b42b0f77
2014-06-30Mark WindowImpl as noncopyableStephan Bergmann
Change-Id: I80f981216067a03578cfc812b006e6b68b77068e
2014-06-30use VCL_HIDE_WINDOWS env on Mac to 'simulate' headless mode on MacNorbert Thiebaud
Building, and running the unit/subsequent test on Mac cause massive amount of flashing windows creation/destruction that make building with test very annoying on a box used for other purposes. This patch prevent the windows to be actually displayed hence mitigating the problem Change-Id: Ied2a36699b50856e0c4e6b618212481796ec99d3
2014-06-30Called C++ object pointer is nullCaolán McNamara
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6