summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-02-08coverity#1267681 Dereference before null checkCaolán McNamara
Change-Id: I629b12d53ef3bbadeb43e9555a8499252c1a1800
2015-02-07loplugin:deletedspecial (Mac OS X)Stephan Bergmann
Change-Id: Ia09e2e7b3e40bd04da64b52fe29258017b90b156
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I9ea64443350ed2e1341b99270fa8b29189f07eb2
2015-02-07tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82
2015-02-07Fixup --without-x buildRiccardo Magliocchetti
Accept gl linkage in hope of future offscreen mesa support. Avoid linking with GLX though. Change-Id: I4e666f60e74fe34075a8da9eeba95807cf8fe38c Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/13452 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-06fix mac buildCaolán McNamara
Change-Id: Ic98ada6d0bca124194cea24a1ed30d30a1c0a85e
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-05Resolves tdf#89129: crash when defining a specific relationshipJulien Nabet
Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging. /usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy- construct an iterator from a singular iterator. Objects involved in the operation: iterator "this" @ 0x0x7fffffff3a30 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = past-the-end; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } iterator "other" @ 0x0x7fffffff3a90 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = singular; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } 4 0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121 5 0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179 6 0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340 7 0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342 Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62 Reviewed-on: https://gerrit.libreoffice.org/14325 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05Remove uses of deprecated salhelper/refobj.hxxStephan Bergmann
Change-Id: Ibf4a2ed99024568b2d370b22919e3a25c43c6fbf
2015-02-05-Werror,-Wformat-securityStephan Bergmann
Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d
2015-02-05tdf#84102: Expose XAccessibleExtendedAttributes through ATKJacobo Aragunde Pérez
Those attributes contain a lot of interesting properties, among them the heading level which fixes this bug. Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05callcatcher: update unused codeCaolán McNamara
Change-Id: I540d192a361938cd4dca811e7170d762841662ee
2015-02-04fix leak from framework::AddonMenuManager::BuildMenuCaolán McNamara
provide a callback when a menu item gets deleted Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
2015-02-04discard excessive (X11) autorepeat keyboard events if they overload LOLuboš Luňák
If e.g. a document is slow to redraw, scrolling it by holding down a key such as PageDown can make LO lag behind and continue processing the queued up input events even (long) after the key has been released. Since with autorepeat keyboard events the normal user expectations are to hold it until something happens and the exact number of the events doesn't matter, simply discard excessive autorepeat keyboard events if LO can't keep up with them. Change-Id: I45acdc9aa5033647fb80760991437dddfcb6591c
2015-02-04compress (X11) mouse wheel eventsLuboš Luňák
There is one event per wheel step, so wheeling more can create a number of wheel events, and LO processed those one by one. If processing one took long (e.g. the repaint was complicated), the scrolling visibly lagged. This commit works only for X11 VCL backend (and by extension, KDE3/4 backends). Change-Id: I5eff7446da16167ec75925e75243314c68bc81a4
2015-02-04make idle timers actually activate only when idleLuboš Luňák
Without this, they can activate after any call to the event processing, so they may activate in cases such as when updating progressbar while loading a document, or on repeated user input (so things like showing spellchecking get updated when the app is busy redrawing). This change makes idle timers activate only when there's nothing more for the event loop to process. It's a bit of a question if this doesn't break something that happens to expect idle timers to be not-really-idle timers, but oh well. No change for non-X11 platforms, as there's I don't know how to check the event queues. Change-Id: I074a88f2f5eeb4b456a11916a0ec2ad6f54dfbab
2015-02-04coverity#708576 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8810389998fdcf43c55db7e6cd1acd8600e91e2b
2015-02-04coverity#982431 Division or modulo by float zeroCaolán McNamara
Change-Id: Icb43cae170b8ca5dc3ef3379136d265869eb978e
2015-02-04coverity#1268022 Logically dead codeCaolán McNamara
Change-Id: I49a058915f0fd7caaa3793e70784a30efcac15d3
2015-02-04coverity#1268025 Uninitialized scalar fieldCaolán McNamara
Change-Id: I36b72abc7021aa9a0f64f4a2ac71a7eedd75f6ec
2015-02-04coverity#1268025 mnOrigHeight and mnNewHeight is unused nowCaolán McNamara
Change-Id: I242a332adf9961881599ba048f8f63b2711e8b4d
2015-02-03GlyphCachePeer::mnBytesUsed is always zeroStephan Bergmann
...at least since 1c064d1460fbf84a2fc6c2cdc7824937735a4312 "I don't see that any of this makes sense anymore" removed the last uses of it from X11GlyphPeer::RemovingGlyph. Change-Id: Ic8c879ac6023a1e796da220dd61dc33750aaad60
2015-02-03valgrind: glXChooseVisual says to use XFree to free its returned dataCaolán McNamara
Change-Id: I4949b9daaae183efcbab21dafca0c84838c2c6d0
2015-02-03WaE: variable 'kind' set but not usedTor Lillqvist
Change-Id: I5078e0e4df18d0aece3240dc537504c11cd623de
2015-02-03Initialize graphics in OutputDevice::getFallbackFont.Ashod Nakashian
OutputDevice::getFallbackFont requires mpGraphics to be created/initialized. Without the check and initialization OutputDevice::getFallbackFont will segfault. Change-Id: I18225a24a6767933c8f1ff8f1cfd392543a95132 Reviewed-on: https://gerrit.libreoffice.org/14287 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Fix for unaddressable access reading TT font data.Ashod Nakashian
As part of commit 'fdo#82259 we don't actually care about the ttf version here' the font data table pointer was incremented presumably to skip the version number. This results in reading past the end of the array, confirmed by DrMemory. There is no need in changing the pointer as the parsing is done using absolute offsets. Furthermore, by moving the pointer, the parser reads incorrect fields (everything shifted 4 bytes). However, moving the pointer had the desired side-effect (at least on Windows) that the hints on the right side of most of the fonts were gone for most cases (the purpose of fdo#82259). It seems that this was accidental and not the proper fix to that issue. This patch does make most of the hints show up again on win, and I don't have a mac to verify if the fonts with the nonsensical hint texts still suffer the issue in fdo#82259. Change-Id: Idf3bfa292fa063fa05e0ff62920a6bdfa4c94647 Reviewed-on: https://gerrit.libreoffice.org/14281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Don't call touch_ui_*() API that are no-ops anywayTor Lillqvist
Theiry implementations were empty both for iOS (well, TiledLibreOffice, our iOS test viewer app, anyway) and Android. Part of work to make TiledLibreOffice use LibreOffieKit instead of <touch/touch.h> and the older Writer-specific tiled rendering API. Change-Id: I602a1ebd58ec2c8d6b2d170d65e157d91e0bf521
2015-02-03vcl: Remove commented-out codeAdolfo Jayme Barrientos
Change-Id: I4bd2cf8a920c119d508e3316107fa2a616472ba2 Reviewed-on: https://gerrit.libreoffice.org/14259 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-02crash on toggling "empty" menu in basic's language toolbarCaolán McNamara
tools->macros->organize->basic->edit drag language toolbar to undock, click down arrow in pseudo-title bar to get "no selection possible" entry. click down arrow again to dismiss it. get debug stl iterator error the mpSalMenu goes out of sync with its owner Change-Id: If82aac004e623787389dd415c2006b99778f710d
2015-02-02don't need this caseCaolán McNamara
Change-Id: Ib4445031b62248207e3eee257e2b71c446aa5b9d
2015-02-02coverity#1244944 Untrusted value as argumentCaolán McNamara
Change-Id: If50a20e9fbb0bf55488b3ccc8ea28f2a54aa62e0
2015-02-02coverity#1242704 Untrusted loop boundCaolán McNamara
Change-Id: I88c8ff03361aa83b23c811b5d693864360f31f7f
2015-02-02coverity#736943 Untrusted loop boundCaolán McNamara
Change-Id: I18a19770f7bb328b889b8da1fb73d20bc1ca9064
2015-02-02vcl: add SAL_OVERRIDE attributes to Windows-specific classesNoel Grandin
and fix a bug where SalObject::Enabled(bool) should be virtual, introduced by my commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 "new loplugin: change virtual methods to non-virtual" Change-Id: I08cdddb36eed887ea7bd01f6260fa5fd89d12429 Reviewed-on: https://gerrit.libreoffice.org/14273 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-01coverity#1267676 Identical code for different branchesCaolán McNamara
Change-Id: Ia7abc084acb0f9e8a25e93fa86bf254eee7cda21
2015-02-01help coverity out wrt coverity#1267682 String not null terminatedCaolán McNamara
Change-Id: Ib72c0daf8573314d601d7acea3a1fbb3183b4bb6
2015-01-31coverity#1267670 Division or modulo by float zeroCaolán McNamara
and coverity#1267699 Division or modulo by float zero Change-Id: If31037712208673438155b30369ebe1068387cba
2015-01-30chisel off some more unused codeCaolán McNamara
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-30fix buildMarkus Mohrhard
Change-Id: I8cea0324a6bee716dd352e5a21f5e5444872760b
2015-01-30vcl: add GenericSalLayout::GetTextRect()Chris Sherlock
I have extended GlyphItem to also record the original and new height, along with the y offset. Change-Id: I1e9646a8f0d844951d5533d035d9a16dbc8e257c Reviewed-on: https://gerrit.libreoffice.org/14216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-01-30vcldemo: more text changesChris Sherlock
Changes: + Move the rotated text down the screen to show more of it. + Only one colour (black) + Only one line of text now + smaller font size + fixed issue caused by not resetting clipping area at the right time Note that the old changes can be brought back easily by changing a hardcoded variable in the source. Change-Id: I5b0688af0f344f89cd252d43b1b8964b0c456bef Reviewed-on: https://gerrit.libreoffice.org/14247 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-01-30vcl: OpenGL code for adding preambles to glsl fragments now handles #versionChris Sherlock
If you include the #version directive then it must be on the first non-comment line in a glsl fragment. This is now handled. Change-Id: I7e938c27b24d20f25e656667a122d7a341f51611 Reviewed-on: https://gerrit.libreoffice.org/14246 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29images: Don't fallback to indrustrial, it's merged to tango during build.Jan Holesovsky
Change-Id: Ie361365e65626b0118393960e381aff9745af83d
2015-01-29vcl: copy-pasted SAL_WARN_IF conditionMichael Stahl
Change-Id: Icb0109b954b9a7710309cc9bca30309a6ec90a73
2015-01-28fix crash in vcldemoMarkus Mohrhard
Change-Id: Id502a36ece4ecc4551ee67f1818fb9886d6e0ce5
2015-01-28loplugin:cstylecast (Mac OS X)Stephan Bergmann
Change-Id: If1fd605c01fa892c7730930606a29a7bed9edb5e
2015-01-28Some more loplugin:cstylecast clean-upStephan Bergmann
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
generated by cgit (git 2.34.1) at 2025-02-14 21:22:09 +0000