summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-10-15coverity#704088 Unchecked return valueCaolán McNamara
Change-Id: I0fc00b445db0a6254adbfa335e6971c6787109d5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15Resolves: #i63015# always default to WinAnsiEncoding...Herbert Dürr
for non-symbol PDF-Type1 export Suggested-By: edv@gruene.de Reviewed-By: hdu@apache.org (cherry picked from commit b8186703cb43d2b57460cb23a7a4e3f989e95426) Conflicts: vcl/source/gdi/pdfwriter_impl.cxx Change-Id: I02227724bff301133ac8ce5562ec5ca1ed94f136
2014-10-15Resolves: fdo#85032 max len property of -1 -> crashCaolán McNamara
Change-Id: Ief903c619204f01784e93fd5e2d582632cef032e
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15vcl: cleanup salgdi.hxxChris Sherlock
Change-Id: Iced928a97afdc30e8cb1e24dd148c8b838e8eb72
2014-10-14vcl: re-factor scaling to use a single fn. pointer based invocation.Michael Meeks
Change-Id: Ide61808dbfa82ce67794150f44b6bac4f3c8e302
2014-10-14vcl: Re-factor to use the ScaleContext to pass parameters.Michael Meeks
Change-Id: If4359a6b776b4a94a6934e9fd02ede475a0612a7
2014-10-14vcl: create a ScaleContext to share copy/paste Bitmap scaling code.Michael Meeks
Change-Id: I5a90b7c6065829d74c61b833f0551b8adc3f2711
2014-10-14vcl: hide bitmap helpers in an anonymous namespace.Michael Meeks
Change-Id: I96ad50f538cfb6ecd256c4268feb81796a135b2b
2014-10-14basebmp: accelerated method to create a clipping device.Michael Meeks
This was some staggering proportion of tiled rendering documents with complex clipping; it seems 'clear' is not what memset is for 1bit clip masks. Change-Id: I9142ffb7d7016603feb7782d6f03b9992b9494e3
2014-10-14vcl: warning C4717: GetCharCount() recursive on all control pathsMichael Stahl
Change-Id: Id86dcd2c701510ce15cc2cf71e35c1d908ec6049
2014-10-14vcl: cleanup salframe.hxxChris Sherlock
Change-Id: I0f331a2589d0fab5cf3843bf7531333e07067997
2014-10-14vcl: change to css alias namespaceChris Sherlock
Change-Id: I4af1bd5cd1d614ca92cf843ad7fa5bb518829f89
2014-10-13valgrind + bff, multiple failures, initialize ref counts to 0...Caolán McNamara
for boost::intrusive_ptr ==6595== Conditional jump or move depends on uninitialised value(s) ==6595== at 0xB21664D: intrusive_ptr_release(FontCharMap*) (metric.hxx:226) ==6595== by 0xB2172F6: boost::intrusive_ptr<FontCharMap>::~intrusive_ptr() (intrusive_ptr.hpp:97) ==6595== by 0xB5AE196: FtFontInfo::GetFontCharMap() (gcach_ftyp.cxx:1287) Change-Id: Iea5ab13b093945c840481f29bc626a16dcbc234b
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13Quit after 100 roundsTor Lillqvist
Also, print the timing output to stdout, so that one can run the time command on this, redirecting the program output to /dev/null, and just see the 'time' output. Change-Id: I4b2bfe7f0d37746fe0a015b961512850a880560c
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-13Make the image continuously resize back and forth in both casesTor Lillqvist
Change-Id: Ia543e5355c8d6a7712bf6f10c989945ff830627d
2014-10-11vcl: whitespace cleanup.Michael Meeks
Change-Id: I0e61ecfc32f13bba0fa992689604c8b79e6139e9
2014-10-11coverity#735621 Division or modulo by zeroCaolán McNamara
Change-Id: Ic92bb6946495124d50e57c2c84995cae6465af92
2014-10-11coverity#1242425 Dereference after null checkCaolán McNamara
Change-Id: I638d1601ac6cb5e43ee60f60869f6128060e6d05
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10Print out the timing results unconditionallyTor Lillqvist
Because that is after all what we are after here, and we want them even in a non-debug build. Change-Id: I4770f6b0420b2a65ccc813f0e400cbb39b0d44fe
2014-10-10Add some silly looping and timingTor Lillqvist
Change-Id: Ibfb77e7d5fb32c317e773851536444679e5b65fa
2014-10-10coverity#1242714 Untrusted value as argumentCaolán McNamara
Change-Id: I1524722feae3ad9f67627cb34dec83632edefec4
2014-10-10coverity#1244944 experiment to silence Untrusted loop boundCaolán McNamara
there's a warning for nPolygonCount but none for nPointCount. I wonder what happens if I tweak the code like this Change-Id: I7e1b02c4790f6b2d1c59e38de1a6a0b17a0485b1
2014-10-10More hacking on 'icontest'Tor Lillqvist
What we want is to test is not loading and displaying many images. It is just to test just one. So simplify. (Yes, the name 'icontest' is even more misleading now.) Check whether the OpenGL context supports non-power-of-two textures, and also check the maximum texture size, and scale / pad appropriately. Change-Id: I02bccd33e08749d972652173a881aa40870c12d8
2014-10-10typo: follwing -> followingAndras Timar
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-10Use gb_Executable_use_system_win32_libs for MinGW's sakeTor Lillqvist
Change-Id: I9a8ead19e6caa33d7941f11d0d9b5a1ad98ed661
2014-10-10coverity738920 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic1571d24a8a696dc24b899d262b9e560d005ee88
2014-10-10coverity#1242439 ALPHABITS == nAlphaShift == 8Caolán McNamara
Change-Id: Ifde395113524df03a2523115ab2234403d405455
2014-10-10drop unused ImplBlendLines templateCaolán McNamara
Change-Id: Id680f6031d40f086e74472d14fbf70cbf8cc43a1
2014-10-10coverity#736943 try another experimental warning workaroundCaolán McNamara
Change-Id: I4fc951e21915f7cbb03ee10fd2c9c4977a2f510a
2014-10-10coverity#1244943 Resource leakCaolán McNamara
Change-Id: Ibee999fada60eed067d0d4e44a94294084529294
2014-10-10Fix fdo#84795 Menu, DropDown-List not disappears with right mouse clickJuergen Funk
Set for menu and float-list-box the PopupModeFlags to FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK + FLOATWIN_POPUPMODE_ALLMOUSEBUTTONCLOSE Improving the comments Change-Id: I313e4ec38637fa3d46567e08bdb9560ce8475b6a Reviewed-on: https://gerrit.libreoffice.org/11881 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-10Build icontest for OS X, too. Does not work at all, thoughTor Lillqvist
Change-Id: Id1c82638f12514f55f297ec5e4a07444849175ce
2014-10-10Build icontest for Windows, tooTor Lillqvist
Change-Id: I7c23d9a41c9b517bf8dcdd3e1de2ab24a8a1d0d0
2014-10-10Add informative comment, and use 'auto' in a couple of places where sensibleTor Lillqvist
Change-Id: Ia01404f8d0a5e5aa94d8a9b3f45421950831c5cb
2014-10-10move TRANSPARENT #define from windows.h out of global namespaceNoel Grandin
so it doesn't conflict with enums Change-Id: Ic4143130762d6e878d7c23276393ba09d9f86d45 Reviewed-on: https://gerrit.libreoffice.org/11880 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10vcl, sd: fix some TempFile leaks from vcl Graphic in cppunit testsMichael Stahl
The problem is that utl::TempFile::GetURL() will return an empty string if the file UCP is not available. There will be an entry in the log file: warn:legacy.osl:25344:1:ucb/source/core/provprox.cxx:366: UcbContentProviderProxy::getContentProvider - No provider for 'com.sun.star.ucb.FileContentProvider. Change-Id: I2741a04cf4b8b420294ae521199706921b37e5c6
2014-10-09move copy of icu's ScriptRun into vcl namespaceCaolán McNamara
Change-Id: Idbd3f3e903d6e411d565d29884e52862c3e1cc58
2014-10-09convert BKMODE #defines to 'enum class'Noel Grandin
mostly to get the TRANSPARENT #define out of the global namespace Change-Id: Iec592d26d4d12b5f30f7f9a04dd377a1fb20d643
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09Resolves: fdo#84809 crash when button is too short for textCaolán McNamara
regression from 4c539fac018dfd44cd8db52161a8cb930c627da7 commit 4c539fac018dfd44cd8db52161a8cb930c627da7 Date: Tue Dec 17 05:18:35 2013 -0600 vcl get rid of xub_StrLen and STRING_LEN in outdev3 before this there was a dubious cast which hid the problem Change-Id: I7c01c0f0ac211196a62acaf02297f29ae829403d
2014-10-08More hacking on the 'icontest' test programTor Lillqvist
Use correct aspect ratio for the images. Change-Id: I99c676c8c843c48633b5f17fd9333d0e0af4753f
2014-10-08Store the image bitmaps in MyWorkWindow in the OpenGL caseTor Lillqvist
Change-Id: I1acac06f076a4f8173929a0fe0c0d9eaf6b8d1ff
2014-10-08coverity#704183 Resource leak in objectCaolán McNamara
Change-Id: I64b995c15a83d71aaa6745323141e71cc55cf000
2014-10-08coverity#1066165 Resource leakCaolán McNamara
no close on error paths Change-Id: Ie544bcd6ea7224bee2a092013a589c509d42c735
2014-10-08vcl: make IconTestApp build with gcc 4.6Michael Stahl
Change-Id: I5897a774b8949f336a40096a0727a347bae012ac
generated by cgit (git 2.34.1) at 2025-03-04 18:32:29 +0000