summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2023-05-23Resolves tdf#145080 - Use accent color for focused cellHeiko Tietze
Accent color added but effectively working only on macOS See inline comments for gtk, qt, and win Change-Id: I1e4a729331735683921f94b27bb2bb02555c0165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-21Revert "tdf#63130 when getting the size, do not do a full paint"Caolán McNamara
because it is triggering many CppunitTest_toolkit_a11y failures This reverts commit 67c3b3becab2aa2b9522e3a092d46bfe507c3101. ImplCallResize is not called on the same Window after that commit than it was originally called on. Change-Id: I0c3721d2674067ac7f0bf765e0fe1097b1d67dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-21Simplify a bitMike Kaganski
Change-Id: I4be66ff1ea2a15d3345134f4131bd0fabb5de9ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152028 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ief95f111350808f010539bb733a553007d30a9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-20loplugin:unusedfieldsNoel Grandin
Change-Id: I5036b484055e516fd808428238a044e12d34e089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-19loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3a3d4debd83f1a6452721ce704b6b88622b38109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-18CppunitTest_vcl_filters_test: just pass the file name as parameterXisco Fauli
Otherwise these files would be flagged as unused Change-Id: I3203ef7820a6e5b31d48578d9184b5822836f27c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151940 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-18tdf#63130 reduce large memory copies when reading from BinaryDataContainerNoel Grandin
rather than writing a bunch more code, extract the common part from comphelper::SequenceInputStream into a new base class Change-Id: I0d3561e3ca2e748b904128e3b5955e27196d7170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-18Fix typoAndrea Gelmini
Change-Id: I89d8b370cf95d43de33c35b788fc955adfb85a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151948 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-18tdf#63130 reduce duplicated work when pixel snappingNoel Grandin
Cache the calculations so we don't repeat work unnecessarily. Shaves 5% off load time. Change-Id: Iffbdd08768fea5b25ac83926b812067f52cba3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17vcl: fix crash in Window::GetOutDev()Miklos Vajna
Crashreport signature: program/libmergedlo.so rtl::Reference<vcl::WindowOutputDevice>::get() const include/rtl/ref.hxx:208 program/libmergedlo.so vcl::Window::GetOutDev() vcl/source/window/window.cxx:574 program/libswlo.so SwViewShell::ImplEndAction(bool) sw/source/core/view/viewsh.cxx:294 program/libswlo.so SwViewShell::EndAction(bool) sw/inc/viewsh.hxx:611 i.e. GetOutDev() is called on a disposed vcl::Window. Change-Id: I5b17225fced85c6804fc93fd12021c92966d3aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151857 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-17tdf#63130 when getting the size, do not do a full paintNoel Grandin
otherwise we end up doing double work when called from ImplWindowFrameProc, which is the main driver of painting on the screen This reduces the load time by 10% Change-Id: I9eb82a180344875f707fbf3d8128351a35def6a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17menus all black with SAL_RTL_ENABLED=1 and SAL_USE_VCLPLUGIN=genCaolán McNamara
export SAL_USE_VCLPLUGIN=gen export SAL_RTL_ENABLED=1 run writer and the menus are all black a problem since: commit 622e8cd9e5c96d0fe0bb02e07d95efa93c156c44 Date: Wed Jan 11 11:00:43 2023 +0000 reuse CairoCommon GetGraphicsWidth from X11CairoSalGraphicsImpl so restore the use of mrParent.m_pFrame as done in original implementation Change-Id: I21f76b2e57b7ea6d910552d3b07830811152bfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-17Silence loplugin:external and lopluign:unreffun in (WIP?) a11y.cxx for nowStephan Bergmann
Change-Id: Iea207bca4fee57e8c7dd5d307ccd42efc0dd2542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151866 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17Avoid loplugin:unreffunStephan Bergmann
> vcl/unx/gtk4/a11y.cxx:295:1: error: redundant function redeclaration [loplugin:unreffun] > G_DEFINE_TYPE_WITH_CODE(LoAccessible, lo_accessible, G_TYPE_OBJECT, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:1730:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE' > #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_) _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END() > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:2213:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN' > _G_DEFINE_TYPE_EXTENDED_BEGIN_PRE(TypeName, type_name, TYPE_PARENT) \ > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:2160:17: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_PRE' > static void type_name##_class_init (TypeName##Class *klass); \ > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > <scratch space>:47:1: note: expanded from here > lo_accessible_class_init > ^ > vcl/unx/gtk4/a11y.cxx:236:13: note: previous declaration is here [loplugin:unreffun] > static void lo_accessible_class_init(LoAccessibleClass* klass) > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I22bad5cf5e546d3a4dff4c1de3b3bb06638d1200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151865 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17loplugin:externalStephan Bergmann
"externally available entity '...' is not previously declared in an included file (if it is only used in this translation unit, make it static; otherwise, provide a declaration of it in an included file)" Change-Id: Id53a4fd0b01ea7a91735231750c32200ea1529b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151864 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17loplugin:reservedidStephan Bergmann
Change-Id: Ia24f5214f44a5ef4f5ac4397b8adcd6d46a99676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151863 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17loplugin:fakeboolStephan Bergmann
Change-Id: I8c7fe59223dfda4c376e50bb4b6fedee341bd85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-16Resolves tdf#155278 - Adjust minimum statusbar height according iconsHeiko Tietze
Change-Id: I7dbcf35f338bfe87702afb45651cd99630efe875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151768 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-15tdf#155143: blacklist 3 Nvidia cards for Skia hardware renderingJulien Nabet
GeForce GTX 1660 SUPER (516.376.0) GeForce GTX 970 (531.272.0) Quadro P400 (516.376.0) Change-Id: I2ba3cc33dabcbd821459493ae94bdfbb130653de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151801 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-15LOK: Navi-1 open/close on sidebarAttila Szűcs
Enabling Navigator sidebar in case of LOKit. Change-Id: I3a656fa12822e5866c2cd4fbf82627a88f26903a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151307 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151704 Tested-by: Jenkins
2023-05-15Resolves tdf#155070 - Easy access to skia.logHeiko Tietze
Change-Id: I2aac7a060bbb1d31510da67120728c8a24f0de88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151699 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-13tdf#148251 qt: Use std::swap instead of using temporary valuesDr. David Alan Gilbert
Another std::swap case in drawLine Change-Id: I207fe3c8c6c88532c23faf3aa3188acdcda3a5b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151654 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-05-12ofz#58883 Out-of-memoryCaolán McNamara
Change-Id: I91de8f537ae237de814ed7e933fb6d0a3cc98466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-12LOK: Navi-4 tree dblclickAttila Szűcs
Removed sendUpdate that was called 1/sec, so selection dont revert 1/sec. Put sendUpdate into set_cursor(), that seems to be a better spot. Fixed set_cursor usage in executor, that caused slection to not work in dblclick at all. Because set_cursor(int) use not absolute position, but relative to parent And root was used as parent, so it picked SwContent from the 1. lvl, but the 1. lvl items are not real items, just SwContentTypes .. e.g.:Headings.. that cannot be activated.. so never happened anything. Change-Id: Iea373af3a0832a4f97202122bd36022eddf26efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151308 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151703 Tested-by: Jenkins
2023-05-12LOK: Navi-6 page selector SpinFieldAttila Szűcs
Grab the focus back to the spinfield in sidebar, so the document will be able to scroll to the right page. It seems there is a condition check, on move to page, that focus must be not on document, or else it does not move. AFAIK in lok code we dont try to simulate the focus of the core, but maybe we should, for cases like this. Change-Id: Ie9a30e6bd944cfa1729861eb0ac1924b946f4185 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151309 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151701 Tested-by: Jenkins
2023-05-12tdf#155228 vcl: PDF export: /Tabs needs PDF name, not stringMichael Stahl
(regression from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9) Change-Id: I5ccc37cd538448b2cb9db594287b49869589b2db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151700 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-12jsdialog: enable image properties dialogsSzymon Kłos
Change-Id: Id3bf64e38093e7c068871029599a13f64891b6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151557 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151693 Tested-by: Jenkins
2023-05-12jsdialog: don't send full update on message dialog closeSzymon Kłos
this fixes regression introduced in: commit 09976bda9c196b2426b8826941f21384a58bf536 jsdialog: don't close dialog on tab page destroy when enable macro warning was shown it required to close manually the dialog with 'x' button because after click on "enable' or 'disable' it wasn't closed Change-Id: I4741a874f93481ad03d043349520a1bf91a882be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151694 Tested-by: Jenkins
2023-05-11move xmlSetGenericErrorFunc into LLVMFuzzerInitializeCaolán McNamara
and add xmlInitParser there Change-Id: Ifde0f8d9e8be413fd3dcf216ad33effa731fa549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151684 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11libxml2's fuzzers call xmlResetLastError so do that tooCaolán McNamara
Change-Id: I6a422be17569340865d8799a74dbc5a9867b7562 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151683 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11tdf#155241 keep current MetricSpinButton value if unparseable junk inputCaolán McNamara
Change-Id: I0f13c9ae25c1788924fd81ed77307e96400f6220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11cid#1529966 silence bogus Resource leakCaolán McNamara
Bitmap::ReleaseAccess(foo) is just delete foo, so null is fine there anyway Change-Id: I18143c9cf0c63e985866276273b099f5d3b8d5a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11ofz#58818 Direct-leakCaolán McNamara
Change-Id: I8974b998397aa521c9ee61651b5ce45d4189b303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151662 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-11tdf#97228 Move MenubarValue class to separate include fileanfanite396
Change-Id: I5da4bb1765f91d1f9d78e27221d243d5c2ef92e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149076 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-10tdf#152173 Don't display tooltip windows when mousing over non-key windowsPatrick Luby
Don't display tooltips when mousing over non-key windows even if the application is active as the tooltip window will pull the non-key window in front of the key window. Change-Id: I425b9af09de0272ebee84a218e2e5ae8c200a4e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151646 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-05-10ImplPrintTransparent is always called with an empty maskNoel Grandin
which we can use to simplify it Change-Id: I8fa38a9f414d8d720e31bd1f71fd722f6a95fdbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151635 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-10AlphaMask::BlendWith wants an AlphaMask parameterNoel Grandin
so make it so Change-Id: Ia5a91c78d2fd10f22eb19e4ebbd753151149190f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-09Resolves: tdf#142176 under GNOME inhibit logout if there are modified docsCaolán McNamara
and if we are forced to quit anyway, unset modifications on documents and terminate. Change-Id: If4a3aed48a4621950e2d630fdfef34b28ba1b089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09drop unused ImplPrepareExitMsgCaolán McNamara
Change-Id: I9254328829ac051524fbfdf6a3b5b2f72b12c427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09increase max_len for fodt2pdffuzzerCaolán McNamara
Change-Id: Ib8c3c0e35c6a7cc8b3b40fce4f89c038e819f088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151587 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09Related: tdf#142176 rearrange screensaver inhibiter to be more genericCaolán McNamara
and for not-x11 I see gtk just uses 0 for xid (which is called window_system_id there now) Change-Id: I9248bcceaa2d21d34133dea80697776df0aa8c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151560 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09Related: tdf#142176 document what the other inhibit options areCaolán McNamara
via an enum like the gtk one so it can be seen how to inhibit logging out due to unsaved changes Change-Id: I07609cfb7a97b5b6c1b94a09b7b79bcca308d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151559 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09ofz#58756 Integer-overflowCaolán McNamara
Change-Id: Ie2782c1d68f73e5e88cf868eb1ce106ec0c181b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151558 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-09tdf#155186 crash Inserting tables and switching slides (gtk3)Noel Grandin
regression from commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 4 10:06:14 2023 +0200 tdf#105404 [API CHANGE] add index to accessiblity change event where something is forgetting to send events for some of the changes, so just ignore a bad indexhint here Change-Id: I9228b480be10b2f267c2a76cb30a9faf1476639e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-08tdf#155161: Always embed fonts with CFF2 table as PDF Type 3 fontsKhaled Hosny
PDF doesn’t support CFF2 table and we currently don’t convert them to Type 1 (like we do with CFF table), so treat it like fonts with variations and embed as Type 3 fonts. Change-Id: I963b55d5d0ed1470eda157c7e10cae63195a0c91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151532 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-05-08unique_ptr->optional for BitmapNoel Grandin
since Bitmap is really just a tiny wrapper around SalBmp Change-Id: Ie2c9be40f6abba72c600c6778ec42d0689c66558 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07use AlphaMask for variables when calling GetAlphaMaskNoel Grandin
Right now this doesn't make any difference, since Bitmap is the superclass of AlphaMask. But when I switch to using alpha instead of transparency, passing AlphaMask around is going to mean something different to passing plain Bitmap around. Change-Id: Ic1541e5f0a3b97331793cd23e23115faa7f382b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07simplify codeNoel Grandin
The BitmapEx constructor already does this check, no need to do it here Change-Id: Iacd0e1b1d4aa3dfae120e0d4a60a6924ecd9f778 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-07crash seen with empty moLineColor on macOS with skiaCaolán McNamara
Change-Id: I260f6bd060b9f1ec3a782ff765b676f78d126d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>