summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2023-01-29Add dropdownfielddialog.ui to JSON dialogues.Gökay Şatır
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I4cfc792f0b1269936723285cc5ff1324bc22c161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145871 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 23e6f05a8ee80c33dd624dd6582f26b3dcf8f490) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146212 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-28Fix typoAndrea Gelmini
Change-Id: I45f5252291875b8e3dbf8f39f304e3a3f77a9f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146289 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-28Make minvcl and svdemo VCL examples build on WindowsHossein
Previously, minvcl and svdemo VCL examples were not built on Windows. With this patch, both of the minvcl.exe and svdemo.exe are built on Windows. To run, one can invoke: ./bin/run minvcl and: ./bin/run svdemo Change-Id: I43bfb314b41c662250615486a3ca783fc6d82600 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146264 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-28Add exception handling to minvcl, minify codeHossein
Improve minvcl example: * Add exception handling * Minify code by removing custom Window Change-Id: I1f1dc10c05812b4cfad7d38e09d7ecd26bec35b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143650 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-01-27Remove support for AIXStephan Bergmann
As discussed in the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html> "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)", the bridge implementation at bridges/source/cpp_uno/gcc3_aix_powerpc is apparently dead and should thus be removed. However, that was the only bridge implementation for AIX, which implies that support for the AIX platform as a whole is dead and should thus be removed. Change-Id: I96de3f7f97d4fd770ff78256f0ea435383688be9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146057 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26tdf#147342 Notify Skia that the window's backing properties changedPatrick Luby
Change-Id: I4185a240a2ca6df1c92e86ff9950f86234d4ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146142 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-25ofz#55392 Out-of-memoryCaolán McNamara
Change-Id: Id1a351e25c3dcbff513357bb3ff4370e1430ff68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146147 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25ofz#55389 Integer-overflowCaolán McNamara
Change-Id: I98bd62634ca054a668513df426fca408c78e7c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25Revert "Update skia to m110"Stephan Bergmann
This reverts commit aef70869b0fae3001648ec2a2651ffc9c507678f plus follow-up 4172fcb7514ff8a9e9740ff0939e9a2f611edbce "Fix no-pch Windows build: missing include". It caused my Windows build `instdir/program/soffice` to immediatley fail with > skia\include/core/SkRefCnt.h(62): fatal error: "assert(this->getRefCnt() > 0)" > warn:skia:10572:7804:external/skia/source/SkMemory_malloc.cxx:32: sk_abort_no_print on start. Change-Id: I751f83eda28d9a5a8f9dd4b2429389906ffce983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146132 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25Update skia to m110Noel Grandin
Removing those bits of the patches that appear to have been upstreamed. Change-Id: Ia7683c26af4c622ca4fccb828df023ae30e724a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146069 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-24tdf#152404 crash with ibus-mozc with ctrl+alt+c during ExtTextInputCaolán McNamara
Change-Id: I86e19387d93a57c3ad263f0c2dc9222a5f3480be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24tdf#152404 crash in Windows with ctrl+alt+c during ExtTextInputCaolán McNamara
Change-Id: I73ed19eeae49ef737aae372b8f4c053f67a169c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24tdf#66580 write ODF document as an attachment in hybrid modeTomaž Vajngerl
This changes the hybrid mode so that the ODF document is written as an PDF compatible file attachment into the PDF document. It also keeps writing the /AdditionalStreams element into the trailer to keep backwards compatibility for now. Change-Id: Ica31159cfbd591c6741e3da62c42d1fefd085696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146053 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-23[API CHANGE] sd::frame::Configuration does not need to be an UNO serviceNoel Grandin
It does not ever appear to have been used as such, and it makes no sense to be constructed externally. Change-Id: Ia1a0cccdaeb19ded1197ad8aae701ac86dd3bb48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145989 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-23XUnoTunnel->dynamic_cast in vcl::GraphicNoel Grandin
Change-Id: Iecbae3570851784f0da75fd2899daf620c8e4c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20tdf#148453 Fix crash by turning off optimization for Objective-C selectorPatrick Luby
The default attributes sequence sometimes crashes when it is released but only when compiler optimization is enabled, so disable optimization for the +[AquaA11yTextAttributesWrapper createAttributedStringForElement] selector. Also, disabling optimization by itself is apparently not enough to stop the crashing. Acquiring the solar mutex during native accessibility calls is also needed. Native accessibility calls are called from native input sources in [NSApp nextEventMatchingMask:untilDate:inMode:dequeue:]. Since AquaSalInstance::DoYield() releases the solar mutex before calling [NSApp nextEventMatchingMask:untilDate:inMode:dequeue:], we need to always acquire the solar mutex during all NSAccessibility selectors (both the old informal protocol and the newer formal protocol) that we implement. Change-Id: I9b715e17e9c5a32b7ce28815e288b2af236c3cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145742 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-20[API CHANGE] remove unused SlideSorterServiceNoel Grandin
which was introduced in commit 8c4d7aa42dd4b3b08c3b4a9e4ba772737b7bd0c4 Author: Kurt Zenker <kz@openoffice.org> Date: Thu Apr 3 13:42:43 2008 +0000 INTEGRATION: CWS presenterview (1.1.2); FILE ADDED but does not appear to have ever been actually used. Change-Id: Icd33f81cfee246fe72a4b9e584f7a6ca96d6e38b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20[API CHANGE] PresenterTextView UNO service is deadNoel Grandin
Nothing constructs it, and it looks like it was never fully hooked up, various bits of it have been removed, starting with commit a38cbc58bbe3b385830a5287ea272e28a8ae3652 Author: Felix Zhang <fezhang@suse.com> Date: Mon Oct 24 17:50:01 2011 +0800 remove unused methods from sdext:presenter Change-Id: I61080fa589ab6b886b841d7be5eed892c4bd829a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145898 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-20Fix typoAndrea Gelmini
Change-Id: I97309a5cf314b08547ac535a2d1baa6e8b7d064c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145910 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-20Base GraphicDescriptor on OWeakObjectStephan Bergmann
...rather than on the legacy OWeakAggObject. It was found that e.g. Graphic, deriving from GraphicDescriptor, was implementing queryInterface in a way that is incompatible with XAggregation protocol inherited via OWeakAggObject. It looks like no code actually made use of the XAggregation offered by this class hierarchy, so the easiest fix for that queryInterface implementation appears to switch from OWeakAggObject to OWeakObject. Change-Id: I54514db32b731b9fa83831a1071da6f665fdf25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-20ofz#54685 TimeoutCaolán McNamara
Change-Id: I2f71f61c371055521c884a00dde48a811d204df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-20ofz#54895 Out-of-memoryCaolán McNamara
Change-Id: I2faf68d8ed56e7d2b44bc7cae953716ea6dd7172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-20tdf#147906 Use std::hypot for Pythagorean additionektagoel12
Change-Id: I4b16fc7daff2f85ae60666e512636634f7d6eb19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145822 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Hossein <hossein@libreoffice.org>
2023-01-20tdf#149412 gtk3: show all selected rows in dnd iconCaolán McNamara
otherwise it looks like only one row is getting moved Change-Id: Ie0b63a9c3cea377c3753785d9c6f7958cbc7ac1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-20tdf#153047 sw: fix PDF export of content controls in placeholder modeMiklos Vajna
Importing an inline content control from DOCX used to be just plain text in Writer, so the PDF export of that was also just plain text. Now that content controls are actually supported, we used to not emit them as plain text in the PDF export, since 82d90529dc2b3cb8359dec78852cbd910a66d275 (sw content controls, rich text: add initial PDF export, 2022-09-12). Part of this was to write the string value of the content control as the /V (value) key of the form, when it's not in placeholder mode. This made sure that once the form is filled in, no overlap between the plain text and the filled in text happens. Try to support both use-cases at the same time by also mapping the value of the content control to /V, even if it's in placeholder mode. This keeps avoiding the unwanted overlap, but this way the placeholder text is no longer lost on PDF export. An alternative would have been to map the placeholder text to description when the alias/title is empty, but that would show up only as a mouse tooltip, so won't change the behavior when the PDF is printed. Change-Id: I9408b5abe36af28cd00845a74a3dfff13973b83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145828 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-19Resolves: tdf#153091 support text/plain without encoding from neditCaolán McNamara
Change-Id: I56dfc6dfec21b8c57b6f402c53b0229a2a2e7778 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-19save last mouse press location even if no handlers setCaolán McNamara
Change-Id: I24ce412fd3b62843ee3fabc7a3fca36ae91c0222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-19use cairo_surface_destroy after gtk_drag_set_icon_surfaceCaolán McNamara
Change-Id: Iac543121a809eeabae630d4a426e72d5f9d47057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145783 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-19Make PDFExport Password Subdialog AsyncNickWingate
Dialog in File>Export As PDF>Security>Set Password Close subdialog when parent dialog is closed Signed-off-by: NickWingate <nick.wingate@collabora.com> Change-Id: I9db8459309f2806ed47f9f932e0bde246400b2dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144854 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145759 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-18tdf#152770 move warning about ppd with no resolution to use of resolutionCaolán McNamara
so bizarro ppds with no resolutions don't trigger a warning unless it gets queried about the resolution Change-Id: I4828ddf80d011265aefb271d964f6362842b3014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-18Related: tdf#152770 we don't use the font list, so don't warn if its emptyCaolán McNamara
this is a left over from unused code removal Change-Id: I6f6451561ae644a41d402f4de0d805a00945a66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-18only need ooo_fixed for gtk3Caolán McNamara
Change-Id: I2ddc54d013dbeeb75fd07bd5c4ec413306472167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145680 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-18tdf#153080 RTL UI was misbehavingAron Budea
Regression from 6f43f00279252265fe4892b46fe0b4686ff721ed Change-Id: I472381252641bdcd1416bad0893c416a041cc49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145704 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-01-17Related: tdf#42437 Skip special press-and-hold handling for action keysPatrick Luby
Pressing and holding action keys such as arrow keys must not be handled like pressing and holding a character key as it will insert unexpected text. Change-Id: I6beaff265e6cae30337b025791692ff67b760ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145689 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-17gtk4: some basis for experimenting on a11y supportCaolán McNamara
4.10 makes GtkAccessible public Change-Id: Ib6ec27f9db9c9b87ff775fdc5a075b5b26a16b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-17loplugin:casttovoid ("unnecessary cast to void")Stephan Bergmann
Change-Id: Ic891e3ea72e7946a9088ab77ba561d0f1c9b77e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145673 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-17tdf#153049 use ScrollType::DontKnow for a mouse wheel spinCaolán McNamara
use has_grab() to try and distinguish these Change-Id: I09e0f2219458e9ca0e6f0c0093aea5d5920acef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-17Reset BitmapWriteAccess before further bitmap useMike Kaganski
It started failing an assertion recently (maybe after the 1-bit images support drop in commit 21734247d58a6e915b058d8fa55ece949d049613), when opening Styles sidebar, with this call stack: ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444 C++ vcllo.dll!SkiaSalBitmap::AcquireBuffer(BitmapAccessMode nMode) Line 230 C++ vcllo.dll!BitmapInfoAccess::BitmapInfoAccess(Bitmap & rBitmap, BitmapAccessMode nMode) Line 47 C++ vcllo.dll!Bitmap::AcquireInfoAccess() Line 368 C++ vcllo.dll!vcl::ScopedBitmapAccess<BitmapInfoAccess,Bitmap,&Bitmap::AcquireInfoAccess>::ScopedBitmapAccess<BitmapInfoAccess,Bitmap,&Bitmap::AcquireInfoAccess>(Bitmap & rBitmap) Line 55 C++ vcllo.dll!Bitmap::HasGreyPalette8Bit() Line 291 C++ vcllo.dll!Bitmap::Convert(BmpConversion eConversion) Line 868 C++ vcllo.dll!AlphaMask::AlphaMask(const Bitmap & rBitmap) Line 35 C++ vcllo.dll!BitmapEx::BitmapEx(const Bitmap & rBmp, const AlphaMask & rAlphaMask) Line 142 C++ vcllo.dll!vcl::bitmap::CreateFromData(const unsigned char * pData, long nWidth, long nHeight, long nStride, char nBitCount, bool bReversColors, bool bReverseAlpha) Line 216 C++ ... The comment at the assert in SkiaSalBitmap::AcquireBuffer (that is called from BitmapInfoAccess ctor) tells: BitmapWriteAccess stores also a copy of the palette and it can be modified, so concurrent reading of it might result in inconsistencies Change-Id: I364060cf3c2073cfd8bf3288140a7ab3604cd2a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145659 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-17assert/SAL_WARN in BlendWithNoel Grandin
instead of just silently doing nothing, so we get some indication of error Change-Id: Iac7e21d42b45ebc97cfb95552d98c186b9eb05ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-16ofz#55090 fuzzers need docmodel nowCaolán McNamara
Change-Id: I89ffdca9a6d497cd57788e125cbfc7bb1cfde672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145643 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-16The third "depth argument is unusedCaolán McNamara
as far as I can determine. We do query the 2nd arg in "gen" when there is an opengl slide transition. Change-Id: I180c91fa193ee6e7e3d5a415e4278aded9fbbba1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-16getFormat() is always DeviceFormat::DEFAULTCaolán McNamara
Change-Id: I93139a6c2ce28f28f615b7399e37fcb06fac0997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-16cid#1412875 Uninitialized pointer fieldCaolán McNamara
Change-Id: I551a18eddb5a2f436ecb947411faef09ac74d016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-15XUnoTunnel->dynamic_cast in UnoBinaryDataContainerNoel Grandin
Change-Id: Ifdef69448558f4c5d6902188208d3eea1a080334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-15vcl: add more device independent checks for bitmaps in svmtestTomaž Vajngerl
Adds writing of "contentchecksum" to MetafileXmlDump, which sums the content of all the colors in an device independent way, by reading the each pixel color from the bitmap and summing each component always in RGBA order. In addition add some others bitmap attributes not checked before, like bitmap width, height and pixel format. Change-Id: I3bb5f7f6342766df235af71a4682a5d3ce17ab44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145500 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13XUnoTunnel->dynamic_cast in TransferableHelperNoel Grandin
which leads us to find that we can skip all the dynamic_cast'ing altogether in SwView_Impl Change-Id: I8914f78df6bfdd743df370c0017d5b8521863594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13Related: tdf#152703 Eliminate potential blocking during live resizePatrick Luby
Some events and timers call Application::Reschedule() or Application::Yield() so don't block and wait for events when a window is in live resize. Also, only native events and timers need to be dispatched to redraw the window so skip dispatching user events when a window is in live resize. Lastly, only higher priority tasks need to be fired to redraw the window so skip firing potentially long-running tasks, such as the Writer idle layout timer, when a window is in live resize. Change-Id: I5d449caa432399e836b8e59781e5cc53af718873 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145211 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-13tdf#152994 actually return in this caseCaolán McNamara
Change-Id: I40cb4dc4ce1fd3caa2464f92803124c3d2107afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12tdf#152994 only query dark mode in Windows >= 10.0.18362Caolán McNamara
Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12Fix VclTextTest with colorized antialiasingStephan Bergmann
The Flathub build for <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d5ac1d2bd680970ba992c8c6836683262f067592> "Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at <https://buildbot.flathub.org/#/builders/6/builds/16778> consistently failed for both aarch64 and x86_64 builds with > text.cxx:260:Assertion > Test name: VclTextTest::testSimpleText > double equality assertion failed > - Expected: 28 > - Actual : -1 > - Delta : 2 during CppunitTest_vcl_text. The reason (as seen with a temporary build setting mbExportBitmap = true and looking at the resulting workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the stem of the "L" doesn't contain any COL_BLACK pixels, so getCharacterLeftSideHeight returns early with -1. The stem is drawn as three vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 23/0/0), and a blue (RGB 31/155/199) one. In comparison, when running the same test on Fedora 37, the three vertical lines use gray-scale instead of colors, RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115. An earlier test build of <https://github.com/flathub/org.libreoffice.LibreOffice/pull/206> "Update to LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at <https://buildbot.flathub.org/#/builders/6/builds/14712> succeeded, so I assume that it must be some change in the meantime to the underlying org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing here. Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 06:52:20 +0000