summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-06-28coverity#1308563 Uncaught exceptionCaolán McNamara
Change-Id: I2ab21b98f4dee612b8c82ca7f1d0fef14b2a847e
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-27coverity#1308603 Uninitialized scalar fieldCaolán McNamara
Change-Id: I77ecdb2703e7957613db005517a354879f5bb009
2015-06-26vcl: convert some BOOLsMichael Stahl
Change-Id: I6d6d63a88ef125b12614f1daeab7afbab06c47ca
2015-06-26vcl: document the non-obvious WinSalInstance's WaitMutex membersMichael Stahl
Change-Id: I004f082c9e4a17aeb7a8bd778bf45dff93e47ee8
2015-06-26vcl: fix Win32 deadlocks from SolarMutexReleaserMichael Stahl
To create and destroy thread-affine Win32 Windows and DCs, non-main threads SendMessage() special messages like SAL_MSG_CREATEFRAME. The main thread must handle these messages and return the result to un-block the other thread. This works fine as long as the main thread is in its message loop anyway and blocked on GetMessage(); however if the main blocks trying to acquire the SolarMutex that is held by the sending thread, deadlock results. In order to work around this, there is some peculiar code in ImplSalYieldMutexAcquireWithWait() to avoid blocking the main thread on mpSalYieldMutex but instead block in GetMessage(). The crucial detail is that GetMessage() will immediately dispatch any message sent via SendMessage(), which avoids the deadlock. https://msdn.microsoft.com/en-us/library/windows/desktop/ms644936.aspx https://msdn.microsoft.com/en-us/library/windows/desktop/ms644927.aspx Most of the Win32 WndProc that acquire SolarMutex do so via ImplSalYieldMutexAcquireWithWait(), but the main thread may also temporarily drop SolarMutex and re-aquire it with the questionable SolarMutexReleaser hack, which calls ImplSalAcquireYieldMutex() instead, which blocks on mpSalYieldMutex. Fix SolarMutexReleaser to call a new function Application::ReAcquireSolarMutex() that does the right thing here: acquire SolarMutex via ImplSalYieldMutexAcquireWithWait(). It turns out that this problem was already fixed before in commit 6a8fd4c76a969ac98d1aff91ff7442f43aee0006 but the problem was insufficiently documented in the commit and it introduced the bug that Application::Reschedule() was called without having the SolarMutex locked, which caused timers to run without SolarMutex, so the commit was reverted in 1ef1781390845d03b6e1518bbac81b818be62f3d. Change-Id: I60aae555a9ee3c6390f584feddbc6b3cb7de0250
2015-06-26gtk3: gtk_window_set_transient_for on overwrite warning dlgCaolán McNamara
Change-Id: I91d21e3d1663880de14792ded0a1e079d1a40f09
2015-06-26gtk3: fpicker, try removing both locationsCaolán McNamara
Change-Id: I0f10d03c1e4481e8efa765e52b5264071c86a3cf
2015-06-26Related: tdf#92293 gtk3 a11y: I suspect that all of this is redundantCaolán McNamara
in favor of hooking in via get_accessible Change-Id: I8c265e0d9a5f8bdf02b7ba4be71fc58194cf5aa4
2015-06-26Resolves: tdf#92293 gtk3: get a11y workingCaolán McNamara
Change-Id: I89cfde9b4c97852d36817b716ac08bd32096915b
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: I6c82e5071038990489e85ac27758867205ba476a
2015-06-25WaE: -Winconsistent-missing-overrideTor Lillqvist
(No idea how well it works any more, though.) Change-Id: I3f58a7415e493a7bd8cb534697f40c4c2fa8d054
2015-06-25gtk-menu-popup-delay only deprecated in gtk3 I thinkCaolán McNamara
Change-Id: I4bf77a912296f2d4a14c8bedf6b6bed6b52f9023
2015-06-25GtkSettings:gtk-menu-images deprecatedJulien Nabet
Not sure here if we should set true or false by default Change-Id: I120c33bf726150506d282e972facd4dca0db83aa Reviewed-on: https://gerrit.libreoffice.org/16456 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-25these ancient baselines are breaking my spiritCaolán McNamara
Change-Id: I96dbe2c1213c78da1114f9270953334a38c7b2ae
2015-06-25try harder to hide this from android tinderboxCaolán McNamara
Change-Id: I586fea9f1570b68ed789da8b10a3b46216c42969
2015-06-25implement GtkSalFrame::GetKeyName with some code lying around handyCaolán McNamara
Change-Id: I6a41ae2b8056737008add98c35d06f3859e71171
2015-06-25WaE: error: 'CAIRO_VERSION' is not definedCaolán McNamara
Change-Id: I9e4f0d0af541226089a6295962a91ca09debb418
2015-06-25error: missing binary operator before token '('Caolán McNamara
Change-Id: Ieafb13245a11347cbda8a33e49ad618bf85d8a89
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I918023aa2e14d0913e6e05129ceb0c528b6cfd96
2015-06-25gtk3: render menu arrows with menuitem style not menu styleCaolán McNamara
Change-Id: I35de4ed31bfb9830f52aa5a25ea12bdf719c56ef
2015-06-25Fixup vcl build with --without-xRiccardo Magliocchetti
Fix provided by Abhimanyu Singh Change-Id: I5d87aa76517b1cf9d7464f43b9be236de0e92039 Reviewed-on: https://gerrit.libreoffice.org/16452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-25tdf#91362: Don't override printer page autodetectionKatarina Behrens
if printer settings haven't been modified Change-Id: I68b0096ce6fa0f9e50db640a0acb3039ff7e66b5 Reviewed-on: https://gerrit.libreoffice.org/16454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-25WaE: -Werror=unused-parameter on AndroidCaolán McNamara
Change-Id: Ie5a4015794350a513c39a60ae650f4626d92e1b8
2015-06-25stinking ancient cairo implsCaolán McNamara
Change-Id: I35e826bc78556a912358dfad2fac7c45ca35bfd1
2015-06-25gtk3: fix 'degenerate' clip in cairo clippingCaolán McNamara
fix spelling in basebmp clipping case and downgrade to INFO Change-Id: I16ec943bd4be8ca374ded7827e4ec24e7df03e8e
2015-06-25gtk3: move cairo region clipping to svpCaolán McNamara
Change-Id: I4b4f09ee3fb7edbda3b6bb5af024c0966e3a2082
2015-06-25gtk3: alpha rects using cairoCaolán McNamara
Change-Id: I7fdcd6336fdc7ea8149c385a177db91ffaa61c94
2015-06-25cairo_format_stride_for_width is 1.6 onwardsCaolán McNamara
Change-Id: Ic233b4b6c7067f2473eb76b0c7e520cfe1dfcd14
2015-06-25fix spelling Unimplmented -> UnimplementedNoel Grandin
Change-Id: I39df0cd556ae40b6ae40eaec1d64ee59ff8de241
2015-06-24gtk3: move createCairoContext down to svpgdiCaolán McNamara
Change-Id: Ib3c6d6689c4b79a636a3f2f0f985f3573aa46f3d
2015-06-24Another gross inclusion hack that can apparently go nowStephan Bergmann
Change-Id: I261596e5d20360ecfaf57f9ddc4419ca305e3194
2015-06-24X11SalInstance->SalGenericInstanceCaolán McNamara
Change-Id: I6805178d2a344243d487ace3331ca71b667cd819
2015-06-24don't need to include svpinst.cxx anymoreCaolán McNamara
a hold over from before 6efb7f65eea764ffe5b71f65f9b7eea125183ec3 I believe Change-Id: Idea86f782cad4da98bbe4308968277886923ee5e
2015-06-24GtkSettings:gtk-menu-popup-delay deprecatedJulien Nabet
I took example from https://mail.gnome.org/archives/commits-list/2013-June/msg06434.html Change-Id: I5fb090c3245848c92238f34259f1a2f77f9080c7 Reviewed-on: https://gerrit.libreoffice.org/16432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-24tdf#91380 add WB_MOVEABLE bit to docking windowsAndras Timar
Change-Id: Iab913747180bf1588da2d703069650e3e6916414 Reviewed-on: https://gerrit.libreoffice.org/16444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23vcl: fix window vs buffer map mode mismatch in PaintHelperMiklos Vajna
This avoids painting the first few menu items in really large scale on the whole window after window resize. Change-Id: I2469403684b1ae3b93892d49536115df2cef81bc Reviewed-on: https://gerrit.libreoffice.org/16429 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-06-23tdf#92088: Fix an overlook in the refactor.Jan Holesovsky
This was causing 'if you click in the "default style" combobox in writers standard bar and press tab and press tab the next two combo boxes go "blue", happens in gtk2, gtk3 and gen.' reported by Caolan. Change-Id: I0d97a181a605088a0b8bb8043771eb56280521e0
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-23rendercontext: Don't spam on the terminal.Jan Holesovsky
Change-Id: Ica36bb1123145a75edddc8c9e0a283d2b0129edb
2015-06-23rendencontext: Wallpaper needs to fit the provided dimensions, not the outdev.Jan Holesovsky
Otherwise we are painting according to the rendercontext size in the double-buffered case. This fixes the rendering of the image in the startcenter. Change-Id: I2630137c5d176d818bc1a68a970a9e5256ace97c
2015-06-22gtk3: native render the comically oversized gtk3 spinbuttonsCaolán McNamara
Change-Id: I3e97200d59a97271617a6e9a88c807a07a33edfe
2015-06-22Re-factor AddTempDevFont to share it with headless backend.Michael Meeks
Change-Id: Ic316b18eace3445edef346fe319cbb0e557607fa Reviewed-on: https://gerrit.libreoffice.org/16412 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-22Fix typosAndrea Gelmini
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22new uno sidebar api tdf#91806Laurent Godard
the entry point is SfxBaseController::getSidebar() the Decks and panels are now per SidebarController and not global anymore ' macro example Sub testSidebarApi controller = thisComponent.currentcontroller frameIni = thisComponent.currentcontroller.frame sidebar = thisComponent.currentcontroller.getSidebar() sidebar.setVisible(true) frame = sidebar.getFrame() decks = sidebar.getdecks() c = decks.count h = decks.hasElements() e = decks.getElementNames() a = decks.hasByName("MyDeck") deck = decks.getByName("MyDeck") deck.activate(true) t = deck.getTitle() deck.setTitle("new deck title") deck.moveFirst() deck.moveLast() deck.moveUp() deck.moveDown() index = deck.getOrderIndex() panels = deck.getPanels() ep = panels.getElementnames() ap = panels.hasByName("aPanelName") panel = panels.getByName("aPanelName") panel.setTitle("new panel title") panel.collapse() panel.expand(true) ' expand and collapse other index = panel.getOrderIndex() panel.moveLast() panel.moveFirst() panel.moveDown() panel.moveUp() End Sub Change-Id: I7a4b953f2277dea483bb296ba6ead35de7205ace Reviewed-on: https://gerrit.libreoffice.org/15856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-06 16:22:03 +0000