summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-07-22kf5/gtk3_kde5 fpickers: Drop unused 'allowRemoteUrls'Michael Weghorn
Change-Id: I591bf9fbe6e22bedda5a94334130a4f674cd66e6 Reviewed-on: https://gerrit.libreoffice.org/76110 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-07-22cid#1448542 Unintended sign extensionCaolán McNamara
Change-Id: I8673f177a0ae6fe9bfd6e2ee7a87f80b058bb24f Reviewed-on: https://gerrit.libreoffice.org/76104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1209863 Untrusted loop boundCaolán McNamara
Change-Id: Ie9c3672a065b9df4580559cd927c6b1524edde0e Reviewed-on: https://gerrit.libreoffice.org/76099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22Patch fixes the image rendering issue of extension in NotebookBarSumit Chauhan
Change-Id: I7645766af1a6acfd7117fce3fcb29da038d9d92f Reviewed-on: https://gerrit.libreoffice.org/75986 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-22Drop undefined QT5_GLIB_*Jan-Marek Glogowski
These defines were removed in commit a6201725d760 ("Don't link avmediagst with gtk3 and qt5"). Change-Id: I3e0f22c7e2f25ea2b69efa19124ab3feca3f0a15 Reviewed-on: https://gerrit.libreoffice.org/76076 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-21tdf#125922 rename kde5 to kf5 + plasma5Jan-Marek Glogowski
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as it is based on the KDE frameworks 5 libraries. This also includes: * a convenience alias to load the kf5 VCL plugin in case someone requests the kde5 plugin. * keep convenience kde5 configure switch, but warn about it * rename detected desktop from kde5 to plasma5 Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735 Reviewed-on: https://gerrit.libreoffice.org/75313 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-21loplugin:referencecasting in vbahelper..vclNoel Grandin
Change-Id: I2bd9e2c4e8a3d56a7b2168bd2ccff389051e5b4c Reviewed-on: https://gerrit.libreoffice.org/76032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20cid#1448542 Unintended sign extensionCaolán McNamara
Change-Id: I5ef8661a1c8e28537c96cb899d124012938f4b1f Reviewed-on: https://gerrit.libreoffice.org/76017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448527 Unchecked return valueCaolán McNamara
Change-Id: I31c7cc4ee308c7e3841067b5bc5536ac1382e941 Reviewed-on: https://gerrit.libreoffice.org/76010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448247 Division or modulo by float zeroCaolán McNamara
Change-Id: I591ac0446494a8a8c4b3481bdf91e60de0c9ebe1 Reviewed-on: https://gerrit.libreoffice.org/76011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19Engine to add Extension inside extension tab in NotebookBarSumit Chauhan
The patch provides backend for adding the extension.Schema for the adding extension in notebookbar can be seen here https://gerrit.libreoffice.org/#/c/75134/ Change-Id: I10f0e83d1aaec5330c80b3b53cf59a21b93be015 Reviewed-on: https://gerrit.libreoffice.org/75650 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-19cid#1448455 Unchecked return valueCaolán McNamara
Change-Id: I4526fbd939934fc4233279d9839f72c781a588b5 Reviewed-on: https://gerrit.libreoffice.org/75894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448527 Unchecked return valueCaolán McNamara
Change-Id: I024b2cc088027cfb74dc009220e75e24b7228ea2 Reviewed-on: https://gerrit.libreoffice.org/75902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1451641 Unchecked return valueCaolán McNamara
Change-Id: Ifc9a6d3e268af27515cdf3b2b1da471368d50e87 Reviewed-on: https://gerrit.libreoffice.org/75904 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448308 Unintended sign extensionCaolán McNamara
Change-Id: I3d89afa66dc42144f0717c34593d48c4869aeec4 Reviewed-on: https://gerrit.libreoffice.org/75923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448435 Unchecked return valueCaolán McNamara
Change-Id: I1c75280dfcfa1f475d657570bf390847ab922cc8 Reviewed-on: https://gerrit.libreoffice.org/75889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448479 Logically dead codeCaolán McNamara
Change-Id: I1190bd238fad3e5343e83f9c6261d71a44bc6717 Reviewed-on: https://gerrit.libreoffice.org/75831 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448365 silence Arguments in wrong orderCaolán McNamara
Change-Id: I20a64d73add3636e02e02ea970577c0505e2b5fd Reviewed-on: https://gerrit.libreoffice.org/75804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17No reason to have OSL_FAIL() with a fixed string inside #ifdef DBG_UTILTor Lillqvist
Change-Id: I99cc88031e601fd52c2858813d82f58f84fe8ca4 Reviewed-on: https://gerrit.libreoffice.org/75797 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-07-17vcl: make "Reduce Transparency" parameter tweakableVasily Melenchuk
"Reduce transparency" feature previously was using hardcoded value of 0.25. If current object area to whole printing area ratio exceeds this value, object is being written without any extra transparency layers in order to reduce metafile size. Right now this value can be adjusted in "Expert Configuration". Parameter is called "ReduceTransparencyMinArea". Change-Id: I43d5801a1dff6241de214f7b24425626dc06b4fb Reviewed-on: https://gerrit.libreoffice.org/75471 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-17vcl: make it possible to select specific scaling algorithmTomaž Vajngerl
Default, Fast, BestQuality scaling flags are used for selecting the best sclaing algorithm for a specific task, but not all specialized sclaing algorithms have its own flag (Super, NearestNeighbor) and are just selectable using one of the above. This adds the missing flags so it's possible to select a specific algorithm. Change-Id: Ied41f27a21a4fcc799537396f9077a9c77cc1c60 Reviewed-on: https://gerrit.libreoffice.org/75759 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-17external: update pdfium to 3849Miklos Vajna
Change-Id: I616f57bd9de72b078500a290bf9ff89c71773f26 Reviewed-on: https://gerrit.libreoffice.org/75736 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-17Revert "Fix Windows build: missing include"Stephan Bergmann
This reverts commit 8f18fca2714a80e236cdb041a7f6d17d0abcb619, the problem had already been fixed with be394e1cec8eefd21f5963857b90c2268b511fc5 "missing include". Change-Id: Ib9de606d9bca2c183b4774bb26d01f134af725d8 Reviewed-on: https://gerrit.libreoffice.org/75731 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-17loplugin:unusedmethodsNoel Grandin
Change-Id: Ie2285f64919d1c83b0a8df4ceb827f731e5cd609 Reviewed-on: https://gerrit.libreoffice.org/75739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16Fix Windows build: missing includeTamás Zolnai
Change-Id: I129648c471df8f91c52c5e7c4172781aa1eeb6fc Reviewed-on: https://gerrit.libreoffice.org/75692 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-16Resolves: tdf#126190 don't default to WB_NOHIDESELECTIONCaolán McNamara
i.e use traditional style as used before... commit 41db073808566641a3c364e6490f33b7f204d0b0 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Sep 19 13:47:11 2018 +0100 Change-Id: I2f01f33055e8735d52de26651dba3853739c07aa Reviewed-on: https://gerrit.libreoffice.org/75689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448456 Uninitialized scalar fieldCaolán McNamara
Change-Id: I9b29898db96709f5b2d47deb962a124d7cb33eff Reviewed-on: https://gerrit.libreoffice.org/75655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16loplugin:simplifyconstruct (macOS)Stephan Bergmann
Change-Id: Ifad405b05142ce61673f22ec3160f50314419ce7 Reviewed-on: https://gerrit.libreoffice.org/75680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16missing includeStephan Bergmann
(Windows --disable-pch missed declaration of HasAtHook) Change-Id: I7573328a4f672cbf3585a55ed87199f0982aa987 Reviewed-on: https://gerrit.libreoffice.org/75673 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16cid#1448365 silence Arguments in wrong orderCaolán McNamara
Change-Id: I9da2188f9e6ec2cd07cf4e79ff436cb7c3572c6f Reviewed-on: https://gerrit.libreoffice.org/75665 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448533 Uninitialized scalar fieldCaolán McNamara
Change-Id: I20a1be6d14f11ffc6d04f60419fc5c659e59c6fa Reviewed-on: https://gerrit.libreoffice.org/75656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448410 Explicit null dereferencedCaolán McNamara
Change-Id: I491e7b0bd2e3aee02f72da907abe4cbae30ce798 Reviewed-on: https://gerrit.libreoffice.org/75654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16write out empty state explicitly in writeRectangleNoel Grandin
this is purely an internal XML format, so we can change it Change-Id: I9e2a4350c6c3f51031742e94823ea052dd73c8df Reviewed-on: https://gerrit.libreoffice.org/75639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-15cid#1448245 uninit scalar fieldCaolán McNamara
and cid#1448340 uninit scalar field Change-Id: Idfd0944c1a6765593e334b1db56a80e144aedd5e Reviewed-on: https://gerrit.libreoffice.org/75651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15cid#1448286 Uninitialised scalar fieldCaolán McNamara
Change-Id: I064a996c52a95922d72ac8577c98dbb6354daa72 Reviewed-on: https://gerrit.libreoffice.org/75653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15cid#1448240 Unchecked dynamic_castCaolán McNamara
Change-Id: I1d76775d3f78a128aebce1d3b4018e437cf0931b Reviewed-on: https://gerrit.libreoffice.org/75652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15cid#1448232 Unchecked dynamic_castCaolán McNamara
Change-Id: Ice3f3b2453c0b38288e859bfa87d582365570377 Reviewed-on: https://gerrit.libreoffice.org/75630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15KDE5 renaming KDE5 to PLASMA5 hasn't happend yetJan-Marek Glogowski
Change-Id: I1b9ae8de562026d609a13bcf9c13c6fa6dd08f34 Reviewed-on: https://gerrit.libreoffice.org/75608 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2019-07-14Gtk remove the QtEngineStyle workaroundJan-Marek Glogowski
The detection code for KDE is long gone, so this code will never be called. Change-Id: I2ceff5f184ca6149f0625c9588b5dc876d418503 Reviewed-on: https://gerrit.libreoffice.org/75498 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-14Qt5 also has native file selectionJan-Marek Glogowski
Change-Id: Ia47ab46f27e07b396aa324dd01af9d152b65de98 Reviewed-on: https://gerrit.libreoffice.org/75573 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-12make tools::Rectangle::Right return Left when emptyNoel Grandin
I tried making this assert, but there are just too many places where we pass around empty rectangles, so rather just return the value of nLeft, in a similar fashion to methods like Rectangle::TopLeft Change-Id: I3377071ecae26f13e895ae411cd269f0bdbe0ef6 Reviewed-on: https://gerrit.libreoffice.org/75486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-12Qt5 drop special QPushButton handlingJan-Marek Glogowski
Basically reverts commit 3f0dbdd61df ("Draw button focus so that it doesn't obscure the actual button") and declares qt5 doesn't support an extra native focus for a button. LO's own "ant" focus is prevented by Qt5Data::Qt5Data(): pSVData->maNWFData.mbNoFocusRects = true; pSVData->maNWFData.mbNoFocusRectsForFlatButtons = true; Change-Id: Ifdce615cac92f69b008780cf986cdfd0915ccd14 Reviewed-on: https://gerrit.libreoffice.org/75415 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-11Qt5 / KDE5 drop unused configure.ac bug testsJan-Marek Glogowski
These were moved from the kde4 backend but never used. The tested bugs don't exists in Qt5 AFAIK, so just remove them. Change-Id: Ib30c3aee8caf0addd6cf17938f7915a65733e328 Reviewed-on: https://gerrit.libreoffice.org/75428 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2019-07-11Qt5 set default QStyle::State for draw functionsJan-Marek Glogowski
Just a little cleanup for all functions, which already modify the QStyle::State of their QStyleOption* parameter. Change-Id: Ib1fbe3ed3481a17a57ac07f390fafe8a7333f218 Reviewed-on: https://gerrit.libreoffice.org/75418 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Qt5 correctly draw rectangle frameJan-Marek Glogowski
This bug can be seen with the Writer comments "button" to hide or show comments, where qt5 misses the bottom and right borders. The drawRect from X11SalGraphicsImpl and SvpSalGraphics do this and it fixes the visual glitch. I'm not sure this is needed for drawAlphaRect, as other implementations don't handle drawing borders in these at all. Change-Id: Ic82d499cd8e1bb420a7df14269e86c75e0d30c0b Reviewed-on: https://gerrit.libreoffice.org/75416 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Qt5 fix drawing of the toolbar handleJan-Marek Glogowski
This is visible in Writer, where the 2nd toolbar misses the handle. Change-Id: Iddf3a002c9d75f668c40977cf02671640b38f083 Reviewed-on: https://gerrit.libreoffice.org/75417 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Correctly position hyperlink focusJan-Marek Glogowski
Handle WB_RIGHT and WB_CENTER (the latter is used in About LO). Change-Id: Ib03b9f7234c573a05eda7b4c0026e3ca7bd34729 Reviewed-on: https://gerrit.libreoffice.org/75414 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-10tdf#126316 revert Clipboard to PrimarySelectionJan-Marek Glogowski
Regression from commit ce9795954d39 ("fix crash in header/footer calc dialog"), which replaced some GetPrimarySelection() calls with GetClipboard() calls. This replaces the Window class calls for clipboard with global GetSystem* calls in vcl/transfer.hxx. Not sure if this is the best place, but the crowded Window class is definitly not. Change-Id: Ic5f9e575c1ac5d43df234426c5616eca616dea30 Reviewed-on: https://gerrit.libreoffice.org/75318 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-09tdf#121793 use cairo_path_extentsNoel Grandin
instead of cairo_fill_extents, which is fairly expensive for drawPolyPolygon fill operations. Shaves about 10% off the CPU time for this bug Change-Id: I04d04eed1bb204f51537f0856844b337c5a4d54c Reviewed-on: https://gerrit.libreoffice.org/75287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-26 05:29:57 +0000