summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-12-07return blank ident if empty notebookCaolán McNamara
Change-Id: Icede4b1458fe858cc6d406b4cbae9f8d579d417b Reviewed-on: https://gerrit.libreoffice.org/84660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-07Avoid loplugin:staticmethodsStephan Bergmann
Change-Id: I93ebdcae5c39566660edbe1d5e76cc548f5b7c49 Reviewed-on: https://gerrit.libreoffice.org/84670 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-07Fix more new dependencies on boost_headersStephan Bergmann
Same as 97b3e455802cfc08568ec5e8379c509efe3e47b1 "Fix some new dependencies on boost_headers" Change-Id: I0f10374650847f4c50a8cff530c15e65906865ad Reviewed-on: https://gerrit.libreoffice.org/84672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06loplugin:redundantcast (macOS)Stephan Bergmann
Change-Id: Ia514e105d913b8cf77d4fe931deb6b559b3525d3 Reviewed-on: https://gerrit.libreoffice.org/84655 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06loplugin:external (macOS)Stephan Bergmann
* OldEntry in fpicker/source/aqua/resourceprovider.mm was apparently unused ever since it got introduced with 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" * impl_throwError is used from multiple TU, connectivity/source/drivers/macab/MacabStatement.cxx just missed the relevant #include Change-Id: Iba131da57aa20085bb1c634ba9a3a59566070abd Reviewed-on: https://gerrit.libreoffice.org/84653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06Removed duplicated includeAndrea Gelmini
Change-Id: Iff578f6bbaf82c45562bd9aad0c8bd15498ce555 Reviewed-on: https://gerrit.libreoffice.org/84641 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-06remove the added pages grid and tabpage when remove page calledCaolán McNamara
Change-Id: Id2df8e320335e2578c2a3f879b1bb6612a77ca8b Reviewed-on: https://gerrit.libreoffice.org/84636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUPJan-Marek Glogowski
This is the application level equivalent of the Qt5 fix for bug QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden by other windows"), which was broken since Qt 5.4 and is just fixed since Qt 5.12. It is needed for some window managers, which don't know about the WM_CLIENT_LEADER property. Both settings are the same, but just the latter is set by older Qt5 releases. This probably isn't a real problem, as GNOME or XFCE would use the gtk VCL plugin, but since I already wrote the code when debugging tdf#129071, there is also no reason to drop it (except: more code, more bugs...). This fix is optional and needs development headers for xcb-icccm, which can actually be compiled into Qt5. If missing configure will just print a warning, since it's a runtime requirement and we explicitly drop the linked Qt version symbol, so the potential build Qt version won't matter. Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b Reviewed-on: https://gerrit.libreoffice.org/84299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06use SkBitmap::setImmutable() where suitableLuboš Luňák
This is a little correctness check, and it may also possibly slightly improve performance. Change-Id: I6e4a013aedcafd9a7d1e0e86a5c036d511078f79 Reviewed-on: https://gerrit.libreoffice.org/84568 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-06make all Skia drawing GPU-backed, if possibleLuboš Luňák
This primarily means using SkiaHelper::createSkSurface(), which will create a GPU-backed SkSurface if Vulkan is used, and it is used in place of temporary SkBitmap instances, which are always raster-based. Change-Id: I3fe35866f962030f464d5c1d1c4bf518c20ee9af Reviewed-on: https://gerrit.libreoffice.org/84562 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-06check also setupDrawBlend() in visualbackendtestLuboš Luňák
Change-Id: I57eb88b7b6bb498253639867d4c158041d8299b7 Reviewed-on: https://gerrit.libreoffice.org/84561 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-06keep just one shared reference to Skia shared GrContextLuboš Luňák
This should make it easier to keep the reference without having to keep references all over the place, especially when the shared GrContext starts to be used also for GPU-backed surfaces elsewhere. Change-Id: Icf3f6eb849ebc5eb63b1836f9caeb6f5e5e58ca6 Reviewed-on: https://gerrit.libreoffice.org/84560 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-06make Skia Windows text rendering use SkImage instead of SkBitmapLuboš Luňák
This will allow making it GPU-backed, as SkImage can be GPU-backed, SkBitmap cannot. Change-Id: I047eefe83741a036d372d39e5fc6a4fa400e6504 Reviewed-on: https://gerrit.libreoffice.org/84559 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-06tdf#129071 Qt5 handle windows with parents as dialogsJan-Marek Glogowski
This is the main fix for this bug. Qt Xcb is a little picky here. It won't tell the window manager about the transient state, using WM_TRANSIENT_FOR, for all Qt::WindowTypes. The QPA internal list (see isTransient function) doesn't include the Qt::Window, which is qt5 VCL's primary used window type. This has two consequences: 1. LO dialogs show up in the plasma task manager as seperate windows. 2. LO has to handle the transient state itself, instead of relying on the window manager. This results in flickering, because LO can just push a transient window to the top again, after the parent window was activated and therefore drawn in front. So this just declares all windows with parents to be dialogs. Almost everything else should be a top-level window anyway. If not, there is SalFrameStyleFlags::DIALOG to create a parent-less dialog window. Change-Id: I89a6d46fd09e4f1d1d2904e152a26733eb266079 Reviewed-on: https://gerrit.libreoffice.org/84298 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06disable VCL backendtest again for qt5svpLuboš Luňák
It fails testDrawInvertTrackFrameWithRectangle. Change-Id: I15b79f8c39073400eceb92e1ad41a3c3f7879022
2019-12-06handle unsetting ImageCaolán McNamara
Change-Id: If4a3ab94c268caeebdc42c664c568aa9004c50ad Reviewed-on: https://gerrit.libreoffice.org/84579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06lok preload: Some symbols are in-process when we need them.Jan Holesovsky
But OTOH in the preload case, the libraries we'd otherwise load are not there. An example was libcuilo.so where the instantiation of the spell checking dialog was failing, because it was impossible to find the makeSentenceEditWindow symbol. Change-Id: Ifc0bc5d8b295912728505fe3ce11fa4a0d198124 Reviewed-on: https://gerrit.libreoffice.org/80229 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-06Resolves tdf#129140 - Wording in printer dialogHeiko Tietze
Wording improved Change-Id: I67fcee9bdae869eb57882b1944e8975d4c564735 Reviewed-on: https://gerrit.libreoffice.org/84572 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-12-05drawPixel() should still get 'true' for bXorModeAllowed.Jan Holesovsky
That part of 7b267be4b2c87b2c3987d4d751307977a7d3ad41 was not necessary. Change-Id: Ie085f635d4adb6f574f3eca37976f9aded505524 Reviewed-on: https://gerrit.libreoffice.org/84534 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-05loplugin:redundantpointerops (clang-cl)Stephan Bergmann
Change-Id: Ibba507b6c2986a529ae75ad84781825f161f2be5 Reviewed-on: https://gerrit.libreoffice.org/84511 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05loplugin:external (clang-cl)Stephan Bergmann
...plus loplugin:consttobool and loplugin:fakebool fallout Change-Id: Ie3d8121815c080b13bea6d9deca1eb138ca56138 Reviewed-on: https://gerrit.libreoffice.org/84515 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05Silence loplugin:unnecessaryoverride (clang-cl)Stephan Bergmann
("public virtual function just calls public parent") Change-Id: Ifd8d6c794ae32af1fe5d2a97389ec87394fdffbc Reviewed-on: https://gerrit.libreoffice.org/84512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05KF5 drop KF5FilePicker::executeJan-Marek Glogowski
To prevent calls to Qt5FilePicker::updateAutomaticFileExtension, it is simply made virtual with an empty override. This is needed, because the KF5 file picker has its own automatic extension handling. The main motivation is the fix for tdf#129071, which will result in some major changes to XExecutableDialog::execute, so this will prevent larger code duplication later. Change-Id: I5f747f0828cb8a65b4e7043f3ee68ebd31973e6a Reviewed-on: https://gerrit.libreoffice.org/84297 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2019-12-05-Werror,-Wnon-virtual-dtor (clang-cl)Stephan Bergmann
Change-Id: I66967a6d79b0568557c67b26c3dc6c65f00db261 Reviewed-on: https://gerrit.libreoffice.org/84509 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05-Werror,-Winconsistent-missing-override (clang-cl)Stephan Bergmann
Change-Id: I2414729b9e5dfbafdc575c022517c12cef682e31 Reviewed-on: https://gerrit.libreoffice.org/84508 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05-Werror,-Wmicrosoft-pure-definition (clang-cl)Stephan Bergmann
("function definition with pure-specifier is a Microsoft extension"). Keeping it pure but implicitly defined (by dropping the "{}" part) would cause unresolved symbols during linking, so keep it explicitly defined inline but non- pure (which should be fine as the class still has other pure members). Change-Id: Ieff73fd5c9010164c202f752605890b78809caa6 Reviewed-on: https://gerrit.libreoffice.org/84507 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05Make sure external/skia include file doesn't define macro YieldStephan Bergmann
Caused build breaker on Windows at least with clang-cl and --disable-pch: > In file included from C:/lo-clang/core/vcl/skia/gdiimpl.cxx:25: > C:/lo-clang/core/include\vcl/svapp.hxx(487,5): error: declaration does not declare anything [-Werror,-Wmissing-declarations] > static void Yield(); > ^~~~~~~~~~~ Change-Id: Ibadd59c99040c318c874d0eb6747006bfb5e248f Reviewed-on: https://gerrit.libreoffice.org/84505 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05use o3tl::optional instead of pointerNoel Grandin
Change-Id: I71084d668829fdaaf383319697d71b4299f9afea Reviewed-on: https://gerrit.libreoffice.org/84500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-05turn TimeFormatter::ImplInit into initializer listCaolán McNamara
Change-Id: I2f21241f753b1fe1300a284cc80a29911cd223ae Reviewed-on: https://gerrit.libreoffice.org/84465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn DateFormatter::ImplInit into initializer listCaolán McNamara
Change-Id: If58b8f5c65f7d920dd3a186cf648db605799b790 Reviewed-on: https://gerrit.libreoffice.org/84464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05no point setting mnDecimalDigits to overwrite it immediatelyCaolán McNamara
Change-Id: I1651ab51bebf7cfa88d55276f9aec337a903083c Reviewed-on: https://gerrit.libreoffice.org/84463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn NumericFormatter::ImplInit into initializer listCaolán McNamara
Change-Id: I5f936ea61a3e17bb534282e4649b21c0ae2565c8 Reviewed-on: https://gerrit.libreoffice.org/84462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn MetricFormatter::ImplInit into initializer listCaolán McNamara
Change-Id: Iccb732517d7827eda1d8962d4dccdb3a01ebce78 Reviewed-on: https://gerrit.libreoffice.org/84461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05replace only use of GetDefaultUnit() with FieldUnit::NONECaolán McNamara
Change-Id: Idf3cf6d0a361c67d4005d627f661ac49e0e3e9de Reviewed-on: https://gerrit.libreoffice.org/84459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05the only call to MetricField::SetDefaultUnit doesn't change the defaultCaolán McNamara
so is of no use Change-Id: Ibb1187183abff6b8dc26ed5011b43af1a86a7d04 Reviewed-on: https://gerrit.libreoffice.org/84458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05headless: Don't leak the cairo context in drawPixel().Jan Holesovsky
Change-Id: If841f655ac634eee2dc7ca6e9445d2f204546545 Reviewed-on: https://gerrit.libreoffice.org/84445 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5b607ae89de9494c01952852df30a6f77206eadc) Reviewed-on: https://gerrit.libreoffice.org/84450 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-05Fix typoAndrea Gelmini
Change-Id: I95bdcf6ad6c7f6dc9e4772d20f941c332e778b80 Reviewed-on: https://gerrit.libreoffice.org/84495 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-05Qt5 hide more Qt5FilePicker detailsJan-Marek Glogowski
* Make most members private * Drop some unused members * Rename some single-char variables for easier reading * Spread some constness * Finalize the KF5FilePicker class * Test the native picker setting of the QFilePicker, instead of an additional bool member This is just some refactoring. While not strictly needed, it helps keeping the following patches fixing tdf#129071 more compact. Change-Id: I15ffe4de848a9498d7f61f99bcf031257da7cb08 Reviewed-on: https://gerrit.libreoffice.org/84456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-12-05make some classes module privateNoel Grandin
Mark some stuff SAL_DLLPUBLIC_RTTI in include/vcl/metaact.hxx in order to make ASAN happy. Change-Id: I97febe0968bf58b9cbe60ce647f0ada25e6f4bb0 Reviewed-on: https://gerrit.libreoffice.org/84202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-04fix manual insert into a size groupCaolán McNamara
Change-Id: I58b58899dacc1bdc6da1ebdd584cba70fe137b1b Reviewed-on: https://gerrit.libreoffice.org/84443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04factor out 'weld::Widget as XWindow'Caolán McNamara
Change-Id: I24b52c5b8908fdf1a66fd26b2dc438b9557afa6e Reviewed-on: https://gerrit.libreoffice.org/82641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04tdf#128992 Compressing PNG files with alpha channel get a black backgroundNoel Grandin
regression from commit d4442ac1ac9aae36dbc08fda8154d71ea0f81708 Date: Wed May 30 13:02:25 2018 +0200 drop Graphic::GetBitmap Change-Id: I937f89255eebc68dffc2987e628a30bc7d2eed7b Reviewed-on: https://gerrit.libreoffice.org/84412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-04honour GtkScrolledWindow shadow-typeCaolán McNamara
Change-Id: If6cc9f9f6c310261d783f2698b86329aa2a12c5a Reviewed-on: https://gerrit.libreoffice.org/84401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04weld ONavigatorCaolán McNamara
Change-Id: I0b1ae0d50fa8b4c01c36ece0fdd1c2b316ccd27b Reviewed-on: https://gerrit.libreoffice.org/84357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03toolbar item visibilty defaults to false in GtkBuilder but true in vclCaolán McNamara
Change-Id: I91152db48fee77b95fa542790839a574b87161db Reviewed-on: https://gerrit.libreoffice.org/84361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
Change-Id: Ibc7bffe3bb2bf67f85102c03f48e3b44d89c60cc Reviewed-on: https://gerrit.libreoffice.org/84334 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03tdf#129068 try dialog content area help before dialog itselfCaolán McNamara
we already check current notebook page before the dialog, now check the content area before the dialog Change-Id: Ieedb5727ddec6d24adc6e70144977b5c3063c0fd Reviewed-on: https://gerrit.libreoffice.org/84245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Use namespaces instead of structsStephan Bergmann
Change-Id: I82e49d666376c31f3a8e407aedd05cfaee2f2bde Reviewed-on: https://gerrit.libreoffice.org/84301 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-24 19:27:05 +0000