summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-04-04tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()Tor Lillqvist
Somewhere, in time before calling epoxy-wrapper OpenGL functions. This seems to be a good place. Educated guess based on debugging, turned out to work. Change-Id: Id3f1dfb0c5a9dbfb166c47ea81db902af1a4fc08
2017-04-04loplugin:unusedmethodsNoel Grandin
Change-Id: I30f9b6e68a7aa73782c980749e34f8f8d40ae57b Reviewed-on: https://gerrit.libreoffice.org/36047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03vcl: avoid divide by zero in PDFExtOutDevData::HasAdequateCompression()Miklos Vajna
My stub graphic import filter created a graphic with 0 data size, don't crash on that. Change-Id: Ie9b93fce1bcae04d555a0610f674603c6945a54a Reviewed-on: https://gerrit.libreoffice.org/36048 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-03iOS update for Rectanglejan Iversen
Updated Rectangle to tools::Rectangle Change-Id: I1577dffe8d51ac3a33bbc2e0771b338d5fdd0220
2017-04-03use actual UNO enums in vcl..xmlsecurityNoel Grandin
Change-Id: Id862544f27ebcbe8363f93dc83192d0f0cddb5cc Reviewed-on: https://gerrit.libreoffice.org/36041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-02split up doc testing for three major variantsCaolán McNamara
Change-Id: Iac1b5cb1c209ba27d185c8a7ba1e59c663553d77
2017-04-02we're either reading or writing, not bothCaolán McNamara
Change-Id: I6b004c7f7957f3843d37063b182cac0cd07e5f44
2017-04-02SwapOutData url is always a file urlCaolán McNamara
so can just use SvFileStream here and not go through ucb Change-Id: I1d70a4e39977a178afaf7eeadb552f1bd7d9fd1a Reviewed-on: https://gerrit.libreoffice.org/36024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-02add cgm fuzzerCaolán McNamara
Change-Id: Id3bf2bc3c50421bb46e6fbdf3c492bdd2e3a976c
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-02ofz: avoid oomCaolán McNamara
Change-Id: Ibffae78a1186492300c237e85089702491cf4a0f
2017-04-02align fftester and wmffuzzerCaolán McNamara
Change-Id: Ib0017cfd290b41fc886b5516d2f50ee219185d5a
2017-04-01add rtf fuzzerCaolán McNamara
Change-Id: I36a6294c158232bef8fceeaf5159527f467f5786
2017-04-01coverity#1403664 Dereference null return valueCaolán McNamara
and coverity#1403663 Dereference null return value Change-Id: I17b7f977e802aa5bdc5b58895fe2cdeea2c96ebe
2017-04-01adjust cgm import to make testing easierCaolán McNamara
Change-Id: I2979af77522e085075d4f1e1e379fe82e614163b
2017-04-01Get rid of magic numbersBartosz Kosiorek
Change-Id: Ia9ccacc3a21c837e69e3901e262cdd052e4be3f3 Reviewed-on: https://gerrit.libreoffice.org/35982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31vcl android: more adaptions to tools::RectangleMiklos Vajna
Change-Id: Id85ee2a943047c22f77a758238e51e580b7d079b
2017-03-31ofz: 0 bitcount bmps are unsupportedCaolán McNamara
Change-Id: Ibd7b25546006506350f9fc009596f2989a305a4c
2017-03-31expand forcing to mono mask during load to non-indexed sources tooCaolán McNamara
Change-Id: I38c1eec5e180d689de72413b1438c88a1085bbb5
2017-03-31vcl: attempt to blindly make androids properly rectangularMichael Stahl
Change-Id: I5d43744b754817174401558a200a4cd204779515
2017-03-31vcl kde: adapt to tools::RectangleMiklos Vajna
Blind fix, I have no idea how to install TDE today. Change-Id: I9b6143ba09353d4f3cc09eb38327d73582506087
2017-03-31tdf#106458 Color widget should list an exact number of itemsheiko tietze
mnColorValueSetMaximumRowCount set to 10 after decision from design team Change-Id: If6cf93354af6bbdbbefcd026e5aa05689acdaf93 Reviewed-on: https://gerrit.libreoffice.org/35902 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-31vcl kde4: adapt to tools::RectangleMiklos Vajna
Change-Id: I047a69bd084f44c7bc7a132eddf2ee09e811d783
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30ofz#968 short-cut slow create mask when we are our own mask alreadyCaolán McNamara
Change-Id: I5969226bf2da34d34e30e44ae763792cdc072bc8 Reviewed-on: https://gerrit.libreoffice.org/35921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-30tweak indent a littleCaolán McNamara
Change-Id: Icc3c69887a15eb0eacfa9209630a57f602c44422 Reviewed-on: https://gerrit.libreoffice.org/35920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-30vcl PDF export, norefxobj: add test for thisMiklos Vajna
Assert two important properties: - the pdf image is described using the form xobject markup (not the reference xobject one) - the form xobject refers to a vector image, not to a bitmap one Change-Id: I94b88976c1e5392758d56254143fbeeeeba51412 Reviewed-on: https://gerrit.libreoffice.org/35901 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30convert GradientType to scoped enumNoel Grandin
Change-Id: Ie71ead122965e967796ed01270cc2824d35905ac Reviewed-on: https://gerrit.libreoffice.org/35900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30Fix overflow case returned by XmbLookupStringJulien Nabet
man of XbmLookupString when XBufferOverflow: XBufferOverflow The input string to be returned is too large for the supplied buffer_return. The required size (for XmbLookupString, Xutf8LookupString in bytes; for XwcLookup‐ String in characters) is returned as the value of the function, and the contents of buffer_return and keysym_return are not modified. The client should recall the function with the same event and a buffer of adequate size to obtain the string. So in this case retrieve length expected then call it with +1 for null termination Change-Id: I8507bb249a411c7e899746e0598f4a055a26fb19 Reviewed-on: https://gerrit.libreoffice.org/35519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-30vcl PDF export, norefxobj: copy each object only onceMiklos Vajna
Even if they are referenced multiple times. This is especially important as objects can refer to each other, creating a cyclic graph. But it also makes the output a tiny bit smaller. Change-Id: I561ac319683a19a797282fe259cc68f3a4c50c3e Reviewed-on: https://gerrit.libreoffice.org/35855 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29vcl PDF export, norefxobj: avoid replacement bitmapMiklos Vajna
The whole point of "no reference XObjects" is knowing this vector markup is supported everywhere, so no need to provide a fallback bitmap. It was already unreferenced, but now it's not even written to the file, making the PDF export result smaller. Change-Id: Idf766c8eeded4235ebea49d13698a13c6b60f014 Reviewed-on: https://gerrit.libreoffice.org/35841 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29vcl PDF export, norefxobj: add UI for thisMiklos Vajna
Disable the "use reference XObjects" (old behavior) by default, but keep it as an option in case someone wants it. Summary till the help is updated: the old way is simpler code, so it's always correct, but really only Acrobat supports that markup. The new way is supported by all readers, but more complex, so it's more likely it goes wrong. Change-Id: I4769474f29d98412be496a0aa4e8254ae4f0919e Reviewed-on: https://gerrit.libreoffice.org/35826 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29Attempted fix for mirrored geometry crasher.Michael Meeks
Only plausible cause is pWindow->GetParent() being null, while we have a pParent which has to be valid. http://crashreport.libreoffice.org/stats/crash_details/6161398d-17b6-4a93-aa70-a559efa07868 Code was initially introduced in this form: commit 4716735ba7d0ad133ff018481f94d6b4f201bbd9 Author: Stephan Schäfer <ssa@openoffice.org> Date: Thu Sep 19 15:46:19 2002 +0000 #103362# improve positioning and resizing of system windows No public report, sadly. And modified by commit fba46c6efd08d50fee92cc11546f3ed253a57af8 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Mon Feb 3 16:46:04 2014 +1100 fdo#74424 Use Window::GetOutDev() to access ImplReMirrored() Part of the decoupling of Window from OutputDevice. We now get he Window's OutputDevice instance and manipulate this. Do not rely on the inherited function. where the GetParent()/pWindow->GetParent() problem surfaces Change-Id: Ia261028a4719525135e3fe4b00074427c1d9df6c Reviewed-on: https://gerrit.libreoffice.org/35796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28ofz#954 out of memoryCaolán McNamara
Change-Id: Ib27f2dfe0d0837544910208f38a1bc11a35e3cb4 Reviewed-on: https://gerrit.libreoffice.org/35794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28vcl PDF export, norefxobj: have the list of keys to copy at one placeMiklos Vajna
To avoid repeting ourselves. Change-Id: I39667620b9cf391251327c8f66ad8b9649ead36f Reviewed-on: https://gerrit.libreoffice.org/35810 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28tdf#106693 vcl PDF export, norefxobj: handle multiple refs in copied arraysMiklos Vajna
Also fix confusion about dictionaries in arrays and arrays in dictionaries. Change-Id: I0d71d5796b1eb4f89e3fd9a5b1f807d2a7340a35 Reviewed-on: https://gerrit.libreoffice.org/35806 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28Resolves: tdf#106155 avoid opengl for toplevel X window iconsCaolán McNamara
because an opengl context requires a toplevel window so it recurses to death. Only the gen/kde4 vclplugs are affected here Change-Id: If5396d183d90d1872931b170dc90c3a70d8ea6b6
2017-03-28tdf#106693 vcl PDF export, norefxobj: copy nested arrays correctlyMiklos Vajna
When copying an array we're only interested in the start/end position of the outermost array, otherwise only part of the array is copied. Change-Id: I9f5cb5e3ed395142fd82db34e1153ddfdf9f0eb3 Reviewed-on: https://gerrit.libreoffice.org/35797 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27ofz#948 optimize the edge-case of converting masks to 1bit during dib loadCaolán McNamara
Change-Id: Ibed50b92ab49685a1ac033c93bd52bc7d2ea581c Reviewed-on: https://gerrit.libreoffice.org/35757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-27tdf#106693 vcl PDF export, norefxobj: handle multiple refs in copied dictsMiklos Vajna
When copying font definitions the dictionary has multiple values where the type is a reference. Improve PDFWriterImpl::copyExternalResource(), so that multiple references are copied correctly as well. With this the bugdoc (from comment 5) text appears in the output. Change-Id: I2343e616d8b36e3cdcbd4e713bd3f7fa7bce6d3b Reviewed-on: https://gerrit.libreoffice.org/35760 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27Resolves: rhbz#1436050 im window misplaced for gtk3Caolán McNamara
events are relative to event window not the toplevel window which includes a menubar widget (and maybe the decoration topbar as well) Change-Id: I5101bd4a35d6e3aee03191594e5f6edb7ca34c69
2017-03-27vcl PDF export, norefxobj: improve ref handling in dictsMiklos Vajna
When copying objects referenced from the page stream support references in any item value, not just for one single item key. Also move the dictionary entry generator code to PDFWriterImpl::copyExternalResources(), so other keys can be copied without code duplication. Change-Id: I4004e82014cec915c66a8a9d3aed2155fa2452ef Reviewed-on: https://gerrit.libreoffice.org/35755 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27move bitmap allocation after palette readCaolán McNamara
Change-Id: Ie7b2d64bde48d49c6e389c0770f2456187107bda
2017-03-27return early on errorCaolán McNamara
no logc change intended Change-Id: I9a000ccc53b13d2948264b18ae0abf29a6ddc33c
2017-03-27reuse palette objectCaolán McNamara
Change-Id: I72035a49d30955cdc6334f6064a1a2e902c1a9f0
2017-03-27process palette standaloneCaolán McNamara
Change-Id: I489a5cdecf4a5c856e9e5fdd03e6f9c920c0a4d5
2017-03-27tdf#106693 vcl PDF export, norefxobj: copy array objectsMiklos Vajna
So far only the dictionary and the stream of the object was copied, see if it has an array, and take care of that as well. Also check if the array contains a reference and act accordingly. Change-Id: I7f3bb12ec0bbc6f6e1db4f43625c7768b862c895 Reviewed-on: https://gerrit.libreoffice.org/35744 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>