summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-12-13rhbz#1167250: Avoid X11Clipboard already being destroyed in constructorStephan Bergmann
...via SelectionManager::run's aKeep acquring and releasing getReference() Change-Id: I18696d30c41ca9ae101261668cbf54cb0a6c45fc (cherry picked from commit 94d2de0ba1f010be7acf0d00ce5b2ed4ed2b895b) Reviewed-on: https://gerrit.libreoffice.org/13102 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-12PDF signing feature backported from 4.4Tor Lillqvist
Cherry picked from: 840f75065918c4584fa9159fdc90242b5374ab37 1fe9ee73a758603ee0e1465931352c41ef8bd999 d8a8ff8177df628636d80c4dc1d8f597f6677dfc bfa01d8a8248f7e44675de5ed1f85a1d17105022 bbb18f679f5a50e9c709520d6c3260d3d9db5aa9 c4cc31b5b55019aabad4045c8174b45e1b27073a 7e3c931786c3cbe83ee170b8b0746d141b520ce6 070c93af73df9aa4eb333265c81060d123b530b9 6e91763769a562b88882a4c2a94b1367c6ed4866 Change-Id: Ie8ac5e1e067f8e3b15e2f11389bd0517d348f1e3
2014-11-23valgrind: logic for last-ditch svg detection is bustedCaolán McNamara
bIsGZip was never set, and the condition that uses it is additionally inverted Change-Id: I0496bb27435c4323d74c1b99467d3ede68e7bee6 (cherry picked from commit 631378fe110ec7c4161a6c36011640522b881c27) Reviewed-on: https://gerrit.libreoffice.org/12382 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-23valgrind+afl: various problemsCaolán McNamara
valgrind+afl: check p1 at start of loop (cherry picked from commit e76098b22e5d3f5bb422dfcca34b4d61fe2bd593) valgrind+afl: initialize cSize (cherry picked from commit 9313095ea2d5f3dcc531d658e159e16ac2cb44fd) valgrind+afl: short read (cherry picked from commit 9d7979b1319ed7360cec8765a1b387dc1e086148) valgrind+afl: initialize nFlags (cherry picked from commit f23a51c9f978a3a8796a63ebcc03f7fcad52c6dc) valgrind+afl: short read (cherry picked from commit a967c85b13819e2c81082edec0f217259dca7ca8) valgrind+afl: short read (cherry picked from commit 1e9a50075bd39e1387f43605eeaa0132af1bd2c0) valgrind+afl: bad rle (cherry picked from commit a9aee04ecfbc4494b752b10e2a2348a0ccb991f1) Change-Id: I0a9e5fc88ed1fcc7f1bd21218cabeb0adf65c9f4 Reviewed-on: https://gerrit.libreoffice.org/12383 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-23alloca needs special include on SOLARISRichard PALO
Signed-off-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit c22480ada409325a1c9a67dd06ce95b1028cb07e) Change-Id: I72415dbaf1350913938950eb1c0487a78cd67935
2014-11-23There are three positive return codes from inflateCaolán McNamara
#define Z_OK 0 #define Z_STREAM_END 1 #define Z_NEED_DICT 2 and we don't support dictionaries, so a Z_NEED_DICT return creates an infinite loop Change-Id: Iafb1da594962b3cb456a3223cc6d4122791718c5 (cherry picked from commit 047830de46fc40629dc9bdf1e8b9f427b6648c36) Reviewed-on: https://gerrit.libreoffice.org/12366 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-23Resolves: rhbz#1146169 a11y frames label dies before frameCaolán McNamara
Change-Id: I2bc45dcb92b8e68bf4ae4df72c0fbd4e3b535604 Reviewed-on: https://gerrit.libreoffice.org/12142 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-11-23various untrusted loop boundsCaolán McNamara
coverity#1242704 Untrusted loop bound Change-Id: Ib2e00c0cd269dc7ae55b206713fe07e5326072f2 (cherry picked from commit d615d83381a0830a815fe2879ce761f1b00b04e9) coverity#1242606 Untrusted loop bound Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491 (cherry picked from commit 1361dfc0aa835dcb134d5de4bac594519aa16efe) coverity#1242582 Untrusted loop bound Change-Id: I72d2c4979b62a025d212ce5ee3b7141c40376fa7 (cherry picked from commit 6118c11a0c5122169979547e8c27136cf58a54a7) coverity#1242778 Untrusted value as argument Change-Id: I34d5a5e7c5f0eef51d941c65ab73d5421d5a36cb (cherry picked from commit be31503ef86d2ad3291ced8fddb9c4da4d324c46) coverity#1242724 Untrusted value as argument Change-Id: I6041d09ef0a4ed4af5f1bf93f31a1eac60be1af7 (cherry picked from commit bbe264a19fb82f50d859fc72a47312db0527640f) coverity#1242717 Untrusted loop bound Change-Id: I983bba075ab9626c90555fa41f9d473ae60fafea (cherry picked from commit cf63ebe0f005513c1e989682459bcd0688eb190b) coverity#1242624 Untrusted loop bound Change-Id: If2ae1982eec100f5602a13d648beec247ced6aa2 (cherry picked from commit 711e74544d70b108e9bc70772b31f386dbf1c2a4) coverity#1222238 Untrusted loop bound Change-Id: I1a4dec8727d0a27f7fd0396fd22d955f61daaee4 (cherry picked from commit 5a89092d5fe43638832ea8f86df34f81869337d9) coverity#1242573 Untrusted loop bound Change-Id: Id2847c55ccab7272919e76542bc0e0570bc9af12 (cherry picked from commit 5e2d089f763963e6ce7d3d183bd1bf7932aeaaaf) coverity#1242573 Untrusted loop bound (cherry picked from commit 11a514e06bf38c70f2364c8535782aa3f33d6206) Conflicts: vcl/source/filter/wmf/winwmf.cxx Change-Id: Ic84e57fbfa2b532409865c4364b91be594d252cf pass sfntLen to DumpSfnts etc so sfntP reads can be checked Change-Id: I5d8092eceb31ba251e75fe2c51b87890b8adcbf2 (cherry picked from commit b4a0104849eeecb7779fda41116c92c362759882) coverity#1242908 Untrusted value as argument Change-Id: If9dd92c361d406c435329d29870dc8bb07a8ba7b (cherry picked from commit d0be09322d127e7d517851db38c764d57fbab2dc) Reviewed-on: https://gerrit.libreoffice.org/12067 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-23Resolves: fdo#85032 max len property of -1 -> crashCaolán McNamara
Change-Id: Ief903c619204f01784e93fd5e2d582632cef032e (cherry picked from commit e45136f1ff9d817dfec27a6a20ba29fffc6c54bf) Reviewed-on: https://gerrit.libreoffice.org/11985 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-11-23Resolves: #i63015# always default to WinAnsiEncoding...Herbert Dürr
for non-symbol PDF-Type1 export Suggested-By: edv@gruene.de Reviewed-By: hdu@apache.org (cherry picked from commit b8186703cb43d2b57460cb23a7a4e3f989e95426) Conflicts: vcl/source/gdi/pdfwriter_impl.cxx Change-Id: I02227724bff301133ac8ce5562ec5ca1ed94f136 Reviewed-on: https://gerrit.libreoffice.org/11988 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-10-14Resolves: fdo#84809 crash when button is too short for textCaolán McNamara
regression from 4c539fac018dfd44cd8db52161a8cb930c627da7 commit 4c539fac018dfd44cd8db52161a8cb930c627da7 Date: Tue Dec 17 05:18:35 2013 -0600 vcl get rid of xub_StrLen and STRING_LEN in outdev3 before this there was a dubious cast which hid the problem Change-Id: I7c01c0f0ac211196a62acaf02297f29ae829403d (cherry picked from commit 3144b8deaf8397d719b7ad7a56b309655a53d90a) Reviewed-on: https://gerrit.libreoffice.org/11871 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-14server font dtor always calls ReleaseFaceFTCaolán McNamara
therefore we must always call GetFaceFT in the ctor and not return early *before* calling GetFaceFT which could happen in case of inane font size requests, i.e. if( (mnWidth < 0) || (mfStretch > +64.0) || (mfStretch < -64.0) ) valgrind+bff Change-Id: If22f8f7ff6aaed3ffa9eec68630da8601dfd5cae (cherry picked from commit 884229ed3ee2f84eb052c866e22bdb242a385788) Reviewed-on: https://gerrit.libreoffice.org/11400 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-10-14set mpFirstBand back to 0 after deleting itCaolán McNamara
bff + valgrind ==30470== Invalid read of size 8 ==30470== at 0xA02103F: RegionBand::isSingleRectangle() const (regionband.cxx:294) ==30470== by 0xA01F562: WriteRegion(SvStream&, Region const&) (region.cxx:1640) ==30470== by 0x9F01FD4: MetaClipRegionAction::Write(SvStream&, ImplMetaWriteData*) (metaact.cxx:2487) ... ==30470== Address 0x1d175980 is 0 bytes inside a block of size 56 free'd ==30470== at 0x4A07991: operator delete(void*) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30470== by 0xA020BB1: RegionBand::implReset() (regionband.cxx:87) ==30470== by 0xA020EF2: RegionBand::load(SvStream&) (regionband.cxx:249) Change-Id: I2468d43c7e73b3390f355358990f8af30b5f026e (cherry picked from commit 1ca892488a7a6a9c35fc99c41cd4af788fe0df6e) Reviewed-on: https://gerrit.libreoffice.org/11570 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-09-23What is a ridiculous size in 32-bit code is also ridiculous in 64-bit codeTor Lillqvist
Avoids the CppunitTest_vcl_filters_test allocating an insane amount of memory when run as 64-bit on OS X. Change-Id: I978347849c2cf5fd1663e5a85a788b736e239e94 (cherry picked from commit 633e5e16cd233cbb28b24527bb27bf5463ea7276)
2014-09-15fdo#66701 - don't double destroy the HASH when PDF signing.Michael Meeks
Accidentally introduced in d73c039fa it seems. Change-Id: I846314ebca3a24520492887d4d9027f812cfb32f Reviewed-on: https://gerrit.libreoffice.org/11455 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-13Support version 2 ttf fonts and mac font family name encodingsCaolán McNamara
i.e. get loads more fonts working with LibreOffice Related: fdo#82259 support version 2 ttc fonts on Linux a lot of Mac OSX fonts are in this format, and we're not seeing them under Linux Change-Id: I8a6974ccb43afadec320331eb26bc4a2df9b13c9 (cherry picked from commit 02f8f895f2abc4ee090b4bd42963590aa018fb49) Related: fdo#82259 implement mac ttf fontname encoding support which is why these font's are not appearing under Linux Change-Id: Ib72ddb465b2df729953ece416cfa0477cd565bcd (cherry picked from commit 9436ae99438ccc24a86aff61aaa9174a9686814f) Reviewed-on: https://gerrit.libreoffice.org/11419 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-12Resolves: fdo#82552 we only check pAlphaW on one branchCaolán McNamara
Change-Id: Ib2c5a0d751050af77f267edbb7a5a0fe57494622 (cherry picked from commit fee95be5b637dbfbdbe78426c02240b1dc90e1f2) Reviewed-on: https://gerrit.libreoffice.org/11404 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-10clip PolyPolygon::Insert on .svm loadCaolán McNamara
valgrind + bff Change-Id: Ib3ed8a6e518c0686f8cbeaf021b9ca3a07005032 (cherry picked from commit fd64d444b730f6cb7216dac8f6e3f94b97d7ab60) Reviewed-on: https://gerrit.libreoffice.org/11381 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-04Upgrade libgltf to 0.0.1Zolnai Tamás
News in this version: - Solve some limitations of walkthrough mode (fdo#81425) - Multisampling (better rendering quality, mainly at the edges) - Better error handling (no crash in case of invalid input file) Reviewed-on: https://gerrit.libreoffice.org/11179 Reviewed-by: Zolnai Tamás <tamas.zolnai@collabora.com> Tested-by: Zolnai Tamás <tamas.zolnai@collabora.com> Conflicts: download.lst external/libgltf/UnpackedTarball_libgltf.mk external/libgltf/pathces/append_shader_version.patch external/libgltf/pathces/missing_include.patch vcl/source/opengl/OpenGLContext.cxx Change-Id: I46fdf56b00476614487fbcc04178e43e33a01794 Reviewed-on: https://gerrit.libreoffice.org/11194 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-09-03fdo#80474: Fix the check whether the window is active on OS X.Jan Holesovsky
Change-Id: I68d7d11a93f5d741f2295ef183b2b607ad6833fc Reviewed-on: https://gerrit.libreoffice.org/11266 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 61a9838e521222e0aeb3199e18e6d828801a8035) Reviewed-on: https://gerrit.libreoffice.org/11267 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-03Allow STYLE_OPTION_MONO to be unset from toolkit-created windowLionel Elie Mamane
This was keeping form controls (e.g. CheckBox and RadioButton) to transition from flat style to 3d style, while the 3d-to-flat transition was allowed, making flat some unescapable pit of doom. Whatever the goal of that pinning, it will have to be achieved in a different way. Change-Id: Icc4dfb9673a7dfe4a7d8726fbfd23f75499f8b41 Reviewed-on: https://gerrit.libreoffice.org/9554 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-26bnc#719994: Fix the duotone filter to actually produce duotoneTor Lillqvist
Not sure what it tried to do earlier, but it was obviously wrong. Change-Id: I0b377c4baa88205a9a7ad7c134ec5bc2223e6205 (cherry picked from commit c03f7f2b427f7fe2b94dfb55ea64670426d1a957) Reviewed-on: https://gerrit.libreoffice.org/11125 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-20only subtract height of hscroll if visibleCaolán McNamara
otherwise infinite loop in extensions update check Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3 (cherry picked from commit 749f7548b4ee746d69c20a828ea6d3b853eba8d3) Reviewed-on: https://gerrit.libreoffice.org/11033 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20facepalm: nAvailHeight is not derived from allocation WidthCaolán McNamara
Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52 (cherry picked from commit 36490fff3f4d1b4a7e4b7902a866abb177a0bf54) Reviewed-on: https://gerrit.libreoffice.org/11023 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-08-18check that AddToTable can be done validlyCaolán McNamara
Change-Id: I0ee69279e3bb1d9871feba17b908b8307f0ec5b4 (cherry picked from commit 43b39d3e47ffd179071732c0a8fc201c31b2bb46) Reviewed-on: https://gerrit.libreoffice.org/10949 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-13fdo#78906 (+dup fdo#82484): File crashes while opening.Umesh Kadam
Handled a memory corruption. Cherry-picked from 14ce4b337232f8fb21cc67e7a2844a7de81dfc4c Change-Id: I195d17bcd0a9a86bcc96cc7ad14f1d5f2908cf8c Reviewed-on: https://gerrit.libreoffice.org/9545 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/10897 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-13valgrind + bff: don't add 0xffff oldcodeCaolán McNamara
Invalid read of size 1 at 0x9DC6247: GIFLZWDecompressor::AddToTable(unsigned short, unsigned short) (decode.cxx:117) Change-Id: I9cea8dcd4a5eeaa1e793b9be96f82854b9d088af Reviewed-on: https://gerrit.libreoffice.org/10905 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12fdo#39477: Mac Keyboard shortcut Option key ko in Customize dialogJulien Nabet
There's still a problem of order of symbols between menu shortcut and the 2 shortcuts in Customize dialog Change-Id: I7d8235130e8ddb8aa510a20cf803fbe81038b023 Reviewed-on: https://gerrit.libreoffice.org/10600 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 76e46a52706711c11f1f62373d0db5262dd2be2f) Reviewed-on: https://gerrit.libreoffice.org/10881
2014-08-06fdo#81516: vcl: limit number of CFFs read from fontMichael Stahl
Change-Id: I9928b9805169a2dbb41be669dc37617b30bc672b (cherry picked from commit 45b0b47d114437198c9e0872d427576e6e7e6cc6) Reviewed-on: https://gerrit.libreoffice.org/10751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-08-05fdo#81516 Support fonts like Source Han Sans with > 16 FDArray elementsAudrey Tang
Change-Id: I3f82574f434060d62dc3faeb730341c5b169ce9f (cherry picked from commit 3b38a2342e48a2aec3c2e4f5aebf883db4b84101) Reviewed-on: https://gerrit.libreoffice.org/10745 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-30Resolves fdo#79278: not too dark, not too bright background colorAdolfo Jayme Barrientos
This patch is based on Caolán's one at 68075a61c28a5c72429f78776a822ed45fdcb4a7 I've chosen the background color used in Windows program Paint.NET as our default background color. It's a nice compromise that doesn't look out of place anywhere. Change-Id: I5081201043be4a7ad6152d1ce59451daa4ece1ac Reviewed-on: https://gerrit.libreoffice.org/10527 Reviewed-by: Stefan Knorr <heinzlesspam@gmail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-07-25Related: fdo#81457 skip setting an empty allocationCaolán McNamara
if the dimension is 0, don't bother calculating a bunch of <= 0 sizes, rely on the parents clipping to hide the lot instead Change-Id: I5b593a5b6b6c3614beb7f9bf3328fa469b700972 (cherry picked from commit 13807fbf9f3a4aae6767da8bcf796bea4b065159) and Related: fdo#81457 quadratic time required when setting a11y name when calling SetAccessibleName GetAccessibleName is called in order to send a name changed a11y event. Getting an Accessible Name is very slow in a non-layout aware widget because it scans for a "nearby" label and there is none in this widget, but it has a huge pile of other widgets to iterate over. call add_mnemonic_label before hand to cut off that entire branch. While we're at it, only call InitControl to adjust to a new width if the new width is different from the old width Change-Id: Ie4ba1276127226e49442278e46447b84bbeb1cde (cherry picked from commit aff263c8b814c6bf352312403d3c1e448c8013a3) Reviewed-on: https://gerrit.libreoffice.org/10461 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-21fdo#81055: Crash due to inadequate checks for GL version / capabilitiesZolnai Tamás
Base line is OpenGL 2.1 + extensions. GL_ARB_framebuffer_object (part of OpenGL 3.0) for glGenFramebuffers, glGenRenderbuffers... GL_ARB_vertex_array_object (part of OpenGL 3.0) for glGenVertexArrays, glBindVertexArray... GL_ARB_sampler_objects (part of OpenGL 3.3) for glGenSamplers, glBindSampler... (cherry picked from commit 378b1d24a958114eb4484cb10f609f6e482772ec) (and cherry picked some part of commit 23c876deeb357b6306712ff0586a819176151c15) Change-Id: I3a3caeab7ef593188ee742c53e6715648bf14f50 Reviewed-on: https://gerrit.libreoffice.org/10440 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-21bnc#881024 Don't world transform font size in WMF/EMF importTomaž Vajngerl
Change-Id: Ia865b84ee2b159ff7251ab5a769a2b635dd2a1ea
2014-07-15fdo#80498: vcl: Revert "fdo#74124: Scale the pictures before calling ...Michael Stahl
... ImplDrawAlpha()." This reverts commit 3cf3700b7a903e88f5296076c40ae854bce91cdc. It may look nicer but is unusably slow when scrolling in Writer. Conflicts: vcl/source/gdi/outdev2.cxx Change-Id: I582f3f02a2f8915c244b04b2fe95b6af926396b9 (cherry picked from commit ee36fc7add892690c95a969530ecdcfc1bc9decc) Reviewed-on: https://gerrit.libreoffice.org/10204 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-15Revert "fdo#79673 quartz: draw 'bullet' for 'space' directly in one pass"Norbert Thiebaud
This reverts commit 36ff78d83b6a012d2a2c8ef2c6d8f0db62ecffc9.
2014-07-15Related: fdo#52226 ensure graphics are swapped in on DrawingML::WriteImageCaolán McNamara
I imagine it would be best that the Graphics were delivered pre-swapped in by higher levels in case there are second level caches or more complex caching systemed wrapped around it, so warn about it in debug mode but give it a last-ditch shot anyway. i.e. while the .docx problem should be fixed there is a report of a very similar .xlsx problem Change-Id: Ie40ee10fe5cba8ff9c321f47b83e33ee2c1425fd (cherry picked from commit 6e580f3f53ae2de086a08c8ba1958b67874eb9c5) Reviewed-on: https://gerrit.libreoffice.org/10299 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-15fdo#79673 quartz: draw 'bullet' for 'space' directly in one passNorbert Thiebaud
the current implementation of CoreText simply dropped the proper implementation of DrawTextArray, by ignoring DXArray this very visibly borked the show-non-displayable character feature of writer.. the bullet representing the 'spaces' was quite misplaced. This solve specifically this problem. More work is needed to bring proper support of DXArray back to CoreText cherry picked from master 87854755bcefdc931f7d0b4a50f25f1c62e49e07 Change-Id: Ia8cf6cb3352e49b8a06cd9be5bc36f2d41e3449e Reviewed-on: https://gerrit.libreoffice.org/10318 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-07-08Fix some OUString construction error with VS2013Tor Lillqvist
A bit unclear to me whether the code really did what was intended with earlier VS versions either. VS2013 said: error C2664: 'rtl::OUString::OUString(const sal_uInt32 *,sal_Int32)' : cannot convert argument 1 from 'const char *' to 'const rtl::OUString &' Reason: cannot convert from 'const char *' to 'const rtl::OUString' No constructor could take the source type, or constructor overload resolution was ambiguous Change-Id: Ie23d8382515064062a3ed46418d9d4a977b35d28 (cherry picked from commit eee44c951c104da342d55fd4de634efd51ae59ae) Reviewed-on: https://gerrit.libreoffice.org/10133 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-04fdo#78908 Revert "Merge back branch alg_writerframes to trunk"Miklos Vajna
This reverts commit 6e61ecd09679a66060f932835622821d39e92f01. Better not to have this on libreoffice-4-3 without 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tparea.cxx include/basegfx/numeric/ftools.hxx include/svx/svxids.hrc include/svx/unoshprp.hxx sc/source/ui/drawfunc/drawsh.cxx sd/source/ui/func/fuarea.cxx sfx2/source/dialog/tabdlg.cxx sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/swatrset.hxx sw/inc/unobrushitemhelper.hxx sw/qa/extras/rtfexport/rtfexport.cxx sw/source/core/attr/format.cxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/notxtfrm.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/fntcache.cxx sw/source/core/uibase/shells/frmsh.cxx sw/source/core/unocore/unobrushitemhelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unostyle.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx Also: Revert "cppcheck: Prefer prefix ++/-- operators for non-primitive types" This reverts commit 80ec4885e97b3fcb34b93e71ced52a4aab43ce93. Revert "WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'" This reverts commit d5d10b03b1f3e4bf784ad35254cb55d719a8c1b3. Revert "i#124638 support for DrawingLayre FillStyle for GraphicFrames and ..." This reverts commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c. Revert "svx: fix SID_OFFER_IMPORT and SID_ATTR_CHAR_GRABBAG having the same SID" This reverts commit b66d87086804460c1986df1b832fd6b2ea075a90. Revert "SwXStyle::getPropertyValue: don't try to read a float into a sal_Int32" This reverts commit 1e3c7b854baac2502bed72ff8e3e1b21b507735b. Revert "SwXTextFrame: also restore semi-lost BackColorTransparency property" This reverts commit 102bb87ca1a5dee3a09442bf503a54bb703c79ea. Revert "SwXTextFrame: restore semi-lost BackColor property" This reverts commit 5ce92b73ce06c805c66e53c48aa2c70c722aaf60. Revert "DocxAttributeOutput: port to FillAttributes" This reverts commit ec221b7339f8fe5520926ef85b450daa94392780. Revert "MSWordExportBase::OutputItemSet: handle fill attributes as frame ones" This reverts commit 84c40768f8acb0342dcfa223133497f57620fc14. Revert "sw: put getSvx* and setSvx* to a namespace, now that these are public" This reverts commit ebf960960a69c1edb5da1994c330ddddbecac44d. Revert "sw: fix DOC/DOCX/RTF export of TextFrame background color" This reverts commit c7837b8caad61b8c0dfd3704a133cdeaffd69b06. Revert "sw: still use SvxBrushItem for page style background" This reverts commit e826950e9d7736a6e3f9042755ba1b528f58a505. Revert "cui: unused code in SvxAreaTabPage::ClickBitmapHdl_Impl" This reverts commit 2032e9f5d7683e49b8753d7c7362899c690005b6. Revert "cui: unused code in SvxAreaTabPage::ClickGradientHdl_Impl" This reverts commit f4fa202b31277276dc4f05046c82152c0830ef21. Revert "cui: unused code in SvxAreaTabPage::ClickColorHdl_Impl" This reverts commit 1478e89e08a54f02a137c74c0cde6ae75e80d9f3. Revert "cui: unused code in SvxAreaTabPage::ClickHatchingHdl_Impl()" This reverts commit e9c9f3f793a91525ac4fb74f8791ba74222515e4. Revert "svx: fix Writer's insert -> frame crash" This reverts commit 831b8751fc9f423fd4e459623e54801c0a020eb3. Revert "sw: adapt frame/templatedialog4.ui to FillAttributes" This reverts commit 55916fc50a5b2d6273bca8c9ef6253011cf4fdbc. Revert "-Werror,-Wunused-variable" This reverts commit d0542fe7251d9c6538331b22a4b5e2e294a92e97. Revert "loplugin:implicitboolconversion,literaltoboolconversion" This reverts commit 47862e75de51a4ac7476acff773b504fdc0d6e76. Revert "loplugin:saloverride" This reverts commit be89e8b8ac19c0feca8850ccaddd90205c63dbe5. Revert "loplugin:literaltoboolconversion" This reverts commit 355b31fe347479f63906e41300042ec5cb38837c. Revert "-Werror,-Wunused-private-field" This reverts commit df9d13dd2e754184a4c6e321b8910ee1bc0cafa1. Revert "-Werror,-Wunused-const-variable" This reverts commit d757a98001a65baf4066c2eda037a08ab1beda46. Revert "unused XFillStyleItem ctor" This reverts commit b735fe1d67e6ad7ad448e448f237dcabef1a1c38. Revert "unused XGradient::VclGradient" This reverts commit 5bbc90be755aae4b87125f9d748828d74efe645d. Revert "fix "transparency" of floating tables in docx import (fdo#77723)" This reverts commit 313b59d787357ef3da34e2833fefcf1143b09b5e. Change-Id: If855b090f94288d384f8733f88ef1172e68c50a6 Reviewed-on: https://gerrit.libreoffice.org/10077 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-04fdo#39944: Fix mapping for some a11y roles to ATKJacobo Aragunde Pérez
In particular, EDIT_BAR, EMBEDDED_OBJECT and HYPER_LINK were being mapped to custom roles when specific roles exist; fixed passing the proper name to registerRole. Besides, moved two roles that were in the section 'don't exist in ATK yet' because that's not the case now. Change-Id: I6818a0ac623f45053812b5c6dd5fc25c9abf4f65 (cherry picked from commit 7c37cd7bb26b91bda5e57d7bd0cecdbc9d1ebb22) Reviewed-on: https://gerrit.libreoffice.org/10066 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-01Resolves: #i124935# fix expanded/condensed text breaking...Herbert Dürr
in the CoreText engine the concept of an extra-width per code-unit was obsolete at least since apps supported unicode with its different normalization forms, diacritical marks, surrogate-pairs, non-printing characters such as ZWJ/ZWNJ/RLM, etc. so of course modern engines like CoreText don't aid this typographical crime. The fix here extends the CTLayout::GetTextBreak() method to handle the obsolete semantic of per code-unit extra-widths by successively approximating the number of involved code-units. (cherry picked from commit a9b9ceff86f35be1eeff5f251d24e338db760a1e) Conflicts: vcl/aqua/source/gdi/ctlayout.cxx Change-Id: I52a7f7488a9e8a303ed7271df2a24a3c85098ce3 (cherry picked from commit 687f0c9300d499b78deea2890b4c2019adb2d67d) Reviewed-on: https://gerrit.libreoffice.org/9627 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-07-01fdo#80014: vcl: fix drawing of linear gradientsMichael Stahl
There is an off-by-one error in OutputDevice::ImplDrawLinearGradient() that causes the bottom line to remain black. (regression from 04d937c1ec36c2d9fa8c90604c81a37d30e97da6) Change-Id: I33948ec8065e446a9ec7efeab5e506c93fa2e9e8 (cherry picked from commit d51f53fedb8cd68b1b3122c7199c4ea2d3a6980f) Reviewed-on: https://gerrit.libreoffice.org/10024 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-06-30use VCL_HIDE_WINDOWS env on Mac to 'simulate' headless mode on MacNorbert Thiebaud
Building, and running the unit/subsequent test on Mac cause massive amount of flashing windows creation/destruction that make building with test very annoying on a box used for other purposes. This patch prevent the windows to be actually displayed hence mitigating the problem Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/source/window/window.cxx Change-Id: Ied2a36699b50856e0c4e6b618212481796ec99d3
2014-06-27bah, const issueCaolán McNamara
Change-Id: If7fd95287ba1a28e7b5f5440776859b912d6ad6e (cherry picked from commit d781e874e018988d26b558ae1e4d6a1303b14cc1)
2014-06-27Resolves: fdo#80160 PNG with 1-bit colormap only show black and whiteCaolán McNamara
Change-Id: If0c9950c18e6091fafea47954a4654db436a3a44 (cherry picked from commit 986c0451d05e7bb6ff7edd9f27d0e45532bcd22c)
2014-06-26Related: fdo#33455 retain color on scaling of 1 bit depth pngsCaolán McNamara
Change-Id: I445ce672742ddb6d6592ef419bf5e14c5f09a5b5 (cherry picked from commit be9d65bb5f5a83c19eec02a037b8f808de70ecb8)
2014-06-20Fix build to work with older harfbuzz versions.Thorsten Behrens
Whee, seems hb has changed naming, with 0.9.11 it is spelled as quoted. newer versions have a mapping in hb-deprecated.h ... Change-Id: I425ded33e6b9928aadca9f6988437a021fcecbfb (cherry picked from commit b3911e8adb34c6ee72577e58658b2cb72c6e79a3)
2014-06-17Related: #i125020# fix the calculation of the text-update rectangle...Herbert Dürr
in CoreText by doing the calculation before CTLineDraw() updates the text position. Requesting the update early is possible because that update region is not used until AquaSalInstance::Yield(). (cherry picked from commit ee042661b996fd00d5504caf4f4be60f77bf880f) Conflicts: vcl/aqua/source/gdi/ctlayout.cxx (cherry picked from commit d2bbef3d3d6c7be096175ddbdb788ece5067f5fc) Conflicts: vcl/quartz/ctlayout.cxx Change-Id: I317a2068071a2f6d33f34c81e104e30beedc33db Reviewed-on: https://gerrit.libreoffice.org/9628 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-06-17Resolves: #i125020# fix rounding error in AquaSalGraphics::RefreshRect()Herbert Dürr
Rounding left and width down can accumulate a rounding error of almost two in the calculation of right. The existing code compensates for this by increasing the width by two, but since left has been decremented by one to accommodate for antialiasing artifacts this compensation is one to few by itself and two to few when accounting for antialiasing artifacts on the right. Y-pos and height have the same problems and get the matching fix. (cherry picked from commit 073ec69fb970830d39c8700317ee74dbbdfd1fda) (cherry picked from commit ee9dd6c086f7bda615d5b28d3319a83ce1673607) Change-Id: Ia394859035d59c76c67b6b0d53ddc6cf88582bfe Reviewed-on: https://gerrit.libreoffice.org/9626 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
generated by cgit (git 2.34.1) at 2024-07-18 20:52:29 +0000