summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-08-26loplugin:unusedmethodsNoel Grandin
Change-Id: I9d1abe62e7e0ae3434e0b2d440d6ccf0435e97cc Reviewed-on: https://gerrit.libreoffice.org/78131 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26enum SvLBoxButtonKind is effectively unusedNoel Grandin
since commit e569b9d40eb02f53a3f13024af4ab1dc9ca7634a Date: Tue Jul 30 17:07:41 2019 +0100 weld OfaMSFilterTabPage2 Change-Id: If8777180aec04336eda08c75bbee400de2ccb43b Reviewed-on: https://gerrit.libreoffice.org/78136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26Embedded PDF: It is a shared_ptr, no need to copy.Jan Holesovsky
Change-Id: Iedb31bbe0e81dc9568e84858d8d26eac03c47ffb Reviewed-on: https://gerrit.libreoffice.org/70208 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit ff2c5e766517bbc23409f04335c418bb6fcad6eb) Reviewed-on: https://gerrit.libreoffice.org/77694 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-26Missing include (Windows --disable-pch)Stephan Bergmann
Change-Id: I5a06677fc523e97080e1b6e4ea9318bae7312454 Reviewed-on: https://gerrit.libreoffice.org/78111 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26loplugin:returnconstval in new pdf codeNoel Grandin
Change-Id: I11fdc9a0dcf745dacd516cfc8540a8fb67c45b6c Reviewed-on: https://gerrit.libreoffice.org/78106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26vcl: fix --disable-pdfium buildMiklos Vajna
Which is not covered by Jenkins, but used implicitly by the Android build e.g. Change-Id: Id1ffab54a619fc94bcc3d8bea9eba6301d3d7381
2019-08-26vcl lok: fix UB when lok notifier is deleted before its windowMiklos Vajna
During online.git's unit-copy-paste test: ==18827==ERROR: AddressSanitizer: heap-use-after-free on address 0x61c0000c88c0 at pc 0x7fcbf515fcac bp 0x7ffe9be7eef0 sp 0x7ffe9be7eee8 READ of size 8 at 0x61c0000c88c0 thread T0 (loolkit) #0 0x7fcbf515fcab in vcl::Window::PixelInvalidate(tools::Rectangle const*) core/vcl/source/window/paint.cxx:1227:20 #1 0x7fcbf515efcb in vcl::Window::LogicInvalidate(tools::Rectangle const*) core/vcl/source/window/paint.cxx:1207:9 #2 0x7fcbf5f6f9f4 in vcl::Window::queue_resize(StateChangedType) core/vcl/source/window/window2.cxx:1351:13 #3 0x7fcbf57e3a4f in DockingWindow::queue_resize(StateChangedType) core/vcl/source/window/dockwin.cxx:1046:18 #4 0x7fcbf5f6ff12 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) core/vcl/source/window/window2.cxx:1301:22 #5 0x7fcbf5f6e390 in vcl::Window::queue_resize(StateChangedType) core/vcl/source/window/window2.cxx:1320:26 #6 0x7fcbf5f6ff12 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) core/vcl/source/window/window2.cxx:1301:22 #7 0x7fcbf5f6e390 in vcl::Window::queue_resize(StateChangedType) core/vcl/source/window/window2.cxx:1320:26 #8 0x7fcbf601ebef in vcl::Window::StateChanged(StateChangedType) core/vcl/source/window/window.cxx:1929:13 #9 0x7fcbf601f761 in vcl::Window::CompatStateChanged(StateChangedType) core/vcl/source/window/window.cxx:3719:5 #10 0x7fcbf600d9b6 in vcl::Window::Show(bool, ShowFlags) core/vcl/source/window/window.cxx:2189:9 #11 0x7fcbf50ae584 in vcl::Window::Hide() core/include/vcl/window.hxx:930:50 #12 0x7fcbf5fceb7a in vcl::Window::dispose() core/vcl/source/window/window.cxx:399:5 #13 0x7fcbf629f6fb in Control::dispose() core/vcl/source/control/ctrl.cxx:62:13 #14 0x7fcbf612db90 in Button::dispose() core/vcl/source/control/button.cxx:108:14 #15 0x7fcbf617736d in RadioButton::dispose() core/vcl/source/control/button.cxx:2292:13 #16 0x7fcbf6dd52da in VclReferenceBase::disposeOnce() core/vcl/source/outdev/vclreferencebase.cxx:41:5 #17 0x7fcc1add4fa4 in VclPtr<RadioButton>::disposeAndClear() core/include/vcl/vclptr.hxx:206:19 #18 0x7fcc1adc4b3e in sfx2::sidebar::TabBar::SetDecks(std::__debug::vector<sfx2::sidebar::ResourceManager::DeckContextDescriptor, std::allocator<sfx2::sidebar::ResourceManager::DeckContextDescriptor> > const&) core/sfx2/source/sidebar/TabBar.cxx:116:27 #19 0x7fcc1abb2ebb in sfx2::sidebar::SidebarController::UpdateConfigurations() core/sfx2/source/sidebar/SidebarController.cxx:525:15 #20 0x7fcc1abb0d1e in sfx2::sidebar::SidebarController::notifyContextChangeEvent(com::sun::star::ui::ContextChangeEventObject const&) core/sfx2/source/sidebar/SidebarController.cxx:321:9 #21 0x7fcb4688906e in (anonymous namespace)::ContextChangeEventMultiplexer::BroadcastEventToSingleContainer(com::sun::star::ui::ContextChangeEventObject const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) core/framework/source/services/ContextChangeEventMultiplexer.cxx:254:23 #22 0x7fcb46883d44 in (anonymous namespace)::ContextChangeEventMultiplexer::broadcastContextChangeEvent(com::sun::star::ui::ContextChangeEventObject const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) core/framework/source/services/ContextChangeEventMultiplexer.cxx:237:5 #23 0x7fcc1ac67170 in sfx2::sidebar::ContextChangeBroadcaster::BroadcastContextChange(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, rtl::OUString const&) core/sfx2/source/sidebar/ContextChangeBroadcaster.cxx:108:23 #24 0x7fcc1ac66021 in sfx2::sidebar::ContextChangeBroadcaster::Activate(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) core/sfx2/source/sidebar/ContextChangeBroadcaster.cxx:53:9 #25 0x7fcc19838064 in SfxShell::BroadcastContextForActivation(bool) core/sfx2/source/control/shell.cxx:713:47 #26 0x7fcc19837b2a in SfxShell::Activate(bool) core/sfx2/source/control/shell.cxx:361:5 #27 0x7fcc19836442 in SfxShell::DoActivate_Impl(SfxViewFrame*, bool) core/sfx2/source/control/shell.cxx:314:5 #28 0x7fcc19647b7e in SfxDispatcher::DoActivate_Impl(bool) core/sfx2/source/control/dispatch.cxx:702:42 #29 0x7fcc1b125692 in SfxViewFrame::DoActivate(bool) core/sfx2/source/view/viewfrm.cxx:1173:20 #30 0x7fcc18ed323d in SfxApplication::SetViewFrame_Impl(SfxViewFrame*) core/sfx2/source/appl/app.cxx:311:21 #31 0x7fcc1b1254f7 in SfxViewFrame::SetViewFrame(SfxViewFrame*) core/sfx2/source/view/viewfrm.cxx:3266:19 #32 0x7fcc1b1412fb in SfxViewFrame::MakeActive_Impl(bool) core/sfx2/source/view/viewfrm.cxx:1877:9 #33 0x7fcc1b06d6f4 in SfxLokHelper::setView(int) core/sfx2/source/view/lokhelper.cxx:85:25 freed by thread T0 (loolkit) here: #0 0x610150 in operator delete(void*) _asan_rtl_:0 #1 0x7fcbb32e2560 in ScTabViewShell::~ScTabViewShell() core/sc/source/ui/view/tabvwsh4.cxx:1709:1 #2 0x7fcc1b121be5 in SfxViewFrame::ReleaseObjectShell_Impl() core/sfx2/source/view/viewfrm.cxx:1116:9 #3 0x7fcc1b13caf9 in SfxViewFrame::~SfxViewFrame() core/sfx2/source/view/viewfrm.cxx:1615:5 #4 0x7fcc1b13e234 in SfxViewFrame::~SfxViewFrame() core/sfx2/source/view/viewfrm.cxx:1609:1 #5 0x7fcc1b125143 in SfxViewFrame::Close() core/sfx2/source/view/viewfrm.cxx:1168:5 #6 0x7fcc1afc6a92 in SfxFrame::DoClose_Impl() core/sfx2/source/view/frame.cxx:159:35 #7 0x7fcc1b0bb60d in SfxBaseController::dispose() core/sfx2/source/view/sfxbasecontroller.cxx:983:28 #8 0x7fcb469d1e9b in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) core/framework/source/services/frame.cxx:1492:33 #9 0x7fcb469dd0c0 in (anonymous namespace)::XFrameImpl::close(unsigned char) core/framework/source/services/frame.cxx:1699:12 #10 0x7fcc1b185d84 in SfxViewFrame::Exec_Impl(SfxRequest&) core/sfx2/source/view/viewfrm2.cxx:246:32 #11 0x7fcc1b06c967 in SfxLokHelper::destroyView(int) core/sfx2/source/view/lokhelper.cxx:59:25 #12 0x7fcc2bf0a551 in doc_destroyView(_LibreOfficeKitDocument*, int) core/desktop/source/lib/init.cxx:4473:5 #13 0x980e57 in lok::Document::destroyView(int) core/include/LibreOfficeKit/LibreOfficeKit.hxx:512:9 #14 0x9310e4 in Document::onUnload(ChildSession const&) online/kit/Kit.cpp:1555:29 #15 0x6175e8 in ChildSession::disconnect() online/kit/ChildSession.cpp:98:30 #16 0x616c85 in ChildSession::~ChildSession() online/kit/ChildSession.cpp:85:5 I.e. normally first the vcl::Window is deleted, and only then the view shell, and the lifecycle handled in vcl::Window::ReleaseLOKNotifier(). But at least with DockingWindow, it can happen that the vcl::Window outlives its view shell, so we need to decouple the vcl::Window and its view shell (lok notifier) in both cases, no matter which object is deleted first. Change-Id: I49701817827f8b7545d07a1d74514781551db7e9 Reviewed-on: https://gerrit.libreoffice.org/78105 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-26loplugin:returnconstval in variousNoel Grandin
Change-Id: Ib5d293417b1faeb7ef63a8df99fc1ba644989cdc Reviewed-on: https://gerrit.libreoffice.org/78079 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-25sd: unit-test to check that PDF stream is shared among Graphic instancesAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/70162 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit d3a9bdd982ad1ed17cb6fef91885fc4dcf442fdb) Change-Id: Iebd85e5e60c76e6d0756d15e1fa6107a3fcc837d Reviewed-on: https://gerrit.libreoffice.org/77693 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-25pdfium: Returning a const std::shared_ptr<...>& is not recommended.Jan Holesovsky
Change-Id: Iff6acef712c5b95c8cc222fc5293c9304b1c03ec (cherry picked from commit c0a3f61ef5c42d6cfa7484a2c759e7638da2c096) Reviewed-on: https://gerrit.libreoffice.org/77692 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-25pdfium: Use std::vector to hold the PdfData.Jan Holesovsky
This fixes the destruction of the static cache of the PDF data; without this, there were already missing uno runtime info. (cherry picked from commit 20055ebe1b27f716a2acf1f0f4dda2864ae811bf) Change-Id: I877c9ccf96c4b7eabf3d643e17f324d86d987f94 Reviewed-on: https://gerrit.libreoffice.org/77691 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-25pdfium: Delay the swap out.Jan Holesovsky
If we swap out too early, the constructor of GraphicObject forces a swap in, so we'd render everything during the load anyway. Change-Id: I0ea1a755242fd57ef28d082ce4bf534a32199f87 Reviewed-on: https://gerrit.libreoffice.org/56286 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 242c7663e275a712430a8c4ac8eeacbb8b3bd440) Reviewed-on: https://gerrit.libreoffice.org/77690 Tested-by: Jenkins
2019-08-25pdfium: Avoid unnecessary copying + some warning fixes.Jan Holesovsky
Reviewed-on: https://gerrit.libreoffice.org/56285 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 4ab8dde71c8580bcf2b222ae2d1f68bbe339c754) Change-Id: I114fa6b2d3dda86c55eb245d31ca3a1019197ae9 Reviewed-on: https://gerrit.libreoffice.org/77689 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-25pdfium: Import PDF with unloaded images.Ashod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/56268 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit e07561d2ae743b208a0807ef32d7f011614b73e5) Change-Id: I5e4a16ff38b9643127ce16879b35f456c13bcff8 Reviewed-on: https://gerrit.libreoffice.org/77688 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-25pdfium: Keep the PDF data in memory, so that we can really share them.Jan Holesovsky
Otherwise the swap out / swap in creates new copy of the underlying PDF stream. Change-Id: I88a16a69143783a998201e183bea1a9553e337bd Reviewed-on: https://gerrit.libreoffice.org/56266 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/69626 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 826208d2da6c92e94b38ef447e47550285742755) Reviewed-on: https://gerrit.libreoffice.org/77687 Tested-by: Jenkins
2019-08-25Use HarfBuzz to get glyph bounding rectangleKhaled Hosny
For consistent cross-platform results that also matches our glyph advances since platform functions might be using hints which we don’t use. Keep platform-specific implementations as fallback since HarfBuzz internal font functions (that we use) did not support glyph extents for fonts with CFF table before 2.3.0. Change-Id: I62c6c703ea37d41fd0998309dacadd56565a0fae Reviewed-on: https://gerrit.libreoffice.org/77870 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-08-23Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23cid#1452394 silence Using invalid iteratorCaolán McNamara
Change-Id: Ia4851946f8c05d36f194468b931c2fcb13fb4684 Reviewed-on: https://gerrit.libreoffice.org/78046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23Qt5 some minor code cleanupsJan-Marek Glogowski
Change-Id: I1ee81de7ef03447991e12dcf01aef7858408dc40 Reviewed-on: https://gerrit.libreoffice.org/77975 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-23tdf#98130 vcl CheckBox: fix incorrect ignored mouse eventMiklos Vajna
Regression from commit 53ef550ac6fc3505914c3d77e9d0575913e54bb3 (vcl button: Delegate RenderContext to sub-methods, use Invalidate, 2015-04-28), the problem was that when clicking on the middle checkbox in the second row of the bugdoc, the click was simply ignored, the checkbox widget remained in unchecked state. The above commit changed CheckBox::GetFocus() so that it uses Invalidate() instead of ImplDrawCheckBox(), which looks innocent, but ImplDrawCheckBox() resulted in a call to CheckBox::ImplDraw(), which (as a side effect) initialized maMouseRect to a non-empty rectangle. Now in case GetFocus() was followed by MouseButtonDown() immediately, then that ignored the mouse event as the event position wasn't in the mouse rectangle. Fix this by updating the window right after the invalidate, this way we still don't paint directly, but MouseButtonDown() already has a correct maMouseRect. Change-Id: I0371a2d86a44023042cf742dec70d4558ff5de80 Reviewed-on: https://gerrit.libreoffice.org/78021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-23weld SwMailMergeWizardCaolán McNamara
Change-Id: I03a7fd1f7676792387155db986d710a001887c8d Reviewed-on: https://gerrit.libreoffice.org/77977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23Mark move ctors/assignments noexceptMike Kaganski
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-23an assistant might have no parentCaolán McNamara
Change-Id: Id85bfe822b68aafd4bccdbae3a4ebdc6baa6be4a Reviewed-on: https://gerrit.libreoffice.org/77967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23loplugin:returnconstval in vclNoel Grandin
Change-Id: Id4a0b460ba3c43e80b80ae6e2da9e40a6753e14c Reviewed-on: https://gerrit.libreoffice.org/77965 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-22tdf#71087 sfx2: avoid flicker in the start centerMiklos Vajna
There were a couple of problems here: 1) BackingWindow now does double-buffering to avoid flicker when e.g. navigating with the keyboard in sfx2::RecentDocsView 2) But then the menu background turned into white (instead of the gradient), so MenuBarWindow needs to differentiate between doing its own buffering vs painting into a buffer. 3) The focus rectangles were always painted directly, so keyboard navigation in the startcenter lost focus rectangles, making it hard to see which button is active currently. Fix this by explicitly painting a tracking rectangle in PushButton::ImplDrawPushButton(). This brings an improvement for the Windows GDI and Linux gen backends. Windows GL and Linux gtk3 is meant to be unchanged, they were already flicker-free here. Change-Id: Ib01e330c244c2b38a5b5c52399692e19ff811de3 Reviewed-on: https://gerrit.libreoffice.org/77969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-22weld chart CreationWizardCaolán McNamara
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8 Reviewed-on: https://gerrit.libreoffice.org/77954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22weld ODbTypeWizDialogSetupCaolán McNamara
split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22tdf#126560 Qt5 fix D'n'D key-modifier handlingJan-Marek Glogowski
The patch has still one problem: the key-modifier state isn't reflected by the cursor, unless the user moves the mouse. There is an upstream Qt bug, reported in 2016-09 against Qt 5.6.1! It is supposed to be fixed in Qt 5.12, according to the bug report at https://bugreports.qt.io/browse/QTBUG-56218, which is still open. I thought about adding a configure test, but I couldn't imagine any realistic way to write it. And after Michael Weghorn found the bug is actually not fixed, as claimed in one of the comments, I decided to drop the warning. Change-Id: Ice8ebc4ea149282b4c1551e755efe3d4856cf782 Reviewed-on: https://gerrit.libreoffice.org/77174 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-22loplugin:constmethod in vclNoel Grandin
Change-Id: I20545527b117c9562b91076b748fb3e2659d2497 Reviewed-on: https://gerrit.libreoffice.org/77944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-21atk: Make sure returned values are initializedSamuel Thibault
-1 is the now-document value to be used in this case, see https://gitlab.gnome.org/GNOME/atk/merge_requests/22 Change-Id: I7e8f1c64cf0dfb337f2c1ee026ca68700c893e78 Reviewed-on: https://gerrit.libreoffice.org/77750 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-21Qt5SvpGraphics::handleDamage: Don't leak BitmapBufferMichael Weghorn
Leak found by valgrind. Change-Id: If2d03e94467210bc0e485e6a81bf8480a958323d Reviewed-on: https://gerrit.libreoffice.org/77889 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-21hook GtkAssistant buildable to RoadmapWizardCaolán McNamara
Change-Id: I486ee35423be33f0f78780a43afa324aa66f5f26 Reviewed-on: https://gerrit.libreoffice.org/76904 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21jobset.h: Add missing includeMichael Weghorn
'VCL_DLLPUBLIC' is used, which is defined in '<vcl/dllapi.h>'. A compile error could be provoked e.g. by moving the 'jobset.h' include in 'vcl/unx/generic/print/genprnpsp.cxx' above all other includes. Change-Id: I39de6f213da2fa0ceaa9e9557c24062c2aef1586 Reviewed-on: https://gerrit.libreoffice.org/77883 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-20uitest: Fix typosAhmed ElShreif
Change-Id: I41023dd1fd06ca48849726d3372f74a4990c27a3
2019-08-20loplugin:constvars in vclNoel Grandin
Change-Id: Ic454a4d9520992eaecef4b64ec73d49e52ffcc2c Reviewed-on: https://gerrit.libreoffice.org/77828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20Gtk3 defer LO dragExit handling to an idleJan-Marek Glogowski
LO expects to handle either a drop or an exit event. Quoting the Gtk+ docs: "Likewise, the “drag-leave” signal is also emitted before the ::drag-drop signal, for instance to allow cleaning up of a preview item created in the “drag-motion” signal handler." Since we don't know if there will be a drop-event following the leave event, we have to defer the "fire_draExit" to an idle, which will be removed by the drop event, before it can be processed. Fixes D'n'D between two Writer windows. For whatever reason it works correct in Calc, which probably needs further investigation. Regression from commit c70b86588fe5 ("Gtk3 inform LO of drag leave"). Change-Id: Ia59dcc8b20efd442ac5efc895602e5cc432cc379 Reviewed-on: https://gerrit.libreoffice.org/77753 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-08-20Fix typosAndrea Gelmini
Change-Id: Iae76994e275517d7a1e7b9e29111159f1ec93e2d Reviewed-on: https://gerrit.libreoffice.org/77766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-20Fix typosAndrea Gelmini
Change-Id: I62577ca57b90d6575bfcf722ac2487e057a95715 Reviewed-on: https://gerrit.libreoffice.org/77767 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-19Resolves: tdf#127029 keep spinbuttons blank if explicit set_text("")Caolán McNamara
and the value isn't changed by the user Change-Id: Ib45360c0a1b057c4a31fe399aada143d758615d1 Reviewed-on: https://gerrit.libreoffice.org/77739 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19uitest: fixed for formatting and plugin stringconstantMarkus Mohrhard
Change-Id: Id657c19223f20d1175f9a774357e8b1f11344fdf
2019-08-19uitest: solve problem with un-named parentsAhmed ElShreif
1) Add recursively query for the parent until find an parent with a name. 2) Remove the parent part "from xxxxxx" from the log statment if there is un-named parent 3) Update the compiler to use the most top parent if there is command with no un-named parent Change-Id: Id7dd5092bc995312494b5536720141908e73af9a
2019-08-19uitest: log more events in Calc:Ahmed ElShreif
1) Rename Tab 2) Insert Tab Change-Id: I7a653a4b274c0c8058672c5b0aa1645bb5a51e3a
2019-08-19uitest: log more eventsAhmed ElShreif
Impress: 1) Delete Slide 2) Duplicate Slide 3) Rename Slide Draw: 1) Delte Page 2) Rename Page Change-Id: I124bdf96c58dfe00bdb039c5e93afc0dc6e7163d
2019-08-19uitest: add more events to ui loggerAhmed ElShreif
for Impress: add new Slide for Draw: add new Page Modify the UILogger System to save information about the name of the app Change-Id: I87fd98b2a11783e3410f1c0eba633631addf389b
2019-08-19uitest: start logging draw eventsAhmed ElShreif
Change-Id: I1b77b106db181a8cadc1ff0b2a5de6ad19fe6762
2019-08-19uitest: log more eventsAhmed ElShreif
for Calc: 1) Delete some Cells 2) Remove content from some cells 3) Insert Cells 4) Cut Cells 5) Copy Cells 6) Paste Cells 7) Merge Cells 8) Split Cell ( Delete Merge ) for Writer: 1) Insert Table 2) Copy Text 3) Cut Text 4) Paste Text 5) Inser Break Page Also, Solve some bugs in the UI logger and UNO Commands. Change-Id: Ic7cacbc20e1e400900a9760b61e8b45ae96c84ff
2019-08-19uitest: solve some bugs in the ui loggerAhmed ElShreif
Change-Id: I39836423fad8cb361a8f007f648108618906be8a
2019-08-19uitest: add DSL compiler support for more UI itemsAhmed ElShreif
1) ButtonUIObject 2) CheckBoxUIObject 3) TabControlUIObject 4) ComboBoxUIObject 5) RadioButtonUIObject 6) ListBoxUIObject 7) SpinFieldUIObject 8) EditUIObject Change-Id: Ic81c2a0511351cf91f4514316b9c5854a64a4b05
2019-08-19uitest: change small parts of the grammar and dialog loggerAhmed ElShreif
Change-Id: I615989baafe65a6f6ae26fcd452c1e21081168b4
generated by cgit (git 2.34.1) at 2024-08-02 23:58:25 +0000