summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-10-23tdf#120803: avoid crash if no valid vcl::WindowKatarina Behrens
when called from the destructor it is no longer alive Change-Id: Ia68272253f9c459b2647a0bd389e833fb0b519e3 Reviewed-on: https://gerrit.libreoffice.org/62228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-23weld SpecialSettingsPage and GeneratedValuesPageCaolán McNamara
Change-Id: I3b4c2a4d553032128efe25c008df30d6f1f77628 Reviewed-on: https://gerrit.libreoffice.org/61018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-23tdf#120451: Use primary screen if requested screen doesn't existKatarina Behrens
Change-Id: I3e570bdeddc82f1d8cd46a362964e53527e6c152 Reviewed-on: https://gerrit.libreoffice.org/62193 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-23Antialias drawing is part of the font selectionJan-Marek Glogowski
At least on Windows antialias-drawing has to be selected via LOGFONTW.lfQuality passed to CreateFont, so InitFont is too late. Change-Id: Ie81c5f0074fdbcf1f0e74fbff31a5df663a67884 Reviewed-on: https://gerrit.libreoffice.org/62200 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-23Implement IsUnderlineAbove in vcl::FontJan-Marek Glogowski
There was even a duplicate implementation... Change-Id: I192ac2ec8e5b8dd0e6b3ab9b9ddf0bf53df546ab Reviewed-on: https://gerrit.libreoffice.org/62199 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-22tdf#119856: [Re-]activate menu before dispatching commandKatarina Behrens
Menu entry dispatchers may be cleared (after they've been initially set) when an extension comes with its own menu entries. Activating the entry sets the dispatcher again so that dispatching a command can proceed Change-Id: I3909fb5eb6e6e2fa7db0418aca17009e60f01372 Reviewed-on: https://gerrit.libreoffice.org/62180 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-22pvs-studio: V794 The assignment operator should be protectedCaolán McNamara
Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669 Reviewed-on: https://gerrit.libreoffice.org/62166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The '!aDelData.isDeleted()' condition was already verified in line 359. Change-Id: Ie66aa65c024e30d34a4b0766ddad3fa24ce98644 Reviewed-on: https://gerrit.libreoffice.org/62163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V728 An excessive check can be simplifiedCaolán McNamara
for... "The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression" subcases, where the args are already bool Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af Reviewed-on: https://gerrit.libreoffice.org/62146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22loplugin:singlevalfields look for fields that can be boolNoel Grandin
Change-Id: Ief773b661a8378a10db56943b32127c7a2c86d11 Reviewed-on: https://gerrit.libreoffice.org/62037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-21pvs-studio: V501 same expression twiceCaolán McNamara
Change-Id: I3a2585c605ba9cb83f47fafc93653b36ab4104fc Reviewed-on: https://gerrit.libreoffice.org/62135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: A part of conditional expression is always true: !pIStmCaolán McNamara
Change-Id: I32af1d0041cebdb195e6433a0b44fa6ea271275c Reviewed-on: https://gerrit.libreoffice.org/62105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Not all members of a class are initialized inside the constructorCaolán McNamara
Change-Id: I914c715c96a6701995212fdb76615a19c984a128 Reviewed-on: https://gerrit.libreoffice.org/62113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: silence bogus V557Caolán McNamara
Change-Id: I5aa740afa1143adaf4e2afa5d5e1596497de8323 Reviewed-on: https://gerrit.libreoffice.org/62112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: silence bogus V656Caolán McNamara
Change-Id: Ib54677e4172b8d2b789cf49ab964fbcc112869f8 Reviewed-on: https://gerrit.libreoffice.org/62110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21pvs-studio: Expression 'mnInterlaced == 0' is always true.Caolán McNamara
Change-Id: Ie7f62b8eabf12010aa8f1ab03ca2f65d9c6856ed Reviewed-on: https://gerrit.libreoffice.org/62069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-21loplugin:redundantinlineStephan Bergmann
Change-Id: I5fb1c6ba516e2853b1826e20c6c21cccc1fe98fa Reviewed-on: https://gerrit.libreoffice.org/62074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-21tdf#120703 (PVS): 920d4463f6e59b815852c173e2974ffc7b4bb284 follow-upMike Kaganski
V519 The 'o_rKeyLength' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1276, 1279. V519 The 'o_rRC4KeyLength' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1277, 1280. Change-Id: I1dc4ba9097996201d97ef323113ed0b11f3cb913 Reviewed-on: https://gerrit.libreoffice.org/62120 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): handle malloc/realloc failuresMike Kaganski
V769 The 'pTmpTarget' pointer in the 'pTmpTarget - pTarget' expression could be nullptr. In such case, resulting value will be senseless and it should not be used. Check lines: 81, 67. V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'pTarget' is lost. Consider assigning realloc() to a temporary pointer. V769 The 'pTarget' pointer in the 'pTarget + nOffset' expression could be nullptr. In such case, resulting value will be senseless and it should not be used. Check lines: 85, 82. Change-Id: I883ea42fca66467edfe26382c78636c1d48c5260 Reviewed-on: https://gerrit.libreoffice.org/62115 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20use std::unique_ptrCaolán McNamara
Change-Id: I8645d1d0776f7b7f2cd6e6d18f387210c6e126d9 Reviewed-on: https://gerrit.libreoffice.org/62068 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20ImpDetectPCX 2nd arg always overwrittenCaolán McNamara
Change-Id: I0ec1e71d40c34f021003330c4dd0a8d5ee2b6ce2 Reviewed-on: https://gerrit.libreoffice.org/62018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20weld SchAttribTabDlgCaolán McNamara
Change-Id: Ia53547b7b42a3ff8848085ab8f8d214259d5cc7b Reviewed-on: https://gerrit.libreoffice.org/61959 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20wrong pointer checkCaolán McNamara
since... commit 2636ab883adbcb1f6593787934c6d6d3fff67c21 Date: Mon Sep 15 20:13:54 2014 +0200 vcl menu: Rename CloseStartedFrom() to ClosePopup() + adapt code. Change-Id: Ie30f6d907907551e23e592b8502107e75c333f2e Reviewed-on: https://gerrit.libreoffice.org/61997 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-20when calling std::lower_boundNoel Grandin
it's not enough to compare != end(), you also need to compare the key against the iterator result Change-Id: Ide5f151ba2297a35e5546f47fbc3c53cbe5ab533 Reviewed-on: https://gerrit.libreoffice.org/62014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19WIN fix CacheGlyphToAtlas resource handlingJan-Marek Glogowski
Use :comphelper::ScopeGuard to handle cleanup. And actually restore the original font on the correct DC. Change-Id: Ib59d430636b470486da2f8e5e34ed8d71b57aac2 Reviewed-on: https://gerrit.libreoffice.org/62010 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-19simplify comparisonCaolán McNamara
Change-Id: Ia298ee3e315e241ebc1c1664958d5a3a47820f28 Reviewed-on: https://gerrit.libreoffice.org/61999 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-19tdf#120452: Just enough of SystemEnvData in Qt5ObjectKatarina Behrens
the video in the presentation still doesn't play but at least the crash is gone Change-Id: I78ab4ff9412998f235a4b44a23b0e9d3ef4143e0 Reviewed-on: https://gerrit.libreoffice.org/61944 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Make repeated drag'n'drop possibleKatarina Behrens
Change-Id: If87ceeb8ddc4b2aada8ea0c963385a291622fef6 Reviewed-on: https://gerrit.libreoffice.org/61932 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Now that initiating drag works, let's also accept dropsKatarina Behrens
Change-Id: Iab328edd799dd4ce04312db4e640f86a8f7fda77 Reviewed-on: https://gerrit.libreoffice.org/61897 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19Kick-start beginning of drag eventKatarina Behrens
Change-Id: Iaad25a7acdc7d64013bc3dd0d9410e7d2d5c6762 Reviewed-on: https://gerrit.libreoffice.org/61791 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy modernize-redundant-void-argNoel Grandin
Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19loplugin:staticvar in vclNoel Grandin
Change-Id: I2bdab84dc81e0545aa96542caec213db61765f68 Reviewed-on: https://gerrit.libreoffice.org/61922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18Implement drag'n'drop-related qt5 events, no-op so farKatarina Behrens
Change-Id: I67b8cecdc85ad77d7ab48d229459a79bc168072d Reviewed-on: https://gerrit.libreoffice.org/61721 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Just enough of SystemEnvData for drag'n'dropKatarina Behrens
Change-Id: I18ef6cb58632898ddfcb28098b99447565bcfb99 Reviewed-on: https://gerrit.libreoffice.org/61720 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Basic structures for qt5 drag'n'drop supportKatarina Behrens
put (so far) no-op UNO ifaces in place Change-Id: I95394cfe05b8e3db21ddce6dfed1c1bb1d0e6381 Reviewed-on: https://gerrit.libreoffice.org/61385 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18weld SdPresLayoutTemplateDlgCaolán McNamara
Change-Id: Ifc4c9a4631e92eee4b7f9b215c41d2bcc12a17d1 Reviewed-on: https://gerrit.libreoffice.org/61926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18tdf#119847 - Can now autoselect font size on first clickNickson
Change-Id: Id49f4d039f0eb7c4efccecda91bd656c1c31d497 Reviewed-on: https://gerrit.libreoffice.org/60784 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18Qt5AccessibleEventListener: Improve mappingSamuel Mehrbrodt
Change-Id: I8852b37b2c82f88b5feb5aa42775fbfeb3c9b187 Reviewed-on: https://gerrit.libreoffice.org/61886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17fix buildRene Engelhard
Change-Id: I33451bd326697cfffb156f041dd1c2500da385da
2018-10-17tdf#120651 have to sort radiogroup by tab positionCaolán McNamara
Change-Id: I8fcf4c4b186d8292c85babaa90e98396a5fbc71b Reviewed-on: https://gerrit.libreoffice.org/61882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Implement Qt5AccessibleText::characterCountSamuel Mehrbrodt
Change-Id: I91135172bbfb34010f6c53833ac4b7c06b0f7d26 Reviewed-on: https://gerrit.libreoffice.org/61872 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17qt5 a11y: Add event notificationsSamuel Mehrbrodt
Change-Id: Idb2fb2f880b4e848adc213a4e2cea33c5eb56f05 Reviewed-on: https://gerrit.libreoffice.org/61424 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16coverity#1440242 silence Useless callCaolán McNamara
Change-Id: Idde46e74d15698e1665f3e439e3063ed5cb4f79a Reviewed-on: https://gerrit.libreoffice.org/61836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16coverity#1440300 rework to silence Using invalid iteratorCaolán McNamara
Change-Id: Icf887a54f0e999c633e4e3f514086c29842427fc Reviewed-on: https://gerrit.libreoffice.org/61835 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16loplugin:singlevalfields in vclNoel Grandin
Change-Id: I159f94fba64acc0e0599b64be02c7864b1ed02c3 Reviewed-on: https://gerrit.libreoffice.org/61813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16drop LazyDeletorCaolán McNamara
Change-Id: I7d2e00466f321994a46b0529d645e342f229c929 Reviewed-on: https://gerrit.libreoffice.org/61718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-31 22:35:59 +0000