summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-03-26tdf#67990: Management of case in comboboxJulien Nabet
I noticed these 2 points: 1) Combobox were used with autocomplete with default (false) value for matchCase => so initialize autocomplete with true value for matchCase 2) FindMatchingEntry uses bLazy as !matchCase but when bLazy = false, no autocomplete can work since you must type the whole word so just use "entryCombo" startsWith "typed string" instead of "entryCombo" == "typed string" (thank you Lionel for this tip: http://nabble.documentfoundation.org/Finding-the-right-location-for-tdf-67990-Base-module-td4143324.html) Change-Id: Ib1063002c3284122fd5279f27c1ccbc177bbac7c Reviewed-on: https://gerrit.libreoffice.org/14885 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 76f33f10309b0ee384a75a7a854858b068d60495) Reviewed-on: https://gerrit.libreoffice.org/15021
2015-03-19vcl/text: fix duplicate text in fontwork tdf#81876Pierre-Eric Pelloux-Prayer
Regression introduced by commit 2ba05b4800d6cc322276a6911792363f8eb32051 because space character will take the error code path. The error propagates up to GetTextOutlines which then uses the fallback method. In this case, we now reset any work done before, to avoid having duplicate outlines. Change-Id: Ie15524ac462d4b4bb3c482e49c4fe96a2f2d2c71 Reviewed-on: https://gerrit.libreoffice.org/14850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 162f11cdb94b415ff9d58674e94fb01a745a69eb) Reviewed-on: https://gerrit.libreoffice.org/14899 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-03-18fdo#52540, fdo#88051: fix Graphite layoutLászló Németh
The previous fixes were incomplete solutions (see the new test cases of the bug reports). Change-Id: I928f09d94edf68d268de9046c16582e6f016d561 Reviewed-on: https://gerrit.libreoffice.org/14880 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-09Resolves: fdo#86493 Fix crash while scaling large bitmaps.Ashod Nakashian
Fast bitmap scaling overflowed the LUT used by the nearest-neighbor algorithm. When a bitmap has 46k pixel on a side and is enlarged, the scaling code overflows the 32-bit long, resulting in negative indexes, which then segfaults. This isn't as rare as it sounds. At least in web-view in writer the border/shadow bitmap is as long as the document (which is an issue in its own right,) which can overflow for large documents during scaling and segfault. Reviewed-on: https://gerrit.libreoffice.org/14597 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c91bfb9ac7d110c5dca0ea34ec0e1668a985b34c) Change-Id: I1ccf73d02469f6601a9a7e67b30524cb497cf6bc Reviewed-on: https://gerrit.libreoffice.org/14809 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-09tdf#84102: Expose XAccessibleExtendedAttributes through ATKJacobo Aragunde Pérez
Those attributes contain a lot of interesting properties, among them the heading level which fixes this bug. Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b (cherry picked from commit 1e6515e64cb4a40071e09d5df000a94f96311ea1) Reviewed-on: https://gerrit.libreoffice.org/14807 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-05tdf#89482 - return size of system virtual device resource at construction.Michael Meeks
Reviewed-on: https://gerrit.libreoffice.org/14678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/inc/win/salinst.h Change-Id: I832a5626b52935180f24857e56297840667eec2a Reviewed-on: https://gerrit.libreoffice.org/14679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-02in BITFIELDS mode (3) there are *3* pal entries not 12Caolán McNamara
There are 12 *bytes*, which presumably is the thinko there. But this nPalCount gets multiplied by 4 to convert it to bytes later. This is the source of the bad mask values found after "Use the cairo-compatible basebmp surface for headless" etc. Arbitrary values ended up being read as mask values. Change-Id: If5d93f74b1c58d3ecdb5186f93cb0215a556586a (cherry picked from commit 5e5b90c12862b522a4553337fbf6309bb8278b8c) Reviewed-on: https://gerrit.libreoffice.org/14659 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-27tdf#89666: vcl: speed up HbLayoutEngine line layout for large paragraphsMichael Stahl
When formatting a 180k char Writer paragraph, most of the time is spent in vcl::ScriptRun::next(), which is called twice per line from SwTxtGuess::Guess(), once via GetTxtBreak() and once via GetTxtSize(). In the second call, from GetTxtSize(), the end position of the line is known, and passed to vcl, and iterating beyond that position seems pointless. This reduces vcl::ScriptRun::next() from 24 to 11 billion callgrind cycles when built with GCC 4.9.2 -m32 -Os. Change-Id: Ia23fcccaf5ef9c9ecdcb54bfc8f0f8a043c8711e (cherry picked from commit 7fde44c85620f8079bc4863fe3f7ea1f69a0f88c) Reviewed-on: https://gerrit.libreoffice.org/14646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-17Resolves: tdf#86159 floating windows have complicated bordersCaolán McNamara
take the border window dimensions into account on the layout size, but not the layout position (cherry picked from commit d1f38b47c29ef5e2db2cabeb657668637d97e13d) Conflicts: include/vcl/syswin.hxx Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d Reviewed-on: https://gerrit.libreoffice.org/14480 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-12Resolves: tdf#87663 update checker tries to add icon to toc preview toolbarCaolán McNamara
i.e. CRASH when attempting to add ToC to document if the updatechecker fires while this dialog is activating/active because the preview has hidden menubars which have no associated window Change-Id: I45a254dba647910d7743f6d8173c2547dd82c791 (cherry picked from commit c6b40488c07149a2fcc8023dce4e9efb9e2fdf89) Reviewed-on: https://gerrit.libreoffice.org/14445 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-12Resolves: tdf#89252 Fix bold, regular font spacing bug for Graphite fontsMartin Hosken
Change-Id: I31a09fa753ed15e302e5407ce8a0c46f3b13e099 Reviewed-on: https://gerrit.libreoffice.org/14380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0ed14401925d16932ed98bc418d395adac047b39) Reviewed-on: https://gerrit.libreoffice.org/14440
2015-02-09tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). (cherry picked from commit 905d4db48a0b98f540c8abc3e12fb80be4826029) Conflicts: vcl/source/gdi/impgraph.cxx Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82 Reviewed-on: https://gerrit.libreoffice.org/14357 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-02-06Resolves tdf#89129: crash when defining a specific relationshipJulien Nabet
Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging. Cherry-picked from 30f6ec7cfdf63cea265148bbe3a07d8df34e96d5 /usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy- construct an iterator from a singular iterator. Objects involved in the operation: iterator "this" @ 0x0x7fffffff3a30 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = past-the-end; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } iterator "other" @ 0x0x7fffffff3a90 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = singular; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } 4 0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121 5 0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179 6 0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340 7 0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342 Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62 Reviewed-on: https://gerrit.libreoffice.org/14325 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-on: https://gerrit.libreoffice.org/14348
2015-02-03tdf#88051 fix Graphite layout at Linux Libertine G ligature followed by tabLászló Németh
Change-Id: Iecedb87f6329c1cddcaa4cd939b349924e58d256 Reviewed-on: https://gerrit.libreoffice.org/14200 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Resolves: fdo#87639 Image-filter Smooth crashesCaolán McNamara
regression from commit 10e77ab3ff6f4314137acd6e2702a6e5c1ce1fae Author: Thorsten Behrens <thb@documentfoundation.org> Date: Sun Nov 2 22:37:32 2014 +0100 coverity#1242508: swapped arguments rename the variables to indicate which are source and which are dest indexes and that the aNewBitmap argument is always, and assert that it must be, of equivalent rotated source to the Bitmap which has ImplConvolutionPass called on it. Change-Id: If9715b9f29655da66c6981c0f7cab3d89c528ed7 (cherry picked from commit 4b9ecfd4f45501e4696f966c714fc2bcc43ce38b) Reviewed-on: https://gerrit.libreoffice.org/14115 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-30rhbz#1177022: vcl: fix PDF embedding of Type 1 fontsMichael Stahl
Problem is that for the "CM Typewriter" font the Width for "space" (32) is exported as 0 instead of 525, which is the correct value in the AFM. The reason is that PDFWriterImpl::emitEmbeddedFont() has various arrays to map from font code points to Unicode code points, and there are duplicate mappings, so the 160->32 mapping overrides 32->32. The PrintFontManager::PrintFont::readAfmMetrics() actually creates a Unicode to font code mapping (which may legitimately be n:1) that is then inverted; add an additional hack to store a set of "preferred" Unicodes so that PDFWriterImpl can pick the right Unicode. Presumably the code that is stored explicitly via "C" or "CH" in the AFM should take priority over more generic mappings. (cherry picked from commit 5183910a90e97cafc3cfaaad40acdaec0b792f6d) Conflicts: vcl/inc/cairotextrender.hxx vcl/inc/textrender.hxx vcl/inc/unx/salgdi.h vcl/source/gdi/pdfwriter_impl.cxx Change-Id: Id4205a1cd45ba6a0a5facee1e39f70c3535e7dd4 Reviewed-on: https://gerrit.libreoffice.org/14205 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-28when drawing a transformed bitmap in opengl backend, scale it betterLuboš Luňák
The plain scaling is rather rough, and in fact drawing a scaled bitmap the normal way gives much better results (because OutputDevice pre-scales the bitmap before it's drawn). This one may be a bit slow perhaps, but hopefully nobody there's no code that'd extensively use bitmap drawing with custom transformations (wishful thinking). Change-Id: I83e05307adfaeac0ed0757f1a0b2603f64caf8f8 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28make it possible to easily have variants of glsl programsLuboš Luňák
Now it's possible to add a preamble to the compiled program, so there can be just one program with #ifdef's inside and the small variants can be selected using #define in the preamble instead of having several almost identical programs. Change-Id: I6c5112313b91b6269ebdecdfc896e0f96209ea2b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28prefer ptr_container to manual memory managementMarkus Mohrhard
Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: vcl/source/opengl/OpenGLContext.cxx Change-Id: I11326c2873aad5116fd70bfa31eb94e93fef3f40
2015-01-28some debug code for finding leaked OpenGLContextsMarkus Mohrhard
Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28Apply GLSL patch for areaScaleFragmentShaderChris Sherlock
Thanks to Lubos Lunak Change-Id: I9bb72e1a5b11102963481dac7c11ab4a9fe90b0b Signed-off-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/14095 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28there's no bigger or smaller halfLuboš Luňák
Change-Id: Ida0e92abd806d017d17365fa2ac53b4f7cb2ebad Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-28draw polypolygon outline properly (if wanted)Luboš Luňák
Again, polygons can apparently have curved edges. Change-Id: I6519da7bb7f0dde7f1550fe6b03c09be127f77d6 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-27don't strip font names of apparent script suffixes anymoreCaolán McNamara
e.g. "CM Roman CE" should be left alone. bump font cache id to invalidate old cached lists I think this practice stems from Window 3.1/Word 95 where the encoding was included in the font name http://www.webcenter.ru/~kazarn/eng/fonts_ttf.htm#charsettbl Microsoft Office still generates RTF files with weird-ass Win 3.1 style fontnames but any actual existing fonts that happen to have names that fall into that pattern should be left alone now. Change-Id: Ibb704048d63b33ce510d6b1076700c6e94a0af2a (cherry picked from commit 15e1c881684c0127c0ca989924bbf2508b4fd780) Reviewed-on: https://gerrit.libreoffice.org/14210 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27Resolves: rhbz#1177022 no width set on space glyph with CM Typewriter fontsCaolán McNamara
Change-Id: I0dfb044b8a339fa6c473e42f31fc28c200cd03ea (cherry picked from commit 37dc4bdbf25847c95f1668553dbae3e2dc885816) Reviewed-on: https://gerrit.libreoffice.org/14204 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27font cache gets broken on adding an embedded fontCaolán McNamara
Change-Id: I665cde5d4c89443238efb283c86277dedf621197 (cherry picked from commit 20142afafc809890d5e8dcfd4103c46319a488df) Reviewed-on: https://gerrit.libreoffice.org/14045 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-27Resolves: tdf#88819 printing with ps hangsCaolán McNamara
regression from commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Nov 14 11:06:44 2014 +0000 coverity#705989 silence Insecure temporary file and coverity#705983 Insecure temporary file Change-Id: If580196322e68098adc38a9fdb775827843a9c30 Reviewed-on: https://gerrit.libreoffice.org/14202 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-23calling alloca() requires #include <sal/alloca.h>Michael Stahl
Change-Id: I59e5ede0c0cfb10f4196d79ae762132ae4ecb9bb (cherry picked from commit 91567c26f436ccce0fb60ad6a9671f046a4a68e7) Reviewed-on: https://gerrit.libreoffice.org/14125 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-21do not draw with SALCOLOR_NONELuboš Luňák
Change-Id: I882a42f58ac298d333985068b2fe6ef9ac198c8b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-20accidentally ran make with VALGRIND set and walked away...Caolán McNamara
and found this bug triggered by CppunitTest_filter_eps_test when I got back Change-Id: I20943e5bd0fbf8aed923699dd5f1e88fada43e81 (cherry picked from commit 6cf58a33676cebc9f2c1d26163793ba7dce46262) Reviewed-on: https://gerrit.libreoffice.org/14044 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-20Fix Windows build (typo: VENT_COMMAND instead of EVENT_COMMAND)László Németh
Change-Id: I31ba4b911dfc0acbcc4dece80bb5ed8bedb4cd54 Reviewed-on: https://gerrit.libreoffice.org/14048 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Resolves: fdo#32664 pass keyboard media keys through to the OSCaolán McNamara
if we didn't make use of them. (cherry picked from commit 508c020cf5f7999f0c23d972133f9b6bf85de245) Conflicts: sw/source/uibase/docvw/edtwin.cxx vcl/osx/salinst.cxx vcl/win/source/window/salframe.cxx Change-Id: Iee1c2fef5966a614b068c832bf8c6b51973b4c8a Reviewed-on: https://gerrit.libreoffice.org/13993 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Resolves: fdo#88417 Dropdown for ruler settings should show radio buttonsCaolán McNamara
This reverts commit 9995222d1141b326197a387cc7897b3971ce9e9a and additionally converts the ruler settings to radio buttons and not checkboxes Conflicts: vcl/source/control/tabctrl.cxx Change-Id: Ie0eac5f07729447942065b7f415398165fbf067c (cherry picked from commit 251737f0dd186b0f169f5ba237e1e8c28a320e00) Reviewed-on: https://gerrit.libreoffice.org/14017 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-01-19vcl: fix glsl int casts of floats.Michael Meeks
Change-Id: Ifa22e2914a1e34f6e2fd635973eca4101914bb88 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-01-19try to handle properly fillcolor != linecolor in opengl polypolygons drawingLuboš Luňák
Change-Id: I962416f48fdb348d8a3d95edf747cfe2f1c929c9 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19draw polypolygons properly in opengl backendLuboš Luňák
The polygons that make the polypolygon cannot be simply drawn one onto another, because if they overlap, it's actually xor (as used e.g. for drawing the border when editing a text box Impress, which without this fix just made it a full rectangle instead of a frame). Change-Id: I67c7f6448fb3ee0f9742a2299c612515abff68d8 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19fix opengl hairline special casingLuboš Luňák
Apparently polygons can consist of curves too. Change-Id: Ie35861e6d182e4bd4ac0523e78a90618c96f09a6 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19use AA for convex polygons when needed tooLuboš Luňák
Change-Id: I8e66d369956a9bcf9c63c6eccad47d4b7a7eb67d Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19use supersampling in Impress if fast opengl scaling is availableLuboš Luňák
So far it's been always disabled, with the exception of the slide preview extension. Change-Id: Iaee6fe2d5267c9dfdc31cbf4fb90a9ac0e08e781 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19"area" scaling for opengl that has good results for downscalingLuboš Luňák
Change-Id: I0e4ad776cbf31f9a130aedf0f9741927560b5ac1 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19implement optimized hairline drawing for openglLuboš Luňák
As a side effect, this prevents the lines from looking too wide, because of generic polygon drawing being a bit too generous with AA. Change-Id: I17314c39fd57e33ecbd10b8a8785c600bdc5b212 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19do not set Y line width to 0Luboš Luňák
I'm somewhat confused by why there needs to be a separate line width for X and Y, but apparently there is, and the latter shouldn't be just plain 0 (otherwise a number of drawPolyLine() implementations either skip using a simpler path for the usual case of them being equal, or even plain to refuse work at all and cause a fall back). And I hope this doesn't lead to finding out that some of those implementation are actually buggy. Change-Id: I2dbbd1539c4a96d41935cce9ae6565872e2a459b Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19make AA edges of objects look smoother (opengl)Luboš Luňák
Change-Id: I66a04febdbfa673e0883ab6f574bb7768cad7953 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19clean up resetting of solid color when using opengl AALuboš Luňák
118529d4644a and 011903894 might have been technically correct, but 'mProgramIsSolidLineColor' is clearly a misnomer at best, and they'd have made it even more likely that this would break yet again. Change-Id: I1f01663e2abc0b1b0e557ae7241637a96e1a402a Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19fix confusion between transparency and opacityLuboš Luňák
Change-Id: Ifa69f3272ebda2a61ac00d2affb8aebd4524f0fc Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-19loplugin:saloverrideStephan Bergmann
Change-Id: I4509ee714622ad1fcccfed9255a474727e0f8e16 (cherry picked from commit 7c2250cbd2fc392e11cb1fe70ff139457968e23a)
2015-01-17no need to do that for all contextsMarkus Mohrhard
This fixes a crash as we would need to make each context current before calling ReleaseFramebuffers. However this is totally unnecessary as only the current context can have bound framebuffers. Change-Id: I8b1496bb890982742b3d2ebf60fdce47db642d70 Reviewed-on: https://gerrit.libreoffice.org/13973 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-01-16fdo#86674 paragraphs have ATK_STATE_INVALIDNiklas Johansson
A few states have been added in the IA2 integration. These need to be handled somehow on linux as well. At the moment they all get the state INVALID. Let's add the state DEFAULT that already have a equivalent. The state MOVEABLE is causing the issues in paragraphs of LibreOffice Writer. The state is not invalid so let's avoid reporting it at all. There must be a cleaner way of doing this however. Change-Id: I859439f92fe19f5050195383f43fa4af787b249e Reviewed-on: https://gerrit.libreoffice.org/13727 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit df5fa4082cfb17c5d5be6678995689485df6d429) Reviewed-on: https://gerrit.libreoffice.org/13947
2015-01-13opengl scaling can also handle the generic aliasesLuboš Luňák
Was missing from 82bc764bc9, without this opengl scaling wasn't used for these. Change-Id: If853435b12383e799afe2f057c43263b2d2297fa Reviewed-on: https://gerrit.libreoffice.org/13872 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-12Resolves: fdo#87015 image missing from docCaolán McNamara
regression from commit e0cce521f1ad0cc384d30ce2f1077ea229fffe62 Author: Armin Le Grand <alg@apache.org> AuthorDate: Thu Jan 10 16:28:40 2013 +0000 Commit: Caolán McNamara <caolanm@redhat.com> CommitDate: Thu Jun 13 14:50:46 2013 +0100 Resolves: #i121504# Support for alpha channel in clipboard for all systems (cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519) which blindly just bulldozed out the bMSOFormat branch Change-Id: Iec354f1fb585f0803b9df472bc9ec9e103aa5847 (cherry picked from commit 470fcca594ba4f6bf473d4d44b415c2ba151b0d9) Reviewed-on: https://gerrit.libreoffice.org/13874 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>