summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-12-21set dbus id for existing DbusSessionHelper usersCaolán McNamara
Change-Id: I64329e21ae79b6607856de9781bee0274b9cb136 Reviewed-on: https://gerrit.libreoffice.org/46854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21add html fuzzerCaolán McNamara
This reverts commit 111db5b992ae5870e76313f76e633a4edcccf010. Change-Id: I1138592ab54865f4c2ac4599fab572c5666bf723 Reviewed-on: https://gerrit.libreoffice.org/46864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21Resolves: tdf#114592 mark geometry as provisionalCaolán McNamara
when we predict what it will be and use that flag to decide to forward notification of arrival of confirmation of geometry Change-Id: I4a7334d75eb7977c85aebcf2b652cc4b2d6b25bb Reviewed-on: https://gerrit.libreoffice.org/46911 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-21Prevent out-of-order LO event processingJan-Marek Glogowski
There's a callback processing loop, introduced by a7c84375db517769035080c8fed33b2f303fc42f, which releases the SolarMutex and is triggered by a queued user event. Such a scenario can easily be reproduced by any LOK client resulting in hitting the empty user event processing list assertion. I'm not sure this should be handled via LO events at all. So this - again - gets rid of the the assertion and tries to prevent processing the user events out-of-order. In the case of giving up the SolarMutex while processing a user event an other thread or even nested loop can "steal" the user event list and continue processing. Most VCL backends run the event loop just in the main process, so for them this scenario is guaranteed. But the headless backend - running without UI or from LOK - is still allowed to process events in any thread. This is harder to fix and probably should use the same solution the gtk* backends use. This also changes the dequeues into lists to use splice for appending them. Change-Id: Id4a93a01dea415271ad96098830f18f06d4a75b9 Reviewed-on: https://gerrit.libreoffice.org/46550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-12-20remove html fuzzerCaolán McNamara
still not ready after all This reverts commit 6fc7f85de7f0bfa8ee36f867e321a8816ad1e385.
2017-12-20add html fuzzerCaolán McNamara
Change-Id: I03a61421c477642548d9814610faeb570bd34c8d Reviewed-on: https://gerrit.libreoffice.org/45970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-20Related: tdf#79657 Different approach to disable the context menuMaxim Monastirsky
... in the overflow toolbar. Using ToolBoxMenuType::NONE is wrong as it might affect the layout. Can be easily triggered here by adding FloatWinPopupFlags::GrabFocus to StartPopupMode (which likely will be needed to fully solve tdf#79657). Another case was fixed in 91053763a7189c8ac03a59dc996e6333404f846e ("Fix sub-toolbar tearoff for .uno:ChooseControls"), but without providing a solution for the context menu. Change-Id: I4a0b4560fe49106613fa2337b5dd83eb7fa29f47 Reviewed-on: https://gerrit.libreoffice.org/46837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-20coverity#1426738 Dereference null return valueCaolán McNamara
Change-Id: I85957928c2f7fa742d379f289192c05e3f4177a8
2017-12-20reversed assertCaolán McNamara
Change-Id: I018417df11a41ebb1c453a51a70368b0eae8f6d4
2017-12-20lokdialog: Use Application::Post{Mouse,Key}Event() to post to main threadPranav Kant
... instead of custom machinery there to post to main thread. This also now posts window key events to the main thread instead of processing them on the lok thread. Change-Id: Ided1efb3f237a1838fa50bb8d74752be714c3032
2017-12-20tdf#79077: Cleanup PapersizeFromSetup related codeKatarina Behrens
Change-Id: If77c43a7eb97de0a2e23195a9539f00e452343d8 Reviewed-on: https://gerrit.libreoffice.org/45096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-20tdf#79077: copy 'paper from printer setup' toggleKatarina Behrens
into printer properties dialog, it is rather badly accessible (almost invisible) in File > Print > Options tabpage Change-Id: I18d538a20dc207c359ae1e7c2c914a68daf58f31 Reviewed-on: https://gerrit.libreoffice.org/43956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-20Fix typoAndrea Gelmini
Change-Id: I70dc1742bc9462db96c4be7d37d1881a8cb0b0a6 Reviewed-on: https://gerrit.libreoffice.org/46788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19vcl: explicitly qualify ICU types with icu:: namespaceEike Rathke
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: Iecb30b903e9a67252147a8cc78c641621d763755
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19coverity#1426313 Unchecked return valueCaolán McNamara
Change-Id: Ic6eb7eec01ced2105144b123f8f9f8ecd25f6008 Reviewed-on: https://gerrit.libreoffice.org/46702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19loplugin:unusedenumconstantsNoel Grandin
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7 Reviewed-on: https://gerrit.libreoffice.org/46684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Fix typosAndrea Gelmini
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19show rest of the menu bar in a pop-up if the are is too smallTomaž Vajngerl
In case when the window is to small to show the whole menu then the use couldn't access the rest of the items in the menu. This change adds a button in the end (using the ">>" marker as in toolbar) which on click adds a pop-up that shows the rest of the menu items. Change-Id: I9218dba504464bdd44d61ebb383f7674f3df760f Reviewed-on: https://gerrit.libreoffice.org/46711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-19menu: pass paint size to ImplPaint and account for buttonsTomaž Vajngerl
When a menu bar is painted it needs to take into account that the buttons (close) is positioned at the right side of the paint area. To do this we need to pass what the output size is when painting (ImplPaint) on the common menu code, instead of assuming the whole area can be used. Change-Id: I2e9d6c686929fe1cd7e28368a8055c1e2df13c49 Reviewed-on: https://gerrit.libreoffice.org/46710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-19coverity#1426314 silence Resource leakCaolán McNamara
Change-Id: I266463184f902df11943a23fa4129086c6441783 Reviewed-on: https://gerrit.libreoffice.org/46703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17ofz#4678 ensure null terminationCaolán McNamara
Change-Id: I6b6b0763e85a41d03f9e03c6abc17c6c311f6519 Reviewed-on: https://gerrit.libreoffice.org/46641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16Fix typosAndrea Gelmini
Change-Id: Iedb99e41887ebfd6fa290bc113b473c5cc9693b4 Reviewed-on: https://gerrit.libreoffice.org/46600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-16sal_uLong->SalPrinterError in SalPrinterNoel Grandin
and define a default implementation in the base class that returns SalPrinterError::NONE, since only one of the subclasses wants to override and return something useful Change-Id: Id41ff90693527e8624cc2993b7481114af85fcee Reviewed-on: https://gerrit.libreoffice.org/46509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16sal_uIntPtr->sal_uInt32 in yieldCountsNoel Grandin
to match the underlying field in GenericSolarMutex Change-Id: I98dcab3b684278c4a184534ba782b5b03b0504f0 Reviewed-on: https://gerrit.libreoffice.org/46508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15lokdialog: Give non-programmatic name to autofilterPranav Kant
Change-Id: I8670a5aaa1703677cab173b2341c6e70e689f61a (cherry-picked from 04abf03ecb18ccf1f805faa763d6f29013efc6bb)
2017-12-15lokdialog: If we already have the title, emit it during creationPranav Kant
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 (cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
2017-12-15Protect all LogicalFontInstance constructorsJan-Marek Glogowski
This way LogicalFontInstance can just be constructed by a PhysicalFontFace based factory. The patch also drops the wrong "Java logical font" comment added by commit 125cdf3404e60cf78f2a5547e9a06ce994df5c8e. Change-Id: Ibd5d7da0c3a65dbfa2c8ae6b05cf616d39b749f2 Reviewed-on: https://gerrit.libreoffice.org/46475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-12-15Report more debug information about caught exceptionStephan Bergmann
...in an attempt to track down why various tinderbox builds started to fail CppunitTest_sw_filters_test with an "Uncaught exception during Task::Invoke()!" abort. On IRC, jmux claims that catching exceptions and turning them into abort() here (instead of letting them propagate) is necessary: "The main problem was the wrong state in the scheduler. So something actually handled the exception, but the next caller into the scheduler had an invalid linked list of tasks, breaking things left and right." Change-Id: Ic3365e282404483518652c00160c2036b79991cf Reviewed-on: https://gerrit.libreoffice.org/46450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15loplugin:salcall (macOS)Stephan Bergmann
Change-Id: I297ac09358ce948acae9b73e8ed605964520c73b Reviewed-on: https://gerrit.libreoffice.org/46437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15sal_uIntPtr/sal_uLong->void* in Popover idsNoel Grandin
Change-Id: Ifd7eeadeacffb90ea303c1e6bca807d310098f66 Reviewed-on: https://gerrit.libreoffice.org/46484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->sal_uInt32 in X11SalGraphicsImplNoel Grandin
which matches the call sites Change-Id: I4db0c87f29c3368f32d600a10b5f43cb5ea6027c Reviewed-on: https://gerrit.libreoffice.org/46483 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14Fix memleakPranav Kant
Change-Id: I557b2f43263fc125d0ee87b968dee1893e4ca7cf
2017-12-14lokdialog: Unblock custom window mouse key eventsPranav Kant
In some cases, the mouse event blocks. Eg: when the mouse event is responsible for launching a new dialog (cf. Spell dialog -> Options). We don't want any kind of blocking behavior whatsoever in LOK. Post all custom window mouse events back the main-loop thread and keep the current LOK thread free. Change-Id: I018870fadcb62dbb7b33a7d93f8af3a0000442b5
2017-12-14Move call to Scheduler::ImplDeInitScheduler in DeInitVCL back to orig. placeStephan Bergmann
Dec 13 16:18:27 <sberg> jmux, any reason fd0fff67798fea87217e65bb1561aa0d0e741c51 moved the call to Scheduler::ImplDeInitScheduler() in DeInitVCL (vcl/source/app/svmain.cxx) past the call to the pSVData->maDeInitHook? Dec 13 16:18:30 <IZBot> core - Assert active Tasks on scheduler de-init - http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd0fff67798fea87217e65bb1561aa0d0e741c51 Dec 13 16:20:06 <sberg> jmux, observing a crash in CppunitTest_dbaccess_firebird_test here when comphelper::geProcessServiceFactory wants to be used after it has been cleared, <https://paste.fedoraproject.org/paste/H8bVCcpNjSipm59Ih952nw> Dec 13 16:22:41 <jmux> sberg: no. That was still during the analysis with all those static tasks and cleanup problems. Dec 13 16:23:17 <sberg> jmux, I'll see what breaks if I move the call back to its original place, then The relevant backtraces from <https://paste.fedoraproject.org/paste/H8bVCcpNjSipm59Ih952nw>: > #0 0x00007fffee08c160 in comphelper::setProcessServiceFactory(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) (xSMgr=...) at comphelper/source/processfactory/processfactory.cxx:55 > #1 0x00007fffe8b120eb in (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) () at test/source/setupvcl.cxx:54 > #2 0x00007fffe8b11f8d in (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) (instance=0x0, data=0x0) at test/source/setupvcl.cxx:37 > #3 0x00007fffe76a9cb1 in Link<LinkParamNone*, void>::Call(LinkParamNone*) const (this=0x7fffe8374418 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+984>, data=0x0) at include/tools/link.hxx:84 > #4 0x00007fffe79c5baf in DeInitVCL() () at vcl/source/app/svmain.cxx:517 > #5 0x00007fffe8d1cc0a in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:34 > #6 0x00007fffe8d1cc5e in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:43 > #7 0x00007ffff7b962f3 in CppUnit::ProtectorChain::pop() (this=0x630e00) at ProtectorChain.cpp:56 > #8 0x00007ffff7ba65d4 in CppUnit::TestResult::popProtector() (this=0x7fffffff2870) at TestResult.cpp:196 > #9 0x0000000000408998 in (anonymous namespace)::ProtectedFixtureFunctor::run() const (this=0x7fffffff2840) at sal/cppunittester/cppunittester.cxx:328 > #10 0x0000000000409484 in sal_main() () at sal/cppunittester/cppunittester.cxx:469 > #11 0x000000000040900b in main(int, char**) (argc=23, argv=0x7fffffff2be8) at sal/cppunittester/cppunittester.cxx:376 and > #0 0x00007fffee08c213 in comphelper::getProcessServiceFactory() () at comphelper/source/processfactory/processfactory.cxx:64 > #1 0x00007fffee08c651 in comphelper::getProcessComponentContext() () at comphelper/source/processfactory/processfactory.cxx:96 > #2 0x00007fffe79a7281 in setupPersonaHeaderFooter(WhichPersona, rtl::OUString&, BitmapEx&, boost::optional<Color>&) (eWhich=PERSONA_HEADER, rHeaderFooter=..., rHeaderFooterBitmap=..., rMenuBarTextColor=...) at vcl/source/app/settings.cxx:2135 > #3 0x00007fffe79a7c96 in StyleSettings::GetPersonaHeader() const (this=0x15d7130) at vcl/source/app/settings.cxx:2214 > #4 0x00007fffe757285f in MenuBarWindow::ApplySettings(OutputDevice&) (this=0x1644ee0, rRenderContext=...) at vcl/source/window/menubarwindow.cxx:1022 > #5 0x00007fffe7488fdb in PaintHelper::DoPaint(vcl::Region const*) (this=0x7fffffff1720, pRegion=0x0) at vcl/source/window/paint.cxx:298 > #6 0x00007fffe748a74e in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x1644ee0, pRegion=0x0, nPaintFlags=(ImplPaintFlags::PaintAll | ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at vcl/source/window/paint.cxx:606 > #7 0x00007fffe748a0e5 in PaintHelper::~PaintHelper() (this=0x7fffffff1890, __in_chrg=<optimized out>) at vcl/source/window/paint.cxx:540 > #8 0x00007fffe748a7a7 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x1510d40, pRegion=0x0, nPaintFlags=ImplPaintFlags::PaintChildren) at vcl/source/window/paint.cxx:603 > #9 0x00007fffe748a8ea in vcl::Window::ImplCallOverlapPaint() (this=0x1510d40) at vcl/source/window/paint.cxx:630 > #10 0x00007fffe748aa34 in vcl::Window::ImplHandlePaintHdl(Timer*) (this=0x1510d40) at vcl/source/window/paint.cxx:651 > #11 0x00007fffe748a929 in vcl::Window::LinkStubImplHandlePaintHdl(void*, Timer*) (instance=0x1510d40, data=0x1511940) at vcl/source/window/paint.cxx:634 > #12 0x00007fffe79c7f33 in Link<Timer*, void>::Call(Timer*) const (this=0x1511960, data=0x1511940) at include/tools/link.hxx:84 > #13 0x00007fffe79c7d97 in Timer::Invoke() (this=0x1511940) at vcl/source/app/timer.cxx:76 > #14 0x00007fffe799a873 in Scheduler::ProcessTaskScheduling() () at vcl/source/app/scheduler.cxx:440 > #15 0x00007fffe7999d95 in Scheduler::CallbackTaskScheduling() () at vcl/source/app/scheduler.cxx:263 > #16 0x00007fffe7ad3bbb in SalTimer::CallCallback() (this=0x156fbc0) at vcl/inc/saltimer.hxx:55 > #17 0x00007fffe7ad3209 in SvpSalInstance::CheckTimeout(bool) (this=0x730900, bExecuteTimers=true) at vcl/headless/svpinst.cxx:188 > #18 0x00007fffe7ad35b8 in SvpSalInstance::DoYield(bool, bool) (this=0x730900, bWait=false, bHandleAllCurrentEvents=true) at vcl/headless/svpinst.cxx:272 > #19 0x00007fffe79be4a1 in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=true) at vcl/source/app/svapp.cxx:469 > #20 0x00007fffe79ba4c7 in Application::Reschedule(bool) (i_bAllEvents=true) at vcl/source/app/svapp.cxx:486 > #21 0x00007fffe79ba4f9 in Scheduler::ProcessEventsToIdle() () at vcl/source/app/svapp.cxx:492 > #22 0x00007fffe79991a9 in Scheduler::ImplDeInitScheduler() () at vcl/source/app/scheduler.cxx:114 > #23 0x00007fffe79c5f80 in DeInitVCL() () at vcl/source/app/svmain.cxx:579 > #24 0x00007fffe8d1cc0a in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:34 > #25 0x00007fffe8d1cc5e in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:43 > #26 0x00007ffff7b962f3 in CppUnit::ProtectorChain::pop() (this=0x630e00) at ProtectorChain.cpp:56 > #27 0x00007ffff7ba65d4 in CppUnit::TestResult::popProtector() (this=0x7fffffff2870) at TestResult.cpp:196 > #28 0x0000000000408998 in (anonymous namespace)::ProtectedFixtureFunctor::run() const (this=0x7fffffff2840) at sal/cppunittester/cppunittester.cxx:328 > #29 0x0000000000409484 in sal_main() () at sal/cppunittester/cppunittester.cxx:469 > #30 0x000000000040900b in main(int, char**) (argc=23, argv=0x7fffffff2be8) at sal/cppunittester/cppunittester.cxx:376 Change-Id: I75ee6a7b663f6117f004877fc9ba5a3ed79d66e4 Reviewed-on: https://gerrit.libreoffice.org/46415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-14sal_uIntPtr->unsigned long in SystemEnvDataNoel Grandin
to match the type used by X11 Change-Id: I5fe043e33602be21c84b81780c89df751c3bc96c Reviewed-on: https://gerrit.libreoffice.org/46393 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13Fix --enable-qt5Stephan Bergmann
...after e75abe6e0a4ea250366bb29c0ece697e9b1b80a1 "convert tolerance params to sal_uInt8" Change-Id: I6677fa21d4786ebadcded53e1542514465d5d0a2
2017-12-13sal_uLong->void* for userdata in MenuNoel Grandin
Change-Id: I58fb10136a23c445edfd63a1f86ace3995524704 Reviewed-on: https://gerrit.libreoffice.org/46350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13convert tolerance params to sal_uInt8Noel Grandin
since their range is 0-255 Also drop pTols from ImplColReplaceParam, since it is always nullptr. Change-Id: I9e9ab7f7596e18cab1d67dd69922e5ac9867f45b Reviewed-on: https://gerrit.libreoffice.org/46274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-12Remove obsolete "explicit operator bool" hackStephan Bergmann
...and fix the call sites that exploited the hack's internals being non- transparent. Change-Id: Ib3b06c3945e303d4088c4e1b65be5beed8613bac Reviewed-on: https://gerrit.libreoffice.org/46325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-12tdf#114408 set correct tooltip rectangleCaolán McNamara
The original code tried to get the position of the window relative to its parent and then ask the parent to adjust that position to a position relative to the toplevel. But the position to use in that case should have be WindowImpl::nX/WindowImpl::nY not GetPosPixel() Much easier to just directly ask the the current window for its position relative to the toplevel. Change-Id: Iff202f052bc651a8c0e3a57ff3322e5e2a3e4b9a Reviewed-on: https://gerrit.libreoffice.org/46314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12tdf#114407 let tooltip children of non-nwf widgets be nwf themedCaolán McNamara
alternative is to not use themed text color when writing text in non-nwf tooltips Change-Id: I12556d5fd9a38c4b36f77c97144898f08fa4d738 Reviewed-on: https://gerrit.libreoffice.org/46312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12Revert "lok: Assertion `m_aProcessingUserEvents.empty()' failed"Henry Castro
This reverts commit ad35cc9ed0faa6555bc09e5e065abb5cdc6c4ee6. Change-Id: I8943deb0b78a14d10ed6e8d052b2ac8eb58bccae Reviewed-on: https://gerrit.libreoffice.org/46321 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2017-12-12lok: Assertion `m_aProcessingUserEvents.empty()' failedHenry Castro
This occurs after saving a writer document loolforkit: /home/hcastro/projects/lo-sid/vcl/source/app/salusereventlist.cxx:56: bool SalUserEventList::DispatchUserEvents(bool): Assertion `m_aProcessingUserEvents.empty()' failed. /home/hcastro/build/gcc-lool-sid/loolforkit(_ZN7SigUtil13dumpBacktraceEv+0x49) [0x55ba3f0740c6] /home/hcastro/build/gcc-lool-sid/loolforkit(+0x149fb1) [0x55ba3f073fb1] /lib/x86_64-linux-gnu/libpthread.so.0(+0x110c0) [0x7f57a41350c0] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xcf) [0x7f57a3db7fcf] /lib/x86_64-linux-gnu/libc.so.6(abort+0x16a) [0x7f57a3db93fa] /lib/x86_64-linux-gnu/libc.so.6(+0x2be37) [0x7f57a3db0e37] /lib/x86_64-linux-gnu/libc.so.6(+0x2bee2) [0x7f57a3db0ee2] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN16SalUserEventList18DispatchUserEventsEb+0x86) [0x7f5798f2178c] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN14SvpSalInstance7DoYieldEbb+0x3b) [0x7f57990ce48d] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(+0xa7b2fd) [0x7f5798f5b2fd] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN11Application5YieldEv+0x13) [0x7f5798f5735b] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN11Application7ExecuteEv+0x167) [0x7f5798f56f11] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(+0x4e419) [0x7f57a30d3419] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(+0xa87119) [0x7f5798f67119] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_Z6SVMainv+0x4d) [0x7f5798f67282] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(soffice_main+0x1bf) [0x7f57a312a6b5] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(+0xe8db2) [0x7f57a316ddb2] /home/hcastro/build/gcc-lo-sid/instdir/program/libuno_sal.so.3(+0x77581) [0x7f579f807581] /lib/x86_64-linux-gnu/libpthread.so.0(+0x7494) [0x7f57a412b494] /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f) [0x7f57a3e6daff] Change-Id: I455bd44d40c6c9b3ed49d047b8bce23a4600c265 Reviewed-on: https://gerrit.libreoffice.org/46206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-11loplugin:salcallStephan Bergmann
Change-Id: I7521b2adb9572efbb1d28f9f44f9d29c62d6e1e9
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10Use some for range loops in vclJulien Nabet
Change-Id: I58a334e4d1252b2addd6784ab60d15b60593f722 Reviewed-on: https://gerrit.libreoffice.org/46184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-08-14 11:12:23 +0000