summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-06-01various sft fixesCaolán McNamara
backport removing unneeded code use ptr diff rather than int (cherry picked from commit 5b426038a7befcaf0d05824ffb20200ff8833ad3) fix mem leak (cherry picked from commit 603cb6cf31a5212d03736a552770e5734b0e8066) check more table sizes (cherry picked from commit 1828490bb22f1c8273c4a9f5b1db819b173ca70d) check cmap offset (cherry picked from commit 683d9883ad8fd6568e6a7832e5bb347c1d043e4b) check tableoffset against size (cherry picked from commit ae73c3ff112e1ed38eb4678ac5745990661a2e66) check ntables offset (cherry picked from commit 75a171a405afd6eac236af93aa9d29a9c3ec9c64) use safeint on calculations (cherry picked from commit 139b6c6cf898467098f3a6f29fa84013a182285f) simplify returns (cherry picked from commit e8b2aad1cb2107304761e68aa380b5c29d8ef22f) extend to cover the last byte needed (cherry picked from commit c7b0117f26a386c98a721ff3897479c268103d74) bounds check (cherry picked from commit bb32616bdd6e3b327654bab0e1d790d8d50b893d) move largest bounds check to start (cherry picked from commit f832198e6a33052c7cc86b25843badfb962a2ae8) android:update safeint header to use the else implementation with clang Clang toolchain does not defines the __builtin_mul_overflow for 32-bit ARM. So, fallback to else implementation of checked_multiply when building Android with Clang Reviewed-on: https://gerrit.libreoffice.org/39005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 2149d4a88e9dc88c30e7475f8ea317e5c7b78529) add checked_add Reviewed-on: https://gerrit.libreoffice.org/43779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9cfb27ae6cb94f0a853ff70e9ad9f3109d305a94) Change-Id: I0b59f1b93d31a7cb5b8db2a21736db11aed46536 a174fd94c57cc3c899c10e1c0dc5968965a50427 0d329357ac282d4652b0f7ebc401cbd51963461b 004a6d322f60d916cc4635b362ce948e8a10d7c7 5aae26c38f3645020f0e1d6d7b6877c2727af1b4 a79be052dd3f6b6ed38fb326558924c853af5fff d75f5f4b578fd176c17e5763569f1403260c6594 c063786ba41aa9a985f505e62b43d3d543a0d48f 1a67cb2f1c686032438852fec1267a59fbd04d7f 5177d42b47a4bca614878dce4a69ab16b5cfe163 6d32a6b6f1dd91db42a3f154700ea55603f0e4dd 03fe80f9568759b829fac4e9bcfd496efebe6a26 6120606f521ce121541a5b7f1150229258012d55 10cba898bba528f5f1bfbd583e27a6821c789ab9 Reviewed-on: https://gerrit.libreoffice.org/49485 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01check O_head sizeCaolán McNamara
Change-Id: Idf5d30eaed0196cfa9266e35131c538c606a0960 Reviewed-on: https://gerrit.libreoffice.org/49365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b10ae2faae6f3c448bbab71585550387e18cc248) Reviewed-on: https://gerrit.libreoffice.org/49367 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01check O_hhea and O_vhea sizesCaolán McNamara
Change-Id: I82e47732815f0112801c8c3a3e5b0b09ac25610a Reviewed-on: https://gerrit.libreoffice.org/49439 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01check table size before reading nglyphsCaolán McNamara
Change-Id: Ib511fdf16006877ca76085137eb9200601b2f8f7 Reviewed-on: https://gerrit.libreoffice.org/49363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 08dd51bfcaa6b493e134bcc7787cc18c36ad5db1) Reviewed-on: https://gerrit.libreoffice.org/49436 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01return early on short streamCaolán McNamara
Change-Id: Ia9cb4dec5358281322a2428c5f2153836a1ee1af Reviewed-on: https://gerrit.libreoffice.org/49375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01stay within font boundsCaolán McNamara
Change-Id: Ie8ed610b71cb1b20963827c2be97155d2d8aa22c Reviewed-on: https://gerrit.libreoffice.org/49371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01what matters is the availability of the last element, not the firstCaolán McNamara
Change-Id: I23d3abdbe62b735d66261fb337613da88cc4206b Reviewed-on: https://gerrit.libreoffice.org/49380 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-06-01check kern table sizeCaolán McNamara
Change-Id: I65b5f0a8950d54c00d6fd7c385ca1c5dca2ef2c8 Reviewed-on: https://gerrit.libreoffice.org/49384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01sanity check cmap table sizeCaolán McNamara
Change-Id: I010c2fd221bcd86a62efd9996a0c34930828cb6d Reviewed-on: https://gerrit.libreoffice.org/49350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01forcepoint #25 ensure null terminationCaolán McNamara
Change-Id: I37f4787fb5772e959c45280d9650adcc15591033 Reviewed-on: https://gerrit.libreoffice.org/51130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01forcepoint #14 check to see if we incremented at allCaolán McNamara
Change-Id: Ia4670adbddcc8501cf522be296b3061a3529f880 Reviewed-on: https://gerrit.libreoffice.org/50607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-06-01forcepoint #4Caolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I569ca80267ad9b5a21da0029ba903d2a4c45a035 Reviewed-on: https://gerrit.libreoffice.org/50086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-01ofz#3419 Null-dereference READCaolán McNamara
(cherry picked from commit 3e8ef0e1a40a14d1c2bdb5345ed59941c765356b) Conflicts: vcl/unx/generic/glyphs/freetype_glyphcache.cxx Change-Id: I32c5d5039034ac76262223e42a1f27d6f1b84cb5 Reviewed-on: https://gerrit.libreoffice.org/50567 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-13tdf#104883 Don't call InstallFontconfigResources if it's not availableSamuel Mehrbrodt
We need to call it once because we have no other way to detect whether it's working or not. But if we receive an error the first time, we disable it from now on. Change-Id: I67dba8b65660ff7e05bdf2ddc18b565550901cd1
2017-04-25catch exception like text_wrapper_get_caret_offset doesCaolán McNamara
Change-Id: I7d681a5cd58af60005eefa9969ec975d5cfc5580 (cherry picked from commit 0d2a607a849e3f1b51092c7d96bc5529420cfab2) Reviewed-on: https://gerrit.libreoffice.org/36637 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-29Attempted fix for mirrored geometry crasher.Michael Meeks
Only plausible cause is pWindow->GetParent() being null, while we have a pParent which has to be valid. http://crashreport.libreoffice.org/stats/crash_details/6161398d-17b6-4a93-aa70-a559efa07868 Code was initially introduced in this form: commit 4716735ba7d0ad133ff018481f94d6b4f201bbd9 Author: Stephan Schäfer <ssa@openoffice.org> Date: Thu Sep 19 15:46:19 2002 +0000 #103362# improve positioning and resizing of system windows No public report, sadly. And modified by commit fba46c6efd08d50fee92cc11546f3ed253a57af8 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Mon Feb 3 16:46:04 2014 +1100 fdo#74424 Use Window::GetOutDev() to access ImplReMirrored() Part of the decoupling of Window from OutputDevice. We now get he Window's OutputDevice instance and manipulate this. Do not rely on the inherited function. where the GetParent()/pWindow->GetParent() problem surfaces Change-Id: Ia261028a4719525135e3fe4b00074427c1d9df6c Reviewed-on: https://gerrit.libreoffice.org/35796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d93b8268da982ad26db9e03156ce9b89f3410486) Reviewed-on: https://gerrit.libreoffice.org/35828 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-22Implement disabling of Menubar under UnityMaxim Monastirsky
This is a combination of 5 commits: * gtk3: Implement menubar hiding * tdf#106271 Cannot disable Menubar under Unity * Destroy menu widget when enabling Unity integration * Don't use SetDisplayable when enabling Unity mode * Keep menubar hidden after Unity registrar activated Change-Id: I3c5e17100622cd8d22c4348cf90a76233dd0fd4c Reviewed-on: https://gerrit.libreoffice.org/35206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-03ofz: Z_NEED_DICT is unsupportedCaolán McNamara
Change-Id: Ib0945d5a4606915aff9ee3019203caaf2a3cc7c5 (cherry picked from commit aacaacc16938b030a1341d8dbaf56c6a2efeb1dc) Reviewed-on: https://gerrit.libreoffice.org/34744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-22tdf#105256 gtk findfocus return only if focusedJustin Luth
A patch related to tdf#96685 (commit 598e6a024163f1510d076000788b7745625f5ed5) caused the initial regression that Japanese-mozc would freeze(tdf#100903). That patch only modified what happened when the text was marked as focused. However, the regression fix for Japanese bug 100903 (commit 1c81af2c1814e8bd12701f85e09cebf5fe206647) was not placed inside of the "if focused" code, and so it applies to more situations than were broken by the first regression, thus causing new bug 105256. So, applying fix 100903 ONLY when focused solves both problems. Change-Id: I1d8381f2d8cf793d481287ae975ce8a485b6c573 Reviewed-on: https://gerrit.libreoffice.org/34453 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 1c3a784d38fc5986c78bab8d283c4661347baf43) Reviewed-on: https://gerrit.libreoffice.org/34486 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c6a48e66deef01aa82409aec0ab3c2a9201d467b) Reviewed-on: https://gerrit.libreoffice.org/34489
2017-02-13Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabledCaolán McNamara
so no Invalidate will be called if auto accelerators are not enabled so there should be no blinking under windows (cherry picked from commit f67dc04cfdd9e63a45ec6c8bc00829bce8f17d4b) Change-Id: Iccc5dad7af41f39ac02d3be93e935f2d926a82a6 Reviewed-on: https://gerrit.libreoffice.org/34077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-10Resolves: ofz#576 unexpected exception with invalid fractionCaolán McNamara
(cherry picked from commit cff6cdb2ee37e836b9bab39500d24fcedc360121) Change-Id: I1d653775e88e9fa2ba7b62fce39d52fc21ffe363 Reviewed-on: https://gerrit.libreoffice.org/34070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-09ofz#574 sanitize png palette indexesCaolán McNamara
clarify we're not setting a pal index in the mask no logic changed intended, SetPixelIndex expands to this, just want to clarify that this is an alpha value, not an index into a palette (cherry picked from commit e5b23d924d60e7a0fb67c44c6dad3f4cb3bd5ddc) Change-Id: I006ffdf5c8c751e7e07b133716022e2a9b154478 e9bb188b116adf3eab4e2bb1d6da8badbaead88b crashtesting: fix tdf95481-1.odg reexport to odg failure revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. png spec says that the palette has to appear before the first IDAT so we should always know the palette size here Change-Id: I6e04223adce1c88d037f9cf34862e6f54e381bb0 (cherry picked from commit 9d2fa0bfdc93fa9bfed7dea89d603b1611d7a6e0) Reviewed-on: https://gerrit.libreoffice.org/34036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-02tdf#105461 PDF export: handle text fill colorMiklos Vajna
Text portion level background in Writer text was working already, as Writer paints its background explicitly, and then uses no text fill color in the metafile (that is turned into a PDF later). However, text fill color is used for Writer shape text and also in Impress. The rectangle is not just the text itself, but also the ascent / descent region, this matches the desktop rendering result. (cherry picked from commit ee32c7d8083ae1449d6b379034be92995c142da9) Change-Id: I644007ade43a8b9e663890643b826ae12c427ea5 Reviewed-on: https://gerrit.libreoffice.org/33795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01gtk3 hidpi xor hack needs to use unscaled extentsCaolán McNamara
so that e.g. the xor cursor in csv dialog can be seen when moving the mouse across the ruler Change-Id: Ia2f367d5f610d486a8e10b6bc278cbc8029cf2a1 (cherry picked from commit 00c4679641bc2b84c6496258c0c5bd84df75ae42) Reviewed-on: https://gerrit.libreoffice.org/33792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01ofz#502 negative indexCaolán McNamara
Change-Id: I2eb3da9d378cd8fdace5ccd644f501f5119f6698 Reviewed-on: https://gerrit.libreoffice.org/33741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01Resolves: rhbz#1417480 stray bare XWarpPointer call in gtk3 codeCaolán McNamara
which blows up under wayland naturally can get here from tools->options->mouse positioning->"dialog center" table->insert table Change-Id: Id81b06a63cc3a2a1073d236e2f36dc65e533e598 (cherry picked from commit b4b989b59cc5841fdf4635b19b975cae3a88430f) Reviewed-on: https://gerrit.libreoffice.org/33689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-30Resolves: tdf#105416 blank windows under HiDPI RTLCaolán McNamara
Change-Id: I819f06babd448c37ce2d58297562b640aba1c8c6 (cherry picked from commit 4e9cfc178c47893229f8030bfe73e2b7c5de92c3) Reviewed-on: https://gerrit.libreoffice.org/33302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit c9ab894ae846185a0341656922b0aa1632bfe886) Reviewed-on: https://gerrit.libreoffice.org/33653 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26Resolves: ofz#424 guard against broken dxary lengthCaolán McNamara
ofz#424 vcl: reset nLen too (cherry picked from commit 7f5a10a3aaf8b48156aeab168afb7648dae1e020) Change-Id: Ia2569e963edd75cd6c27399d33e73bafe8b3f073 Reviewed-on: https://gerrit.libreoffice.org/33321 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-26Resolves: tdf#94457 our EmfPlusSetPageTransform is malformedCaolán McNamara
we write a single short, resulting in a record of 0x000C in length MS-EMFPLUS spec has EmfPlusSetPageTransform as 0x0010 in length because we're not writing the 4 byte PageScale value. the previous pageunit unit we are writing is of value 1, which is UnitTypeDisplay, the same spec says... "The unit of measure for page space coordinates, from the UnitType enumeration. This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld" and footnotes that with... "Windows never writes those values to the PageUnit field, but they are accepted with undefined results." Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048 Reviewed-on: https://gerrit.libreoffice.org/33560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-26ofz#439 protect against 0 len textCaolán McNamara
Change-Id: Ib67284636235b0d43df626a4aeed67f2bc64b491 Reviewed-on: https://gerrit.libreoffice.org/33376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-25ofz#463 unable to mmapCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/33519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f6c465bc8e7583a8321f5c881cb008b980e0e3fa) Change-Id: I509faeda019f42bbe7cdc5fc249f2ea2076bb702 Reviewed-on: https://gerrit.libreoffice.org/33522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-01-19Resolves: tdf#98593 buttons in writer show different text at different zoomsCaolán McNamara
The DrawControlText always renders with a reference device positions but we pass in a rectangle which is derived a different way. So, add a GetControlTextRect which operates on the same reference device as DrawControlText so the rectangles match The rectangle is mapped from pixels to logic and back from logic to pixel, so add an argument to store the logic size from GetControlTextRect and re-use it without conversion on the cases where we pass back the original rectangle zooming in/out on the button in writer is now stable wrt text shown at all zoom levels Reviewed-on: https://gerrit.libreoffice.org/33277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db9ef688edd86b31606e0dd6df6a77732faca49b) change DrawControlText to return new rect rather than change old one (cherry picked from commit bc6479e92b56df742dd7339d337ffc78d2f9e4a1) Ref...DeviceTextLayout::GetTextArray is only called by Ref...DeviceTextLayout so set it as private to de-confuse this a little (cherry picked from commit 3d002fdb8738d9bbc9b04c0270510e349bd58149) d5c80ff263e429d4239a844db216e87a656edb2e dde7f78a767227cc2d52e417b6c39d12e1339745 Change-Id: Ic581eca67d0ff265e2753ab8b6c40e8fca7e6ae4 Reviewed-on: https://gerrit.libreoffice.org/33282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-18ofz#419 same problem as wmf and emfCaolán McNamara
this is the *third* effective copy of this, see the other two uses of LF_FACESIZE in wmf parsing Change-Id: I475b18314784ad072fe58730c361fc5ca6e65819 Reviewed-on: https://gerrit.libreoffice.org/33257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-18ofz: reduce scope, check stream, validate nActionsCaolán McNamara
(cherry picked from commit bd78b28a1233e26c023a52df6b119d60a61d53ad) Change-Id: Ie420ad40b0d852708828620cd26c2f746398f5a8 Reviewed-on: https://gerrit.libreoffice.org/33260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-17ofz#411: XPMReader::ImplGetColKey short readCaolán McNamara
Change-Id: I2e47ef6478b8349a562b294d0fbdad65c2a3b543 Reviewed-on: https://gerrit.libreoffice.org/33218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-13ofz: ensure all not explicitly set indexes are zeroCaolán McNamara
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000 (cherry picked from commit 14d9b3519adac8543b52ddb84e49eecbdd1d9eb2) Reviewed-on: https://gerrit.libreoffice.org/33036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-11Resolves: rhbz#1408500 gtk3 toolbar borders too distinct vs native gtk3 onesCaolán McNamara
Change-Id: I7ce284d3e6f999e2ac08326dc40b060bf70d7d4b (cherry picked from commit 5088b2066651ed133dcfd93388f7ac7187844d33) Reviewed-on: https://gerrit.libreoffice.org/32955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-09ofz#394 xbm ParseDefine problemCaolán McNamara
Change-Id: I75fb761d23fdb3780088a9d209200429edb57a26 Reviewed-on: https://gerrit.libreoffice.org/32878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-09tdf#105151 - be more conservative about EndTracking / Tracking calls.Michael Meeks
We really shouldn't be emitting these into widgets after they are disposed - it serves only to confuse things. Restore behaviour to how it was before the VclPtr change for this. Change-Id: Ife666929f8aac0e4431a5e43970769692c11888c Reviewed-on: https://gerrit.libreoffice.org/32785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d788d37a16d382d7ff32a19e8d65e5c605ac55dd) Reviewed-on: https://gerrit.libreoffice.org/32819 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-04Resolves: ofz#313 cbBmiSrc > getDIBV5HeaderSizeCaolán McNamara
Change-Id: I67fb67dc0a4cb609b8f1391c1eb6dd395755a933 (cherry picked from commit 7485fc2a1484f31631f62f97e5c64c0ae74c6416) (cherry picked from commit 371f0f6770add78ae81e0f769d0490874bca353c) Reviewed-on: https://gerrit.libreoffice.org/32338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-02Related: rhbz#1405521 abrt reported crash in dndCaolán McNamara
Change-Id: I8d8f9379d36dd3dd1a8973cd9f9c14860765630b Reviewed-on: https://gerrit.libreoffice.org/32178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02valgrind: stick 0 at end of successfully read dataCaolán McNamara
(cherry picked from commit 0dfc6f70ab53a773ee05664235d7c8927ab20f2c) (cherry picked from commit 3ea598f65bed096dbf4bda5fe4105b57c58b5310) Change-Id: Id79f68c9095ab313ac05d2c8b55df71788df81d3 Reviewed-on: https://gerrit.libreoffice.org/32335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02Resolves: ofz#310: Sanitize 1 bit bitmap palette indexes tooCaolán McNamara
(cherry picked from commit b08e48166310ab8a53f06f4fee227a948416cf4a) (cherry picked from commit 3bff2da31ed580817f6b5b653f48727e38078af5) crashtesting: fix bmp->odg failure... id:000178,src:000000,op:havoc,rep:16.bmp id:000383,src:000047,op:flip2,pos:18,+cov.bmp id:000403,src:000047,op:arith32,pos:22,val:-33.bmp id:000317,src:000025,op:havoc,rep:8.bmp id:000119,src:000000,op:havoc,rep:16.bmp id:000167,src:000000,op:havoc,rep:8.bmp revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. we load the palette before getting here, so we should always know the palette size here (cherry picked from commit 92cee94a262a3a2f43c87bb940c50cb90a2ebd89) Change-Id: Ied2b71eb1c9088bbbff5fed97f7a04b43f4b4827 Reviewed-on: https://gerrit.libreoffice.org/32333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02Revert "tdf#103514: Always ignore bitmap fonts on Windows"Khaled Hosny
This reverts commit e80621fb04093d5ab950485357f6058dcbaf8aaf. Lots of crashes related to this change, lets revert and see if we can fix it in 5.3: http://crashreport.libreoffice.org/stats/signature/ImplReleaseTempFonts(SalData%20&) Change-Id: I86b7d85fe1bfb7be28fbed7dc8957f71d1bedc55 Reviewed-on: https://gerrit.libreoffice.org/32591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13Resolves: rhbz#1401778 gtk3+wayland switching windows from the menu woesCaolán McNamara
ignore 0 timestamps cause they're useless and get the current event time stamp during MenuBarReturnFocus to determine the timestamp of the menu command dispatch (cherry picked from commit adfcd16220444ef3ea318515c5a331210250e45f) Change-Id: Ia4b00aafc9ef47b41dcca2c160e943200db5c524 (cherry picked from commit 1b2bb1c952a3e8dc5c625c7a9f0042f06ba1c9a0) Reviewed-on: https://gerrit.libreoffice.org/31706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-13oss-fuzz: handle W_META_CREATEFONTINDIRECT like EMR_EXTCREATEFONTINDIRECTWCaolán McNamara
Change-Id: Iaa142d5d0ac0f00e89e8b7d7ffdef8137157cec9 (cherry picked from commit e718ac0ae415bba2988c96c36995755bbfd9df7f) (cherry picked from commit d3ea20e55ca7d82b6121f7ed3db5fd170fcac94f) Reviewed-on: https://gerrit.libreoffice.org/31839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-11Resolves: rhbz#1362453 use the cairo scaling approach on both wayland and XCaolán McNamara
so have the same hidpi solution on both setups Change-Id: I669eba55830a28c1850f4679dfa824798bd3a383 Reviewed-on: https://gerrit.libreoffice.org/31540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 3a9609653697ac851ee1c55a41aa143d3bca335e) Reviewed-on: https://gerrit.libreoffice.org/31836 Tested-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit abf54716da33b8252c32b545bd02b33eef3b9a07) Reviewed-on: https://gerrit.libreoffice.org/31876
2016-12-11tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entryTamás Zolnai
Squashed from two commits: tdf#93430: Get run attributes of text objects .. which are not paragraphs. Note: For some reason in character attributes sequence we have a wrong Any value for "CharPosture" property. Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/31591 (cherry picked from commit 17773e1a8dd6e97f57db111819338c418f819cef) tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entry Reviewed-on: https://gerrit.libreoffice.org/31778 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e0d8c3821b8fa1e7d00f7b4a7d007f9cb5c592a5) Reviewed-on: https://gerrit.libreoffice.org/31792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> tdf#93430: Return the right offsets for runs MultiLineEdit is a special control which can have more text portions with different text attributes. Reviewed-on: https://gerrit.libreoffice.org/31813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8d52045853cecb716138d51b8b6ad0272a86af86) Change-Id: Ia45526c01cc381d3d6a1b56dbf4f03fdd38a0989 Reviewed-on: https://gerrit.libreoffice.org/31804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-09oss-fuzz we don't want this stream to automatically resize on seeks past endCaolán McNamara
Change-Id: Ie42b2e173cd3ed9faaf17c3c978227613129fa84 (cherry picked from commit f212bd45a7c7d97fb16380cd9fa7c6abbfb71e05) (cherry picked from commit b832d7019f7e7499f5fb3da5d5f49ddbf0f35585) Reviewed-on: https://gerrit.libreoffice.org/31803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-09tdf#104034 skip polygons with less than 2 points (LO 5-2)Tomaž Vajngerl
We can get polypolgons with polygons that have 0 or 1 point only, so we need to guard agains division-by-zero errors by skipping if we detect such polygons (as we can't draw them anyway). Change-Id: I08c4f4c9bb946fcbaedede4b4ae23c96e431190e Reviewed-on: https://gerrit.libreoffice.org/31790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-10 21:06:48 +0000