summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-03-12weld SpellOptionsDialogCaolán McNamara
Change-Id: I813b166a8c4658e08b185a43a464b6b370b62c66 Reviewed-on: https://gerrit.libreoffice.org/69099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12Write HiDPI consistently without a hyphenTor Lillqvist
Hopefully makes it easier to find locations in the code related to HiDPI issues. Change-Id: I2b4e5ff6d66c0ca5792250c3fd0d42eeb59eb3ef
2019-03-12tdf#123304: Allow the full feature syntax as pre 6.2Khaled Hosny
Fix regression from: commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Fri Jun 15 19:32:15 2018 +0200 vcl: parser of font features included in the font name Where hb_feature_from_string() was replaced by a simple parser that supports avery limited subset of the syntax it supports (as documented in https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string) Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f Reviewed-on: https://gerrit.libreoffice.org/69062 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2019-03-11widget theme: change the tab item height to (min) 32 pxTomaž Vajngerl
Change-Id: I1919300071a06242fe832880b46c944989daa4b6 Reviewed-on: https://gerrit.libreoffice.org/69057 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11better adjustment algorithm for dynamic sized widgetsTomaž Vajngerl
A algorithm that gives better results for dynamically sized widgets is to increase proportionally only the points in shapes that are over the half of the widget width (or height, when adjusting the other dimension). This preserves the margins and doesn't distort the shape of the paths, which is especially visible when the source needs to be largely resized in one dimension only. Change-Id: I2cceb249063387c0f7400ef8d75adb5899aa8c23 Reviewed-on: https://gerrit.libreoffice.org/69056 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11cache file based widget images and draw commandsTomaž Vajngerl
It is wasteful to parse svg icons all the time so lets cache the result when this make sense in a LRU map. Change-Id: I95cc317c9301138a9e384d270223ba147a123e59 Reviewed-on: https://gerrit.libreoffice.org/69055 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11weld SvxConfigDialogCaolán McNamara
Change-Id: Ia6983fd658521cf8704ca1ed95ecff6590ddde09 Reviewed-on: https://gerrit.libreoffice.org/68906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11Fix typoAndrea Gelmini
Change-Id: Ia4ca41607d13553f7924f0cce6276c114608216e Reviewed-on: https://gerrit.libreoffice.org/69041 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-11weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara
Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld SfxDocumentPageCaolán McNamara
Change-Id: I99f342ad1c0620147ce23b4670323056d7ccc508 Reviewed-on: https://gerrit.libreoffice.org/69008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11merge SalLayoutGlyphsImpl and SalGenericLayoutGlyphsImplNoel Grandin
Change-Id: I5697d2b7961ce714835316879610f23aeabbd8ec Reviewed-on: https://gerrit.libreoffice.org/69030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-11widget theme: slight window borders, use font 10 instead of 12Tomaž Vajngerl
Change-Id: I6b0ba769817894b99c3f757d23948783a66fce12 Reviewed-on: https://gerrit.libreoffice.org/69023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11widget theme: support disabled pushbuttonTomaž Vajngerl
Change-Id: I8c6e019f5d1f12c85334f3440e09ef755ed6863d Reviewed-on: https://gerrit.libreoffice.org/69022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11loplugin:constantparamNoel Grandin
Change-Id: Ibe167c208844b4cdd10df80ae804b1e5bfa6aa13 Reviewed-on: https://gerrit.libreoffice.org/68998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-11widget theme: add support for menubar, menupopup and tooltipTomaž Vajngerl
But they are not used - for now. Change-Id: I93a74f5a9e52791fd08afbb5502427a0684d60cf Reviewed-on: https://gerrit.libreoffice.org/69021 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11widget theme: change color for window background and frameTomaž Vajngerl
Change-Id: I37f1524db71eea2912ffb65fdd7a00605e6b1d4d Reviewed-on: https://gerrit.libreoffice.org/69017 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-11widget theme: take into account scaling factor for imagesTomaž Vajngerl
Change-Id: I65bd71dfd113fae33aee7c2b60b945e065314f80 Reviewed-on: https://gerrit.libreoffice.org/69016 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10widget theme: draw slider button from svg, left and right trackTomaž Vajngerl
Change-Id: Iaba4a67845699d795c719d0259e93bb6c72df470 Reviewed-on: https://gerrit.libreoffice.org/69015 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10widget theme: draw listheader button and arrowTomaž Vajngerl
Also adds support for signaling if arrow points up or down, which is signaled through extra attribute. Change-Id: I5a87cdb31e18150495df521bf925c7b983e2313a Reviewed-on: https://gerrit.libreoffice.org/69013 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10widget theme: support "height" for editbox and set to "32"Tomaž Vajngerl
Change-Id: Iff48c83b6f1b28bc7fbf7646c399a844a3155970 Reviewed-on: https://gerrit.libreoffice.org/69012 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10widget theme: toolbar drawing definition - separator, buttonsTomaž Vajngerl
Change-Id: Ic8574c0f0c3c51526254c34d820977a0fbb520a0 Reviewed-on: https://gerrit.libreoffice.org/69011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10weld ScTpSubTotalGroupCaolán McNamara
Change-Id: Icab13fec62ac69305550fa860700f883ffaaf1f9 Reviewed-on: https://gerrit.libreoffice.org/68983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-10widget theme: adjust draw positions of editbox, combobox, listboxTomaž Vajngerl
Change-Id: Id14b5530c994e10bb9f45f036b43025c73c7ac83 Reviewed-on: https://gerrit.libreoffice.org/68977 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-10only read and parse widget definition once from the fileTomaž Vajngerl
Change-Id: I71c095e5e5dd21650663e6fb717bcb22958a597f Reviewed-on: https://gerrit.libreoffice.org/68976 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-09Separate style colors from WidgetDefinition into its own classTomaž Vajngerl
Change-Id: I11cd695da81bae7b49b2319b89e5c560ba64f04e Reviewed-on: https://gerrit.libreoffice.org/68975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-09Fix multiline tabs drawing of first / last tabTomaž Vajngerl
Use is{Left,Right}Aligned instead of is{First,Last}. In multi-line tabs, not only first/last item needs to be drawn differently, but also some middle, which is now the first in the new line now. Change-Id: I81ddde192eca794f16df98d629f47991c59732c7 Reviewed-on: https://gerrit.libreoffice.org/68945 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-09replace feeble triangle drawing with DrawPolygonCaolán McNamara
which will result in a hidpi triangle rather than a bunch of visible lines arranged in a triangle pattern Change-Id: I9208177aa5e32791f46c9b1dcbe71f5442475282 Reviewed-on: https://gerrit.libreoffice.org/68946 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-09out of line some heavily repeated functionsNoel Grandin
Change-Id: Icd9f7ebab89d6c2b166b6f42fd7682e89127fd51 Reviewed-on: https://gerrit.libreoffice.org/68903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09loplugin:unusedmethodsNoel Grandin
Change-Id: I242f56f2bc5dc8fce6db1ba8f1f8269da4fec0fa Reviewed-on: https://gerrit.libreoffice.org/68938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-08Fix crash in widget drawing of a SVG as imageTomaž Vajngerl
Change-Id: Iaa7e01b49b9c2dcdfa98e4e8bc431dba82fe6bb4 Reviewed-on: https://gerrit.libreoffice.org/68942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-08tdf#121120 vcl opengl: handle 8-bit palette bitmap as 24 bit RGB textureMiklos Vajna
This fixes the black rectangle instead of actual image content in the bugdoc. An alternative would be to handle this in the PNG import, but commit 66dbd4da3afcadb1393daf9be9cecff71b86509a (tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed Bitmap, 2017-11-20) already tried something similar and failed, leading to the revert in commit 25cd843664919974f0d21ca7a0b02cc43e9eeabb (tdf#115297: alternative fix for displaying 1bit images, 2018-02-27). The test is especially useful with SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen specified on Linux, so the GL codepath is triggered. Change-Id: Ia9d049d09dce2ac34826ee427f74616a96a35c88 Reviewed-on: https://gerrit.libreoffice.org/68925 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-08Don'tbuild HarfBuzz with Core Text support on macOS/iOSKhaled Hosny
HarfBuzz 2.x has native support for AAT fonts which is, according to Chrome developers, sgnificantly faster that HarfBuzz Core Text integration. Change-Id: I4d5e861a1958402a6e3ccb720b10f40828c3db6a Reviewed-on: https://gerrit.libreoffice.org/68919 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-03-08use gtk_toggle_button_get_mode as trigger for pan-down inclusionCaolán McNamara
Change-Id: Ic8cd9babe3c196cdd66524f39a78940c9a029d2e Reviewed-on: https://gerrit.libreoffice.org/68917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-08vcl opengl: avoid task priority warning on cursor blinkMiklos Vajna
warn:vcl.schedule:22358:22358:include/vcl/task.hxx:107: Priority will just change after next schedule! Just don't set the priority if it's already set to the correct value, so we can avoid a warning each time the visible cursor is shown or hidden. Change-Id: Ie11164db0af4cfba06a620c9b2426cb903af3887 Reviewed-on: https://gerrit.libreoffice.org/68907 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-08make it possible to use FileDefinitionWidgetDraw in more backendsTomaž Vajngerl
Change-Id: I8871eb49e11d8c72c469230967c3c979091a0f9b Reviewed-on: https://gerrit.libreoffice.org/68898 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-07map reorderable to DragDropMode::CTRL_MOVECaolán McNamara
workaround baseclass NotifyStartDrag weirdness rather than risk changing it Change-Id: I70b56a913e6192da9b3a57653924dcc4160352c0 Reviewed-on: https://gerrit.libreoffice.org/68879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-07tdf#119947 vcl opengl win: fix fontwork popup menuMiklos Vajna
Regression from commit b160db926b574b7e9d6696d49dbbce8dd289aade (tdf#96947 vcl opengl win: fix background of menu items w/ check/radio marks, 2018-05-14), the problem was that GetMenuPopupMarkRegion() did an unconditional downcast from ImplControlValue to MenupopupValue. This looked safe, but when the extracted function was used in WinSalGraphics::drawNativeControl(), then that argument was not safe to downcast. Fix the problem by switching to safe downcast, and returning an empty rectangle (instead of a bogus one) on error. This way the old bug stays fixed but fontwork popup menu works again as well. Change-Id: I2b69b9f2e6823850892ac73df78dac5c2f04ec03 Reviewed-on: https://gerrit.libreoffice.org/68883 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-07don't need "spinbox-entire" svg anymoreTomaž Vajngerl
Change-Id: I8385acf7ecd46b7c8b990abb688bd2ddddcb6bc5 Reviewed-on: https://gerrit.libreoffice.org/68867 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07widget theme - update editbox, draw from svgTomaž Vajngerl
Change-Id: I0dfdaaf74c9b31ecd9b1de511b48dacf2e90f59f Reviewed-on: https://gerrit.libreoffice.org/68866 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07widget theme - update combobox/listbox, draw from svgTomaž Vajngerl
Change-Id: Ie5e28883d70ad61340c58bcacd8c2ffb2ced1536 Reviewed-on: https://gerrit.libreoffice.org/68865 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07widget theme - update scrollbars, draw from svgTomaž Vajngerl
Change-Id: I7e7cd05ce516ab24d380bb8b6a264fd45e1d553c Reviewed-on: https://gerrit.libreoffice.org/68864 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07widget theme - update spinbox with more statesTomaž Vajngerl
Change-Id: I398293c30e015eeb53b8403f1e6fc628227de9ac Reviewed-on: https://gerrit.libreoffice.org/68863 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07Fixes, don't draw IntroProgress, adjust EditBox bounding sizeTomaž Vajngerl
Change-Id: I1d1944faed05ec3753709e39fa1a820d795e26d5 Reviewed-on: https://gerrit.libreoffice.org/68862 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07can drop wallpaper if use alpha-enabled virdevCaolán McNamara
Change-Id: I655dca755ed8e1c1266c191f61998b3838fe9797 Reviewed-on: https://gerrit.libreoffice.org/68860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-07Add width, height and margin parameters for widget part def.Tomaž Vajngerl
For some control parts we need to provide the size or redefine the size. Previously this was hardcoded, but this adds new attriburtes for widget part definition: - width, height: defines size for buttons in spinbox, the size of the checkbox or radiobutton - margin-width, margin-height: increases the size (margin) of tab items by the specified amount Change-Id: Ieea69b92ad21adc4f4954e7555f4d59348f5dea8 Reviewed-on: https://gerrit.libreoffice.org/68829 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-07Make definition state attribute default to "any"Tomaž Vajngerl
...and remove all the "any" from definition.xml Change-Id: I8a91129c89255c83c1c2f975bf9acb710b664efc Reviewed-on: https://gerrit.libreoffice.org/68828 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Increase font size when drawing from widget definitionTomaž Vajngerl
Change-Id: I983dde507758a42c6ce421ea970b6e5d54c5dcae Reviewed-on: https://gerrit.libreoffice.org/68826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06draw combobox (entire areaonly) from external svg, fix editboxTomaž Vajngerl
Change-Id: Iba7e5b45c4f1ac6f87cbca963bb5284ce810ebcf Reviewed-on: https://gerrit.libreoffice.org/68825 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw tabs from external svg image, fixes for tabs (colors)Tomaž Vajngerl
Change-Id: I35db7b8e36c474d2196bfae1ec4dd352e17d2a14 Reviewed-on: https://gerrit.libreoffice.org/68822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>