summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-12-28WaE: -Werror,-WreorderTor Lillqvist
Change-Id: Ida0d80829f3055d3ed4f6c0e6cde34fb7a61cfec
2018-12-27Make two private PNGReaderImpl fields constTor Lillqvist
Change-Id: I54a21a239b41aade0b7745c2bae232dade4b6ce2
2018-12-27tdf#107792 vcl/win/gdi: introduce ScopedHBRUSHDmitriy Shilin
Change-Id: Ieca634892f4af1b0c38fa6bd8a8bbbb8f1c7370d Reviewed-on: https://gerrit.libreoffice.org/65141 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-27Add some pondering what a comment means...Tor Lillqvist
Change-Id: I8835a5910df8c8cd2f17c4b6a46549575ea22d8c
2018-12-26The macOS+iOS-specific BitmapSystemData::rImageContext was not used anywhereTor Lillqvist
Change-Id: I7190a44d4857fd337fb49e689cd71ffb78b86b9d
2018-12-26The Windows-specific BitmapSystemData::pDDB is unusedTor Lillqvist
Its comment, "if not NULL then this is actually an HBITMAP", makes me wonder whether we lost some functionality, or broke something, or pessimized code, when the field became unused, whenever that was... Change-Id: I8bc95a1c5aca3ed80448c7c03ae0b1bb586bf5ae
2018-12-26Add some pondering about code of questionable provenance in a commentTor Lillqvist
Change-Id: I20b3c8ba0ae4018307a97150440c708cfa3edc40
2018-12-25Try fixing VclComplexTextTest::testArabic by reschedulingMike Kaganski
The test keeps sporadically falling on Windows; it just has failed twice in a row for me at line 98, with actual values 90 and 76, instead of 72. Unfortunately, in subsequent testing, the test keeps working OK, so no reliable reproducing. I suspect some problem with initialization possibly missing; so try to fix it by inserting an Application::Reschedule(). I am not an expert in this code, so this change could of course make no sense. I reenable tests that were skipped because of the instability; if the fix is wrong, hopefully this will make it apparent sooner to revert it. Change-Id: I939375de6046e3698574be019f6ea512af53dacd Reviewed-on: https://gerrit.libreoffice.org/65594 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-24tdf#107792: vcl/win/gdi: extract Get50PercentBrushDmitriy Shilin
Change-Id: If62d9f5429a78d39dc5edbe434308603b1b09fe9 Reviewed-on: https://gerrit.libreoffice.org/65307 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-24tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093 Reviewed-on: https://gerrit.libreoffice.org/65592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-23tdf#122116 Only create CPDManager if D-Bus descriptions presentMichael Weghorn
Since the XML files are required in the 'onNameAcquired()' method, check for their existence before returning a CPDManager pointer in 'tryLoadCPD()', to avoid returning a CPDManager that is unusable (and will even lead to a crash). Change-Id: I83c493ba8bd775ea398111971cbecb9352050194 Reviewed-on: https://gerrit.libreoffice.org/65576 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-21workaround to make Qt5 code build with Clang+icecreamLuboš Luňák
Qt5 uses QT_HAS_INCLUDE (which maps to __has_include), and uses it to guard #include <chrono>. Clang's -frewrite-includes, which icecream uses for distributing source to remote nodes, for some reason doesn't recognize __has_include properly when wrapped by this macro, and this all results in strange compile errors related to std::chrono. Change-Id: Ia375ebd928b40ebd51ab4cc59488f3b62939e039 Reviewed-on: https://gerrit.libreoffice.org/65506 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-21tdf#121161 Qt5 initial IM supportJan-Marek Glogowski
This just implements some minimal solution, since I have no idea, how all this IM handling should actually work. Change-Id: I0d02dfb96680891e275881927ebc17f798dc1f29 Reviewed-on: https://gerrit.libreoffice.org/65553 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-21hook up m_nHAdjustChangedSignalIdNoel Grandin
to the other places that need to deal with it found by loplugin:unusedfields Change-Id: Ice46c1fce19afcac92854a5a8a204b71d178977f Reviewed-on: https://gerrit.libreoffice.org/65491 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I4ca101ba838afecbbc8e841a6a9fa6c9c0460f14 Reviewed-on: https://gerrit.libreoffice.org/65497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21Bin unnecessary #ifdef, this file is for macOS onlyTor Lillqvist
Change-Id: Ia969648653b71e441446c38c4bed632ff1e53cc6
2018-12-21Add follow-up comment with guess why it must be 96Tor Lillqvist
Change-Id: Ifa725c40c5756ba7999423a782180c1ac3901d30
2018-12-21Add a bit more information to a SAL_WARNTor Lillqvist
Change-Id: Iea825271825119bddfdaa79af3b111659f084d0b
2018-12-20vcl/win/gdi: unify private API naming in WinSalGraphicsImplDmitriy Shilin
Change-Id: I0279e8796c750678607b3db8b3e209110d41cfd7 Reviewed-on: https://gerrit.libreoffice.org/65140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-20Resolves: tdf#119688 under X full-screen doesn't work before gtk_widget_showCaolán McNamara
Change-Id: I3ba29a235c8c5807e79e83dd1eb65b99f1dfa9cf Reviewed-on: https://gerrit.libreoffice.org/65476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-20weld SwTOXEntryTabPageCaolán McNamara
Change-Id: Ib093fbb78a73b26060613ea72030e92f7d3681a5 Reviewed-on: https://gerrit.libreoffice.org/65325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19Resolves: tdf#121555 sometime crash on menu hierarchy changeCaolán McNamara
seems menubar gets set to dirty due to some menu activity that needs a refresh, but then the hierarchy changes and as its already dirty the maUpdateMenuBarIdle doesn't get launched the placement of the mbMenuBar test inside the loop through parents shows some confusion as to what which mbMenuBar might be met, the one belonging to this, or that of the parent being traversed, but it does seem to be the one belonging to this. Change-Id: I0b9dceadf64f7adf18eb1aa2dbda9bbfbcb66e0a Reviewed-on: https://gerrit.libreoffice.org/65452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19FAST_ARGB_BGRA has been #defined since 2006Tor Lillqvist
Change-Id: Ia031c95c5a211f655c32afdd351afb182349e065
2018-12-19Resolves: tdf#105602 fix extended help for non-dispatchable toolbox commandsCaolán McNamara
Change-Id: I832a043ca5ae3a4030b9ac22447cecfabd3650c0 Reviewed-on: https://gerrit.libreoffice.org/65422 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19Qt5: remove assert leading to crash while executing 'open' dialogAleksei Nikiforov
When Writer is opened using "qt5" VCL plugin, opening menu item "File" -> "Open" leads to a crash due to presence of mentioned assert. Impress crashes same way when same menu item is used. Change-Id: I9d1937344c694d4f4620be1b71d1181eb9645427 Reviewed-on: https://gerrit.libreoffice.org/65344 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-19Removed useless semicolonsAndrea Gelmini
Change-Id: I6efd221e71020030ae5b8ac8800f72e42b13aa28 Reviewed-on: https://gerrit.libreoffice.org/65390 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-19tdf#121247, tdf#121266 KDE5: Add basic support for OpenGLAleksei Nikiforov
Change-Id: Id3a5879f661a6fa51b9f9dc40af73687a8f624df Reviewed-on: https://gerrit.libreoffice.org/65310 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins
2018-12-18tdf#122055: catch RuntimeException if a11y context no longer aliveKatarina Behrens
otherwise Desktop::Main will do it and soffice will crash w/ empty error msg Change-Id: I56768909227a6ff158ae353e1eff9b249d6ba9d4 Reviewed-on: https://gerrit.libreoffice.org/65357 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-18Qt5: Fix fullscreen window sizeAleksei Nikiforov
Allow setting Qt5Object's position and size Change-Id: I9f70b68ff402a3975e36baca4d81103603110d82 Reviewed-on: https://gerrit.libreoffice.org/65309 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2018-12-18Qt5 fix SalGraphics::invertJan-Marek Glogowski
... and also print the invert mode name into the inverted region when running "./bin/run vcldemo --show ellipse". Change-Id: Id461a32756583df1ef778320c29c45c0e7e4fbc8 Reviewed-on: https://gerrit.libreoffice.org/65326 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-18Qt5: fix color bits interpretation for 32bit ARGB image formatsAleksei Nikiforov
Change-Id: Iea8547089a0ce2dc9f6a06b84552f4261fbfa0f1 Reviewed-on: https://gerrit.libreoffice.org/65311 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-17Qt5 don't re-register system fontsJan-Marek Glogowski
System fonts are already registered in the QFontDatabase. And addApplicationFont seems to be really expensive especially when registering large fonts like the Noto CJK fonts, which increases load time by 4 seconds per font. This skips all font + style combinations already known in the DB. Since addApplicationFont already relies on fontconfig on Unix/X11 this should be fine. Change-Id: Ief13a613abd99b9fe391d9afe868541035340d1c Reviewed-on: https://gerrit.libreoffice.org/65270 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-17vcl/win/gdi: merge ImplRenderPath into drawPolyLineBezierDmitriy Shilin
Change-Id: I6e0a5d81bc155c8ad3603c4451a557f8412245bd Reviewed-on: https://gerrit.libreoffice.org/65139 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-17kde5: remove older kde/tde plugins, and references to thatThorsten Behrens
KDE4 is out of maintenance upstream since Nov. 2014, and binaries provided by TDF have switched to KDE5 as the official backend. Change-Id: I165465b56d3ba3a18912b203c06ae8fc6111c0c9 Reviewed-on: https://gerrit.libreoffice.org/60014 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-17Use 'gb_Library_set_include' for GTK3_CFLAGSMichael Weghorn
This among others makes sure that the '-I'/'-isystem' compiler flags for the gtk3 includes end up in the 'INCLUDE' section in 'workdir/GbuildToJson/Library/libvclplug_gtk3lo.so' when that file is generated by 'gbuildtojson'. That file is used by 'gbuild-to-ide' to generate IDE-specific config files. Having the gtk3 headers in the 'INCLUDE' section makes sure that the includes are properly taken into account when generating the IDE-specific files, and the included files can thus actually be found. Also, there's no need to set '$$(INCLUDE)' via 'gb_Library_add_cxxflags', since the flags are already set via 'gb_Library_set_include', so drop the 'gb_Library_add_cxxflags' part altogether. Change-Id: Ibf198be9372ce2bec4c8a16d8530edf860733a57 Reviewed-on: https://gerrit.libreoffice.org/65207 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-12-17Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-12-16drop scroll-wheel moves notebook page workaroundCaolán McNamara
now that the double-decker monstrosity is in place Change-Id: I8bc8f98d0cfd2bf4506bbc61632c1e7b0f9cd3f1 Reviewed-on: https://gerrit.libreoffice.org/65181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-16SalGtk{File,}Picker.hxx: Add missing includesMichael Weghorn
Since 'XComponentContext' and 'DECL_STATIC_LINK' are used, add the corresponding includes. Otherwise a successful build depends on the header being included after other headers that make sure that compilation still works. An error could be provoked e.g. by moving the '#include <gtk/fpicker/SalGtkFilePicker.hxx>' in 'vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx' above all other existing includes. Change-Id: Ib23f8b714fb971238eab28a8d4d02414a0b13812 Reviewed-on: https://gerrit.libreoffice.org/65208 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-15Resolves: tdf#121050 draw fixedlines like toolbar separatorsCaolán McNamara
Change-Id: Ib91b3f204d847cbe96750b4c080e958597bb3b9b Reviewed-on: https://gerrit.libreoffice.org/65110 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-12-15tdf#116290 allow menubar to shrink past its minimum sizeCaolán McNamara
with a scrolledwindow with a horizontal external policy which doesn't show a scrollbar, but allows the scrolledwindow to shrink past its child size Change-Id: Ia73fc819a16bef49008e7e41bcc2d523c28268b0 Reviewed-on: https://gerrit.libreoffice.org/65171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14Resolves: tdf#122059 don't crash with no parent for tabpageCaolán McNamara
Change-Id: Id27609a86558094e6b53c763aebe77c97cc11672 Reviewed-on: https://gerrit.libreoffice.org/65147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14tdf#122042: It's two clipboards, actuallyKatarina Behrens
Change-Id: I0e975bb73211b1d4ddb2e721659f64b361d11322 Reviewed-on: https://gerrit.libreoffice.org/65121 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-12-14Qt5Menu.hxx: Add missing include/forward-declarationMichael Weghorn
Since 'QObject' and the 'Q_OBJECT' macro are used, the corresponding header needs to be included. Without the include and forward-declaration given here, the compiler doesn't know about 'QObject' and 'QAction' which are used further below, unless another header that takes care of this is included before 'QtMenu.hxx'. The error could be provoked e.g. by moving the '#include <Qt5Menu.hxx>' in front of all other includes in 'vcl/qt5/Qt5Frame.cxx'. Change-Id: I76c15eb445cbe26774d6e4177e12c93658daf0ad Reviewed-on: https://gerrit.libreoffice.org/65130 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-12-13Use the non-deprecated NSEventMaskAnyTor Lillqvist
(Exactly the same thing as the old name NSAnyEventMask. The naming convention just has changed to use a common prefix: NSEventMask* instead of NS*EventMask.) Change-Id: I18a1ae0a2b399ac38567a0171b0d211dcc9faec1
2018-12-13tdf#120342 OSX always lock SolarMutex in drawRectJan-Marek Glogowski
Since we're now a good OSX citizen and do all our drawing in the main thread, I believe the workaround from i#93512 and merged in commit 81ec69125209 ("CWS-TOOLING: integrate CWS i93512_DEV300") isn't needed anymore. Therefore we can just claim the SolarMutex and draw. And I couldn't reproduce the deadlock of i#93512 with this patch applied. But I already was wrong a few times and many drawing semantics have changed for OSX 10.14, so I might be wrong again ;-) Change-Id: Ibbf1c1f394038ee5051bc16d2f3c677f4231b2ba Reviewed-on: https://gerrit.libreoffice.org/65009 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-13WIN move native dialog hack into WinSchedulerJan-Marek Glogowski
The "hides" the hack for native Windows dialogs introduced in commit 5bb798a99e7b ("tdf#117295 WIN no main loop shortcut for OLE dialog") in its own header. Change-Id: I1f36aad20dec50ae1f296001b51085989afb19f6 Reviewed-on: https://gerrit.libreoffice.org/65100 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-12-13weld SwTOXSelectTabPageCaolán McNamara
Change-Id: I2acd547263ab254edd609da4e928738f8b0b9d3b Reviewed-on: https://gerrit.libreoffice.org/65091 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-13Resolves: tdf#122016 crash accessing deleted GtkSalMenuCaolán McNamara
Change-Id: Ib6527e17110b55251fea9f0701d0e02f6fa5a9fe Reviewed-on: https://gerrit.libreoffice.org/65092 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-13vcl/win/gdi: get dither mapping value explicitlyDmitriy Shilin
Having a macro with a very short and nice API but assuming that some variables must be defined before using it leads to a huge misunderstanding. Change-Id: Idb16307ab4bdeff055ee2a9e237c1436cacd3591 Reviewed-on: https://gerrit.libreoffice.org/65069 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-27 08:02:25 +0000