summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-01-10New loplugin:conststringvar: vclStephan Bergmann
Change-Id: I573c19e4a2f6ee041998216ea4cf29677986d731
2017-01-10loplugin:unusedmethodsNoel Grandin
Change-Id: Ibe11923601760ded53a277c48631e4893606b2d6 Reviewed-on: https://gerrit.libreoffice.org/32875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10loplugin:unusedfieldsNoel Grandin
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1 Reviewed-on: https://gerrit.libreoffice.org/32873 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10defaults are good enoughCaolán McNamara
Change-Id: I4520e00b8c48938a4ff1ed89e3c61948d886972c Reviewed-on: https://gerrit.libreoffice.org/32889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09replace C-style casts with const_castJochen Nitschke
Change-Id: Ica6522b4bfe2aa4517469e89cabe5d4d057cb6b7 Reviewed-on: https://gerrit.libreoffice.org/32657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-09loplugin:externvarStephan Bergmann
Change-Id: Ie6834e7cb1e65a2e24c6250126c24463e6e49354
2017-01-09add pcd fuzzerCaolán McNamara
Change-Id: Id21659687952ec5e868733fbca12353dd71b8153 Reviewed-on: https://gerrit.libreoffice.org/32902 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09New loplugin:externvar: vclStephan Bergmann
Change-Id: I8b01a7bd7459db242364b6a766549374264f26f2
2017-01-09add svm fuzzerCaolán McNamara
Change-Id: I56606605e7ce7e282960432384057f2986d3a187
2017-01-09add bmp fuzzerCaolán McNamara
Change-Id: I5a564402b7a0b6ae1fcbeef6d84f85f1d3e4f4ce Reviewed-on: https://gerrit.libreoffice.org/32850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09add png fuzzerCaolán McNamara
Change-Id: I06a92aff55f4e107781b5e7b2b95eb61692a929b Reviewed-on: https://gerrit.libreoffice.org/32849 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09unnecessary const castCaolán McNamara
Change-Id: Ib88b8de40184b13cd7aa0ae4787e6b6477996d67
2017-01-08Get rid of #include "../foo/bar.hxx" type includesGaurav Dhingra
Change-Id: I18e2094c1d28b6e0d860e474e33bbf8642ba78fd Reviewed-on: https://gerrit.libreoffice.org/32845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-08add xpm fuzzerCaolán McNamara
Change-Id: Ic4869b58914079662b09c8ef406b4f65d21b5270 Reviewed-on: https://gerrit.libreoffice.org/32839 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-08add xbm fuzzerCaolán McNamara
Change-Id: I23d65c01bfd1ff083cda0f48c5db1636f1c6095b Reviewed-on: https://gerrit.libreoffice.org/32821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-08Work around -fsanitize=float-cast-overflowStephan Bergmann
...when the value is outside the range of type 'unsigned char'; hopefully it'll always be in the range of type 'long long' Change-Id: I8ec38727648bea20875cb488fe143b4759812b5a
2017-01-08loplugin:salboolStephan Bergmann
Change-Id: I1da621fa46de1ff0c268d10d46a7b5a8bd860623
2017-01-08Simplify setting Kashida width on WindowsKhaled Hosny
This should also make sure we are getting it from the current font, which the old, convoluted way does not seem to guarantee. Change-Id: If0a4cf18e472b1489115eeb7b1b2bdbb5f13abb0 Reviewed-on: https://gerrit.libreoffice.org/32595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-07forward decl of Graphic needed hereCaolán McNamara
Change-Id: I81a4bb99ffa41531323e5a5b3473f54dd0cb8910
2017-01-07come up with a conservative max compression ratio for gifsCaolán McNamara
Change-Id: I01bc452a0bcc003bf9b7b65d9a2a49b6c1acebc1
2017-01-07lok: refill font list if emptyHenry Castro
After preinit stage the font list is empty when creating documents. Reviewed-on: https://gerrit.libreoffice.org/32108 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: sd/source/ui/docshell/docshel4.cxx svtools/source/control/ctrltool.cxx Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415 Reviewed-on: https://gerrit.libreoffice.org/32796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-01-06Drop macros that are used only onceKhaled Hosny
Change-Id: Ib75c0db614448f5297de9924335e2ee9f71f3a3f Reviewed-on: https://gerrit.libreoffice.org/32766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-06oss-fuzz: make max sane bitmap allocation smallerCaolán McNamara
Change-Id: I0b924f615ed4652ce605c12d2d2e9ca2ad2befbf
2017-01-06tdf#105151 - be more conservative about EndTracking / Tracking calls.Michael Meeks
We really shouldn't be emitting these into widgets after they are disposed - it serves only to confuse things. Restore behaviour to how it was before the VclPtr change for this. Change-Id: Ife666929f8aac0e4431a5e43970769692c11888c Reviewed-on: https://gerrit.libreoffice.org/32785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-06New loplugin:charrightshiftStephan Bergmann
Change-Id: Ib645fb11004bc0fe05c9c416ae72b0ae56c23a15
2017-01-06use same logic in both CreatesCaolán McNamara
Change-Id: I49dab360c5f93e40f5a6e91fbe721935d795472c
2017-01-06lsan+wmffuzzer shows a circular reference leading to a leakCaolán McNamara
graphic gets a context set on it which has a shallow copy of the graphic in it. ==37==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 1024 byte(s) in 1 object(s) allocated from: #0 0x6170b0 in operator new[](unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:84 #1 0x91361b in BitmapPalette::BitmapPalette(unsigned short) /src/libreoffice/include/vcl/salbtype.hxx:467:56 #2 0x9029f0 in GIFReader::GIFReader(SvStream&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:114:7 #3 0x91648d in std::__1::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>, GIFReader, 1u>::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>&, SvStream&, 0ul, 0ul>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>, std::__1::__tuple_indices<0ul>, std::__1::__tuple_indices<0ul>) /usr/local/bin/../include/c++/v1/memory:2173:15 #4 0x91648d in std::__1::__compressed_pair<std::__1::allocator<GIFReader>, GIFReader>::__compressed_pair<std::__1::allocator<GIFReader>&, SvStream&>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>) /usr/local/bin/../include/c++/v1/memory:2330 #5 0x91648d in std::__1::__shared_ptr_emplace<GIFReader, std::__1::allocator<GIFReader> >::__shared_ptr_emplace<SvStream&>(std::__1::allocator<GIFReader>, SvStream&) /usr/local/bin/../include/c++/v1/memory:3827 #6 0x91648d in std::__1::shared_ptr<GIFReader> std::__1::shared_ptr<GIFReader>::make_shared<SvStream&>(SvStream&) /usr/local/bin/../include/c++/v1/memory:4443 #7 0x91284b in _ZNSt3__111make_sharedI9GIFReaderJR8SvStreamEEENS_9enable_ifIXntsr8is_arrayIT_EE5valueENS_10shared_ptrIS5_EEE4typeEDpOT0_ /usr/local/bin/../include/c++/v1/memory:4807:12 #8 0x91284b in ImportGIF(SvStream&, Graphic&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:889 #9 0x61c85c in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/giffuzzer.cxx:18:11 #10 0x575ef58 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:546:13 #11 0x575fcb4 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:497:3 #12 0x577e43a in fuzzer::Fuzzer::RunOne(std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) /src/libfuzzer/FuzzerInternal.h:119:41 #13 0x575e5ad in fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >*) /src/libfuzzer/FuzzerLoop.cpp:476:30 #14 0x5708588 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:534:6 #15 0x56fb3c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10 #16 0x7fb5f13da82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) Change-Id: I1384f4ced094e79a27e7d15b569c88f129cd115a
2017-01-05add gif fuzzerCaolán McNamara
Change-Id: I47dc449464cc7643d05b73e9612d01e50a8d4b8e
2017-01-05Related: tdf#45820 polygon clipping during wmf load is ultra slowCaolán McNamara
For file fuzzing defer actually doing it during load and just set a clipping region, which can take a polypolygon argument, instead of setting a basic cliping rectangle + complexclip flag to specially clip certain things for normal use, continue to do the slow thing as it gives different visual output, so its either not quite the right thing, or there's bugs elsewhere that would need to be fixed to go this way the whole time Change-Id: Ieac7ab54ed7d7c1ca14afd75b25fe273fd676c5d
2017-01-05move ImageList to frameworkCaolán McNamara
this can probably be replaced by a std::*map<Image> Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05move CommandImageResolver out of vcl and beside its only userCaolán McNamara
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05drop unused forward declCaolán McNamara
Change-Id: Ie4a2ac8e5363539eb09bb16f13f46829c3c63785
2017-01-05drop newly unused InsertFromHorizontalBitmapCaolán McNamara
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
2017-01-05drop newly unused definesCaolán McNamara
Change-Id: I9ab375c851b4c0738bceec3c2cefc16df57c16ce
2017-01-05unwind radio and check img listsCaolán McNamara
Change-Id: I7ce7621254583207b913555614204a3733e74263
2017-01-05Improve last commitMaxim Monastirsky
Change-Id: I4feb71c9117e13f18e2c5215714fd0170f166b64
2017-01-05tdf#102059 NotebookBar accessible using F6 keySzymon Kłos
Change-Id: I873c49d8c0557eb3702de921fb5d2281acfed526 Reviewed-on: https://gerrit.libreoffice.org/32459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-04tdf#104944 gtk3: Ignore mouse up event if the wrong frameMaxim Monastirsky
Change-Id: I3d0aad6d2b434866df9110d3b8493fec2d2c94fe Reviewed-on: https://gerrit.libreoffice.org/32465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-04last bitmaps that pMaskColor arg was used on converted to true transparencyCaolán McNamara
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04convert these mono versions to pngCaolán McNamara
Change-Id: I93755ac95c170c457b32adac07557ed48ad8beee
2017-01-04drop unused SplitWindow::ImplDrawButtonRectCaolán McNamara
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04unused bitmap resourcesCaolán McNamara
Change-Id: Ia76b548e993d13c7706ab126109086cbd0717b4c
2017-01-04follow up remove unused autohide leftoversCaolán McNamara
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04drop AutoHide codeCaolán McNamara
only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04tdf#105093 sd PDF export: handle embedded videosMiklos Vajna
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04tdf#97228 Moved class ControlCacheKey in a seperate include file.Huzaifa Iftikhar
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used only by vcl therefore it is moved to a seperate include file named ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx. This header file contains the definition of the the class ControlCacheKey. Since this class uses an object of another class named Size which is defined in gen.hxx therefore this is included in ControlCacheKey.hxx. All the files that references the class ControlCacheKey includes ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx" Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd Reviewed-on: https://gerrit.libreoffice.org/32422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04split SV_RESID_BITMAP_MSGBOX upCaolán McNamara
Change-Id: I4ebf48e5def5fb31aa7e34b5b6f89b220a27d1a6
2017-01-04vcl: hold VclPtrs to avoid possible lifecycle related crashers.Michael Meeks
Makes code on common EnableInput crash reporter trace safer. Change-Id: Ibcf218d0d2460383d12e19f48aaf0ab08e541532 Reviewed-on: https://gerrit.libreoffice.org/32706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-04Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-03split SV_RESID_BITMAP_SCROLLBMP upCaolán McNamara
Change-Id: I303f60b3347f6e079dd951b0c2a0b727a0696eef
generated by cgit (git 2.34.1) at 2024-07-13 21:50:22 +0000