summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2013-08-21Resolves: rhbz#998136 different index to gWidgetData vs NWEnsureGTKNotebookCaolán McNamara
Change-Id: Ib3ebbfda09cd05477b65c1d81ac77e977b2a11e5 (cherry picked from commit 0aa3a73c9463f4d1e8918383b21131352635fe75) Reviewed-on: https://gerrit.libreoffice.org/5546 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2013-08-21NSAppKitVersionNumber10_7 is not defined in SDK 10.6Norbert Thiebaud
Change-Id: Ie52fdd9360bd8393baa733aed0d42f5cb9a57bf7 Reviewed-on: https://gerrit.libreoffice.org/5555 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi> Reviewed-on: https://gerrit.libreoffice.org/5564 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-08-04fdo#67235 adapt form control code to time nanosecond API changeLionel Elie Mamane
squash of steps 1, 2 and 3 in master Change-Id: If68ecf0691919d71d06d7b97d46db115013f9805 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-07-31Resolves: fdo#67378 merge the label into the disclosure buttonCaolán McNamara
(cherry picked from commit 479bba2cdcda8dbd86861ea62c8c25bfef633148) (cherry picked from commit 06ac689a8d3887519d98a616f9a1727fcc7d0bf6) (cherry picked from commit 5718ffbf0e3e68e43f87541ce0368a15de8ec90e) Change-Id: I11c9a35e3d50a827127e4542a40f6f29580d4e8b 8b65b4986bf316e352131e737ebf736d91173d16 43df94c16a178c90da9c006565390a81c2fda29b Related: fdo#67378 rows missing HIG 6pixel spacing Change-Id: I6d4767c3159c1e9ebef19978a94ad994aab6ff4b (cherry picked from commit c2ce9bf0c2bfd2b38262de8571257c8f02b076b4) Reviewed-on: https://gerrit.libreoffice.org/5202 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-31fdo#66715: fontconfig: try harder to ignore duplicate fontsMichael Stahl
The thin space not being displayed correctly is caused by using the wrong font, namely /usr/share/fonts/liberation/LiberationSerif-Regular.ttf, which (on Fedora 18) is version 1 and does not contain u2006 etc. glyphs, whereas the LiberationSerif-Regular.ttf bundled with LO is version 2 and does contain these. There is already isPreviouslyDuplicateOrObsoleted() function to ignore older fonts but it does not work for this case because: 1) Only the previous element was looked at, but there may be several fonts with different weight/slant that need to be checked. 2) The LiberationSerif-Regular.ttf differ in the "lang" entry. Change-Id: I2f9e8d50a1f8155b65f8f07c9259dd988c32992a (cherry picked from commit 1c48e4efa2369e5708798bdefb46b74a86415d00) Reviewed-on: https://gerrit.libreoffice.org/5203 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-30Related: fdo#66817 pressing space on a DisclosureButton should toggle itCaolán McNamara
Change-Id: Ib0f03e4389a35f1eb66c3c5951e89a9f70ec7145 (cherry picked from commit 9f7eab01a65c39b07afb1fba8819593694a3fef3) Reviewed-on: https://gerrit.libreoffice.org/5168 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-30fdo#54264: Fix multi-argument ApplicationEvent::TYPE_OPEN/PRINTStephan Bergmann
...that had been broken when 5c22a03320f20ae9ac2c3c16025e7c5e3a7915d5> "Cleaned up CommandLineArgs" changed the representation of those multi-arguments from a single string with \n delimiters to vector<string> in desktop/soruce/app/cmdlineargs.hxx, but missed updating other producers of such ApplicationEvents. (cherry picked from commit 787940e0ac285aa1101ca8964d252faaab3ea8c1, plus 04f4d4bfb708ef477618fa47d5f17779f4e4cf3c "Add TODO comment expressing doubts about existing code") Conflicts: sfx2/source/appl/appdde.cxx Change-Id: I527d620c60a87f3a01d970927c521163fb6df192 Reviewed-on: https://gerrit.libreoffice.org/5192 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-29Avoid an unnecessary static initialisationTor Lillqvist
(cherry picked from commit 70f56860e4a9ee2a25abf64142a7f0ed4d446bfb) Change-Id: I204158ef6965cc9aa19c458f514e265ede8587f4 Reviewed-on: https://gerrit.libreoffice.org/5169 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-07-29fdo#66006 Convert to PNG for JPEG that can't be losslessly rotatedTomaž Vajngerl
If a JPEG image has a width or height which is not a multiple of 16 (width/heigh % 16 != 0) then it can't be completelly lossleessly rotated (the last uncomplete MCUs can't be rotated) and the image is cropped on the lower size. To prevent this such JPEG images must be rotated to PNG to prevent loss. Afterwards image can still be compressed with "Compress Graphic Dialog". Change-Id: Ie2803512a93bba55573bf66c547f132f37cba711 Reviewed-on: https://gerrit.libreoffice.org/5159 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29protect against past-the-end access of empty stringLionel Elie Mamane
Change-Id: I4518d1a2795f4775aec7f3eb495e39afe30ec7be Reviewed-on: https://gerrit.libreoffice.org/5151 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29Use the Win7 semantics of SHAddToRecentDocs when possibleJesús Corrius
Change-Id: I7cf0dfaec408800f3c682b3ef56799818b805881 (cherry picked from commit e62fec4075e55fd62a3f0d25b230498e5705dd26) Reviewed-on: https://gerrit.libreoffice.org/5163 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29Make AddToRecentDocumentList aware of the DocumentServiceFridrich Štrba
This information helps to map a document with an application ID needed for Windows 7 shell integration. (cherry picked from commit a9ae9aefe8384a81dd79827cb76daa9ed8b58dbc) Conflicts: helpcontent2 Change-Id: I1224f566037ab7597a29b16f310f93d9f5441cce WaE: unused rDocumentService in one ifdef branch Change-Id: I542cf23c8077d9f867a2d890dc326465fce8c3a3 (cherry picked from commit 0354b4335b5c4fcf65d954e03116c44aabe7fa1d) Reviewed-on: https://gerrit.libreoffice.org/5161 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-28fdo#54320: VoiceOver does not follow keyboard focusBoris Dušek
The AXFocusedUIElementChanged notification must have the application object as its parameter, as it is the application object whose AXFocusedUIElement attribute value is changing (and because the docs say so). Change-Id: Ife63a1e59d8a24256ace38fb98b69fd1544f9c96 Reviewed-on: https://gerrit.libreoffice.org/5157 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-07-28fdo#67397: don't bother to create BlendFrame for width == 1 or height == 1Ivan Timofeev
... because: 1) frame painted as a line doesn't make sense to me anyway; 2) it leads to x = 1 or y = 1 in createBlendFrame, while the max value for that variable is "width (or height) - 1", i.e. 0. Change-Id: I7437bce6681e42cb57458c012927cf5d6bfc154f (cherry picked from commit dd6518d42fce1416fa00f80a7b7dead113c37752) Reviewed-on: https://gerrit.libreoffice.org/5154 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-26fdo#67086 - clear device font list before re-fetching it.Michael Meeks
Seemingly if this is done in the other order, then ImplUpdateFontData reads the old font list into mpGraphics leaving pointers around that are then freed by ClearDevFontCache -> GlyphCache::ClearFontCache Change-Id: I06fdc428c782820dd9f98cf77dc0eef486a096ee Signed-off-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-26targetted clean of redundant header piece from 62badf3828Michael Meeks
Change-Id: Ic1240114d667fb7797afae4847427cc889f3cb48 (cherry picked from commit 03993b47c522dcc71f7cd73ee21df3de9650080d)
2013-07-26Resolves: fdo#61544 improve handling of grid's not enough layout spaceCaolán McNamara
(cherry picked from commit b64adf65afb1cfe1bd48fed0d71ac333ad962776) Conflicts: vcl/source/window/layout.cxx Change-Id: I9a73e90f639bb853b67daa98d5daac155dab5900 Reviewed-on: https://gerrit.libreoffice.org/5119 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-07-25Resolves: fdo#63618 don't include border size twice in edit optimal sizeCaolán McNamara
CalcSize calls CalcWindowSize, but we will call that also in GetOptimalSize, so undo the first one with CalcOutputSize. This makes the editboxes especially less tall under MacOSX (cherry picked from commit 0fcf74d203d97b7e829e72b7e55782d86a048802) Change-Id: Ibbbf5a30e0c640744b1a979937301f87d250873a Reviewed-on: https://gerrit.libreoffice.org/5098 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-25fdo#46271: No arrows in scrollbars in OS X 10.7 and laterTor Lillqvist
So no need to take them into account when calculating the geometries of the scrollbar parts. (cherry picked from commit e8c467d134c1c49d2b25c72fbd45dd1c6b77b171) Change-Id: Ie8d4b38107466663e6ff8c26aec3537638976f98 Reviewed-on: https://gerrit.libreoffice.org/5090 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-23move static bitmap into a svapp memberCaolán McNamara
so it won't crash on exit when its dtor uses stuff destroyed by deinitvcl already. also fix comparisons, i.e. presumably aLastColorTopLeft == aLastColorTopLeft etc should have been aLastColorTopLeft == aColorTopLeft Change-Id: I1f3dc47504c5add113b3a8bcadf010ca3b9f4c31 (cherry picked from commit a3694b1b32cb0677019962a5908fe775c83ed5a6) Reviewed-on: https://gerrit.libreoffice.org/5050 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-22Resolves: #i122418# Added workaround to not use GetBitmap on windowsNorbert Thiebaud
(cherry picked from commit 136976efb17b8617a83c7f26601cd04031b51e7f) Change-Id: I9c3aeae76c155c9050404f67adeb91106502c3f1 Reviewed-on: https://gerrit.libreoffice.org/5011 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-22fdo#35785 LibreOffice's support of recent documents in Windows 7 brokenJesús Corrius
Change-Id: I916ba1335b0a0420f568ab9340632f273e3c9516 Reviewed-on: https://gerrit.libreoffice.org/4997 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> (cherry picked from commit 19f3d9310caef84fe2815eb89af448a81937bddd) Shell32.dll is already loaded Since the vcllo.dll links already the shell32.dll because of its symbol SHAddToRecentDocs, no need to increase reference of that library. Just get the module handle. Moreover, a mere presence of the symbol SHGetPropertyStoreForWindow in shell32.dll indicates that we are running at least on Windows 7 or Windows Server 2008 R2. There is thus no need to check for the library version. Change-Id: I9ddfb8407fd805faf588779ac5fa8c10a0ae8898 Reviewed-on: https://gerrit.libreoffice.org/5016 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> (cherry picked from commit 50d330c3d238b7b6182787959b30a6d665eab078) Reviewed-on: https://gerrit.libreoffice.org/5024 Reviewed-by: Jesús Corrius <jcorrius@gmail.com> Reviewed-by: Tor Lillqvist <tml@iki.fi> Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-16fdo#66577: Cursor displaced in Web LayoutKhaled Hosny
Using lrint() helps a bit, but does not fix the issue entirely. Change-Id: Ib80e2c5a57d632f289e49322d3712c6321ae1ec2 Reviewed-on: https://gerrit.libreoffice.org/4907 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-15build breaker: remove XSystemClipboard.hpp from pch againEike Rathke
Commit 60455c972b09ca02b18660c6fb3dafc03b30b2b5 reverted introduction of XSystemClipboard but not from pch. Change-Id: I2c59a575c0649cc3a2cfc3a4f2e812be9a902573
2013-07-15do not include UNO header that does not seem to exist(?) in 4.1Luboš Luňák
Change-Id: Iea8a41c8fac98eb647a2cd135d2ba9038d03ecaf
2013-07-13fdo#66811: vcl: fix broken OUString with length STRING_LENMichael Stahl
ImplSalGetUniString was wrongly converted and constructs OUString with invalid length in WinSalGraphics::CreateFontSubset; this is then implicitly converted to an empty UniString so the font names are missing in the PDF files generated on Windows. (regression from 9e310cc32923ceb4b18d97ce68d54a339b935f01) Change-Id: I1603e62cf18f353f3d7de322b9111a173dc6b225 (cherry picked from commit 82f742f65d35896c69be38fa3b1c78a22226f71c) Reviewed-on: https://gerrit.libreoffice.org/4875 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-12tab traversal order wrongCaolán McNamara
Change-Id: If3b46a1f41cfdde7e6ae04c2aba48fc49d6f2230 (cherry picked from commit 76789dd61c750b5655fc4dcd7629b12e1ff5d17b) Reviewed-on: https://gerrit.libreoffice.org/4860 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-07-11Resolves: fdo#66524 string conversion gone wrongCaolán McNamara
Change-Id: Ie885514cdfaecc14ac57bb53a2da7c51274d54b0 (cherry picked from commit 019a8f3f74ec778d5fead4d2b4d47e75cf750bf7) Reviewed-on: https://gerrit.libreoffice.org/4848 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-11rhbz#980387 fix filter selection from file ext.David Tardon
... for filters that have more than one extension associated with them (e.g., JPEG). Change-Id: Ic6b16d3b4aa17580404d02a9fb7b087b9aa52fc2 (cherry picked from commit 70376f610a7eb876739829e1f362bc94b21cb82f) Signed-off-by: David Tardon <dtardon@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/4823 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-07-10fdo#66718: Revert "fdo#46808, Adapt SystemClipboard UNO service to new style"Stephan Bergmann
This reverts commit 2fe852386c9450014f84910b0a282d684f40b56a, see <https://bugs.freedesktop.org/show_bug.cgi?id=66718#c8> for details. (On master towards LO 4.2, this will be addressed differently, by modifying 2fe852386c9450014f84910b0a282d684f40b56a instead of reverting it, so this libreoffice-4-1 commit is not a cherry-pick of any master commit.) Conflicts: dtrans/source/win32/clipb/WinClipboard.cxx offapi/com/sun/star/datatransfer/clipboard/XSystemClipboard.idl offapi/type_reference/types.rdb vcl/ios/source/dtrans/ios_clipboard.cxx vcl/ios/source/dtrans/ios_clipboard.hxx vcl/source/window/window.cxx Change-Id: Idb804196bc5693e4e8674d805edefd9d1ae7c178
2013-07-10Revert "fix for fdo#66718, access correct clipboard"Stephan Bergmann
This reverts commit 942501b6e49c6c9e19556d9ec132a458e5fef6c3. As explained at <https://bugs.freedesktop.org/show_bug.cgi?id=66718#c8>, a better fix is coming, reverting 2fe852386c9450014f84910b0a282d684f40b56a "fdo#46808, Adapt SystemClipboard UNO service to new style" completely for LO 4.1 again and re- introducing it in simplified form for LO 4.2. (cherry picked from commit 9579db98d87c13977bd3a907f3560d564d5d9302)
2013-07-09fix for fdo#66718, access correct clipboardNoel Power
Changes to use SystemClipboard::createUnix break some subtle behaviour ( or is it even misbehaviour ) that users of the service "com.sun.star.datatransfer.clipboard.SystemClipboard" depend on. When creating the SystemClipboard the arguments passed to X11SalInstance::CreateClipboard(...) are used to access cached instances. Previously the window clipboard was created with 'no' params and then initialised ( via XInitialisation ) later This ensured users creating the "css.datatransfer.clipboard.SystemClipboard" with no paramaters immediately get that same clipboard. Note: creating the SystemClipboard with no param seesm a sensible thing from an scripters point of view as the params that would be required to match the correct Clipboard seem rather difficult to access in an uno only world Change-Id: Ib71d6744086d354025de4db62039b9a98f230eca (cherry picked from commit 942501b6e49c6c9e19556d9ec132a458e5fef6c3) Reviewed-on: https://gerrit.libreoffice.org/4784 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-07-08fdo#66524 - export a means of detecting preferred icon size for toolbars.Michael Meeks
Also fix human / tango / and other icon theme item sizing. Change-Id: I7039f8f671834237a7ec9b2e4b5227e9c47e7143 Reviewed-on: https://gerrit.libreoffice.org/4744 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-08fdo#66478: sw: un-break hyphenationMichael Stahl
The main problem is calling SetHyphPos with a stack pointer. Converting STRING_LEN <-> -1 can't hurt though. (regression from a2f6402b1fe769a430019042e14e63c9414715dc) Change-Id: I59a4e3b16b418082de468c7d7f7f38a9b0bccd01 (cherry picked from commit 6fa07d2d608646004bc45261275c4ebabb578a09) Reviewed-on: https://gerrit.libreoffice.org/4757 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-04fix %VARIABLE replacements in item listsCaolán McNamara
Change-Id: I94f129e26afdac9dc2e0d712c79d73142ced5eee (cherry picked from commit c104e2b661ec840951d39b5889495e2c42ff3d36) Reviewed-on: https://gerrit.libreoffice.org/4715 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-03fdo#66335: fix fdo#44582 and fdo#63254 differentlyIvan Timofeev
This combines the following cherry picked commits: 1) fdo#66335: gtk: Revert hacks for RTL scrollbars returning false here in getNativeControlRegion results in a fallback to square buttons in vcl scrollbar code. But there is no problem in gtk+ backend in this case, let's fix the problem differently. This reverts commits 898a3e84807bccbb876e3f5583728f6d24e05e9a and e8e82bd2109b82ddd535cdac30303249c6b62942. (cherry picked from commit 48e1d9c7afe5c2a39d9a08d7a38f7c8ff39d8c84) 2) fdo#44582: fix scrollbars in RTL UI (cherry picked from commit e3a801e2454eed2e61202bbacca01fe3fcc20c1d) 3) fdo#63254: correct re-mirroring formula This patch fixes horizontal scrollbar in Calc when a sheet is RTL and UI is LTR. When a particular window (horizontal scrollbar in this case) is RTL and a whole UI is LTR this code used for mirroring and re-mirroring back coordinates. AFAICS mirroring is correct, but re-mirroring is not. The used formula comes from commit 69b684b12e42bf1396bdffca88ca880ac3c2e00b, and the same formula appears in the other variant of overloaded function "mirror": mirror(sal_uInt32, const SalPoint*, SalPoint*, const OutputDevice*, bool), but it does not affect the bug. (cherry picked from commit a08f579e3704fbd97590f9b050d250ae445725a7) Change-Id: If23ae46f1286048808faf878953dfa65e67d1962 Reviewed-on: https://gerrit.libreoffice.org/4621 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Reviewed-by: Abdulaziz A Alayed <aalayed@kacst.edu.sa> Tested-by: Abdulaziz A Alayed <aalayed@kacst.edu.sa>
2013-07-02Resolves: fdo#66502 set AutoMnemonics before calculating layoutCaolán McNamara
Change-Id: I3274ec9e8e4e1f61f0108a3e6ba64107128736c2 (cherry picked from commit 00601259144f5b49b516581ca6ae28fc6e524030) Reviewed-on: https://gerrit.libreoffice.org/4679 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-02Handle synthetic bold italic with Core TextKhaled Hosny
Core Text does not fake missing italic and bold (unlike ATSUI), so we have to do it on our own. Change-Id: Ia5977d53739b7a6eaaccbf3aeb24adb820ca05c6 Reviewed-on: https://gerrit.libreoffice.org/4658 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-02fdo#66385: bad line spacing under Core TextKhaled Hosny
We should be setting mnExtLeading not mnIntLeading, at least this is what ATSUI code was doing. Change-Id: Ibe69da4ea60630a31593b538f55fd2cd95642bf9 Reviewed-on: https://gerrit.libreoffice.org/4638 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-02using primary font for secondary max text widthCaolán McNamara
Change-Id: If4d5d4be2a5552c52e7e98ff891e2166b7541800 (cherry picked from commit fea12c47101d3d13d1e6a611f88c54f257b49b11) Reviewed-on: https://gerrit.libreoffice.org/4640 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-01Fix jitter when editing RTL textKhaled Hosny
When drawing right aligned text, rounding errors in the position returned by GetDrawPosition() cause the right margin of the text to change whenever text width changes causing "jumping letters" effect. So here we calculate the drawing position relative to the right margin on our own to avoid the rounding errors. That is basically a hack, and it should go away if one day we managed to get rid of those rounding errors. Continue using GetDrawPosition() for non-right aligned text, to minimize any unforeseen side effects. Change-Id: Ia095a17a41f723f5fb7afc99df4250262e9a0051 Reviewed-on: https://gerrit.libreoffice.org/4618 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-01fix OUString conversionSean Young
This used to be equalsAscii( "hg", 0, 2 ) before conversion. Fixes 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10 Change-Id: I2cf61d88c79b3ab33c0ee7d077ee65b16053c05c Reviewed-on: https://gerrit.libreoffice.org/4035 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org> Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2013-06-28fdo#31525 Dialogues now have an appropriate background in OSXJason Hulme
The proper background is now set using HIThemeBackground. Change-Id: I71e4287273f7345a18eee4c4fc494eea10f2deb2 Reviewed-on: https://gerrit.libreoffice.org/4287 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-06-28fdo#50506, incomplete indent markers in Mac rulersKhaled Hosny
AquaSalGraphics::drawPolygon() should close the path like other polygon drawing functions. It have been like that for 5 years since 3ca40fb8a2e8c805517b351ebd97c1385cfc92a3, no idea how it was never noticed. Change-Id: Ifba740afa66ad485943c7873d78e007b778cd7b3 Reviewed-on: https://gerrit.libreoffice.org/4448 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-on: https://gerrit.libreoffice.org/4456
2013-06-28Attempt to fix Core Text full justificationKhaled Hosny
Apparently we need to subtract the trailing white space from the desired line length or text will sometimes protrude to the margin. Change-Id: Iee5ef40670c2fefc189afa319387b180c4ed648d Reviewed-on: https://gerrit.libreoffice.org/4455 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-26Fixup alpha bitmap generation for Windows.Thorsten Behrens
This improves upon d6f58fd25eeca84a94528409a05b80aa5172b8b8 by using the BitmapEx ctor instead of manual initialisation. Several EMF+ files would otherwise show up horribly mangled on Windows. Change-Id: I1808cb45818f3f0118653164c83c49d6134b9324 (cherry picked from commit fefab3bb38f55471d9fa9316d1249ad00adefc37) (cherry picked from commit 77b273ee3a2df87664262418c360d3a4a0ed48ea) Reviewed-on: https://gerrit.libreoffice.org/4473 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-24fdo#66108 crash in PDF when using Helvetica fontKhaled Hosny
When using Helvetica fonts with any character it supports outside Adobe standard font encoding, PDF writer will force font fallback which we do not support in Core Text and AquaSalGraphics will crash. With ATSUI we do not crash, but no characters are output either. This happens because PDF writer registers 14 “virtual” standard PDF fonts, including Helvetica, and tries to use them if possible instead of the real font. Now the concept of standard fonts is obsolete, and Adobe now recommends that all fonts are embedded in the PDF, so here I just disable that mechanism when on Mac as a quick fix to avoid the crash, but eventually this stuff should dropped entirely. Change-Id: I3a4d8793d1d2124749372452ffa6ba3145dbd9cd Reviewed-on: https://gerrit.libreoffice.org/4485 Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-24Resolves: fdo#66105 set max growth width for labels/edits which take pathsCaolán McNamara
Change-Id: I12220821f76550baacdc8ce604f2e612d260c1a1 (cherry picked from commit 9495e912797f67897a4a658d20137bb94f39e9ab) Reviewed-on: https://gerrit.libreoffice.org/4481 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-24Related: fdo#66105 clip message box dialogs to some reasonable widthsCaolán McNamara
(cherry picked from commit 19a2685ec04bd6ce882d4dd08d24c7248cf99a84) Change-Id: I7fc179865306ba5b593b090b1fdb8971ba6bd508 Reviewed-on: https://gerrit.libreoffice.org/4480 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-22fdo#65934 and fdo#64189 External export graphic filter name fixTomaž Vajngerl
Change-Id: I798fac589abeac61115210cd4805e6b53a8767c6