Age | Commit message (Collapse) | Author |
|
... and use SvStream::WriteNumberAsString, replacing Write[U]Int32AsString
Change-Id: I10e56c532494239ed40ec01b6184dd06db463a0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150193
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
WriteOString is a better replacement
Change-Id: Ic431b9aeb98d19fe61cff71360eee555105cc2bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150192
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
As noel indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=154631#c6
"GIF does not (as far as I can tell) support partial transparency, it only has full or none transparency.
See specs linked from https://en.wikipedia.org/wiki/GIF"
Change-Id: Ib110f344a6b8f0fdfd1355e6521d979b33548709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150184
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
after commit d7910847fba1694c83dc57a1f27b8eaabb2a7d85.
Thanks to mike kaganski for spotting this.
Change-Id: Ie7272b6f97e3b292439aedb3a163bf00ca26f852
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which prevents constructing unnecessary temporaries via getStr()
Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
both because it is more obvious to read, and it takes a string_view,
which is handy
Change-Id: Ic201cfa0434446f51436d23c33d3f1a919ed65be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150167
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I32fc2570e8553be356e5c5c059b92791f5e9106a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150164
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
eventtesting with input of fuzzed keystroke was a fairly nifty idea, but
I never did anything with it beyond an initial experimental run and its
cluttering up things so drop it now
Change-Id: I44571e3e33124f522374d7c6772b7a7e7721aa1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150125
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I785120bdad1a3c3311aeca0c8ec5b8b014999872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150108
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
For similar code sequences that can be improved.
Also move containsComment from collapseif plugin code to
plugin.cxx so we can use it from stringadd.
Change-Id: Ie07d9aedf2c31cb0b2080e1b8584294d7046a8e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ieab3d9fdbcee90ccd125e84f74c06cd1d6711a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149953
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150057
Tested-by: Jenkins
|
|
Change-Id: Ia2865346e966cdd4b64ed588a29cc1e760d36c73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149969
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Specifically in sd/source/core/annotations/Annotation.cxx
We seem to end up fixing leaks here often.
The current tools::JsonWriter API is just very hard to use correctly.
So rather return an OString, which is cheap to copy,
and push that down into the LOK code.
AFAIK that seems to end up requiring less code and less adhoc copying
of data (specifically the queueing code in init.cxx was creating
copies when converting to std::string).
Ideally, we could have some special API to avoid the new strdup()
calls in init.cxx, but not sure how to prevent other people
from accidentally using that.
Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I449ae3f8cf294e2ab81a5b47862278e325f2cb1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148937
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150041
Tested-by: Jenkins
|
|
7.18.6.2 Media clip data
In the media clip data dictionary, the optional CT and Alt keys
(ISO 32000-1:2008, 13.2.4.2, Table 274) are required.
Presumably writing a potentially wrong hard-coded mime type here isn't
intended.
Change-Id: Ifa8ee199a4cf9ce83f410860d59b6c30475f80e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150050
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I1cf23442667a8ac6e9f8da2ea72bf60f5126236e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150047
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
which propogates to cairo and once a cairo surface is in an error state,
that cannot be cleared and all subsequent drawing fails, so bodge that
with a high degree of stretch we draw the brace without stretch to a
temp surface and stretch that to give a far poorer visual result, but
one that can at least be rendered.
Change-Id: I6b8bb079e82c3cf03a908de750c5c445ad230750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150031
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I89fbaca1fa7303904681f75ee4a7fc90aeb9ef8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150030
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibcbd175e9b7c04f30acd4c5d23998b00889e7b0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149714
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150040
|
|
Change-Id: I45c086ce652487017817fcdb2a3c5329a8f2a30f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149689
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150039
|
|
Change-Id: I0577832f57b15621d150da4cb50e134c9c06bae7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150029
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
in the past there was intermediate calls that these affected
Change-Id: I5bb15046ff5869522dfafe72e16f9be4707c1f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since:
commit 6c9948d80aaa1d4827ccf741d900093abe7a973e
Date: Mon May 3 06:51:50 2021 +0800
vcl: adjust cairo text renderer for vertical writing
Change-Id: I853b5f3b8c8979468d6c72617b7991f4c7d509d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150026
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
i.e if the crossing was triggered ultimately by a key stroke which is
likely from exiting the search box.
This way we can avoid the problem that with hover-selection that after
"enter" is used in the search box, selecting a matching row, then during
teardown of the widget the box is hidden, and the generated crossing
notification triggers unwanted selection of a different row under the
mouse.
If needs be this could be refined further to only happen for a specific
key or other details of the triggering event
Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150016
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1849e40508a8754ec567da5913d3454571da5bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149063
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150015
Tested-by: Jenkins
|
|
Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
veraPDF complains:
Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 2
If the Form element omits a Role attribute (Table 348), it shall have
only one child: an object reference (14.7.4.3) identifying the widget
annotation per ISO 32000-1:2008, 14.8.4.5, Table 340.
LO forms produce both page content in an MCID and an /Annot, so Role is
needed.
Change-Id: Ic231931a7c35d8da37ca76e02d97501edb43347c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149626
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
PDFWriterImpl::beginStructureElementMCSeq() emits a spurious MCID
definition outside of any stream, before the 1st page:
/Document<</MCID 1>>BDC
% PDFPage::emit
1 0 obj
<</Type/Page/Parent...
This is because SwPageFrame is translated to a Document StructElem in
EnhancedPDFExportHelper, but PDFPage::emit is called at a later time
than when the page content stream is produced, so this is just wrong; an
MCID inside the page content stream is pointless because that's an
object already anyway, so just suppress this.
Looks like other applications don't produce Document currently.
Change-Id: Ic2e30e4125c0e97c8e47330c7a247f74efc18f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150017
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I02cb63b57960c1d7425fe97c341eaf24f216c3a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149496
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150013
Tested-by: Jenkins
|
|
Change-Id: I625346049b866d9f231bba461f40b671f4959e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149717
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150012
|
|
Change-Id: Ia33980d3536b3a52a24161e789f04ee4de75f2e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149540
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149999
|
|
Change-Id: If7bcdf7afdf6e272e47531c2b2b0b75046c561a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149425
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149965
Tested-by: Jenkins
|
|
Change-Id: I5c6b0c24a049a2368dbe084bcfffc4f777d88625
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149423
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149964
Tested-by: Jenkins
|
|
Change-Id: I43324a4159a0562a87594662a634fae91b216055
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149955
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and make it async
Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824
Tested-by: Jenkins
|
|
...seen with CppunitTest_desktop_lib
CPPUNIT_TEST_NAME=DesktopLOKTest::testControlState after
116b9d6ddf2b61186b29f0370234eec9c1bbe306 "Avoid conversions between OUString and
OString in VCL",
> ==883385==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000937904 at pc 0x7fe40a2ef6ad bp 0x7fff0a077390 sp 0x7fff0a077388
> READ of size 4 at 0x603000937904 thread T0
> #0 in rtl::OUString::equalsAsciiL(char const*, int) const at include/rtl/ustring.hxx:1279:21
> #1 in rtl::libreoffice_internal::ConstCharArrayDetector<char const [11], bool>::Type rtl::operator==<char const [11]>(rtl::OUString const&, char const (&) [11]) at include/rtl/ustring.hxx:1815:24
> #2 in JSDialogNotifyIdle::Invoke() at vcl/jsdialog/jsdialogbuilder.cxx:283:27
> #3 in JSDialogSender::flush() at vcl/inc/jsdialog/jsdialogbuilder.hxx:172:34
> #4 in JSDialogSender::sendClose() at vcl/jsdialog/jsdialogbuilder.cxx:345:5
> #5 in JSDialogSender::~JSDialogSender() at vcl/jsdialog/jsdialogbuilder.cxx:320:5
> #6 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1
> 0x603000937904 is located 4 bytes inside of 24-byte region [0x603000937900,0x603000937918)
> freed by thread T0 here:
> #0 in free at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:52:3 (workdir/LinkTarget/Executable/cppunittester +0x139452)
> #1 in void rtl::str::release<_rtl_uString>(_rtl_uString*) at sal/rtl/strtmpl.hxx:875:9
> #2 in rtl_uString_release at sal/rtl/ustring.cxx:1204:12
> #3 in rtl::OUString::~OUString() at include/rtl/ustring.hxx:546:13
> #4 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1
Change-Id: Ib95b4d16c7a7d74ad989716e7829de775ed0de8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149954
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Iab24e8d18bf7badbca672fbdbf455f78d08f41a0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149905
Tested-by: Jenkins
|
|
Standardize on OUString, which is the main internal string class.
Convert from/to OUString only when communicating with respective
external APIs.
Removes about 200 conversions from the code.
Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I67a769a6108fb8590d6304390a4f27ef95927c9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149922
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
... regardless of the script of the mark itself.
Change-Id: I15a5d8cb2e1d7b7a26316689ffa11c278d1f6365
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149925
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
|
|
Essentially add back the workaround originally added in
commit e770bacc85a0eec96de77068d61b03f374b3cdec
Date: Sun Jun 2 21:01:33 2019 +0000
Qt5 workaround modal change after show bug
but then dropped again in
commit 2dc6bdd1d5789ace0500cad90f5d2eb930888bb9
Date: Wed Jun 5 17:39:45 2019 +0000
tdf#125692 SalObject always holds a SystemChildWindow
, since it turns out that it is still needed for other
use cases than the original one from tdf#125692, as the freeze
of the basic IDE dialog dialog preview described in tdf#152979.
The
qt.qpa.xcb: internal error: void QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window
issue mentioned there is apparently also worked around in
upstream Qt tests, s. this qtbase commit [1]:
commit 3714e51436eebb64873c58dc36cf89ef8f139f09
Author: Volker Hilsheimer <volker.hilsheimer@qt.io>
Date: Mon Sep 20 13:44:26 2021 +0200
QWidgetWindow: Stabilize test on Xcb
Showing, hiding, and showing a window can result in the Xcb QPA plugin
warning about
qt.qpa.xcb: internal error: void QXcbWindow::setNetWmStateOnUnmappedWindow()
called on mapped window
The point of the test is to verify that we get a paint event on a window
that is shown again after having been hidden, not to verify that async
windowing systems can handle a show/hide/show sequence. So wait for the
window being exposed before we hide it.
Pick-to: 6.2 5.15
Change-Id: If91a9926613645e78e332dacff34bd57e4034b6f
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Decrease the sleep from the original 250 ms to 100 ms,
since tdf#152979 comment 14 mentions that this is enough.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3714e51436eebb64873c58dc36cf89ef8f139f09
Change-Id: I57ed520d0df85b7a3bcf47c2f9314754649482ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149912
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
|
|
Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere.
Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iac64dea2811b8a784ff237d72eb02b36b29d042b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149422
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149837
Tested-by: Jenkins
|
|
Change-Id: Ib6f1cd1ffac5479ae9cdf1e47fe0cb69abfc8c91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148889
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149365
|
|
Change-Id: I2c40b1e6dbfcb8693afc27e65a75ef71e6a9b7e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148996
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149821
Tested-by: Jenkins
|
|
Change-Id: I694bf3ea9982032b0202e408f8121a6407427cca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148789
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149820
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I19722ac3e8b3f58ba916aa21513ba7ee34ef0bb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148990
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149366
|
|
role mappings are somewhat unsatisfactory, but can serve as placeholders
for now
Change-Id: I050fdc0e85fc57de6d79823b2432b521dcffcad4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149215
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id5e920c16f005512a14e41d453f435826a9e7053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149775
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7d4776d77385dc46f496b873c75e2be25840f86b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|